Xetaravel\Http\Controllers\Blog\CategoryController

Complexity

Total Complexity

3

Size/Duplication

Total Lines	43
Duplicated Lines	62.79 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
B	show()	27	27	2

<?php
namespace Xetaravel\Http\Controllers\Blog;

use Xetaravel\Http\Controllers\Controller;
use Xetaravel\Models\Category;
use Illuminate\Http\Request;

class CategoryController extends Controller
{

    public function __construct()
    {
        parent::__construct();

        $this->breadcrumbs->addCrumb('Blog', route('blog_article_index'));

The property breadcrumbs does not exist. Did you maybe forget to declare it?

    }

    /**
     * Show the article by his id.
     *
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\View\View

Should the return type not be \Illuminate\Http\RedirectResponse|\Illuminate\View\View|\Illuminate\Contracts\View\Factory?

     */
    public function show(Request $request, $slug, $id)

The parameter $request is not used and could be removed.

The parameter $slug is not used and could be removed.

This method seems to be duplicated in your project.

    {
        $category = Category::with('articles')

The method where does only exist in Illuminate\Database\Eloquent\Builder, but not in Illuminate\Database\Eloquent\Model.

            ->where('id', $id)
            ->first();

        if (is_null($category)) {
            return redirect()
                ->route('blog_article_index')
                ->with('danger', 'This category doesn\'t exist or has been deleted !');
        }

        $articles = $category->articles()->paginate(config('xetaravel.pagination.blog.article_per_page'));

        $this->breadcrumbs->addCrumb(
            "Category : " . e($category->title),
            route(
                'blog_article_show',
                ['slug' => $category->slug, 'id' => $category->id]
            )
        );

        return view(
            'Blog::category.show',
            ['articles' => $articles, 'category' => $category, 'breadcrumbs' => $this->breadcrumbs]
        );
    }
}