UsersController::search() - Code Metrics - XetaIO/Xeta - Measure and Improve Code Quality continuously with Scrutinizer

UsersController::search() C
last analyzed 2017-04-25 20:37 UTC

↳ Parent: UsersController

Complexity

Conditions	9
Paths	45

Size

Total Lines	88
Code Lines	58

Duplication

Lines	63
Ratio	71.59 %

Importance

Changes

Metric	Value
dl	63
loc	88
rs	5.2636
c	0
b	0
f	0
cc	9
eloc	58
nc	45
nop	0

How to fix Long Method

<?php
namespace App\Controller\Admin;

use App\Controller\AppController;

class UsersController extends AppController
{

    /**
     * Search users form.
     *
     * @return void
     */
    public function index()
    {
    }

    /**
     * Search users.
     *
     * @return void
     */
    public function search()
    {
        //Keyword to search. (For pagination)
        if (!empty($this->request->getData('search'))) {

            $keyword = $this->request->getData('search');
            $this->request->session()->write('Search.Admin.Users.Keyword', $keyword);
        } else {
            if ($this->request->session()->read('Search.Admin.Users.Keyword')) {
                $keyword = $this->request->session()->read('Search.Admin.Users.Keyword');
            } else {
                $keyword = '';
            }
        }

        //Search type. (For pagination)
        if (!empty($this->request->getData('type'))) {

            $type = $this->request->getData('type');
            $this->request->session()->write('Search.Admin.Users.Type', $type);
        } else {
            if ($this->request->session()->read('Search.Admin.Users.Type')) {
                $type = $this->request->session()->read('Search.Admin.Users.Type');
            } else {
                $type = '';
            }
        }

        switch ($type) {
            case "username":

                $this->paginate = [
                    'limit' => 15,
                    'conditions' => [
                        'Users.username LIKE' => "%$keyword%"
                    ],
                    'order' => [
                        'Users.username' => 'asc'
                    ]
                ];
                break;

            case "ip":

                $this->paginate = [
                    'limit' => 15,
                    'conditions' => [
                        'Users.last_login_ip LIKE' => "%$keyword%"
                    ],
                    'order' => [
                        'Users.last_login_ip' => 'asc'
                    ]
                ];
                break;

            case "mail":

                $this->paginate = [
                    'limit' => 15,
                    'conditions' => [
                        'Users.email LIKE' => "%$keyword%"
                    ],
                    'order' => [
                        'Users.email' => 'asc'
                    ]
                ];
                break;

            case "group":
                $this->paginate = [
                    'limit' => 15,
                    'conditions' => [
                        'Groups.name LIKE' => "%$keyword%"
                    ],
                    'contain' => ['Groups']
                ];
                break;

            default:

                $this->paginate = [
                    'limit' => 15,
                    'conditions' => [
                        'Users.username LIKE' => "%$keyword%"
                    ],
                    'order' => [
                        'Users.username' => 'asc'
                    ]
                ];
        }

        $users = $this->paginate($this->Users->find());
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->set(compact('users', 'keyword', 'type'));
    }

    /**
     * Edit an user.
     *
     * @return \Cake\Network\Response|void
     */
    public function edit()
    {
        $user = $this->Users
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->where([
                'Users.id' => $this->request->id
            ])
            ->first();

        //Check if the user is found.
        if (empty($user)) {
            $this->Flash->error(__d('admin', 'This user doesn\'t exist or has been deleted.'));

            return $this->redirect(['action' => 'index']);
        }

        if ($this->request->is('put')) {
            $this->Users->patchEntity(
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $user,
                $this->request->getParsedBody(),
                [
                    'validate' => 'update',
                    'accessibleFields' => ['group_id' => true]
                ]
            );

            if ($this->Users->save($user)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $this->Flash->success(__d('admin', 'This user has been updated successfully !'));

                return $this->redirect(['action' => 'index']);
            }
        }

        $this->loadModel('Groups');

        $groups = $this->Groups->find('list');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $this->set(compact('user', 'groups'));
    }

    /**
     * Delete an user and all his articles, comments and likes.
     *
     * @return \Cake\Network\Response
     */
    public function delete()
    {
        $user = $this->Users
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->where([
                'Users.id' => $this->request->id
            ])
            ->first();

        //Check if the user is found.
        if (empty($user) || $user->is_deleted == true) {
            $this->Flash->error(__d('admin', 'This user doesn\'t exist or has been deleted.'));

            return $this->redirect(['action' => 'index']);
        }

        $user->is_deleted = true;

        if ($this->Users->save($user)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->Flash->success(__d('admin', 'This user has been deleted successfully !'));

            return $this->redirect(['action' => 'index']);
        }

        $this->Flash->error(__d('admin', 'Unable to delete this user.'));

        return $this->redirect(['action' => 'index']);
    }

    /**
     * Delete an avatar.
     *
     * @return \Cake\Network\Response
     */
    public function deleteAvatar()
    {
        $user = $this->Users
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->where([
                'Users.id' => $this->request->id
            ])
            ->first();

        //Check if the user is found.
        if (empty($user)) {
            $this->Flash->error(__d('admin', 'This user doesn\'t exist or has been deleted.'));

            return $this->redirect(['action' => 'index']);
        }

        $user->avatar = '../img/avatar.png';

        if ($this->Users->save($user)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->Flash->success(__d('admin', 'His avatar has been deleted successfully !'));

            return $this->redirect($this->referer());

        }

        $this->Flash->error(__d('admin', 'Unable to delete his avatar.'));

        return $this->redirect($this->referer());

    }
}


1		<?php
2		namespace App\Controller\Admin;
3
4		use App\Controller\AppController;
5
6		class UsersController extends AppController
7		{
8
9		/**
10		* Search users form.
11		*
12		* @return void
13		*/
14		public function index()
15		{
16		}
17
18		/**
19		* Search users.
20		*
21		* @return void
22		*/
23		public function search()
24		{
25		//Keyword to search. (For pagination)
26	View Code Duplication	if (!empty($this->request->getData('search'))) {
		0 ignored issues – show Duplication introduced 2016-10-25 05:06 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
27		$keyword = $this->request->getData('search');
28		$this->request->session()->write('Search.Admin.Users.Keyword', $keyword);
29		} else {
30		if ($this->request->session()->read('Search.Admin.Users.Keyword')) {
31		$keyword = $this->request->session()->read('Search.Admin.Users.Keyword');
32		} else {
33		$keyword = '';
34		}
35		}
36
37		//Search type. (For pagination)
38	View Code Duplication	if (!empty($this->request->getData('type'))) {
		0 ignored issues – show Duplication introduced 2016-10-25 05:06 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...

XetaIO / Xeta

UsersController::search() C last analyzed 2017-04-25 20:37 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

UsersController::search() C
last analyzed 2017-04-25 20:37 UTC