App\Controller\Admin\UsersController

Complexity

Total Complexity

21

Size/Duplication

Total Lines	219
Duplicated Lines	28.77 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	3	1
C	search()	63	88	9
B	edit()	0	39	4
B	delete()	0	28	4
B	deleteAvatar()	0	28	3

<?php
namespace App\Controller\Admin;

use App\Controller\AppController;

class UsersController extends AppController
{

    /**
     * Search users form.
     *
     * @return void
     */
    public function index()
    {
    }

    /**
     * Search users.
     *
     * @return void
     */
    public function search()
    {
        //Keyword to search. (For pagination)
        if (!empty($this->request->getData('search'))) {

This code seems to be duplicated across your project.

            $keyword = $this->request->getData('search');
            $this->request->session()->write('Search.Admin.Users.Keyword', $keyword);
        } else {
            if ($this->request->session()->read('Search.Admin.Users.Keyword')) {
                $keyword = $this->request->session()->read('Search.Admin.Users.Keyword');
            } else {
                $keyword = '';
            }
        }

        //Search type. (For pagination)
        if (!empty($this->request->getData('type'))) {

This code seems to be duplicated across your project.

            $type = $this->request->getData('type');
            $this->request->session()->write('Search.Admin.Users.Type', $type);
        } else {
            if ($this->request->session()->read('Search.Admin.Users.Type')) {
                $type = $this->request->session()->read('Search.Admin.Users.Type');
            } else {
                $type = '';
            }
        }

        switch ($type) {
            case "username":

This code seems to be duplicated across your project.

                $this->paginate = [
                    'limit' => 15,
                    'conditions' => [
                        'Users.username LIKE' => "%$keyword%"
                    ],
                    'order' => [
                        'Users.username' => 'asc'
                    ]
                ];
                break;

            case "ip":

This code seems to be duplicated across your project.

                $this->paginate = [
                    'limit' => 15,
                    'conditions' => [
                        'Users.last_login_ip LIKE' => "%$keyword%"
                    ],
                    'order' => [
                        'Users.last_login_ip' => 'asc'
                    ]
                ];
                break;

            case "mail":

This code seems to be duplicated across your project.

                $this->paginate = [
                    'limit' => 15,
                    'conditions' => [
                        'Users.email LIKE' => "%$keyword%"
                    ],
                    'order' => [
                        'Users.email' => 'asc'
                    ]
                ];
                break;

            case "group":
                $this->paginate = [
                    'limit' => 15,
                    'conditions' => [
                        'Groups.name LIKE' => "%$keyword%"
                    ],
                    'contain' => ['Groups']
                ];
                break;

            default:

This code seems to be duplicated across your project.

                $this->paginate = [
                    'limit' => 15,
                    'conditions' => [
                        'Users.username LIKE' => "%$keyword%"
                    ],
                    'order' => [
                        'Users.username' => 'asc'
                    ]
                ];
        }

        $users = $this->paginate($this->Users->find());

The property Users does not exist on object<App\Controller\Admin\UsersController>. Since you implemented __get, maybe consider adding a @property annotation.

        $this->set(compact('users', 'keyword', 'type'));
    }

    /**
     * Edit an user.
     *
     * @return \Cake\Network\Response|void
     */
    public function edit()
    {
        $user = $this->Users

The property Users does not exist on object<App\Controller\Admin\UsersController>. Since you implemented __get, maybe consider adding a @property annotation.

            ->find()
            ->where([
                'Users.id' => $this->request->id
            ])
            ->first();

        //Check if the user is found.
        if (empty($user)) {
            $this->Flash->error(__d('admin', 'This user doesn\'t exist or has been deleted.'));

            return $this->redirect(['action' => 'index']);
        }

        if ($this->request->is('put')) {
            $this->Users->patchEntity(

The property Users does not exist on object<App\Controller\Admin\UsersController>. Since you implemented __get, maybe consider adding a @property annotation.

                $user,
                $this->request->getParsedBody(),
                [
                    'validate' => 'update',
                    'accessibleFields' => ['group_id' => true]
                ]
            );

            if ($this->Users->save($user)) {

The property Users does not exist on object<App\Controller\Admin\UsersController>. Since you implemented __get, maybe consider adding a @property annotation.

                $this->Flash->success(__d('admin', 'This user has been updated successfully !'));

                return $this->redirect(['action' => 'index']);
            }
        }

        $this->loadModel('Groups');

        $groups = $this->Groups->find('list');

The property Groups does not exist on object<App\Controller\Admin\UsersController>. Since you implemented __get, maybe consider adding a @property annotation.

        $this->set(compact('user', 'groups'));
    }

    /**
     * Delete an user and all his articles, comments and likes.
     *
     * @return \Cake\Network\Response
     */
    public function delete()
    {
        $user = $this->Users

The property Users does not exist on object<App\Controller\Admin\UsersController>. Since you implemented __get, maybe consider adding a @property annotation.

            ->find()
            ->where([
                'Users.id' => $this->request->id
            ])
            ->first();

        //Check if the user is found.
        if (empty($user) || $user->is_deleted == true) {
            $this->Flash->error(__d('admin', 'This user doesn\'t exist or has been deleted.'));

            return $this->redirect(['action' => 'index']);
        }

        $user->is_deleted = true;

        if ($this->Users->save($user)) {

The property Users does not exist on object<App\Controller\Admin\UsersController>. Since you implemented __get, maybe consider adding a @property annotation.

            $this->Flash->success(__d('admin', 'This user has been deleted successfully !'));

            return $this->redirect(['action' => 'index']);
        }

        $this->Flash->error(__d('admin', 'Unable to delete this user.'));

        return $this->redirect(['action' => 'index']);
    }

    /**
     * Delete an avatar.
     *
     * @return \Cake\Network\Response
     */
    public function deleteAvatar()
    {
        $user = $this->Users

The property Users does not exist on object<App\Controller\Admin\UsersController>. Since you implemented __get, maybe consider adding a @property annotation.

            ->find()
            ->where([
                'Users.id' => $this->request->id
            ])
            ->first();

        //Check if the user is found.
        if (empty($user)) {
            $this->Flash->error(__d('admin', 'This user doesn\'t exist or has been deleted.'));

            return $this->redirect(['action' => 'index']);
        }

        $user->avatar = '../img/avatar.png';

        if ($this->Users->save($user)) {

The property Users does not exist on object<App\Controller\Admin\UsersController>. Since you implemented __get, maybe consider adding a @property annotation.

            $this->Flash->success(__d('admin', 'His avatar has been deleted successfully !'));

            return $this->redirect($this->referer());

It seems like $this->referer() targeting Cake\Controller\Controller::referer() can also be of type object<Cake\Http\ServerRequest>; however, Cake\Controller\Controller::redirect() does only seem to accept string|array, maybe add an additional type check?

        }

        $this->Flash->error(__d('admin', 'Unable to delete his avatar.'));

        return $this->redirect($this->referer());

It seems like $this->referer() targeting Cake\Controller\Controller::referer() can also be of type object<Cake\Http\ServerRequest>; however, Cake\Controller\Controller::redirect() does only seem to accept string|array, maybe add an additional type check?

    }
}