Test Failed
Branch master (19f93b)
by Michael
10:44
created
htdocs/modules/profile/class/profile.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -235,9 +235,9 @@  discard block
 block discarded – undo
235 235
             $field->setVar('field_options', array());
236 236
         }
237 237
         if ($this->insertField($field)) {
238
-            $msg = '&nbsp;&nbsp;Field <strong>' . $vars['name'] . '</strong> added to the database';
238
+            $msg = '&nbsp;&nbsp;Field <strong>'.$vars['name'].'</strong> added to the database';
239 239
         } else {
240
-            $msg = '&nbsp;&nbsp;<span class="red">ERROR: Could not insert field <strong>' . $vars['name'] . '</strong> into the database. ' . implode(' ', $field->getErrors()) . $this->db->error() . '</span>';
240
+            $msg = '&nbsp;&nbsp;<span class="red">ERROR: Could not insert field <strong>'.$vars['name'].'</strong> into the database. '.implode(' ', $field->getErrors()).$this->db->error().'</span>';
241 241
         }
242 242
         unset($field);
243 243
 
@@ -295,32 +295,32 @@  discard block
 block discarded – undo
295 295
         $searchvars_profile = array_diff($searchvars, $uservars);
296 296
         $sv                 = array('u.uid, u.uname, u.email, u.user_viewemail');
297 297
         if (!empty($searchvars_user)) {
298
-            $sv[0] .= ',u.' . implode(', u.', $searchvars_user);
298
+            $sv[0] .= ',u.'.implode(', u.', $searchvars_user);
299 299
         }
300 300
         if (!empty($searchvars_profile)) {
301
-            $sv[] = 'p.' . implode(', p.', $searchvars_profile);
301
+            $sv[] = 'p.'.implode(', p.', $searchvars_profile);
302 302
         }
303 303
 
304
-        $sql_select = 'SELECT ' . (empty($searchvars) ? 'u.*, p.*' : implode(', ', $sv));
305
-        $sql_from   = ' FROM ' . $this->db->prefix('users') . ' AS u LEFT JOIN ' . $this->table . ' AS p ON u.uid=p.profile_id' . (empty($groups) ? '' : ' LEFT JOIN ' . $this->db->prefix('groups_users_link') . ' AS g ON u.uid=g.uid');
304
+        $sql_select = 'SELECT '.(empty($searchvars) ? 'u.*, p.*' : implode(', ', $sv));
305
+        $sql_from   = ' FROM '.$this->db->prefix('users').' AS u LEFT JOIN '.$this->table.' AS p ON u.uid=p.profile_id'.(empty($groups) ? '' : ' LEFT JOIN '.$this->db->prefix('groups_users_link').' AS g ON u.uid=g.uid');
306 306
         $sql_clause = ' WHERE 1=1';
307 307
         $sql_order  = '';
308 308
 
309 309
         $limit = $start = 0;
310 310
         if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) {
311
-            $sql_clause .= ' AND ' . $criteria->render();
311
+            $sql_clause .= ' AND '.$criteria->render();
312 312
             if ($criteria->getSort() !== '') {
313
-                $sql_order = ' ORDER BY ' . $criteria->getSort() . ' ' . $criteria->getOrder();
313
+                $sql_order = ' ORDER BY '.$criteria->getSort().' '.$criteria->getOrder();
314 314
             }
315 315
             $limit = $criteria->getLimit();
316 316
             $start = $criteria->getStart();
317 317
         }
318 318
 
319 319
         if (!empty($groups)) {
320
-            $sql_clause .= ' AND g.groupid IN (' . implode(', ', $groups) . ')';
320
+            $sql_clause .= ' AND g.groupid IN ('.implode(', ', $groups).')';
321 321
         }
322 322
 
323
-        $sql_users = $sql_select . $sql_from . $sql_clause . $sql_order;
323
+        $sql_users = $sql_select.$sql_from.$sql_clause.$sql_order;
324 324
         $result    = $this->db->query($sql_users, $limit, $start);
325 325
 
326 326
         if (!$result) {
@@ -347,7 +347,7 @@  discard block
 block discarded – undo
347 347
 
348 348
         $count = count($users);
349 349
         if ((!empty($limit) && $count >= $limit) || !empty($start)) {
350
-            $sql_count = 'SELECT COUNT(*)' . $sql_from . $sql_clause;
350
+            $sql_count = 'SELECT COUNT(*)'.$sql_from.$sql_clause;
351 351
             $result    = $this->db->query($sql_count);
352 352
             list($count) = $this->db->fetchRow($result);
353 353
         }
Please login to merge, or discard this patch.
htdocs/modules/system/class/block.php 2 patches
Indentation   +26 added lines, -26 removed lines patch added patch discarded remove patch
@@ -84,17 +84,17 @@  discard block
 block discarded – undo
84 84
         // Side position
85 85
         $side_select = new XoopsFormSelect(_AM_SYSTEM_BLOCKS_TYPE, 'side', $this->getVar('side'));
86 86
         $side_select->addOptionArray(array(
87
-                                         0  => _AM_SYSTEM_BLOCKS_SBLEFT,
88
-                                         1  => _AM_SYSTEM_BLOCKS_SBRIGHT,
89
-                                         3  => _AM_SYSTEM_BLOCKS_CBLEFT,
90
-                                         4  => _AM_SYSTEM_BLOCKS_CBRIGHT,
91
-                                         5  => _AM_SYSTEM_BLOCKS_CBCENTER,
92
-                                         7  => _AM_SYSTEM_BLOCKS_CBBOTTOMLEFT,
93
-                                         8  => _AM_SYSTEM_BLOCKS_CBBOTTOMRIGHT,
94
-                                         9  => _AM_SYSTEM_BLOCKS_CBBOTTOM,
95
-                                         10 => _AM_SYSTEM_BLOCKS_CBFOOTERLEFT,
96
-                                         11 => _AM_SYSTEM_BLOCKS_CBFOOTERRIGHT,
97
-                                         12 => _AM_SYSTEM_BLOCKS_CBFOOTERCENTER));
87
+                                            0  => _AM_SYSTEM_BLOCKS_SBLEFT,
88
+                                            1  => _AM_SYSTEM_BLOCKS_SBRIGHT,
89
+                                            3  => _AM_SYSTEM_BLOCKS_CBLEFT,
90
+                                            4  => _AM_SYSTEM_BLOCKS_CBRIGHT,
91
+                                            5  => _AM_SYSTEM_BLOCKS_CBCENTER,
92
+                                            7  => _AM_SYSTEM_BLOCKS_CBBOTTOMLEFT,
93
+                                            8  => _AM_SYSTEM_BLOCKS_CBBOTTOMRIGHT,
94
+                                            9  => _AM_SYSTEM_BLOCKS_CBBOTTOM,
95
+                                            10 => _AM_SYSTEM_BLOCKS_CBFOOTERLEFT,
96
+                                            11 => _AM_SYSTEM_BLOCKS_CBFOOTERRIGHT,
97
+                                            12 => _AM_SYSTEM_BLOCKS_CBFOOTERCENTER));
98 98
 
99 99
         $form->addElement($side_select);
100 100
         // Order
@@ -128,10 +128,10 @@  discard block
 block discarded – undo
128 128
             if (in_array($editor_configs['editor'], array('dhtmltextarea', 'textarea'))) {
129 129
                 $ctype_select = new XoopsFormSelect(_AM_SYSTEM_BLOCKS_CTYPE, 'c_type', $this->getVar('c_type'));
130 130
                 $ctype_select->addOptionArray(array(
131
-                                                  'H' => _AM_SYSTEM_BLOCKS_HTML,
132
-                                                  'P' => _AM_SYSTEM_BLOCKS_PHP,
133
-                                                  'S' => _AM_SYSTEM_BLOCKS_AFWSMILE,
134
-                                                  'T' => _AM_SYSTEM_BLOCKS_AFNOSMILE));
131
+                                                    'H' => _AM_SYSTEM_BLOCKS_HTML,
132
+                                                    'P' => _AM_SYSTEM_BLOCKS_PHP,
133
+                                                    'S' => _AM_SYSTEM_BLOCKS_AFWSMILE,
134
+                                                    'T' => _AM_SYSTEM_BLOCKS_AFNOSMILE));
135 135
                 $form->addElement($ctype_select);
136 136
             } else {
137 137
                 $form->addElement(new XoopsFormHidden('c_type', 'H'));
@@ -158,17 +158,17 @@  discard block
 block discarded – undo
158 158
         }
159 159
         $cache_select = new XoopsFormSelect(_AM_SYSTEM_BLOCKS_BCACHETIME, 'bcachetime', $this->getVar('bcachetime'));
160 160
         $cache_select->addOptionArray(array(
161
-                                          '0'       => _NOCACHE,
162
-                                          '30'      => sprintf(_SECONDS, 30),
163
-                                          '60'      => _MINUTE,
164
-                                          '300'     => sprintf(_MINUTES, 5),
165
-                                          '1800'    => sprintf(_MINUTES, 30),
166
-                                          '3600'    => _HOUR,
167
-                                          '18000'   => sprintf(_HOURS, 5),
168
-                                          '86400'   => _DAY,
169
-                                          '259200'  => sprintf(_DAYS, 3),
170
-                                          '604800'  => _WEEK,
171
-                                          '2592000' => _MONTH));
161
+                                            '0'       => _NOCACHE,
162
+                                            '30'      => sprintf(_SECONDS, 30),
163
+                                            '60'      => _MINUTE,
164
+                                            '300'     => sprintf(_MINUTES, 5),
165
+                                            '1800'    => sprintf(_MINUTES, 30),
166
+                                            '3600'    => _HOUR,
167
+                                            '18000'   => sprintf(_HOURS, 5),
168
+                                            '86400'   => _DAY,
169
+                                            '259200'  => sprintf(_DAYS, 3),
170
+                                            '604800'  => _WEEK,
171
+                                            '2592000' => _MONTH));
172 172
         $form->addElement($cache_select);
173 173
         // Groups
174 174
         $form->addElement(new XoopsFormSelectGroup(_AM_SYSTEM_BLOCKS_GROUP, 'groups', true, $groups, 5, true));
Please login to merge, or discard this patch.
Spacing   +42 added lines, -42 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
  */
16 16
 // defined('XOOPS_ROOT_PATH') || exit('XOOPS root path not defined');
17 17
 
18
-require_once XOOPS_ROOT_PATH . '/kernel/block.php';
18
+require_once XOOPS_ROOT_PATH.'/kernel/block.php';
19 19
 
20 20
 /**
21 21
  * System Block
@@ -141,11 +141,11 @@  discard block
 block discarded – undo
141 141
                 $tplfile_handler = xoops_getHandler('tplfile');
142 142
                 $btemplate       = $tplfile_handler->find($GLOBALS['xoopsConfig']['template_set'], 'block', $this->getVar('bid'));
143 143
                 if (count($btemplate) > 0) {
144
-                    $form->addElement(new XoopsFormLabel(_AM_SYSTEM_BLOCKS_CONTENT, '<a href="' . XOOPS_URL . '/modules/system/admin.php?fct=tplsets&amp;op=edittpl&amp;id=' . $btemplate[0]->getVar('tpl_id') . '">' . _AM_SYSTEM_BLOCKS_EDITTPL . '</a>'));
144
+                    $form->addElement(new XoopsFormLabel(_AM_SYSTEM_BLOCKS_CONTENT, '<a href="'.XOOPS_URL.'/modules/system/admin.php?fct=tplsets&amp;op=edittpl&amp;id='.$btemplate[0]->getVar('tpl_id').'">'._AM_SYSTEM_BLOCKS_EDITTPL.'</a>'));
145 145
                 } else {
146 146
                     $btemplate2 = $tplfile_handler->find('default', 'block', $this->getVar('bid'));
147 147
                     if (count($btemplate2) > 0) {
148
-                        $form->addElement(new XoopsFormLabel(_AM_SYSTEM_BLOCKS_CONTENT, '<a href="' . XOOPS_URL . '/modules/system/admin.php?fct=tplsets&amp;op=edittpl&amp;id=' . $btemplate2[0]->getVar('tpl_id') . '" rel="external">' . _AM_SYSTEM_BLOCKS_EDITTPL . '</a>'));
148
+                        $form->addElement(new XoopsFormLabel(_AM_SYSTEM_BLOCKS_CONTENT, '<a href="'.XOOPS_URL.'/modules/system/admin.php?fct=tplsets&amp;op=edittpl&amp;id='.$btemplate2[0]->getVar('tpl_id').'" rel="external">'._AM_SYSTEM_BLOCKS_EDITTPL.'</a>'));
149 149
                     }
150 150
                 }
151 151
             }
@@ -210,13 +210,13 @@  discard block
 block discarded – undo
210 210
             if (!$edit_func) {
211 211
                 return false;
212 212
             }
213
-            if (file_exists($GLOBALS['xoops']->path('modules/' . $this->getVar('dirname') . '/blocks/' . $this->getVar('func_file')))) {
214
-                if (file_exists($file = $GLOBALS['xoops']->path('modules/' . $this->getVar('dirname') . '/language/' . $xoopsConfig['language'] . '/blocks.php'))) {
213
+            if (file_exists($GLOBALS['xoops']->path('modules/'.$this->getVar('dirname').'/blocks/'.$this->getVar('func_file')))) {
214
+                if (file_exists($file = $GLOBALS['xoops']->path('modules/'.$this->getVar('dirname').'/language/'.$xoopsConfig['language'].'/blocks.php'))) {
215 215
                     include_once $file;
216
-                } elseif (file_exists($file = $GLOBALS['xoops']->path('modules/' . $this->getVar('dirname') . '/language/english/blocks.php'))) {
216
+                } elseif (file_exists($file = $GLOBALS['xoops']->path('modules/'.$this->getVar('dirname').'/language/english/blocks.php'))) {
217 217
                     include_once $file;
218 218
                 }
219
-                include_once $GLOBALS['xoops']->path('modules/' . $this->getVar('dirname') . '/blocks/' . $this->getVar('func_file'));
219
+                include_once $GLOBALS['xoops']->path('modules/'.$this->getVar('dirname').'/blocks/'.$this->getVar('func_file'));
220 220
                 $options   = explode('|', $this->getVar('options'));
221 221
                 $edit_form = $edit_func($options);
222 222
                 if (!$edit_form) {
@@ -260,22 +260,22 @@  discard block
 block discarded – undo
260 260
                 // S : use text sanitizater (smilies enabled)
261 261
                 // T : use text sanitizater (smilies disabled)
262 262
                 if ($c_type === 'H') {
263
-                    return str_replace('{X_SITEURL}', XOOPS_URL . '/', $this->getVar('content', 'n'));
263
+                    return str_replace('{X_SITEURL}', XOOPS_URL.'/', $this->getVar('content', 'n'));
264 264
                 } elseif ($c_type === 'P') {
265 265
                     ob_start();
266 266
                     echo eval($this->getVar('content', 'n'));
267 267
                     $content = ob_get_contents();
268 268
                     ob_end_clean();
269 269
 
270
-                    return str_replace('{X_SITEURL}', XOOPS_URL . '/', $content);
270
+                    return str_replace('{X_SITEURL}', XOOPS_URL.'/', $content);
271 271
                 } elseif ($c_type === 'S') {
272 272
                     $myts    = MyTextSanitizer::getInstance();
273
-                    $content = str_replace('{X_SITEURL}', XOOPS_URL . '/', $this->getVar('content', 'n'));
273
+                    $content = str_replace('{X_SITEURL}', XOOPS_URL.'/', $this->getVar('content', 'n'));
274 274
 
275 275
                     return $myts->displayTarea($content, 1, 1);
276 276
                 } else {
277 277
                     $myts    = MyTextSanitizer::getInstance();
278
-                    $content = str_replace('{X_SITEURL}', XOOPS_URL . '/', $this->getVar('content', 'n'));
278
+                    $content = str_replace('{X_SITEURL}', XOOPS_URL.'/', $this->getVar('content', 'n'));
279 279
 
280 280
                     return $myts->displayTarea($content, 1, 0);
281 281
                 }
@@ -338,9 +338,9 @@  discard block
 block discarded – undo
338 338
     {
339 339
         $ret   = array();
340 340
         $limit = $start = 0;
341
-        $sql   = 'SELECT DISTINCT(b.bid), b.* FROM ' . $this->db->prefix('newblocks') . ' b LEFT JOIN ' . $this->db->prefix('block_module_link') . ' l ON b.bid=l.block_id';
341
+        $sql   = 'SELECT DISTINCT(b.bid), b.* FROM '.$this->db->prefix('newblocks').' b LEFT JOIN '.$this->db->prefix('block_module_link').' l ON b.bid=l.block_id';
342 342
         if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) {
343
-            $sql .= ' ' . $criteria->renderWhere();
343
+            $sql .= ' '.$criteria->renderWhere();
344 344
             $limit = $criteria->getLimit();
345 345
             $start = $criteria->getStart();
346 346
         }
@@ -404,20 +404,20 @@  discard block
 block discarded – undo
404 404
         if (!$asobject) {
405 405
             $sql = 'SELECT b.bid ';
406 406
         }
407
-        $sql .= 'FROM ' . $db->prefix('newblocks') . ' b LEFT JOIN ' . $db->prefix('group_permission') . " l ON l.gperm_itemid=b.bid WHERE gperm_name = 'block_read' AND gperm_modid = 1";
407
+        $sql .= 'FROM '.$db->prefix('newblocks').' b LEFT JOIN '.$db->prefix('group_permission')." l ON l.gperm_itemid=b.bid WHERE gperm_name = 'block_read' AND gperm_modid = 1";
408 408
         if (is_array($groupid)) {
409
-            $sql .= ' AND (l.gperm_groupid=' . $groupid[0] . '';
409
+            $sql .= ' AND (l.gperm_groupid='.$groupid[0].'';
410 410
             $size = count($groupid);
411 411
             if ($size > 1) {
412 412
                 for ($i = 1; $i < $size; ++$i) {
413
-                    $sql .= ' OR l.gperm_groupid=' . $groupid[$i] . '';
413
+                    $sql .= ' OR l.gperm_groupid='.$groupid[$i].'';
414 414
                 }
415 415
             }
416 416
             $sql .= ')';
417 417
         } else {
418
-            $sql .= ' AND l.gperm_groupid=' . $groupid . '';
418
+            $sql .= ' AND l.gperm_groupid='.$groupid.'';
419 419
         }
420
-        $sql .= ' AND b.isactive=' . $isactive;
420
+        $sql .= ' AND b.isactive='.$isactive;
421 421
         if (isset($side)) {
422 422
             // get both sides in sidebox? (some themes need this)
423 423
             if ($side === XOOPS_SIDEBLOCK_BOTH) {
@@ -427,9 +427,9 @@  discard block
 block discarded – undo
427 427
             } elseif ($side === XOOPS_FOOTERBLOCK_ALL) {
428 428
                 $side = '(b.side=10 OR b.side=11 OR b.side=12 )';
429 429
             } else {
430
-                $side = 'b.side=' . $side;
430
+                $side = 'b.side='.$side;
431 431
             }
432
-            $sql .= ' AND ' . $side;
432
+            $sql .= ' AND '.$side;
433 433
         }
434 434
         if (isset($visible)) {
435 435
             $sql .= " AND b.visible=$visible";
@@ -459,12 +459,12 @@  discard block
 block discarded – undo
459 459
     public function getBlockByPerm($groupid)
460 460
     {
461 461
         if (isset($groupid)) {
462
-            $sql = 'SELECT DISTINCT gperm_itemid FROM ' . $this->db->prefix('group_permission') . " WHERE gperm_name = 'block_read' AND gperm_modid = 1";
462
+            $sql = 'SELECT DISTINCT gperm_itemid FROM '.$this->db->prefix('group_permission')." WHERE gperm_name = 'block_read' AND gperm_modid = 1";
463 463
             if (is_array($groupid)) {
464
-                $sql .= ' AND gperm_groupid IN (' . implode(',', $groupid) . ')';
464
+                $sql .= ' AND gperm_groupid IN ('.implode(',', $groupid).')';
465 465
             } else {
466 466
                 if ((int)$groupid > 0) {
467
-                    $sql .= ' AND gperm_groupid=' . (int)$groupid;
467
+                    $sql .= ' AND gperm_groupid='.(int)$groupid;
468 468
                 }
469 469
             }
470 470
             $result   = $this->db->query($sql);
@@ -498,12 +498,12 @@  discard block
 block discarded – undo
498 498
         $db       = $GLOBALS['xoopsDB'];
499 499
         $ret      = array();
500 500
         if (isset($groupid)) {
501
-            $sql = 'SELECT DISTINCT gperm_itemid FROM ' . $db->prefix('group_permission') . " WHERE gperm_name = 'block_read' AND gperm_modid = 1";
501
+            $sql = 'SELECT DISTINCT gperm_itemid FROM '.$db->prefix('group_permission')." WHERE gperm_name = 'block_read' AND gperm_modid = 1";
502 502
             if (is_array($groupid)) {
503
-                $sql .= ' AND gperm_groupid IN (' . implode(',', $groupid) . ')';
503
+                $sql .= ' AND gperm_groupid IN ('.implode(',', $groupid).')';
504 504
             } else {
505 505
                 if ((int)$groupid > 0) {
506
-                    $sql .= ' AND gperm_groupid=' . (int)$groupid;
506
+                    $sql .= ' AND gperm_groupid='.(int)$groupid;
507 507
                 }
508 508
             }
509 509
             $result   = $db->query($sql);
@@ -515,14 +515,14 @@  discard block
 block discarded – undo
515 515
                 return $blockids;
516 516
             }
517 517
         }
518
-        $sql = 'SELECT b.* FROM ' . $db->prefix('newblocks') . ' b, ' . $db->prefix('block_module_link') . ' m WHERE m.block_id=b.bid';
519
-        $sql .= ' AND b.isactive=' . $isactive;
518
+        $sql = 'SELECT b.* FROM '.$db->prefix('newblocks').' b, '.$db->prefix('block_module_link').' m WHERE m.block_id=b.bid';
519
+        $sql .= ' AND b.isactive='.$isactive;
520 520
         if (isset($visible)) {
521
-            $sql .= ' AND b.visible=' . (int)$visible;
521
+            $sql .= ' AND b.visible='.(int)$visible;
522 522
         }
523 523
         if (!isset($module_id)) {
524 524
         } elseif (!empty($module_id)) {
525
-            $sql .= ' AND m.module_id IN (0,' . (int)$module_id;
525
+            $sql .= ' AND m.module_id IN (0,'.(int)$module_id;
526 526
             if ($toponlyblock) {
527 527
                 $sql .= ',-1';
528 528
             }
@@ -535,13 +535,13 @@  discard block
 block discarded – undo
535 535
             }
536 536
         }
537 537
         if (!empty($blockids)) {
538
-            $sql .= ' AND b.bid IN (' . implode(',', $blockids) . ')';
538
+            $sql .= ' AND b.bid IN ('.implode(',', $blockids).')';
539 539
         }
540
-        $sql .= ' ORDER BY ' . $orderby;
540
+        $sql .= ' ORDER BY '.$orderby;
541 541
         $result = $db->query($sql);
542 542
         while (false !== ($myrow = $db->fetchArray($result))) {
543 543
             $block              = new XoopsBlock($myrow);
544
-            $ret[$myrow['bid']] =& $block;
544
+            $ret[$myrow['bid']] = & $block;
545 545
             unset($block);
546 546
         }
547 547
 
@@ -562,13 +562,13 @@  discard block
 block discarded – undo
562 562
         $db   = $GLOBALS['xoopsDB'];
563 563
         $ret  = array();
564 564
         $bids = array();
565
-        $sql  = 'SELECT DISTINCT(bid) from ' . $db->prefix('newblocks');
565
+        $sql  = 'SELECT DISTINCT(bid) from '.$db->prefix('newblocks');
566 566
         if ($result = $db->query($sql)) {
567 567
             while (false !== ($myrow = $db->fetchArray($result))) {
568 568
                 $bids[] = $myrow['bid'];
569 569
             }
570 570
         }
571
-        $sql     = 'SELECT DISTINCT(p.gperm_itemid) from ' . $db->prefix('group_permission') . ' p, ' . $db->prefix('groups') . " g WHERE g.groupid=p.gperm_groupid AND p.gperm_name='block_read'";
571
+        $sql     = 'SELECT DISTINCT(p.gperm_itemid) from '.$db->prefix('group_permission').' p, '.$db->prefix('groups')." g WHERE g.groupid=p.gperm_groupid AND p.gperm_name='block_read'";
572 572
         $grouped = array();
573 573
         if ($result = $db->query($sql)) {
574 574
             while (false !== ($myrow = $db->fetchArray($result))) {
@@ -577,14 +577,14 @@  discard block
 block discarded – undo
577 577
         }
578 578
         $non_grouped = array_diff($bids, $grouped);
579 579
         if (!empty($non_grouped)) {
580
-            $sql = 'SELECT b.* FROM ' . $db->prefix('newblocks') . ' b, ' . $db->prefix('block_module_link') . ' m WHERE m.block_id=b.bid';
581
-            $sql .= ' AND b.isactive=' . (int)$isactive;
580
+            $sql = 'SELECT b.* FROM '.$db->prefix('newblocks').' b, '.$db->prefix('block_module_link').' m WHERE m.block_id=b.bid';
581
+            $sql .= ' AND b.isactive='.(int)$isactive;
582 582
             if (isset($visible)) {
583
-                $sql .= ' AND b.visible=' . (int)$visible;
583
+                $sql .= ' AND b.visible='.(int)$visible;
584 584
             }
585 585
             if (!isset($module_id)) {
586 586
             } elseif (!empty($module_id)) {
587
-                $sql .= ' AND m.module_id IN (0,' . (int)$module_id;
587
+                $sql .= ' AND m.module_id IN (0,'.(int)$module_id;
588 588
                 if ($toponlyblock) {
589 589
                     $sql .= ',-1';
590 590
                 }
@@ -596,12 +596,12 @@  discard block
 block discarded – undo
596 596
                     $sql .= ' AND m.module_id=0';
597 597
                 }
598 598
             }
599
-            $sql .= ' AND b.bid IN (' . implode(',', $non_grouped) . ')';
600
-            $sql .= ' ORDER BY ' . $orderby;
599
+            $sql .= ' AND b.bid IN ('.implode(',', $non_grouped).')';
600
+            $sql .= ' ORDER BY '.$orderby;
601 601
             $result = $db->query($sql);
602 602
             while (false !== ($myrow = $db->fetchArray($result))) {
603 603
                 $block              = new XoopsBlock($myrow);
604
-                $ret[$myrow['bid']] =& $block;
604
+                $ret[$myrow['bid']] = & $block;
605 605
                 unset($block);
606 606
             }
607 607
         }
Please login to merge, or discard this patch.
htdocs/include/findusers.php 2 patches
Indentation   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -352,14 +352,14 @@  discard block
 block discarded – undo
352 352
 
353 353
             $mailok_radio = new XoopsFormRadio(_MA_USER_SHOWMAILOK, 'user_mailok', empty($_POST['user_mailok']) ? 'both' : $_POST['user_mailok']);
354 354
             $mailok_radio->addOptionArray(array(
355
-                                              'mailok' => _MA_USER_MAILOK,
356
-                                              'mailng' => _MA_USER_MAILNG,
357
-                                              'both' => _MA_USER_BOTH));
355
+                                                'mailok' => _MA_USER_MAILOK,
356
+                                                'mailng' => _MA_USER_MAILNG,
357
+                                                'both' => _MA_USER_BOTH));
358 358
             $avatar_radio = new XoopsFormRadio(_MA_USER_HASAVATAR, 'user_avatar', empty($_POST['user_avatar']) ? 'both' : $_POST['user_avatar']);
359 359
             $avatar_radio->addOptionArray(array(
360
-                                              'y' => _YES,
361
-                                              'n' => _NO,
362
-                                              'both' => _MA_USER_BOTH));
360
+                                                'y' => _YES,
361
+                                                'n' => _NO,
362
+                                                'both' => _MA_USER_BOTH));
363 363
 
364 364
             $level_radio = new XoopsFormRadio(_MA_USER_LEVEL, 'level', @$_POST['level']);
365 365
             $levels      = array(
@@ -391,8 +391,8 @@  discard block
 block discarded – undo
391 391
             $form->addElement($rank_select);
392 392
         } else {
393 393
             foreach (array(
394
-                         'uname',
395
-                         'email') as $var) {
394
+                            'uname',
395
+                            'email') as $var) {
396 396
                 $title      = $items_match[$var];
397 397
                 $text       = new XoopsFormText('', $var, 30, 100, @$_POST[$var]);
398 398
                 $match      = new XoopsFormSelectMatchOption('', "{$var}_match", @$_POST["{$var}_match"]);
@@ -406,14 +406,14 @@  discard block
 block discarded – undo
406 406
 
407 407
         $sort_select = new XoopsFormSelect(_MA_USER_SORT, 'user_sort', @$_POST['user_sort']);
408 408
         $sort_select->addOptionArray(array(
409
-                                         'uname' => _MA_USER_UNAME,
410
-                                         'last_login' => _MA_USER_LASTLOGIN,
411
-                                         'user_regdate' => _MA_USER_REGDATE,
412
-                                         'posts' => _MA_USER_POSTS));
409
+                                            'uname' => _MA_USER_UNAME,
410
+                                            'last_login' => _MA_USER_LASTLOGIN,
411
+                                            'user_regdate' => _MA_USER_REGDATE,
412
+                                            'posts' => _MA_USER_POSTS));
413 413
         $order_select = new XoopsFormSelect(_MA_USER_ORDER, 'user_order', @$_POST['user_order']);
414 414
         $order_select->addOptionArray(array(
415
-                                          'ASC' => _MA_USER_ASC,
416
-                                          'DESC' => _MA_USER_DESC));
415
+                                            'ASC' => _MA_USER_ASC,
416
+                                            'DESC' => _MA_USER_DESC));
417 417
 
418 418
         $form->addElement($sort_select);
419 419
         $form->addElement($order_select);
@@ -479,8 +479,8 @@  discard block
 block discarded – undo
479 479
             $criteria->add(new Criteria('user_occ', '%' . $myts->addSlashes(trim($_POST['user_occ'])) . '%', 'LIKE'));
480 480
         }
481 481
         foreach (array(
482
-                     'last_login',
483
-                     'user_regdate') as $var) {
482
+                        'last_login',
483
+                        'user_regdate') as $var) {
484 484
             if (!empty($_POST["{$var}_more"]) && is_numeric($_POST["{$var}_more"])) {
485 485
                 $time = time() - (60 * 60 * 24 * (int)trim($_POST["{$var}_more"]));
486 486
                 if ($time > 0) {
Please login to merge, or discard this patch.
Spacing   +75 added lines, -75 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@  discard block
 block discarded – undo
17 17
  */
18 18
 /* @var  $xoopsUser XoopsUser */
19 19
 
20
-include_once dirname(__DIR__) . '/mainfile.php';
20
+include_once dirname(__DIR__).'/mainfile.php';
21 21
 
22 22
 xoops_header(false);
23 23
 
@@ -36,8 +36,8 @@  discard block
 block discarded – undo
36 36
 
37 37
 $token         = isset($_REQUEST['token']) ? $_REQUEST['token'] : '';
38 38
 $name_form     = 'memberslist';
39
-$name_userid   = 'uid' . (!empty($_REQUEST['multiple']) ? '[]' : '');
40
-$name_username = 'uname' . (!empty($_REQUEST['multiple']) ? '[]' : '');
39
+$name_userid   = 'uid'.(!empty($_REQUEST['multiple']) ? '[]' : '');
40
+$name_username = 'uname'.(!empty($_REQUEST['multiple']) ? '[]' : '');
41 41
 
42 42
 xoops_loadLanguage('findusers');
43 43
 
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
     public function get($id = 0)
105 105
     {
106 106
         $object = $this->create(false);
107
-        $sql    = 'SELECT * FROM ' . $this->db->prefix('ranks') . ' WHERE rank_id = ' . $this->db->quoteString($id);
107
+        $sql    = 'SELECT * FROM '.$this->db->prefix('ranks').' WHERE rank_id = '.$this->db->quoteString($id);
108 108
         if (!$result = $this->db->query($sql)) {
109 109
             $ret = null;
110 110
 
@@ -132,11 +132,11 @@  discard block
 block discarded – undo
132 132
             $criteria = new CriteriaCompo();
133 133
         }
134 134
 
135
-        $sql = 'SELECT rank_id, rank_title FROM ' . $this->db->prefix('ranks');
135
+        $sql = 'SELECT rank_id, rank_title FROM '.$this->db->prefix('ranks');
136 136
         if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) {
137
-            $sql .= ' ' . $criteria->renderWhere();
137
+            $sql .= ' '.$criteria->renderWhere();
138 138
             if ($criteria->getSort() != '') {
139
-                $sql .= ' ORDER BY ' . $criteria->getSort() . ' ' . $criteria->getOrder();
139
+                $sql .= ' ORDER BY '.$criteria->getSort().' '.$criteria->getOrder();
140 140
             }
141 141
             $limit = $criteria->getLimit();
142 142
             $start = $criteria->getStart();
@@ -227,14 +227,14 @@  discard block
 block discarded – undo
227 227
         }
228 228
         $groups = array_filter($groups);
229 229
         if (empty($groups)) {
230
-            $sql = '    SELECT COUNT(DISTINCT u.uid) FROM ' . $this->db->prefix('users') . ' AS u' . '    WHERE 1=1';
230
+            $sql = '    SELECT COUNT(DISTINCT u.uid) FROM '.$this->db->prefix('users').' AS u'.'    WHERE 1=1';
231 231
         } else {
232
-            $sql = '    SELECT COUNT(DISTINCT u.uid) FROM ' . $this->db->prefix('users') . ' AS u' . '    LEFT JOIN ' . $this->db->prefix('groups_users_link') . ' AS g ON g.uid = u.uid' . '    WHERE g.groupid IN (' . implode(', ', array_map('intval', $groups)) . ')';
232
+            $sql = '    SELECT COUNT(DISTINCT u.uid) FROM '.$this->db->prefix('users').' AS u'.'    LEFT JOIN '.$this->db->prefix('groups_users_link').' AS g ON g.uid = u.uid'.'    WHERE g.groupid IN ('.implode(', ', array_map('intval', $groups)).')';
233 233
         }
234 234
         if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) {
235 235
             // Use the direct renderer, assuming no `uid` in criteria
236 236
             if ($render = $criteria->render()) {
237
-                $sql .= ' AND ' . $render;
237
+                $sql .= ' AND '.$render;
238 238
             }
239 239
         }
240 240
         $result = $this->db->query($sql);
@@ -260,16 +260,16 @@  discard block
 block discarded – undo
260 260
         $limit  = null;
261 261
         $start  = null;
262 262
         if (empty($groups)) {
263
-            $sql = '    SELECT u.* FROM ' . $this->db->prefix('users') . ' AS u' . '    WHERE 1=1';
263
+            $sql = '    SELECT u.* FROM '.$this->db->prefix('users').' AS u'.'    WHERE 1=1';
264 264
         } else {
265
-            $sql = '    SELECT u.* FROM ' . $this->db->prefix('users') . ' AS u' . '    LEFT JOIN ' . $this->db->prefix('groups_users_link') . ' AS g ON g.uid = u.uid' . '    WHERE g.groupid IN (' . implode(', ', array_map('intval', $groups)) . ')';
265
+            $sql = '    SELECT u.* FROM '.$this->db->prefix('users').' AS u'.'    LEFT JOIN '.$this->db->prefix('groups_users_link').' AS g ON g.uid = u.uid'.'    WHERE g.groupid IN ('.implode(', ', array_map('intval', $groups)).')';
266 266
         }
267 267
         if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) {
268 268
             if ($render = $criteria->render()) {
269
-                $sql .= ' AND ' . $render;
269
+                $sql .= ' AND '.$render;
270 270
             }
271 271
             if ($sort = $criteria->getSort()) {
272
-                $sql .= ' ORDER BY ' . $sort . ' ' . $criteria->getOrder();
272
+                $sql .= ' ORDER BY '.$sort.' '.$criteria->getOrder();
273 273
                 $orderSet = true;
274 274
             }
275 275
             $limit = $criteria->getLimit();
@@ -428,16 +428,16 @@  discard block
 block discarded – undo
428 428
     $acttotal   = $user_handler->getCount(new Criteria('level', 0, '>'));
429 429
     $inacttotal = $user_handler->getCount(new Criteria('level', 0, '<='));
430 430
     echo '</html><body>';
431
-    echo "<h2 style='text-align:left;'>" . _MA_USER_FINDUS . ' - ' . $modes[$mode] . '</h2>';
431
+    echo "<h2 style='text-align:left;'>"._MA_USER_FINDUS.' - '.$modes[$mode].'</h2>';
432 432
     $modes_switch = array();
433 433
     foreach ($modes as $_mode => $title) {
434 434
         if ($mode == $_mode) {
435 435
             continue;
436 436
         }
437
-        $modes_switch[] = "<a href='findusers.php?target=" . htmlspecialchars(@$_REQUEST['target'], ENT_QUOTES) . '&amp;multiple=' . htmlspecialchars(@$_REQUEST['multiple'], ENT_QUOTES) . '&amp;token=' . htmlspecialchars($token, ENT_QUOTES) . "&amp;mode={$_mode}'>{$title}</a>";
437
+        $modes_switch[] = "<a href='findusers.php?target=".htmlspecialchars(@$_REQUEST['target'], ENT_QUOTES).'&amp;multiple='.htmlspecialchars(@$_REQUEST['multiple'], ENT_QUOTES).'&amp;token='.htmlspecialchars($token, ENT_QUOTES)."&amp;mode={$_mode}'>{$title}</a>";
438 438
     }
439
-    echo '<h4>' . implode(' | ', $modes_switch) . '</h4>';
440
-    echo '(' . sprintf(_MA_USER_ACTUS, "<span style='color:#ff0000;'>$acttotal</span>") . ' ' . sprintf(_MA_USER_INACTUS, "<span style='color:#ff0000;'>$inacttotal</span>") . ')';
439
+    echo '<h4>'.implode(' | ', $modes_switch).'</h4>';
440
+    echo '('.sprintf(_MA_USER_ACTUS, "<span style='color:#ff0000;'>$acttotal</span>").' '.sprintf(_MA_USER_INACTUS, "<span style='color:#ff0000;'>$inacttotal</span>").')';
441 441
     $form->display();
442 442
 } else {
443 443
     $myts  = MyTextSanitizer::getInstance();
@@ -451,32 +451,32 @@  discard block
 block discarded – undo
451 451
                 $value = str_replace('_', "\\\_", $myts->addSlashes(trim($_POST[$var])));
452 452
                 switch ($match) {
453 453
                     case XOOPS_MATCH_START:
454
-                        $criteria->add(new Criteria($var, $value . '%', 'LIKE'));
454
+                        $criteria->add(new Criteria($var, $value.'%', 'LIKE'));
455 455
                         break;
456 456
                     case XOOPS_MATCH_END:
457
-                        $criteria->add(new Criteria($var, '%' . $value, 'LIKE'));
457
+                        $criteria->add(new Criteria($var, '%'.$value, 'LIKE'));
458 458
                         break;
459 459
                     case XOOPS_MATCH_EQUAL:
460 460
                         $criteria->add(new Criteria($var, $value));
461 461
                         break;
462 462
                     case XOOPS_MATCH_CONTAIN:
463
-                        $criteria->add(new Criteria($var, '%' . $value . '%', 'LIKE'));
463
+                        $criteria->add(new Criteria($var, '%'.$value.'%', 'LIKE'));
464 464
                         break;
465 465
                 }
466 466
             }
467 467
         }
468 468
         if (!empty($_POST['url'])) {
469 469
             $url = formatURL(trim($_POST['url']));
470
-            $criteria->add(new Criteria('url', $url . '%', 'LIKE'));
470
+            $criteria->add(new Criteria('url', $url.'%', 'LIKE'));
471 471
         }
472 472
         if (!empty($_POST['user_from'])) {
473
-            $criteria->add(new Criteria('user_from', '%' . $myts->addSlashes(trim($_POST['user_from'])) . '%', 'LIKE'));
473
+            $criteria->add(new Criteria('user_from', '%'.$myts->addSlashes(trim($_POST['user_from'])).'%', 'LIKE'));
474 474
         }
475 475
         if (!empty($_POST['user_intrest'])) {
476
-            $criteria->add(new Criteria('user_intrest', '%' . $myts->addSlashes(trim($_POST['user_intrest'])) . '%', 'LIKE'));
476
+            $criteria->add(new Criteria('user_intrest', '%'.$myts->addSlashes(trim($_POST['user_intrest'])).'%', 'LIKE'));
477 477
         }
478 478
         if (!empty($_POST['user_occ'])) {
479
-            $criteria->add(new Criteria('user_occ', '%' . $myts->addSlashes(trim($_POST['user_occ'])) . '%', 'LIKE'));
479
+            $criteria->add(new Criteria('user_occ', '%'.$myts->addSlashes(trim($_POST['user_occ'])).'%', 'LIKE'));
480 480
         }
481 481
         foreach (array(
482 482
                      'last_login',
@@ -519,7 +519,7 @@  discard block
 block discarded – undo
519 519
                 1 => 1,
520 520
                 2 => 0,
521 521
                 3 => -1);
522
-            $level       = isset($level_value[(int)$_POST['level']]) ? $level_value[(int)$_POST['level']] : 1;
522
+            $level = isset($level_value[(int)$_POST['level']]) ? $level_value[(int)$_POST['level']] : 1;
523 523
             $criteria->add(new Criteria('level', $level));
524 524
         }
525 525
         if (!empty($_POST['rank'])) {
@@ -555,21 +555,21 @@  discard block
 block discarded – undo
555 555
     } else {
556 556
         $query = trim($_POST['query']);
557 557
         // Query with alias
558
-        if (preg_match("/select[\s]+.*[\s]+from[\s]+(" . $xoopsDB->prefix('users') . "[\s]+as[\s]+(\S+).*)/i", $query, $matches)) {
558
+        if (preg_match("/select[\s]+.*[\s]+from[\s]+(".$xoopsDB->prefix('users')."[\s]+as[\s]+(\S+).*)/i", $query, $matches)) {
559 559
             $alias    = $matches[2];
560 560
             $subquery = $matches[1];
561 561
 
562 562
             // Query without alias
563
-        } elseif (preg_match("/select[\s]+.*[\s]+from[\s]+(" . $xoopsDB->prefix('users') . "\b.*)/i", $query, $matches)) {
563
+        } elseif (preg_match("/select[\s]+.*[\s]+from[\s]+(".$xoopsDB->prefix('users')."\b.*)/i", $query, $matches)) {
564 564
             $alias    = '';
565 565
             $subquery = $matches[1];
566 566
 
567 567
             // Invalid query
568 568
         } else {
569
-            $query    = 'SELECT * FROM ' . $xoopsDB->prefix('users');
569
+            $query    = 'SELECT * FROM '.$xoopsDB->prefix('users');
570 570
             $subquery = $xoopsDB->prefix('users');
571 571
         }
572
-        $sql_count = 'SELECT COUNT(DISTINCT ' . (empty($alias) ? '' : $alias . '.') . 'uid) FROM ' . $subquery;
572
+        $sql_count = 'SELECT COUNT(DISTINCT '.(empty($alias) ? '' : $alias.'.').'uid) FROM '.$subquery;
573 573
         $result    = $xoopsDB->query($sql_count);
574 574
         list($total) = $xoopsDB->FetchRow($result);
575 575
         $result     = $xoopsDB->query($query, $limit, $start);
@@ -584,15 +584,15 @@  discard block
 block discarded – undo
584 584
 
585 585
     echo $js_adduser = '
586 586
         <script type="text/javascript">
587
-        var multiple=' . (int)$_REQUEST['multiple'] . ';
587
+        var multiple=' . (int)$_REQUEST['multiple'].';
588 588
         function addusers()
589 589
         {
590 590
             var sel_str = "";
591 591
             var num = 0;
592
-            var mForm = document.forms["' . $name_form . '"];
592
+            var mForm = document.forms["' . $name_form.'"];
593 593
             for (var i=0;i!=mForm.elements.length;i++) {
594 594
                 var id=mForm.elements[i];
595
-                if ( ( (multiple > 0 && id.type == "checkbox") || (multiple == 0 && id.type == "radio") ) && (id.checked == true) && ( id.name == "' . $name_userid . '" ) ) {
595
+                if ( ( (multiple > 0 && id.type == "checkbox") || (multiple == 0 && id.type == "radio") ) && (id.checked == true) && ( id.name == "' . $name_userid.'" ) ) {
596 596
                     var name = mForm.elements[++i];
597 597
                     var len = id.value.length + name.value.length;
598 598
                     sel_str += len + ":" + id.value + ":" + name.value;
@@ -600,12 +600,12 @@  discard block
 block discarded – undo
600 600
                 }
601 601
             }
602 602
             if (num == 0) {
603
-                alert("' . _MA_USER_NOUSERSELECTED . '");
603
+                alert("' . _MA_USER_NOUSERSELECTED.'");
604 604
                 return false;
605 605
             }
606 606
             sel_str = num + ":" + sel_str;
607 607
             window.opener.addusers(sel_str);
608
-            alert("' . _MA_USER_USERADDED . '");
608
+            alert("' . _MA_USER_USERADDED.'");
609 609
             if (multiple == 0) {
610 610
                 window.close();
611 611
                 window.opener.focus();
@@ -616,16 +616,16 @@  discard block
 block discarded – undo
616 616
     ';
617 617
 
618 618
     echo '</html><body>';
619
-    echo "<a href='findusers.php?target=" . htmlspecialchars(@$_POST['target'], ENT_QUOTES) . '&amp;multiple=' . (int)(@$_POST['multiple']) . '&amp;token=' . htmlspecialchars($token, ENT_QUOTES) . "'>" . _MA_USER_FINDUS . "</a>&nbsp;<span style='font-weight:bold;'>&raquo;</span>&nbsp;" . _MA_USER_RESULTS . '<br><br>';
619
+    echo "<a href='findusers.php?target=".htmlspecialchars(@$_POST['target'], ENT_QUOTES).'&amp;multiple='.(int)(@$_POST['multiple']).'&amp;token='.htmlspecialchars($token, ENT_QUOTES)."'>"._MA_USER_FINDUS."</a>&nbsp;<span style='font-weight:bold;'>&raquo;</span>&nbsp;"._MA_USER_RESULTS.'<br><br>';
620 620
     if (empty($start) && empty($foundusers)) {
621
-        echo '<h4>' . _MA_USER_NOFOUND, '</h4>';
621
+        echo '<h4>'._MA_USER_NOFOUND, '</h4>';
622 622
         $hiddenform = "<form name='findnext' action='findusers.php' method='post'>";
623 623
         foreach ($_POST as $k => $v) {
624 624
             if ($k === 'XOOPS_TOKEN_REQUEST') {
625 625
                 // regenerate token value
626
-                $hiddenform .= $GLOBALS['xoopsSecurity']->getTokenHTML() . "\n";
626
+                $hiddenform .= $GLOBALS['xoopsSecurity']->getTokenHTML()."\n";
627 627
             } else {
628
-                $hiddenform .= "<input type='hidden' name='" . htmlspecialchars($k, ENT_QUOTES) . "' value='" . htmlspecialchars($myts->stripSlashesGPC($v), ENT_QUOTES) . "' />\n";
628
+                $hiddenform .= "<input type='hidden' name='".htmlspecialchars($k, ENT_QUOTES)."' value='".htmlspecialchars($myts->stripSlashesGPC($v), ENT_QUOTES)."' />\n";
629 629
             }
630 630
         }
631 631
         if (!isset($_POST['limit'])) {
@@ -634,15 +634,15 @@  discard block
 block discarded – undo
634 634
         if (!isset($_POST['start'])) {
635 635
             $hiddenform .= "<input type='hidden' name='start' value='{$start}' />\n";
636 636
         }
637
-        $hiddenform .= "<input type='hidden' name='token' value='" . htmlspecialchars($token, ENT_QUOTES) . "' />\n";
637
+        $hiddenform .= "<input type='hidden' name='token' value='".htmlspecialchars($token, ENT_QUOTES)."' />\n";
638 638
         $hiddenform .= '</form>';
639 639
 
640
-        echo '<div>' . $hiddenform;
641
-        echo "<a href='#' onclick='document.findnext.start.value=0;document.findnext.user_submit.value=0;document.findnext.submit();'>" . _MA_USER_SEARCHAGAIN . "</a>\n";
640
+        echo '<div>'.$hiddenform;
641
+        echo "<a href='#' onclick='document.findnext.start.value=0;document.findnext.user_submit.value=0;document.findnext.submit();'>"._MA_USER_SEARCHAGAIN."</a>\n";
642 642
         echo '</div>';
643 643
     } elseif ($start < $total) {
644 644
         if (!empty($total)) {
645
-            echo sprintf(_MA_USER_USERSFOUND, $total) . '<br>';
645
+            echo sprintf(_MA_USER_USERSFOUND, $total).'<br>';
646 646
         }
647 647
         if (!empty($foundusers)) {
648 648
             echo "<form action='findusers.php' method='post' name='{$name_form}' id='{$name_form}'>
@@ -653,11 +653,11 @@  discard block
 block discarded – undo
653 653
                 echo "<input type='checkbox' name='memberslist_checkall' id='memberslist_checkall' onclick='xoopsCheckAll(\"{$name_form}\", \"memberslist_checkall\");' />";
654 654
             }
655 655
             echo "</th>
656
-            <th align='center'>" . _MA_USER_UNAME . "</th>
657
-            <th align='center'>" . _MA_USER_REALNAME . "</th>
658
-            <th align='center'>" . _MA_USER_REGDATE . "</th>
659
-            <th align='center'>" . _MA_USER_LASTLOGIN . "</th>
660
-            <th align='center'>" . _MA_USER_POSTS . '</th>
656
+            <th align='center'>" . _MA_USER_UNAME."</th>
657
+            <th align='center'>" . _MA_USER_REALNAME."</th>
658
+            <th align='center'>" . _MA_USER_REGDATE."</th>
659
+            <th align='center'>" . _MA_USER_LASTLOGIN."</th>
660
+            <th align='center'>" . _MA_USER_POSTS.'</th>
661 661
             </tr>';
662 662
             $ucount = 0;
663 663
             foreach (array_keys($foundusers) as $j) {
@@ -670,33 +670,33 @@  discard block
 block discarded – undo
670 670
                 echo "<tr class='$class'>
671 671
                     <td align='center'>";
672 672
                 if (!empty($_POST['multiple'])) {
673
-                    echo "<input type='checkbox' name='{$name_userid}' id='{$name_userid}' value='" . $foundusers[$j]->getVar('uid') . "' />";
674
-                    echo "<input type='hidden' name='{$name_username}' id='{$name_username}' value='" . $foundusers[$j]->getVar('uname') . "' />";
673
+                    echo "<input type='checkbox' name='{$name_userid}' id='{$name_userid}' value='".$foundusers[$j]->getVar('uid')."' />";
674
+                    echo "<input type='hidden' name='{$name_username}' id='{$name_username}' value='".$foundusers[$j]->getVar('uname')."' />";
675 675
                 } else {
676
-                    echo "<input type='radio' name='{$name_userid}' id='{$name_userid}' value='" . $foundusers[$j]->getVar('uid') . "' />";
677
-                    echo "<input type='hidden' name='{$name_username}' id='{$name_username}' value='" . $foundusers[$j]->getVar('uname') . "' />";
676
+                    echo "<input type='radio' name='{$name_userid}' id='{$name_userid}' value='".$foundusers[$j]->getVar('uid')."' />";
677
+                    echo "<input type='hidden' name='{$name_username}' id='{$name_username}' value='".$foundusers[$j]->getVar('uname')."' />";
678 678
                 }
679 679
                 echo "</td>
680
-                    <td><a href='" . XOOPS_URL . '/userinfo.php?uid=' . $foundusers[$j]->getVar('uid') . "' target='_blank'>" . $foundusers[$j]->getVar('uname') . '</a></td>
681
-                    <td>' . $fuser_name . "</td>
682
-                    <td align='center'>" . ($foundusers[$j]->getVar('user_regdate') ? date('Y-m-d', $foundusers[$j]->getVar('user_regdate')) : '') . "</td>
683
-                    <td align='center'>" . ($foundusers[$j]->getVar('last_login') ? date('Y-m-d H:i', $foundusers[$j]->getVar('last_login')) : '') . "</td>
684
-                    <td align='center'>" . $foundusers[$j]->getVar('posts') . '</td>';
680
+                    <td><a href='" . XOOPS_URL.'/userinfo.php?uid='.$foundusers[$j]->getVar('uid')."' target='_blank'>".$foundusers[$j]->getVar('uname').'</a></td>
681
+                    <td>' . $fuser_name."</td>
682
+                    <td align='center'>" . ($foundusers[$j]->getVar('user_regdate') ? date('Y-m-d', $foundusers[$j]->getVar('user_regdate')) : '')."</td>
683
+                    <td align='center'>" . ($foundusers[$j]->getVar('last_login') ? date('Y-m-d H:i', $foundusers[$j]->getVar('last_login')) : '')."</td>
684
+                    <td align='center'>" . $foundusers[$j]->getVar('posts').'</td>';
685 685
                 echo "</tr>\n";
686 686
             }
687 687
             echo "<tr class='foot'><td colspan='6'>";
688 688
 
689 689
             // placeholder for external applications
690 690
             if (empty($_POST['target'])) {
691
-                echo "<select name='fct'><option value='users'>" . _DELETE . "</option><option value='mailusers'>" . _MA_USER_SENDMAIL . '</option>';
691
+                echo "<select name='fct'><option value='users'>"._DELETE."</option><option value='mailusers'>"._MA_USER_SENDMAIL.'</option>';
692 692
                 echo '</select>&nbsp;';
693
-                echo $GLOBALS['xoopsSecurity']->getTokenHTML() . "<input type='submit' value='" . _SUBMIT . "' />";
693
+                echo $GLOBALS['xoopsSecurity']->getTokenHTML()."<input type='submit' value='"._SUBMIT."' />";
694 694
 
695 695
                 // Add selected users
696 696
             } else {
697
-                echo "<input type='button' value='" . _MA_USER_ADD_SELECTED . "' onclick='addusers();' />";
697
+                echo "<input type='button' value='"._MA_USER_ADD_SELECTED."' onclick='addusers();' />";
698 698
             }
699
-            echo "<input type='hidden' name='token' value='" . htmlspecialchars($token, ENT_QUOTES) . "' />\n";
699
+            echo "<input type='hidden' name='token' value='".htmlspecialchars($token, ENT_QUOTES)."' />\n";
700 700
             echo "</td></tr></table></form>\n";
701 701
         }
702 702
 
@@ -704,31 +704,31 @@  discard block
 block discarded – undo
704 704
         foreach ($_POST as $k => $v) {
705 705
             if ($k === 'XOOPS_TOKEN_REQUEST') {
706 706
                 // regenerate token value
707
-                $hiddenform .= $GLOBALS['xoopsSecurity']->getTokenHTML() . "\n";
707
+                $hiddenform .= $GLOBALS['xoopsSecurity']->getTokenHTML()."\n";
708 708
             } else {
709
-                $hiddenform .= "<input type='hidden' name='" . htmlspecialchars($k, ENT_QUOTES) . "' value='" . htmlspecialchars($myts->stripSlashesGPC($v), ENT_QUOTES) . "' />\n";
709
+                $hiddenform .= "<input type='hidden' name='".htmlspecialchars($k, ENT_QUOTES)."' value='".htmlspecialchars($myts->stripSlashesGPC($v), ENT_QUOTES)."' />\n";
710 710
             }
711 711
         }
712 712
         if (!isset($_POST['limit'])) {
713
-            $hiddenform .= "<input type='hidden' name='limit' value='" . $limit . "' />\n";
713
+            $hiddenform .= "<input type='hidden' name='limit' value='".$limit."' />\n";
714 714
         }
715 715
         if (!isset($_POST['start'])) {
716
-            $hiddenform .= "<input type='hidden' name='start' value='" . $start . "' />\n";
716
+            $hiddenform .= "<input type='hidden' name='start' value='".$start."' />\n";
717 717
         }
718
-        $hiddenform .= "<input type='hidden' name='token' value='" . htmlspecialchars($token, ENT_QUOTES) . "' />\n";
718
+        $hiddenform .= "<input type='hidden' name='token' value='".htmlspecialchars($token, ENT_QUOTES)."' />\n";
719 719
         if (!isset($total) || ($totalpages = ceil($total / $limit)) > 1) {
720 720
             $prev = $start - $limit;
721 721
             if ($start - $limit >= 0) {
722
-                $hiddenform .= "<a href='#0' onclick='document.findnext.start.value=" . $prev . ";document.findnext.submit();'>" . _MA_USER_PREVIOUS . "</a>&nbsp;\n";
722
+                $hiddenform .= "<a href='#0' onclick='document.findnext.start.value=".$prev.";document.findnext.submit();'>"._MA_USER_PREVIOUS."</a>&nbsp;\n";
723 723
             }
724 724
             $counter     = 1;
725 725
             $currentpage = ($start + $limit) / $limit;
726 726
             if (!isset($total)) {
727 727
                 while ($counter <= $currentpage) {
728 728
                     if ($counter == $currentpage) {
729
-                        $hiddenform .= '<strong>' . $counter . '</strong> ';
729
+                        $hiddenform .= '<strong>'.$counter.'</strong> ';
730 730
                     } elseif (($counter > $currentpage - 4 && $counter < $currentpage + 4) || $counter == 1) {
731
-                        $hiddenform .= "<a href='#" . $counter . "' onclick='document.findnext.start.value=" . ($counter - 1) * $limit . ";document.findnext.submit();'>" . $counter . '</a> ';
731
+                        $hiddenform .= "<a href='#".$counter."' onclick='document.findnext.start.value=".($counter - 1) * $limit.";document.findnext.submit();'>".$counter.'</a> ';
732 732
                         if ($counter == 1 && $currentpage > 5) {
733 733
                             $hiddenform .= '... ';
734 734
                         }
@@ -738,12 +738,12 @@  discard block
 block discarded – undo
738 738
             } else {
739 739
                 while ($counter <= $totalpages) {
740 740
                     if ($counter == $currentpage) {
741
-                        $hiddenform .= '<strong>' . $counter . '</strong> ';
741
+                        $hiddenform .= '<strong>'.$counter.'</strong> ';
742 742
                     } elseif (($counter > $currentpage - 4 && $counter < $currentpage + 4) || $counter == 1 || $counter == $totalpages) {
743 743
                         if ($counter == $totalpages && $currentpage < $totalpages - 4) {
744 744
                             $hiddenform .= '... ';
745 745
                         }
746
-                        $hiddenform .= "<a href='#" . $counter . "' onclick='document.findnext.start.value=" . ($counter - 1) * $limit . ";document.findnext.submit();'>" . $counter . '</a> ';
746
+                        $hiddenform .= "<a href='#".$counter."' onclick='document.findnext.start.value=".($counter - 1) * $limit.";document.findnext.submit();'>".$counter.'</a> ';
747 747
                         if ($counter == 1 && $currentpage > 5) {
748 748
                             $hiddenform .= '... ';
749 749
                         }
@@ -754,16 +754,16 @@  discard block
 block discarded – undo
754 754
 
755 755
             $next = $start + $limit;
756 756
             if ((isset($total) && $total > $next) || (!isset($total) && count($foundusers) >= $limit)) {
757
-                $hiddenform .= "&nbsp;<a href='#" . $total . "' onclick='document.findnext.start.value=" . $next . ";document.findnext.submit();'>" . _MA_USER_NEXT . "</a>\n";
757
+                $hiddenform .= "&nbsp;<a href='#".$total."' onclick='document.findnext.start.value=".$next.";document.findnext.submit();'>"._MA_USER_NEXT."</a>\n";
758 758
             }
759 759
         }
760 760
         $hiddenform .= '</form>';
761 761
 
762
-        echo '<div>' . $hiddenform;
762
+        echo '<div>'.$hiddenform;
763 763
         if (isset($total)) {
764
-            echo '<br>' . sprintf(_MA_USER_USERSFOUND, $total) . '&nbsp;';
764
+            echo '<br>'.sprintf(_MA_USER_USERSFOUND, $total).'&nbsp;';
765 765
         }
766
-        echo "<a href='#' onclick='document.findnext.start.value=0;document.findnext.user_submit.value=0;document.findnext.submit();'>" . _MA_USER_SEARCHAGAIN . "</a>\n";
766
+        echo "<a href='#' onclick='document.findnext.start.value=0;document.findnext.user_submit.value=0;document.findnext.submit();'>"._MA_USER_SEARCHAGAIN."</a>\n";
767 767
         echo '</div>';
768 768
     }
769 769
 }
Please login to merge, or discard this patch.
htdocs/class/model/read.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
             if (!in_array($this->handler->keyName, $fields)) {
43 43
                 $fields[] = $this->handler->keyName;
44 44
             }
45
-            $select = '`' . implode('`, `', $fields) . '`';
45
+            $select = '`'.implode('`, `', $fields).'`';
46 46
         } else {
47 47
             $select = '*';
48 48
         }
@@ -50,12 +50,12 @@  discard block
 block discarded – undo
50 50
         $start = null;
51 51
         $sql   = "SELECT {$select} FROM `{$this->handler->table}`";
52 52
         if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) {
53
-            $sql .= ' ' . $criteria->renderWhere();
53
+            $sql .= ' '.$criteria->renderWhere();
54 54
             if ($groupby = $criteria->getGroupby()) {
55 55
                 $sql .= $groupby;
56 56
             }
57 57
             if ($sort = $criteria->getSort()) {
58
-                $sql .= " ORDER BY {$sort} " . $criteria->getOrder();
58
+                $sql .= " ORDER BY {$sort} ".$criteria->getOrder();
59 59
                 $orderSet = true;
60 60
             }
61 61
             $limit = $criteria->getLimit();
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
      */
106 106
     public function &getObjects(CriteriaElement $criteria = null, $id_as_key = false, $as_object = true)
107 107
     {
108
-        $objects =& $this->getAll($criteria, null, $as_object, $id_as_key);
108
+        $objects = & $this->getAll($criteria, null, $as_object, $id_as_key);
109 109
 
110 110
         return $objects;
111 111
     }
@@ -131,9 +131,9 @@  discard block
 block discarded – undo
131 131
         }
132 132
         $sql .= " FROM `{$this->handler->table}`";
133 133
         if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) {
134
-            $sql .= ' ' . $criteria->renderWhere();
134
+            $sql .= ' '.$criteria->renderWhere();
135 135
             if ($sort = $criteria->getSort()) {
136
-                $sql .= ' ORDER BY ' . $sort . ' ' . $criteria->getOrder();
136
+                $sql .= ' ORDER BY '.$sort.' '.$criteria->getOrder();
137 137
             }
138 138
             $limit = $criteria->getLimit();
139 139
             $start = $criteria->getStart();
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
         $sql   = "SELECT `{$this->handler->keyName}` FROM `{$this->handler->table}`";
165 165
         $limit = $start = null;
166 166
         if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) {
167
-            $sql .= ' ' . $criteria->renderWhere();
167
+            $sql .= ' '.$criteria->renderWhere();
168 168
             $limit = $criteria->getLimit();
169 169
             $start = $criteria->getStart();
170 170
         }
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
      */
193 193
     public function &getByLimit($limit = 0, $start = 0, CriteriaElement $criteria = null, $fields = null, $asObject = true)
194 194
     {
195
-        $GLOBALS['xoopsLogger']->addDeprecated(__CLASS__ . '::' . __FUNCTION__ . '() is deprecated, please use getAll instead.');
195
+        $GLOBALS['xoopsLogger']->addDeprecated(__CLASS__.'::'.__FUNCTION__.'() is deprecated, please use getAll instead.');
196 196
         if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) {
197 197
             $criteria->setLimit($limit);
198 198
             $criteria->setStart($start);
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
      */
217 217
     public function convertResultSet($result, $id_as_key = false, $as_object = true)
218 218
     {
219
-        $GLOBALS['xoopsLogger']->addDeprecated(__CLASS__ . '::' . __FUNCTION__ . '() is deprecated.');
219
+        $GLOBALS['xoopsLogger']->addDeprecated(__CLASS__.'::'.__FUNCTION__.'() is deprecated.');
220 220
         $ret = array();
221 221
         while (false !== ($myrow = $this->handler->db->fetchArray($result))) {
222 222
             $obj = $this->handler->create(false);
@@ -234,7 +234,7 @@  discard block
 block discarded – undo
234 234
                 }
235 235
             } else {
236 236
                 if ($as_object) {
237
-                    $ret[$myrow[$this->handler->keyName]] =& $obj;
237
+                    $ret[$myrow[$this->handler->keyName]] = & $obj;
238 238
                 } else {
239 239
                     $row  = array();
240 240
                     $vars = $obj->getVars();
Please login to merge, or discard this patch.
htdocs/class/model/stats.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -40,12 +40,12 @@  discard block
 block discarded – undo
40 40
         if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) {
41 41
             if ($criteria->groupby != '') {
42 42
                 $groupby = true;
43
-                $field   = $criteria->groupby . ', ';
43
+                $field   = $criteria->groupby.', ';
44 44
             }
45 45
         }
46 46
         $sql = "SELECT {$field} COUNT(*) FROM `{$this->handler->table}`";
47 47
         if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) {
48
-            $sql .= ' ' . $criteria->renderWhere();
48
+            $sql .= ' '.$criteria->renderWhere();
49 49
             $sql .= $criteria->getGroupby();
50 50
         }
51 51
         $result = $this->handler->db->query($sql);
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
                 $groupby_key = $groupby;
88 88
             }
89 89
         }
90
-        $sql = "SELECT {$groupby_key}, COUNT(*) AS count" . " FROM `{$this->handler->table}`" . " {$sql_where}" . " GROUP BY {$groupby_key}";
90
+        $sql = "SELECT {$groupby_key}, COUNT(*) AS count"." FROM `{$this->handler->table}`"." {$sql_where}"." GROUP BY {$groupby_key}";
91 91
         if (!$result = $this->handler->db->query($sql, $limit, $start)) {
92 92
             return $ret;
93 93
         }
Please login to merge, or discard this patch.
htdocs/class/model/write.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
                         continue 2;
180 180
                     }
181 181
                     if ($cleanv != '' && !preg_match("/^http[s]*:\/\//i", $cleanv)) {
182
-                        $cleanv = XOOPS_PROT . $cleanv;
182
+                        $cleanv = XOOPS_PROT.$cleanv;
183 183
                     }
184 184
                     if (!$v['not_gpc']) {
185 185
                         $cleanv = $ts->stripSlashesGPC($cleanv);
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
                         continue 2;
194 194
                     }
195 195
                     if ($cleanv != '' && !preg_match("/^http[s]*:\/\//i", $cleanv)) {
196
-                        $cleanv = XOOPS_PROT . $cleanv;
196
+                        $cleanv = XOOPS_PROT.$cleanv;
197 197
                     }
198 198
                     if (!$v['not_gpc']) {
199 199
                         $cleanv = $ts->stripSlashesGPC($cleanv);
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
                         $cleanv[$key] = str_replace('\\"', '"', addslashes($cleanv[$key]));
232 232
                     }
233 233
                     // TODO: Not encoding safe, should try base64_encode -- phppp
234
-                    $cleanv = "'" . serialize(array_walk($cleanv, 'xoops_aw_encode')) . "'";
234
+                    $cleanv = "'".serialize(array_walk($cleanv, 'xoops_aw_encode'))."'";
235 235
                     break;
236 236
 
237 237
                 case XOBJ_DTYPE_ARRAY:
@@ -273,25 +273,25 @@  discard block
 block discarded – undo
273 273
     public function insert(&$object, $force = true)
274 274
     {
275 275
         if (!$object->isDirty()) {
276
-            trigger_error("Data entry is not inserted - the object '" . get_class($object) . "' is not dirty", E_USER_NOTICE);
276
+            trigger_error("Data entry is not inserted - the object '".get_class($object)."' is not dirty", E_USER_NOTICE);
277 277
 
278 278
             return $object->getVar($this->handler->keyName);
279 279
         }
280 280
         if (!$this->cleanVars($object)) {
281
-            trigger_error("Insert failed in method 'cleanVars' of object '" . get_class($object) . "'", E_USER_WARNING);
281
+            trigger_error("Insert failed in method 'cleanVars' of object '".get_class($object)."'", E_USER_WARNING);
282 282
 
283 283
             return $object->getVar($this->handler->keyName);
284 284
         }
285 285
         $queryFunc = empty($force) ? 'query' : 'queryF';
286 286
 
287 287
         if ($object->isNew()) {
288
-            $sql = 'INSERT INTO `' . $this->handler->table . '`';
288
+            $sql = 'INSERT INTO `'.$this->handler->table.'`';
289 289
             if (!empty($object->cleanVars)) {
290 290
                 $keys = array_keys($object->cleanVars);
291 291
                 $vals = array_values($object->cleanVars);
292
-                $sql .= ' (`' . implode('`, `', $keys) . '`) VALUES (' . implode(',', $vals) . ')';
292
+                $sql .= ' (`'.implode('`, `', $keys).'`) VALUES ('.implode(',', $vals).')';
293 293
             } else {
294
-                trigger_error("Data entry is not inserted - no variable is changed in object of '" . get_class($object) . "'", E_USER_NOTICE);
294
+                trigger_error("Data entry is not inserted - no variable is changed in object of '".get_class($object)."'", E_USER_NOTICE);
295 295
 
296 296
                 return $object->getVar($this->handler->keyName);
297 297
             }
@@ -306,7 +306,7 @@  discard block
 block discarded – undo
306 306
             foreach ($object->cleanVars as $k => $v) {
307 307
                 $keys[] = " `{$k}` = {$v}";
308 308
             }
309
-            $sql = 'UPDATE `' . $this->handler->table . '` SET ' . implode(',', $keys) . ' WHERE `' . $this->handler->keyName . '` = ' . $this->handler->db->quote($object->getVar($this->handler->keyName));
309
+            $sql = 'UPDATE `'.$this->handler->table.'` SET '.implode(',', $keys).' WHERE `'.$this->handler->keyName.'` = '.$this->handler->db->quote($object->getVar($this->handler->keyName));
310 310
             if (!$result = $this->handler->db->{$queryFunc}($sql)) {
311 311
                 return false;
312 312
             }
@@ -328,13 +328,13 @@  discard block
 block discarded – undo
328 328
             $clause = array();
329 329
             $thishandlerkeyNameCount = count($this->handler->keyName);
330 330
             for ($i = 0; $i < $thishandlerkeyNameCount; ++$i) {
331
-                $clause[] = '`' . $this->handler->keyName[$i] . '` = ' . $this->handler->db->quote($object->getVar($this->handler->keyName[$i]));
331
+                $clause[] = '`'.$this->handler->keyName[$i].'` = '.$this->handler->db->quote($object->getVar($this->handler->keyName[$i]));
332 332
             }
333 333
             $whereclause = implode(' AND ', $clause);
334 334
         } else {
335
-            $whereclause = '`' . $this->handler->keyName . '` = ' . $this->handler->db->quote($object->getVar($this->handler->keyName));
335
+            $whereclause = '`'.$this->handler->keyName.'` = '.$this->handler->db->quote($object->getVar($this->handler->keyName));
336 336
         }
337
-        $sql       = 'DELETE FROM `' . $this->handler->table . '` WHERE ' . $whereclause;
337
+        $sql       = 'DELETE FROM `'.$this->handler->table.'` WHERE '.$whereclause;
338 338
         $queryFunc = empty($force) ? 'query' : 'queryF';
339 339
         $result    = $this->handler->db->{$queryFunc}($sql);
340 340
 
@@ -362,10 +362,10 @@  discard block
 block discarded – undo
362 362
             return $num;
363 363
         }
364 364
         $queryFunc = empty($force) ? 'query' : 'queryF';
365
-        $sql       = 'DELETE FROM ' . $this->handler->table;
365
+        $sql       = 'DELETE FROM '.$this->handler->table;
366 366
         if (!empty($criteria)) {
367 367
             if (is_subclass_of($criteria, 'CriteriaElement')) {
368
-                $sql .= ' ' . $criteria->renderWhere();
368
+                $sql .= ' '.$criteria->renderWhere();
369 369
             } else {
370 370
                 return false;
371 371
             }
@@ -396,9 +396,9 @@  discard block
 block discarded – undo
396 396
         } else {
397 397
             $set_clause .= $this->handler->db->quote($fieldvalue);
398 398
         }
399
-        $sql = 'UPDATE `' . $this->handler->table . '` SET ' . $set_clause;
399
+        $sql = 'UPDATE `'.$this->handler->table.'` SET '.$set_clause;
400 400
         if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) {
401
-            $sql .= ' ' . $criteria->renderWhere();
401
+            $sql .= ' '.$criteria->renderWhere();
402 402
         }
403 403
         $queryFunc = empty($force) ? 'query' : 'queryF';
404 404
         $result    = $this->handler->db->{$queryFunc}($sql);
Please login to merge, or discard this patch.
htdocs/class/model/joint.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -80,8 +80,8 @@  discard block
 block discarded – undo
80 80
         }
81 81
 
82 82
         if (is_array($fields) && count($fields)) {
83
-            if (!in_array('o.' . $this->handler->keyName, $fields)) {
84
-                $fields[] = 'o.' . $this->handler->keyName;
83
+            if (!in_array('o.'.$this->handler->keyName, $fields)) {
84
+                $fields[] = 'o.'.$this->handler->keyName;
85 85
             }
86 86
             $select = implode(',', $fields);
87 87
         } else {
@@ -90,11 +90,11 @@  discard block
 block discarded – undo
90 90
         $limit = null;
91 91
         $start = null;
92 92
         // $field_object = empty($field_object) ? $field_link : $field_object;
93
-        $sql = " SELECT {$select}" . " FROM {$this->handler->table} AS o" . " LEFT JOIN {$this->handler->table_link} AS l ON o.{$this->handler->field_object} = l.{$this->handler->field_link}";
93
+        $sql = " SELECT {$select}"." FROM {$this->handler->table} AS o"." LEFT JOIN {$this->handler->table_link} AS l ON o.{$this->handler->field_object} = l.{$this->handler->field_link}";
94 94
         if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) {
95
-            $sql .= ' ' . $criteria->renderWhere();
95
+            $sql .= ' '.$criteria->renderWhere();
96 96
             if ($sort = $criteria->getSort()) {
97
-                $sql .= " ORDER BY {$sort} " . $criteria->getOrder();
97
+                $sql .= " ORDER BY {$sort} ".$criteria->getOrder();
98 98
                 $orderSet = true;
99 99
             }
100 100
             $limit = $criteria->getLimit();
@@ -136,9 +136,9 @@  discard block
 block discarded – undo
136 136
             return null;
137 137
         }
138 138
 
139
-        $sql = " SELECT COUNT(DISTINCT o.{$this->handler->keyName}) AS count" . " FROM {$this->handler->table} AS o" . " LEFT JOIN {$this->handler->table_link} AS l ON o.{$this->handler->field_object} = l.{$this->handler->field_link}";
139
+        $sql = " SELECT COUNT(DISTINCT o.{$this->handler->keyName}) AS count"." FROM {$this->handler->table} AS o"." LEFT JOIN {$this->handler->table_link} AS l ON o.{$this->handler->field_object} = l.{$this->handler->field_link}";
140 140
         if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) {
141
-            $sql .= ' ' . $criteria->renderWhere();
141
+            $sql .= ' '.$criteria->renderWhere();
142 142
         }
143 143
         if (!$result = $this->handler->db->query($sql)) {
144 144
             return false;
@@ -159,9 +159,9 @@  discard block
 block discarded – undo
159 159
         if (!$this->validateLinks()) {
160 160
             return null;
161 161
         }
162
-        $sql = " SELECT l.{$this->handler->field_link}, COUNT(*)" . " FROM {$this->handler->table} AS o" . " LEFT JOIN {$this->handler->table_link} AS l ON o.{$this->handler->field_object} = l.{$this->handler->field_link}";
162
+        $sql = " SELECT l.{$this->handler->field_link}, COUNT(*)"." FROM {$this->handler->table} AS o"." LEFT JOIN {$this->handler->table_link} AS l ON o.{$this->handler->field_object} = l.{$this->handler->field_link}";
163 163
         if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) {
164
-            $sql .= ' ' . $criteria->renderWhere();
164
+            $sql .= ' '.$criteria->renderWhere();
165 165
         }
166 166
         $sql .= " GROUP BY l.{$this->handler->field_link}";
167 167
         if (!$result = $this->handler->db->query($sql)) {
@@ -189,11 +189,11 @@  discard block
 block discarded – undo
189 189
         }
190 190
         $set = array();
191 191
         foreach ($data as $key => $val) {
192
-            $set[] = "o.{$key}=" . $this->handler->db->quoteString($val);
192
+            $set[] = "o.{$key}=".$this->handler->db->quoteString($val);
193 193
         }
194
-        $sql = " UPDATE {$this->handler->table} AS o" . ' SET ' . implode(', ', $set) . " LEFT JOIN {$this->handler->table_link} AS l ON o.{$this->handler->field_object} = l.{$this->handler->field_link}";
194
+        $sql = " UPDATE {$this->handler->table} AS o".' SET '.implode(', ', $set)." LEFT JOIN {$this->handler->table_link} AS l ON o.{$this->handler->field_object} = l.{$this->handler->field_link}";
195 195
         if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) {
196
-            $sql .= ' ' . $criteria->renderWhere();
196
+            $sql .= ' '.$criteria->renderWhere();
197 197
         }
198 198
 
199 199
         return $this->handler->db->query($sql);
@@ -210,9 +210,9 @@  discard block
 block discarded – undo
210 210
         if (!$this->validateLinks()) {
211 211
             return null;
212 212
         }
213
-        $sql = "DELETE FROM {$this->handler->table} AS o " . " LEFT JOIN {$this->handler->table_link} AS l ON o.{$this->handler->field_object} = l.{$this->handler->field_link}";
213
+        $sql = "DELETE FROM {$this->handler->table} AS o "." LEFT JOIN {$this->handler->table_link} AS l ON o.{$this->handler->field_object} = l.{$this->handler->field_link}";
214 214
         if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) {
215
-            $sql .= ' ' . $criteria->renderWhere();
215
+            $sql .= ' '.$criteria->renderWhere();
216 216
         }
217 217
 
218 218
         return $this->handler->db->query($sql);
Please login to merge, or discard this patch.
htdocs/class/xoopsform/form.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
                     @$var['func'] = $this->getArrayID($value, $key, $var['func'], $hashinfo);
168 168
                 }
169 169
 
170
-                @$this->_objid = md5($var['name'] . ':' . $var['func'] . ':' . $var['value']);
170
+                @$this->_objid = md5($var['name'].':'.$var['func'].':'.$var['value']);
171 171
 
172 172
                 return $this->_objid;
173 173
                 break;
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
186 186
                     @$var['func'] = $this->getArrayID($value, $key, $var['func'], $hashinfo);
187 187
                 }
188 188
 
189
-                @$this->_objid = sha1($var['name'] . ':' . $var['func'] . ':' . $var['value']);
189
+                @$this->_objid = sha1($var['name'].':'.$var['func'].':'.$var['value']);
190 190
 
191 191
                 return $this->_objid;
192 192
 
@@ -207,10 +207,10 @@  discard block
 block discarded – undo
207 207
             case 'md5':
208 208
                 if (is_array($value)) {
209 209
                     foreach ($value as $keyb => $valueb) {
210
-                        @$ret = md5($ret . ':' . $this->getArrayID($valueb, $keyb, $ret, $hashinfo));
210
+                        @$ret = md5($ret.':'.$this->getArrayID($valueb, $keyb, $ret, $hashinfo));
211 211
                     }
212 212
                 } else {
213
-                    @$ret = md5($ret . ':' . $key . ':' . $value);
213
+                    @$ret = md5($ret.':'.$key.':'.$value);
214 214
                 }
215 215
 
216 216
                 return $ret;
@@ -218,10 +218,10 @@  discard block
 block discarded – undo
218 218
             default:
219 219
                 if (is_array($value)) {
220 220
                     foreach ($value as $keyb => $valueb) {
221
-                        @$ret = sha1($ret . ':' . $this->getArrayID($valueb, $keyb, $ret, $hashinfo));
221
+                        @$ret = sha1($ret.':'.$this->getArrayID($valueb, $keyb, $ret, $hashinfo));
222 222
                     }
223 223
                 } else {
224
-                    @$ret = sha1($ret . ':' . $key . ':' . $value);
224
+                    @$ret = sha1($ret.':'.$key.':'.$value);
225 225
                 }
226 226
 
227 227
                 return $ret;
@@ -372,7 +372,7 @@  discard block
 block discarded – undo
372 372
      */
373 373
     public function &getElementByName($name)
374 374
     {
375
-        $elements =& $this->getElements(true);
375
+        $elements = & $this->getElements(true);
376 376
         $count    = count($elements);
377 377
         for ($i = 0; $i < $count; ++$i) {
378 378
             if ($name == $elements[$i]->getName(false)) {
@@ -488,7 +488,7 @@  discard block
 block discarded – undo
488 488
      */
489 489
     public function &getExtra()
490 490
     {
491
-        $extra = empty($this->_extra) ? '' : ' ' . implode(' ', $this->_extra);
491
+        $extra = empty($this->_extra) ? '' : ' '.implode(' ', $this->_extra);
492 492
 
493 493
         return $extra;
494 494
     }
@@ -576,7 +576,7 @@  discard block
 block discarded – undo
576 576
         }
577 577
         $formname = $this->getName();
578 578
         $js .= "function xoopsFormValidate_{$formname}() { var myform = window.document.{$formname}; ";
579
-        $elements =& $this->getElements(true);
579
+        $elements = & $this->getElements(true);
580 580
         foreach ($elements as $elt) {
581 581
             if (method_exists($elt, 'renderValidationJS')) {
582 582
                 $js .= $elt->renderValidationJS();
@@ -601,7 +601,7 @@  discard block
 block discarded – undo
601 601
         $i        = -1;
602 602
         $elements = array();
603 603
         if (count($this->getRequired()) > 0) {
604
-            $this->_elements[] = "<tr class='foot'><td colspan='2'>* = " . _REQUIRED . '</td></tr>';
604
+            $this->_elements[] = "<tr class='foot'><td colspan='2'>* = "._REQUIRED.'</td></tr>';
605 605
         }
606 606
         foreach ($this->getElements() as $ele) {
607 607
             ++$i;
@@ -627,7 +627,7 @@  discard block
 block discarded – undo
627 627
             'name'       => $this->getName(),
628 628
             'action'     => $this->getAction(),
629 629
             'method'     => $this->getMethod(),
630
-            'extra'      => 'onsubmit="return xoopsFormValidate_' . $this->getName() . '();"' . $this->getExtra(),
630
+            'extra'      => 'onsubmit="return xoopsFormValidate_'.$this->getName().'();"'.$this->getExtra(),
631 631
             'javascript' => $js,
632 632
             'elements'   => $elements,
633 633
             'rendered'   => $this->render(),
Please login to merge, or discard this patch.
htdocs/class/xml/saxparser.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -260,7 +260,7 @@  discard block
 block discarded – undo
260 260
      */
261 261
     public function handleCharacterData($parser, $data)
262 262
     {
263
-        $tagHandler =& $this->tagHandlers[$this->getCurrentTag()];
263
+        $tagHandler = & $this->tagHandlers[$this->getCurrentTag()];
264 264
         if (isset($tagHandler) && is_subclass_of($tagHandler, 'XmlTagHandler')) {
265 265
             $tagHandler->handleCharacterData($this, $data);
266 266
         } else {
@@ -386,7 +386,7 @@  discard block
 block discarded – undo
386 386
             $ret = '';
387 387
             if (count($this->errors) > 0) {
388 388
                 foreach ($this->errors as $error) {
389
-                    $ret .= $error . '<br>';
389
+                    $ret .= $error.'<br>';
390 390
                 }
391 391
             }
392 392
 
Please login to merge, or discard this patch.