FileForm::__construct() - Code Metrics - Inspection of "Feature/publisher namespaces" - XOOPS/XoopsCore - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#598)

by Michael

created 2019-05-15 16:03 UTC

FileForm::__construct() A

↳ Parent: FileForm

Complexity

Conditions	2
Paths	2

Size

Total Lines	60
Code Lines	39

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	39
nc	2
nop	1
dl	0
loc	60
rs	9.296
c	0
b	0
f	0

How to fix Long Method

<?php

namespace XoopsModules\Publisher\Form;

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 *  Publisher form class
 *
 * @copyright       The XUUPS Project http://sourceforge.net/projects/xuups/
 * @license         GNU GPL V2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
 * @package         Publisher
 * @since           1.0
 * @author          trabis <[email protected]>
 * @version         $Id$
 */
use Xoops;
use Xoops\Form\Button;
use Xoops\Form\ElementTray;
use Xoops\Form\File;
use Xoops\Form\Hidden;
use Xoops\Form\RadioYesNo;
use Xoops\Form\Text;
use Xoops\Form\TextArea;
use Xoops\Form\ThemeForm;
use XoopsModules\Publisher;
use XoopsModules\Publisher\Helper;

require_once \dirname(\dirname(__DIR__)) . '/include/common.php';

/**
 * Class FileForm
 * @package XoopsModules\Publisher\Form
 */
class FileForm extends ThemeForm
{
    public function __construct(Publisher\File $obj)
    {
        $xoops = Xoops::getInstance();
        $helper = Helper::getInstance();
        $helper->loadLanguage('main');

        parent::__construct(_AM_PUBLISHER_UPLOAD_FILE, 'form', $xoops->getEnv('PHP_SELF'));
        $this->setExtra('enctype="multipart/form-data"');

        // NAME
        $name_text = new Text(_CO_PUBLISHER_FILENAME, 'name', 50, 255, $obj->getVar('name'));
        $name_text = new Text(_CO_PUBLISHER_FILENAME, 'name', 50, 255, /** @scrutinizer ignore-type */ $obj->getVar('name'));
        $name_text->setDescription(_CO_PUBLISHER_FILE_NAME_DSC);
        $this->addElement($name_text, true);

        // DESCRIPTION
        $description_text = new TextArea(_CO_PUBLISHER_FILE_DESCRIPTION, 'description', $obj->getVar('description'));
        $description_text = new TextArea(_CO_PUBLISHER_FILE_DESCRIPTION, 'description', /** @scrutinizer ignore-type */ $obj->getVar('description'));
        $description_text->setDescription(_CO_PUBLISHER_FILE_DESCRIPTION_DSC);
        $this->addElement($description_text);

        // FILE TO UPLOAD
        $file_box = new File(_CO_PUBLISHER_FILE_TO_UPLOAD, 'item_upload_file');
        $file_box->set('size', 50);
        $this->addElement($file_box);

        $status_select = new RadioYesNo(_CO_PUBLISHER_FILE_STATUS, 'file_status', _PUBLISHER_STATUS_FILE_ACTIVE);
        $status_select->setDescription(_CO_PUBLISHER_FILE_STATUS_DSC);
        $this->addElement($status_select);

        // fileid
        $this->addElement(new Hidden('fileid', $obj->getVar('fileid')));
        $this->addElement(new Hidden('fileid', /** @scrutinizer ignore-type */ $obj->getVar('fileid')));

        // itemid
        $this->addElement(new Hidden('itemid', $obj->getVar('itemid')));

        $files_button_tray = new ElementTray('', '');
        $files_hidden = new Hidden('op', 'uploadfile');
        $files_button_tray->addElement($files_hidden);

        if (!$obj->getVar('fileid')) {
            $files_butt_create = new Button('', '', _MD_PUBLISHER_UPLOAD, 'submit');
            $files_butt_create->setExtra('onclick="this.form.elements.op.value=\'uploadfile\'"');
            /** @scrutinizer ignore-deprecated */ $files_butt_create->setExtra('onclick="this.form.elements.op.value=\'uploadfile\'"');
            $files_button_tray->addElement($files_butt_create);

            $files_butt_another = new Button('', '', _CO_PUBLISHER_FILE_UPLOAD_ANOTHER, 'submit');
            $files_butt_another->setExtra('onclick="this.form.elements.op.value=\'uploadanother\'"');
            /** @scrutinizer ignore-deprecated */ $files_butt_another->setExtra('onclick="this.form.elements.op.value=\'uploadanother\'"');
            $files_button_tray->addElement($files_butt_another);
        } else {
            $files_butt_create = new Button('', '', _MD_PUBLISHER_MODIFY, 'submit');
            $files_butt_create->setExtra('onclick="this.form.elements.op.value=\'modify\'"');
            /** @scrutinizer ignore-deprecated */ $files_butt_create->setExtra('onclick="this.form.elements.op.value=\'modify\'"');
            $files_button_tray->addElement($files_butt_create);
        }

        $files_butt_clear = new Button('', '', _MD_PUBLISHER_CLEAR, 'reset');
        $files_button_tray->addElement($files_butt_clear);

        $buttonCancel = new Button('', '', _MD_PUBLISHER_CANCEL, 'button');
        $buttonCancel->setExtra('onclick="history.go(-1)"');
        /** @scrutinizer ignore-deprecated */ $buttonCancel->setExtra('onclick="history.go(-1)"');
        $files_button_tray->addElement($buttonCancel);

        $this->addElement($files_button_tray);
    }
}


XOOPS / XoopsCore

Pull Request — master (#598)

FileForm::__construct() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like