XoopsModules\Publisher\Form\FileForm

Complexity

Total Complexity

2

Size/Duplication

Total Lines	62
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	60	2

<?php

namespace XoopsModules\Publisher\Form;

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 *  Publisher form class
 *
 * @copyright       The XUUPS Project http://sourceforge.net/projects/xuups/
 * @license         GNU GPL V2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
 * @package         Publisher
 * @since           1.0
 * @author          trabis <lusopoemas@gmail.com>
 * @version         $Id$
 */
use Xoops;
use Xoops\Form\Button;
use Xoops\Form\ElementTray;
use Xoops\Form\File;
use Xoops\Form\Hidden;
use Xoops\Form\RadioYesNo;
use Xoops\Form\Text;
use Xoops\Form\TextArea;
use Xoops\Form\ThemeForm;
use XoopsModules\Publisher;
use XoopsModules\Publisher\Helper;

require_once \dirname(\dirname(__DIR__)) . '/include/common.php';

/**
 * Class FileForm
 * @package XoopsModules\Publisher\Form
 */
class FileForm extends ThemeForm
{
    public function __construct(Publisher\File $obj)
    {
        $xoops = Xoops::getInstance();
        $helper = Helper::getInstance();
        $helper->loadLanguage('main');

        parent::__construct(_AM_PUBLISHER_UPLOAD_FILE, 'form', $xoops->getEnv('PHP_SELF'));
        $this->setExtra('enctype="multipart/form-data"');

        // NAME
        $name_text = new Text(_CO_PUBLISHER_FILENAME, 'name', 50, 255, $obj->getVar('name'));

It seems like $obj->getVar('name') can also be of type string[]; however, parameter $value of Xoops\Form\Text::__construct() does only seem to accept string, maybe add an additional type check?

        $name_text->setDescription(_CO_PUBLISHER_FILE_NAME_DSC);
        $this->addElement($name_text, true);

        // DESCRIPTION
        $description_text = new TextArea(_CO_PUBLISHER_FILE_DESCRIPTION, 'description', $obj->getVar('description'));

It seems like $obj->getVar('description') can also be of type string[]; however, parameter $value of Xoops\Form\TextArea::__construct() does only seem to accept string, maybe add an additional type check?

        $description_text->setDescription(_CO_PUBLISHER_FILE_DESCRIPTION_DSC);
        $this->addElement($description_text);

        // FILE TO UPLOAD
        $file_box = new File(_CO_PUBLISHER_FILE_TO_UPLOAD, 'item_upload_file');
        $file_box->set('size', 50);
        $this->addElement($file_box);

        $status_select = new RadioYesNo(_CO_PUBLISHER_FILE_STATUS, 'file_status', _PUBLISHER_STATUS_FILE_ACTIVE);
        $status_select->setDescription(_CO_PUBLISHER_FILE_STATUS_DSC);
        $this->addElement($status_select);

        // fileid
        $this->addElement(new Hidden('fileid', $obj->getVar('fileid')));

It seems like $obj->getVar('fileid') can also be of type string[]; however, parameter $value of Xoops\Form\Hidden::__construct() does only seem to accept string, maybe add an additional type check?

        // itemid
        $this->addElement(new Hidden('itemid', $obj->getVar('itemid')));

        $files_button_tray = new ElementTray('', '');
        $files_hidden = new Hidden('op', 'uploadfile');
        $files_button_tray->addElement($files_hidden);

        if (!$obj->getVar('fileid')) {
            $files_butt_create = new Button('', '', _MD_PUBLISHER_UPLOAD, 'submit');
            $files_butt_create->setExtra('onclick="this.form.elements.op.value=\'uploadfile\'"');

The function Xoops\Form\Element::setExtra() has been deprecated: please use attributes for event scripting

            $files_button_tray->addElement($files_butt_create);

            $files_butt_another = new Button('', '', _CO_PUBLISHER_FILE_UPLOAD_ANOTHER, 'submit');
            $files_butt_another->setExtra('onclick="this.form.elements.op.value=\'uploadanother\'"');

The function Xoops\Form\Element::setExtra() has been deprecated: please use attributes for event scripting

            $files_button_tray->addElement($files_butt_another);
        } else {
            $files_butt_create = new Button('', '', _MD_PUBLISHER_MODIFY, 'submit');
            $files_butt_create->setExtra('onclick="this.form.elements.op.value=\'modify\'"');

The function Xoops\Form\Element::setExtra() has been deprecated: please use attributes for event scripting

            $files_button_tray->addElement($files_butt_create);
        }

        $files_butt_clear = new Button('', '', _MD_PUBLISHER_CLEAR, 'reset');
        $files_button_tray->addElement($files_butt_clear);

        $buttonCancel = new Button('', '', _MD_PUBLISHER_CANCEL, 'button');
        $buttonCancel->setExtra('onclick="history.go(-1)"');

The function Xoops\Form\Element::setExtra() has been deprecated: please use attributes for event scripting

        $files_button_tray->addElement($buttonCancel);

        $this->addElement($files_button_tray);
    }
}