Completed
Pull Request — master (#622)
by Richard
29:20 queued 24s
created
htdocs/include/cp_header.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
  * xoops_url/modules/module_directory_name/admin_directory_name/
23 23
  */
24 24
 
25
-require_once dirname(__DIR__) . '/mainfile.php';
25
+require_once dirname(__DIR__).'/mainfile.php';
26 26
 
27 27
 $xoops = Xoops::getInstance();
28 28
 $xoops_url = \XoopsBaseConfig::get('url');
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
         $xoops->redirect($xoops_url, 1, XoopsLocale::E_NO_ACCESS_PERMISSION);
41 41
     }
42 42
 } else {
43
-    $xoops->redirect($xoops_url . '/user.php', 1, XoopsLocale::E_NO_ACCESS_PERMISSION);
43
+    $xoops->redirect($xoops_url.'/user.php', 1, XoopsLocale::E_NO_ACCESS_PERMISSION);
44 44
 }
45 45
 
46 46
 // set config values for this module
Please login to merge, or discard this patch.
htdocs/modules/profile/admin/permissions.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -22,12 +22,12 @@  discard block
 block discarded – undo
22 22
  * @author          Jan Pedersen
23 23
  * @author          Taiwen Jiang <[email protected]>
24 24
  */
25
-include __DIR__ . '/header.php';
25
+include __DIR__.'/header.php';
26 26
 // Get main instance
27 27
 $xoops = Xoops::getInstance();
28 28
 
29 29
 // Get Action type
30
-$op = Request::getString('op','edit');
30
+$op = Request::getString('op', 'edit');
31 31
 // Call header
32 32
 $xoops->header();
33 33
 
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
 $opform->display();
76 76
 
77 77
 $module_id = $xoops->module->getVar('mid');
78
-$form = new Xoops\Form\GroupPermissionForm($title_of_form, $module_id, $perm_name, $perm_desc, 'admin/permissions.php?op=' . $op, $anonymous);
78
+$form = new Xoops\Form\GroupPermissionForm($title_of_form, $module_id, $perm_name, $perm_desc, 'admin/permissions.php?op='.$op, $anonymous);
79 79
 
80 80
 if ($op === 'access') {
81 81
     $member_handler = $xoops->getHandlerMember();
Please login to merge, or discard this patch.
htdocs/modules/profile/admin/visibility.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@
 block discarded – undo
25 25
  * @author          Jan Pedersen
26 26
  * @author          Taiwen Jiang <[email protected]>
27 27
  */
28
-include __DIR__ . '/header.php';
28
+include __DIR__.'/header.php';
29 29
 // Get main instance
30 30
 $xoops = Xoops::getInstance();
31 31
 
Please login to merge, or discard this patch.
htdocs/modules/profile/admin/step.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
  * @author          Jan Pedersen
22 22
  * @author          Taiwen Jiang <[email protected]>
23 23
  */
24
-include __DIR__ . '/header.php';
24
+include __DIR__.'/header.php';
25 25
 
26 26
 // Get main instance
27 27
 $xoops = Xoops::getInstance();
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
     default:
42 42
         // Add Scripts
43 43
         $xoops->theme()->addScript('media/xoops/xoops.js');
44
-        $admin_page->addItemButton(XoopsLocale::A_ADD . ' ' . _PROFILE_AM_STEP, 'step.php?op=new', 'add');
44
+        $admin_page->addItemButton(XoopsLocale::A_ADD.' '._PROFILE_AM_STEP, 'step.php?op=new', 'add');
45 45
         $admin_page->renderButton();
46 46
         $xoops->tpl()->assign('steps', $regstep_Handler->getObjects(null, true, false));
47 47
         $xoops->tpl()->assign('step', true);
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
         break;
57 57
 
58 58
     case "edit":
59
-        $admin_page->addItemButton(XoopsLocale::A_ADD . ' ' . _PROFILE_AM_STEP, 'step.php?op=new', 'add');
59
+        $admin_page->addItemButton(XoopsLocale::A_ADD.' '._PROFILE_AM_STEP, 'step.php?op=new', 'add');
60 60
         $admin_page->addItemButton(_PROFILE_AM_STEP_LIST, 'step.php', 'application-view-detail');
61 61
         $admin_page->renderButton();
62 62
         $id = Request::getInt('id', 0);
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
         break;
93 93
 
94 94
     case "delete":
95
-        $admin_page->addItemButton(XoopsLocale::A_ADD . ' ' . _PROFILE_AM_STEP, 'step.php?op=new', 'add');
95
+        $admin_page->addItemButton(XoopsLocale::A_ADD.' '._PROFILE_AM_STEP, 'step.php?op=new', 'add');
96 96
         $admin_page->addItemButton(_PROFILE_AM_STEP_LIST, 'step.php', 'application-view-detail');
97 97
         $admin_page->renderButton();
98 98
         $id = Request::getInt('id', 0);
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
                 echo $xoops->confirm(
115 115
                     array("ok" => 1, "id" => $id, "op" => "delete"),
116 116
                     'step.php',
117
-                    sprintf(_PROFILE_AM_RUSUREDEL, $obj->getVar('step_name')) . '<br />'
117
+                    sprintf(_PROFILE_AM_RUSUREDEL, $obj->getVar('step_name')).'<br />'
118 118
                 );
119 119
             }
120 120
         } else {
Please login to merge, or discard this patch.
htdocs/modules/profile/admin/category.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
  * @author          Taiwen Jiang <[email protected]>
22 22
  */
23 23
 
24
-include __DIR__ . '/header.php';
24
+include __DIR__.'/header.php';
25 25
 // Get main instance
26 26
 $xoops = Xoops::getInstance();
27 27
 
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
 switch ($op) {
39 39
     case "list":
40 40
     default:
41
-        $admin_page->addItemButton(XoopsLocale::A_ADD . ' ' . _PROFILE_AM_CATEGORY, 'category.php?op=new', 'add');
41
+        $admin_page->addItemButton(XoopsLocale::A_ADD.' '._PROFILE_AM_CATEGORY, 'category.php?op=new', 'add');
42 42
         $admin_page->renderButton();
43 43
         $criteria = new CriteriaCompo();
44 44
         $criteria->setSort('cat_weight');
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
         break;
57 57
 
58 58
     case "edit":
59
-        $admin_page->addItemButton(XoopsLocale::A_ADD . ' ' . _PROFILE_AM_CATEGORY, 'category.php?op=new', 'add');
59
+        $admin_page->addItemButton(XoopsLocale::A_ADD.' '._PROFILE_AM_CATEGORY, 'category.php?op=new', 'add');
60 60
         $admin_page->addItemButton(_PROFILE_AM_CATEGORY_LIST, 'category.php', 'application-view-detail');
61 61
         $admin_page->renderButton();
62 62
         $id = Request::getInt('id', 0);
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
         break;
92 92
 
93 93
     case "delete":
94
-        $admin_page->addItemButton(XoopsLocale::A_ADD . ' ' . _PROFILE_AM_CATEGORY, 'category.php?op=new', 'add');
94
+        $admin_page->addItemButton(XoopsLocale::A_ADD.' '._PROFILE_AM_CATEGORY, 'category.php?op=new', 'add');
95 95
         $admin_page->addItemButton(_PROFILE_AM_CATEGORY_LIST, 'category.php', 'application-view-detail');
96 96
         $admin_page->renderButton();
97 97
         $id = Request::getInt('id', 0);
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
                 echo $xoops->confirm(
114 114
                     array("ok" => 1, "id" => $id, "op" => "delete"),
115 115
                     'category.php',
116
-                    sprintf(_PROFILE_AM_RUSUREDEL, $obj->getVar('cat_title')) . '<br />'
116
+                    sprintf(_PROFILE_AM_RUSUREDEL, $obj->getVar('cat_title')).'<br />'
117 117
                 );
118 118
             }
119 119
         } else {
Please login to merge, or discard this patch.
htdocs/modules/profile/admin/field.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
  * @author          Jan Pedersen
23 23
  * @author          Taiwen Jiang <[email protected]>
24 24
  */
25
-include __DIR__ . '/header.php';
25
+include __DIR__.'/header.php';
26 26
 // Get main instance
27 27
 $xoops = Xoops::getInstance();
28 28
 
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
 switch ($op) {
44 44
     default:
45 45
     case "list":
46
-        $admin_page->addItemButton(XoopsLocale::A_ADD . ' ' . _PROFILE_AM_FIELD, 'field.php?op=new', 'add');
46
+        $admin_page->addItemButton(XoopsLocale::A_ADD.' '._PROFILE_AM_FIELD, 'field.php?op=new', 'add');
47 47
         $admin_page->renderButton();
48 48
         $fields = $field_handler->getObjects(null, true, false);
49 49
         $modules = $xoops->getHandlerModule()->getObjectsArray(null, true);
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
         break;
111 111
 
112 112
     case "edit":
113
-        $admin_page->addItemButton(XoopsLocale::A_ADD . ' ' . _PROFILE_AM_FIELD, 'field.php?op=new', 'add');
113
+        $admin_page->addItemButton(XoopsLocale::A_ADD.' '._PROFILE_AM_FIELD, 'field.php?op=new', 'add');
114 114
         $admin_page->addItemButton(_PROFILE_AM_FIELD_LIST, 'field.php', 'application-view-detail');
115 115
         $admin_page->renderButton();
116 116
         $id = Request::getInt('id', 0);
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
                 $errors = array();
144 144
                 //if there are changed fields, fetch the fieldcategory objects
145 145
                 $fields = $field_handler->getObjects(
146
-                    new Criteria('field_id', "(" . implode(',', $ids) . ")", "IN"),
146
+                    new Criteria('field_id', "(".implode(',', $ids).")", "IN"),
147 147
                     true
148 148
                 );
149 149
                 foreach ($ids as $i) {
@@ -281,7 +281,7 @@  discard block
 block discarded – undo
281 281
                         $removed_groups = array_diff(array_keys($groups), $_REQUEST[$perm]);
282 282
                         if (count($removed_groups) > 0) {
283 283
                             $criteria->add(
284
-                                new Criteria('gperm_groupid', "(" . implode(',', $removed_groups) . ")", "IN")
284
+                                new Criteria('gperm_groupid', "(".implode(',', $removed_groups).")", "IN")
285 285
                             );
286 286
                             $groupperm_handler->deleteAll($criteria);
287 287
                         }
@@ -292,7 +292,7 @@  discard block
 block discarded – undo
292 292
                     unset($criteria);
293 293
                 }
294 294
             }
295
-            $url = $redirect_to_edit ? 'field.php?op=edit&amp;id=' . $obj->getVar('field_id') : 'field.php';
295
+            $url = $redirect_to_edit ? 'field.php?op=edit&amp;id='.$obj->getVar('field_id') : 'field.php';
296 296
             $xoops->redirect($url, 3, sprintf(_PROFILE_AM_SAVEDSUCCESS, _PROFILE_AM_FIELD));
297 297
         }
298 298
         echo $xoops->alert('error', $obj->getHtmlErrors());
@@ -301,7 +301,7 @@  discard block
 block discarded – undo
301 301
         break;
302 302
 
303 303
     case "delete":
304
-        $admin_page->addItemButton(XoopsLocale::A_ADD . ' ' . _PROFILE_AM_FIELD, 'field.php?op=new', 'add');
304
+        $admin_page->addItemButton(XoopsLocale::A_ADD.' '._PROFILE_AM_FIELD, 'field.php?op=new', 'add');
305 305
         $admin_page->addItemButton(_PROFILE_AM_FIELD_LIST, 'field.php', 'application-view-detail');
306 306
         $admin_page->renderButton();
307 307
         $id = Request::getInt('id', 0);
@@ -323,7 +323,7 @@  discard block
 block discarded – undo
323 323
                 echo $xoops->confirm(
324 324
                     array("ok" => 1, "id" => $id, "op" => "delete"),
325 325
                     'field.php',
326
-                    sprintf(_PROFILE_AM_RUSUREDEL, $obj->getVar('field_title')) . '<br />'
326
+                    sprintf(_PROFILE_AM_RUSUREDEL, $obj->getVar('field_title')).'<br />'
327 327
                 );
328 328
             }
329 329
         } else {
Please login to merge, or discard this patch.
htdocs/modules/userrank/admin/userrank.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
  * @package         userrank
20 20
  * @author          Cointin Maxime (AKA Kraven30)
21 21
  */
22
-include __DIR__ . '/header.php';
22
+include __DIR__.'/header.php';
23 23
 
24 24
 // Get main instance
25 25
 $xoops = Xoops::getInstance();
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
                 $userrank['rank_max'] = $userrank_arr[$i]->getVar("rank_max");
74 74
                 $userrank['rank_special'] = $userrank_arr[$i]->getVar("rank_special");
75 75
                 $rank_img = ($userrank_arr[$i]->getVar("rank_image")) ? $userrank_arr[$i]->getVar("rank_image") : 'blank.gif';
76
-                $userrank['rank_image'] = '<img src="' . \XoopsBaseConfig::get('uploads-url') . '/' . $rank_img . '" alt="" />';
76
+                $userrank['rank_image'] = '<img src="'.\XoopsBaseConfig::get('uploads-url').'/'.$rank_img.'" alt="" />';
77 77
                 $xoops->tpl()->appendByRef('userrank', $userrank);
78 78
                 unset($userrank);
79 79
             }
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
 
88 88
     // New userrank
89 89
     case 'userrank_new':
90
-        $admin_page->addTips(sprintf(_AM_USERRANK_TIPS_FORM1, implode(', ', $mimetypes)) . sprintf(_AM_USERRANK_TIPS_FORM2, $upload_size / 1000));
90
+        $admin_page->addTips(sprintf(_AM_USERRANK_TIPS_FORM1, implode(', ', $mimetypes)).sprintf(_AM_USERRANK_TIPS_FORM2, $upload_size / 1000));
91 91
         $admin_page->addItemButton(_AM_USERRANK_LIST, './userrank.php', 'application-view-detail');
92 92
         $admin_page->renderTips();
93 93
         $admin_page->renderButton();
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
 
100 100
     // Edit userrank
101 101
     case 'userrank_edit':
102
-        $admin_page->addTips(sprintf(_AM_USERRANK_TIPS_FORM1, implode(', ', $mimetypes)) . sprintf(_AM_USERRANK_TIPS_FORM2, $upload_size / 1000));
102
+        $admin_page->addTips(sprintf(_AM_USERRANK_TIPS_FORM1, implode(', ', $mimetypes)).sprintf(_AM_USERRANK_TIPS_FORM2, $upload_size / 1000));
103 103
         $admin_page->addItemButton(_AM_USERRANK_ADD, './userrank.php?op=userrank_new', 'add');
104 104
         $admin_page->addItemButton(_AM_USERRANK_LIST, './userrank.php', 'application-view-detail');
105 105
         $admin_page->renderTips();
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
         $verif_rank_special = ($_POST["rank_special"] == 1) ? "1" : "0";
128 128
         $obj->setVar("rank_special", $verif_rank_special);
129 129
 
130
-        $uploader_rank_img = new XoopsMediaUploader(\XoopsBaseConfig::get('uploads-url') . '/ranks', $mimetypes, $upload_size, null, null);
130
+        $uploader_rank_img = new XoopsMediaUploader(\XoopsBaseConfig::get('uploads-url').'/ranks', $mimetypes, $upload_size, null, null);
131 131
 
132 132
         if ($uploader_rank_img->fetchMedia("rank_image")) {
133 133
             $uploader_rank_img->setPrefix("rank");
@@ -136,10 +136,10 @@  discard block
 block discarded – undo
136 136
                 $errors = $uploader_rank_img->getErrors();
137 137
                 $xoops->redirect("javascript:history.go(-1)", 3, $errors);
138 138
             } else {
139
-                $obj->setVar("rank_image", 'ranks/' . $uploader_rank_img->getSavedFileName());
139
+                $obj->setVar("rank_image", 'ranks/'.$uploader_rank_img->getSavedFileName());
140 140
             }
141 141
         } else {
142
-            $obj->setVar("rank_image", 'ranks/' . $_POST["rank_image"]);
142
+            $obj->setVar("rank_image", 'ranks/'.$_POST["rank_image"]);
143 143
         }
144 144
 
145 145
         if ($userrank_Handler->insert($obj)) {
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
                 $xoops->redirect("userrank.php", 3, implode(",", $xoops->security()->getErrors()));
160 160
             }
161 161
             if ($userrank_Handler->delete($obj)) {
162
-                $urlfile = \XoopsBaseConfig::get('uploads-url') . '/' . $obj->getVar("rank_image");
162
+                $urlfile = \XoopsBaseConfig::get('uploads-url').'/'.$obj->getVar("rank_image");
163 163
                 if (is_file($urlfile)) {
164 164
                     chmod($urlfile, 0777);
165 165
                     unlink($urlfile);
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
             $rank_img = ($obj->getVar("rank_image")) ? $obj->getVar("rank_image") : 'blank.gif';
173 173
             echo $xoops->confirm(array(
174 174
                 "ok" => 1, "rank_id" => $_REQUEST["rank_id"], "op" => "userrank_delete"
175
-            ), $_SERVER["REQUEST_URI"], sprintf(_AM_USERRANK_SUREDEL) . '<br \><img src="' . \XoopsBaseConfig::get('uploads-url') . '/' . $rank_img . '" alt="" /><br \>');
175
+            ), $_SERVER["REQUEST_URI"], sprintf(_AM_USERRANK_SUREDEL).'<br \><img src="'.\XoopsBaseConfig::get('uploads-url').'/'.$rank_img.'" alt="" /><br \>');
176 176
         }
177 177
         break;
178 178
 
Please login to merge, or discard this patch.
htdocs/modules/system/admin/tplsets/main.php 1 patch
Spacing   +46 added lines, -46 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
     default:
56 56
         // Define Breadcrumb and tips
57 57
         $admin_page = new \Xoops\Module\Admin();
58
-        $admin_page->addBreadcrumbLink(SystemLocale::CONTROL_PANEL, \XoopsBaseConfig::get('url') . '/admin.php', true);
58
+        $admin_page->addBreadcrumbLink(SystemLocale::CONTROL_PANEL, \XoopsBaseConfig::get('url').'/admin.php', true);
59 59
         $admin_page->addBreadcrumbLink(SystemLocale::TEMPLATES_MANAGER, $system->adminVersion('tplsets', 'adminpath'));
60 60
         $admin_page->renderBreadcrumb();
61 61
         $admin_page->addTips(SystemLocale::TEMPLATES_TIPS);
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
             $xoops->redirect('admin.php?fct=tplsets', 3, implode('<br />', $xoops->security()->getErrors()));
105 105
         }
106 106
         // Assign Breadcrumb menu
107
-        $system_breadcrumb->addHelp(system_adminVersion('tplsets', 'help') . '#override');
107
+        $system_breadcrumb->addHelp(system_adminVersion('tplsets', 'help').'#override');
108 108
         $system_breadcrumb->addLink(SystemLocale::FILES_GENERATED);
109 109
         $system_breadcrumb->render();
110 110
 
@@ -113,8 +113,8 @@  discard block
 block discarded – undo
113 113
             if (isset($_REQUEST['select_theme']) && isset($_REQUEST['force_generated'])) {
114 114
                 //on verifie si le dossier module existe
115 115
                 $template_overload = \XoopsBaseConfig::get('themes-path')
116
-                    . '/' . $_REQUEST['select_theme'] . '/modules';
117
-                $indexFile = \XoopsBaseConfig::get('root-path') . "/modules/system/include/index.html";
116
+                    . '/'.$_REQUEST['select_theme'].'/modules';
117
+                $indexFile = \XoopsBaseConfig::get('root-path')."/modules/system/include/index.html";
118 118
                 $verif_write = false;
119 119
                 $text = '';
120 120
 
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
                         mkdir($template_overload, 0777);
126 126
                     }
127 127
                     chmod($template_overload, 0777);
128
-                    copy($indexFile, $template_overload . "/index.html");
128
+                    copy($indexFile, $template_overload."/index.html");
129 129
                 }
130 130
 
131 131
                 $tplset = Request::getString('tplset', 'default', 'post');
@@ -153,42 +153,42 @@  discard block
 block discarded – undo
153 153
                                 $module = $xoops->getModuleByDirname($moddir);
154 154
                                 if (is_object($module)) {
155 155
                                     // create module folder
156
-                                    if (!is_dir($template_overload . '/' . $module->getVar('dirname'))) {
157
-                                        mkdir($template_overload . '/' . $module->getVar('dirname'), 0777);
158
-                                        chmod($template_overload . '/' . $module->getVar('dirname'), 0777);
159
-                                        copy($indexFile, $template_overload . '/' . $module->getVar('dirname') . '/index.html');
156
+                                    if (!is_dir($template_overload.'/'.$module->getVar('dirname'))) {
157
+                                        mkdir($template_overload.'/'.$module->getVar('dirname'), 0777);
158
+                                        chmod($template_overload.'/'.$module->getVar('dirname'), 0777);
159
+                                        copy($indexFile, $template_overload.'/'.$module->getVar('dirname').'/index.html');
160 160
                                     }
161 161
 
162 162
                                     // create block folder
163
-                                    if (!is_dir($template_overload . '/' . $module->getVar('dirname') . '/blocks')) {
164
-                                        if (!is_dir($template_overload . '/' . $module->getVar('dirname') . '/blocks')) {
165
-                                            mkdir($template_overload . '/' . $module->getVar('dirname') . '/blocks', 0777);
163
+                                    if (!is_dir($template_overload.'/'.$module->getVar('dirname').'/blocks')) {
164
+                                        if (!is_dir($template_overload.'/'.$module->getVar('dirname').'/blocks')) {
165
+                                            mkdir($template_overload.'/'.$module->getVar('dirname').'/blocks', 0777);
166 166
                                         }
167
-                                        chmod($template_overload . '/' . $module->getVar('dirname') . '/blocks', 0777);
168
-                                        copy($indexFile, $template_overload . '/' . $module->getVar('dirname') . '/blocks' . '/index.html');
167
+                                        chmod($template_overload.'/'.$module->getVar('dirname').'/blocks', 0777);
168
+                                        copy($indexFile, $template_overload.'/'.$module->getVar('dirname').'/blocks'.'/index.html');
169 169
                                     }
170 170
 
171 171
                                     $class = "odd";
172
-                                    $text .= '<table cellspacing="1" class="outer"><tr><th colspan="3" align="center">' . XoopsLocale::C_MODULES . ucfirst($module->getVar('dirname')) . '</th></tr><tr><th align="center">' . XoopsLocale::TYPES . '</th><th  align="center">' . XoopsLocale::FILES . '</th><th>' . XoopsLocale::STATUS . '</th></tr>';
172
+                                    $text .= '<table cellspacing="1" class="outer"><tr><th colspan="3" align="center">'.XoopsLocale::C_MODULES.ucfirst($module->getVar('dirname')).'</th></tr><tr><th align="center">'.XoopsLocale::TYPES.'</th><th  align="center">'.XoopsLocale::FILES.'</th><th>'.XoopsLocale::STATUS.'</th></tr>';
173 173
 
174 174
                                     // create template
175 175
                                     $templates = $tpltpl_handler->find($tplsetname, 'module', null, $moddir);
176 176
                                     for ($j = 0; $j < count($templates); ++$j) {
177 177
                                         $filename = $templates[$j]->getVar('tpl_file');
178 178
                                         if ($tplsetname == $tplset) {
179
-                                            $physical_file = \XoopsBaseConfig::get('themes-path') . '/' . $_REQUEST['select_theme'] . '/modules/' . $moddir . '/' . $filename;
179
+                                            $physical_file = \XoopsBaseConfig::get('themes-path').'/'.$_REQUEST['select_theme'].'/modules/'.$moddir.'/'.$filename;
180 180
 
181 181
                                             $tplfile = $tpltpl_handler->get($templates[$j]->getVar('tpl_id'), true);
182 182
 
183 183
                                             if (is_object($tplfile)) {
184 184
                                                 if (!XoopsLoad::fileExists($physical_file) || $_REQUEST['force_generated'] == 1) {
185 185
                                                     $open = fopen($physical_file, 'w+');
186
-                                                    if (fwrite($open, "" . html_entity_decode($tplfile->getVar('tpl_source', 'E'), ENT_QUOTES))) {
187
-                                                        $text .= '<tr class="' . $class . '"><td align="center">' . XoopsLocale::TEMPLATES . '</td><td>' . $physical_file . '</td><td align="center">';
186
+                                                    if (fwrite($open, "".html_entity_decode($tplfile->getVar('tpl_source', 'E'), ENT_QUOTES))) {
187
+                                                        $text .= '<tr class="'.$class.'"><td align="center">'.XoopsLocale::TEMPLATES.'</td><td>'.$physical_file.'</td><td align="center">';
188 188
                                                         if (XoopsLoad::fileExists($physical_file)) {
189
-                                                            $text .= '<img width="16" src="' . system_AdminIcons('success.png') . '" /></td></tr>';
189
+                                                            $text .= '<img width="16" src="'.system_AdminIcons('success.png').'" /></td></tr>';
190 190
                                                         } else {
191
-                                                            $text .= '<img width="16" src="' . system_AdminIcons('cancel.png') . '" /></td></tr>';
191
+                                                            $text .= '<img width="16" src="'.system_AdminIcons('cancel.png').'" /></td></tr>';
192 192
                                                         }
193 193
                                                         $verif_write = true;
194 194
                                                     }
@@ -204,18 +204,18 @@  discard block
 block discarded – undo
204 204
                                     for ($k = 0; $k < count($btemplates); ++$k) {
205 205
                                         $filename = $btemplates[$k]->getVar('tpl_file');
206 206
                                         if ($tplsetname == $tplset) {
207
-                                            $physical_file = \XoopsBaseConfig::get('themes-path') . '/' . $_REQUEST['select_theme'] . '/modules/' . $moddir . '/blocks/' . $filename;
207
+                                            $physical_file = \XoopsBaseConfig::get('themes-path').'/'.$_REQUEST['select_theme'].'/modules/'.$moddir.'/blocks/'.$filename;
208 208
                                             $btplfile = $tpltpl_handler->get($btemplates[$k]->getVar('tpl_id'), true);
209 209
 
210 210
                                             if (is_object($btplfile)) {
211 211
                                                 if (!XoopsLoad::fileExists($physical_file) || $_REQUEST['force_generated'] == 1) {
212 212
                                                     $open = fopen($physical_file, 'w+');
213
-                                                    if (fwrite($open, "" . utf8_encode(html_entity_decode($btplfile->getVar('tpl_source', 'E'))) . "")) {
214
-                                                        $text .= '<tr class="' . $class . '"><td align="center">' . XoopsLocale::BLOCKS . '</td><td>' . $physical_file . '</td><td align="center">';
213
+                                                    if (fwrite($open, "".utf8_encode(html_entity_decode($btplfile->getVar('tpl_source', 'E')))."")) {
214
+                                                        $text .= '<tr class="'.$class.'"><td align="center">'.XoopsLocale::BLOCKS.'</td><td>'.$physical_file.'</td><td align="center">';
215 215
                                                         if (XoopsLoad::fileExists($physical_file)) {
216
-                                                            $text .= '<img width="16" src="' . system_AdminIcons('success.png') . '" /></td></tr>';
216
+                                                            $text .= '<img width="16" src="'.system_AdminIcons('success.png').'" /></td></tr>';
217 217
                                                         } else {
218
-                                                            $text .= '<img width="16" src="' . system_AdminIcons('cancel.png') . '" /></td></tr>';
218
+                                                            $text .= '<img width="16" src="'.system_AdminIcons('cancel.png').'" /></td></tr>';
219 219
                                                         }
220 220
                                                         $verif_write = true;
221 221
                                                     }
@@ -241,23 +241,23 @@  discard block
 block discarded – undo
241 241
                             $module = $xoops->getModuleByDirname($moddir);
242 242
                             if (is_object($module)) {
243 243
                                 // create module folder
244
-                                if (!is_dir($template_overload . '/' . $module->getVar('dirname'))) {
245
-                                    mkdir($template_overload . '/' . $module->getVar('dirname'), 0777);
246
-                                    chmod($template_overload . '/' . $module->getVar('dirname'), 0777);
247
-                                    copy($indexFile, $template_overload . '/' . $module->getVar('dirname') . '/index.html');
244
+                                if (!is_dir($template_overload.'/'.$module->getVar('dirname'))) {
245
+                                    mkdir($template_overload.'/'.$module->getVar('dirname'), 0777);
246
+                                    chmod($template_overload.'/'.$module->getVar('dirname'), 0777);
247
+                                    copy($indexFile, $template_overload.'/'.$module->getVar('dirname').'/index.html');
248 248
                                 }
249 249
 
250 250
                                 // create block folder
251
-                                if (!is_dir($template_overload . '/' . $module->getVar('dirname') . '/blocks')) {
252
-                                    if (!is_dir($template_overload . '/' . $module->getVar('dirname') . '/blocks')) {
253
-                                        mkdir($template_overload . '/' . $module->getVar('dirname') . '/blocks', 0777);
251
+                                if (!is_dir($template_overload.'/'.$module->getVar('dirname').'/blocks')) {
252
+                                    if (!is_dir($template_overload.'/'.$module->getVar('dirname').'/blocks')) {
253
+                                        mkdir($template_overload.'/'.$module->getVar('dirname').'/blocks', 0777);
254 254
                                     }
255
-                                    chmod($template_overload . '/' . $module->getVar('dirname') . '/blocks', 0777);
256
-                                    copy($indexFile, $template_overload . '/' . $module->getVar('dirname') . '/blocks' . '/index.html');
255
+                                    chmod($template_overload.'/'.$module->getVar('dirname').'/blocks', 0777);
256
+                                    copy($indexFile, $template_overload.'/'.$module->getVar('dirname').'/blocks'.'/index.html');
257 257
                                 }
258 258
 
259 259
                                 $class = "odd";
260
-                                $text .= '<table cellspacing="1" class="outer"><tr><th colspan="3" align="center">' . XoopsLocale::C_MODULES . ucfirst($module->getVar('dirname')) . '</th></tr><tr><th align="center">' . XoopsLocale::TYPES . '</th><th  align="center">' . XoopsLocale::FILES . '</th><th>' . XoopsLocale::STATUS . '</th></tr>';
260
+                                $text .= '<table cellspacing="1" class="outer"><tr><th colspan="3" align="center">'.XoopsLocale::C_MODULES.ucfirst($module->getVar('dirname')).'</th></tr><tr><th align="center">'.XoopsLocale::TYPES.'</th><th  align="center">'.XoopsLocale::FILES.'</th><th>'.XoopsLocale::STATUS.'</th></tr>';
261 261
                                 $select_templates_modules = $_REQUEST['select_templates_modules'];
262 262
                                 for ($l = 0; $l < count($_REQUEST['select_templates_modules']); ++$l) {
263 263
                                     // create template
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
                                     for ($j = 0; $j < count($templates); ++$j) {
266 266
                                         $filename = $templates[$j]->getVar('tpl_file');
267 267
                                         if ($tplsetname == $tplset) {
268
-                                            $physical_file = \XoopsBaseConfig::get('themes-path') . '/' . $_REQUEST['select_theme'] . '/modules/' . $moddir . '/' . $filename;
268
+                                            $physical_file = \XoopsBaseConfig::get('themes-path').'/'.$_REQUEST['select_theme'].'/modules/'.$moddir.'/'.$filename;
269 269
 
270 270
                                             $tplfile = $tpltpl_handler->get($templates[$j]->getVar('tpl_id'), true);
271 271
 
@@ -274,11 +274,11 @@  discard block
 block discarded – undo
274 274
                                                     if ($select_templates_modules[$l] == $filename) {
275 275
                                                         $open = fopen($physical_file, 'w+');
276 276
                                                         if (fwrite($open, html_entity_decode($tplfile->getVar('tpl_source', 'E'), ENT_QUOTES))) {
277
-                                                            $text .= '<tr class="' . $class . '"><td align="center">' . XoopsLocale::TEMPLATES . '</td><td>' . $physical_file . '</td><td align="center">';
277
+                                                            $text .= '<tr class="'.$class.'"><td align="center">'.XoopsLocale::TEMPLATES.'</td><td>'.$physical_file.'</td><td align="center">';
278 278
                                                             if (XoopsLoad::fileExists($physical_file)) {
279
-                                                                $text .= '<img width="16" src="' . system_AdminIcons('success.png') . '" /></td></tr>';
279
+                                                                $text .= '<img width="16" src="'.system_AdminIcons('success.png').'" /></td></tr>';
280 280
                                                             } else {
281
-                                                                $text .= '<img width="16" src="' . system_AdminIcons('cancel.png') . '" /></td></tr>';
281
+                                                                $text .= '<img width="16" src="'.system_AdminIcons('cancel.png').'" /></td></tr>';
282 282
                                                             }
283 283
                                                             $verif_write = true;
284 284
                                                         }
@@ -295,19 +295,19 @@  discard block
 block discarded – undo
295 295
                                     for ($k = 0; $k < count($btemplates); ++$k) {
296 296
                                         $filename = $btemplates[$k]->getVar('tpl_file');
297 297
                                         if ($tplsetname == $tplset) {
298
-                                            $physical_file = \XoopsBaseConfig::get('themes-path') . '/' . $_REQUEST['select_theme'] . '/modules/' . $moddir . '/blocks/' . $filename;
298
+                                            $physical_file = \XoopsBaseConfig::get('themes-path').'/'.$_REQUEST['select_theme'].'/modules/'.$moddir.'/blocks/'.$filename;
299 299
                                             $btplfile = $tpltpl_handler->get($btemplates[$k]->getVar('tpl_id'), true);
300 300
 
301 301
                                             if (is_object($btplfile)) {
302 302
                                                 if (!XoopsLoad::fileExists($physical_file) || $_REQUEST['force_generated'] == 1) {
303 303
                                                     if ($select_templates_modules[$l] == $filename) {
304 304
                                                         $open = fopen($physical_file, 'w+');
305
-                                                        if (fwrite($open, utf8_encode(html_entity_decode($btplfile->getVar('tpl_source', 'E'))) . "")) {
306
-                                                            $text .= '<tr class="' . $class . '"><td align="center">' . XoopsLocale::BLOCKS . '</td><td>' . $physical_file . '</td><td align="center">';
305
+                                                        if (fwrite($open, utf8_encode(html_entity_decode($btplfile->getVar('tpl_source', 'E')))."")) {
306
+                                                            $text .= '<tr class="'.$class.'"><td align="center">'.XoopsLocale::BLOCKS.'</td><td>'.$physical_file.'</td><td align="center">';
307 307
                                                             if (XoopsLoad::fileExists($physical_file)) {
308
-                                                                $text .= '<img width="16" src="' . system_AdminIcons('success.png') . '" /></td></tr>';
308
+                                                                $text .= '<img width="16" src="'.system_AdminIcons('success.png').'" /></td></tr>';
309 309
                                                             } else {
310
-                                                                $text .= '<img width="16" src="' . system_AdminIcons('cancel.png') . '" /></td></tr>';
310
+                                                                $text .= '<img width="16" src="'.system_AdminIcons('cancel.png').'" /></td></tr>';
311 311
                                                             }
312 312
                                                             $verif_write = true;
313 313
                                                         }
@@ -365,14 +365,14 @@  discard block
 block discarded – undo
365 365
         }
366 366
         $clean_path_file = Request::getString('path_file', '');
367 367
         if (!empty($clean_path_file)) {
368
-            $path_file = realpath(\XoopsBaseConfig::get('themes-path') . '/' . trim($clean_path_file));
368
+            $path_file = realpath(\XoopsBaseConfig::get('themes-path').'/'.trim($clean_path_file));
369 369
             $path_file = str_replace('\\', '/', $path_file);
370 370
             $pathInfo = pathinfo($path_file);
371 371
             if (!in_array($pathInfo['extension'], array('css', 'html', 'tpl'))) {
372 372
                 $xoops->redirect("admin.php?fct=tplsets", 2, XoopsLocale::E_NOT_DONE);
373 373
             }
374 374
             // copy file
375
-            $copy_file = $path_file . '.back';
375
+            $copy_file = $path_file.'.back';
376 376
             copy($path_file, $copy_file);
377 377
             // Save modif
378 378
             if (isset($_REQUEST['templates'])) {
Please login to merge, or discard this patch.
htdocs/modules/system/admin/blocksadmin/main.php 1 patch
Switch Indentation   +376 added lines, -376 removed lines patch added patch discarded remove patch
@@ -73,260 +73,260 @@  discard block
 block discarded – undo
73 73
 
74 74
 switch ($op) {
75 75
 
76
-    case 'list':
77
-        // Call Header
78
-        $xoops->header('admin:system/system_blocks.tpl');
79
-        // Define Stylesheet
80
-        $xoops->theme()->addStylesheet('modules/system/css/admin.css');
81
-        // Define scripts
82
-        $xoops->theme()->addScript('modules/system/js/admin.js');
83
-        $xoops->theme()->addScript('modules/system/js/blocks.js');
84
-        // Define Breadcrumb and tips
85
-        $admin_page = new \Xoops\Module\Admin();
86
-        $admin_page->addBreadcrumbLink(SystemLocale::CONTROL_PANEL, \XoopsBaseConfig::get('url') . '/admin.php', true);
87
-        $admin_page->addBreadcrumbLink(
88
-            SystemLocale::BLOCKS_ADMINISTRATION,
89
-            $system->adminVersion('blocksadmin', 'adminpath')
90
-        );
91
-        $admin_page->addBreadcrumbLink(SystemLocale::MANAGE_BLOCKS);
92
-        $admin_page->renderBreadcrumb();
93
-        $admin_page->addItemButton(SystemLocale::ADD_BLOCK, 'admin.php?fct=blocksadmin&amp;op=add', 'add');
94
-        $admin_page->renderButton();
95
-        $admin_page->addTips(sprintf(
96
-            SystemLocale::BLOCKS_TIPS,
97
-            system_AdminIcons('block.png'),
98
-            system_AdminIcons('success.png'),
99
-            system_AdminIcons('cancel.png'),
100
-            SystemLocale::DRAG_OR_SORT_BLOCK,
101
-            SystemLocale::DISPLAY_BLOCK,
102
-            SystemLocale::HIDE_BLOCK
103
-        ));
104
-        $admin_page->renderTips();
105
-        // Initialize module handler
106
-        $module_handler = $xoops->getHandlerModule();
107
-        $modules = $module_handler->getObjects(null, true);
108
-        $criteria = new CriteriaCompo(new Criteria('hasmain', 1));
109
-
110
-        $criteria->add(new Criteria('isactive', 1));
111
-        // Modules for blocks to be visible in
112
-        $display_list = $module_handler->getNameList($criteria);
113
-        unset($criteria);
114
-        // Initialize blocks handler
115
-        $block_handler = $xoops->getHandlerBlock();
116
-        $modules = $xoops->getHandlerModule()->getObjects(null, true);
117
-
118
-        $filterform = new Xoops\Form\ThemeForm('', 'filterform', 'admin.php', 'get');
119
-        $filterform->addElement(new Xoops\Form\Hidden('fct', 'blocksadmin'));
120
-        $filterform->addElement(new Xoops\Form\Hidden('op', 'list'));
121
-        $filterform->addElement(new Xoops\Form\Hidden('filter', 1));
122
-        $sel_gen = new Xoops\Form\Select(XoopsLocale::MODULES, 'selgen', $selgen);
123
-        $sel_gen->setExtra("onchange='submit()'");
124
-        $sel_gen->addOption(-1, XoopsLocale::ALL_TYPES);
125
-        $sel_gen->addOption(0, SystemLocale::CUSTOM_BLOCK);
126
-        /* @var $list XoopsModule */
127
-        foreach ($modules as $list) {
128
-            $sel_gen->addOption($list->getVar('mid'), $list->getVar('name'));
129
-        }
130
-        $filterform->addElement($sel_gen);
131
-
132
-        $sel_mod = new Xoops\Form\Select(XoopsLocale::PAGE, 'selmod', $selmod);
133
-        $sel_mod->setExtra("onchange='submit()'");
134
-        ksort($display_list);
135
-        $display_list_spec[0] = XoopsLocale::ALL_PAGES;
136
-        $display_list_spec[-1] = XoopsLocale::TOP_PAGE;
137
-        $display_list_spec[-2] = XoopsLocale::ALL_TYPES;
138
-        $display_list = $display_list_spec + $display_list;
139
-        foreach ($display_list as $k => $v) {
140
-            $sel_mod->addOption($k, $v);
141
-        }
142
-        $filterform->addElement($sel_mod);
143
-
144
-        // For selection of group access
145
-        $sel_grp = new Xoops\Form\Select(XoopsLocale::GROUPS, 'selgrp', $selgrp);
146
-        $sel_grp->setExtra("onchange='submit()'");
147
-        $member_handler = $xoops->getHandlerMember();
148
-        $group_list = $member_handler->getGroupList();
149
-        $sel_grp->addOption(-1, XoopsLocale::ALL_TYPES);
150
-        $sel_grp->addOption(0, XoopsLocale::UNASSIGNED);
151
-        foreach ($group_list as $k => $v) {
152
-            $sel_grp->addOption($k, $v);
153
-        }
154
-        $filterform->addElement($sel_grp);
155
-
156
-        $sel_vis = new Xoops\Form\Select(XoopsLocale::VISIBLE, 'selvis', $selvis);
157
-        $sel_vis->setExtra("onchange='submit()'");
158
-        $sel_vis->addOption(-1, XoopsLocale::ALL_TYPES);
159
-        $sel_vis->addOption(0, XoopsLocale::NO);
160
-        $sel_vis->addOption(1, XoopsLocale::YES);
161
-
162
-        $filterform->addElement($sel_vis);
163
-
164
-        $filterform->assign($xoops->tpl());
165
-
166
-        /* Get blocks */
167
-        $selvis = ($selvis == -1) ? null : $selvis;
168
-        $selmod = ($selmod == -2) ? null : $selmod;
169
-        $order_block = (isset($selvis) ? "" : "b.visible DESC, ") . "b.side,b.weight,b.bid";
170
-
171
-        if ($selgrp == 0) {
172
-            // get blocks that are not assigned to any groups
173
-            $blocks_arr = $block_handler->getNonGroupedBlocks($selmod, $toponlyblock = false, $selvis, $order_block);
174
-        } else {
175
-            $selgrp = ($selgrp == -1) ? null : $selgrp;
176
-            $blocks_arr = $block_handler->
177
-                getAllByGroupModule($selgrp, $selmod, $toponlyblock = false, $selvis, $order_block);
178
-        }
76
+        case 'list':
77
+            // Call Header
78
+            $xoops->header('admin:system/system_blocks.tpl');
79
+            // Define Stylesheet
80
+            $xoops->theme()->addStylesheet('modules/system/css/admin.css');
81
+            // Define scripts
82
+            $xoops->theme()->addScript('modules/system/js/admin.js');
83
+            $xoops->theme()->addScript('modules/system/js/blocks.js');
84
+            // Define Breadcrumb and tips
85
+            $admin_page = new \Xoops\Module\Admin();
86
+            $admin_page->addBreadcrumbLink(SystemLocale::CONTROL_PANEL, \XoopsBaseConfig::get('url') . '/admin.php', true);
87
+            $admin_page->addBreadcrumbLink(
88
+                SystemLocale::BLOCKS_ADMINISTRATION,
89
+                $system->adminVersion('blocksadmin', 'adminpath')
90
+            );
91
+            $admin_page->addBreadcrumbLink(SystemLocale::MANAGE_BLOCKS);
92
+            $admin_page->renderBreadcrumb();
93
+            $admin_page->addItemButton(SystemLocale::ADD_BLOCK, 'admin.php?fct=blocksadmin&amp;op=add', 'add');
94
+            $admin_page->renderButton();
95
+            $admin_page->addTips(sprintf(
96
+                SystemLocale::BLOCKS_TIPS,
97
+                system_AdminIcons('block.png'),
98
+                system_AdminIcons('success.png'),
99
+                system_AdminIcons('cancel.png'),
100
+                SystemLocale::DRAG_OR_SORT_BLOCK,
101
+                SystemLocale::DISPLAY_BLOCK,
102
+                SystemLocale::HIDE_BLOCK
103
+            ));
104
+            $admin_page->renderTips();
105
+            // Initialize module handler
106
+            $module_handler = $xoops->getHandlerModule();
107
+            $modules = $module_handler->getObjects(null, true);
108
+            $criteria = new CriteriaCompo(new Criteria('hasmain', 1));
109
+
110
+            $criteria->add(new Criteria('isactive', 1));
111
+            // Modules for blocks to be visible in
112
+            $display_list = $module_handler->getNameList($criteria);
113
+            unset($criteria);
114
+            // Initialize blocks handler
115
+            $block_handler = $xoops->getHandlerBlock();
116
+            $modules = $xoops->getHandlerModule()->getObjects(null, true);
117
+
118
+            $filterform = new Xoops\Form\ThemeForm('', 'filterform', 'admin.php', 'get');
119
+            $filterform->addElement(new Xoops\Form\Hidden('fct', 'blocksadmin'));
120
+            $filterform->addElement(new Xoops\Form\Hidden('op', 'list'));
121
+            $filterform->addElement(new Xoops\Form\Hidden('filter', 1));
122
+            $sel_gen = new Xoops\Form\Select(XoopsLocale::MODULES, 'selgen', $selgen);
123
+            $sel_gen->setExtra("onchange='submit()'");
124
+            $sel_gen->addOption(-1, XoopsLocale::ALL_TYPES);
125
+            $sel_gen->addOption(0, SystemLocale::CUSTOM_BLOCK);
126
+            /* @var $list XoopsModule */
127
+            foreach ($modules as $list) {
128
+                $sel_gen->addOption($list->getVar('mid'), $list->getVar('name'));
129
+            }
130
+            $filterform->addElement($sel_gen);
131
+
132
+            $sel_mod = new Xoops\Form\Select(XoopsLocale::PAGE, 'selmod', $selmod);
133
+            $sel_mod->setExtra("onchange='submit()'");
134
+            ksort($display_list);
135
+            $display_list_spec[0] = XoopsLocale::ALL_PAGES;
136
+            $display_list_spec[-1] = XoopsLocale::TOP_PAGE;
137
+            $display_list_spec[-2] = XoopsLocale::ALL_TYPES;
138
+            $display_list = $display_list_spec + $display_list;
139
+            foreach ($display_list as $k => $v) {
140
+                $sel_mod->addOption($k, $v);
141
+            }
142
+            $filterform->addElement($sel_mod);
143
+
144
+            // For selection of group access
145
+            $sel_grp = new Xoops\Form\Select(XoopsLocale::GROUPS, 'selgrp', $selgrp);
146
+            $sel_grp->setExtra("onchange='submit()'");
147
+            $member_handler = $xoops->getHandlerMember();
148
+            $group_list = $member_handler->getGroupList();
149
+            $sel_grp->addOption(-1, XoopsLocale::ALL_TYPES);
150
+            $sel_grp->addOption(0, XoopsLocale::UNASSIGNED);
151
+            foreach ($group_list as $k => $v) {
152
+                $sel_grp->addOption($k, $v);
153
+            }
154
+            $filterform->addElement($sel_grp);
155
+
156
+            $sel_vis = new Xoops\Form\Select(XoopsLocale::VISIBLE, 'selvis', $selvis);
157
+            $sel_vis->setExtra("onchange='submit()'");
158
+            $sel_vis->addOption(-1, XoopsLocale::ALL_TYPES);
159
+            $sel_vis->addOption(0, XoopsLocale::NO);
160
+            $sel_vis->addOption(1, XoopsLocale::YES);
161
+
162
+            $filterform->addElement($sel_vis);
163
+
164
+            $filterform->assign($xoops->tpl());
165
+
166
+            /* Get blocks */
167
+            $selvis = ($selvis == -1) ? null : $selvis;
168
+            $selmod = ($selmod == -2) ? null : $selmod;
169
+            $order_block = (isset($selvis) ? "" : "b.visible DESC, ") . "b.side,b.weight,b.bid";
170
+
171
+            if ($selgrp == 0) {
172
+                // get blocks that are not assigned to any groups
173
+                $blocks_arr = $block_handler->getNonGroupedBlocks($selmod, $toponlyblock = false, $selvis, $order_block);
174
+            } else {
175
+                $selgrp = ($selgrp == -1) ? null : $selgrp;
176
+                $blocks_arr = $block_handler->
177
+                    getAllByGroupModule($selgrp, $selmod, $toponlyblock = false, $selvis, $order_block);
178
+            }
179 179
 
180
-        if ($selgen >= 0) {
181
-            foreach (array_keys($blocks_arr) as $bid) {
182
-                if ($blocks_arr[$bid]->getVar("mid") != $selgen) {
183
-                    unset($blocks_arr[$bid]);
180
+            if ($selgen >= 0) {
181
+                foreach (array_keys($blocks_arr) as $bid) {
182
+                    if ($blocks_arr[$bid]->getVar("mid") != $selgen) {
183
+                        unset($blocks_arr[$bid]);
184
+                    }
184 185
                 }
185 186
             }
186
-        }
187
-
188
-        $arr = array();
189
-        foreach (array_keys($blocks_arr) as $i) {
190
-            $arr[$i] = $blocks_arr[$i]->getValues();
191
-            $xoops->tpl()->appendByRef('blocks', $arr[$i]);
192
-        }
193
-        // Call Footer
194
-        $xoops->footer();
195
-        break;
196
-
197
-    case 'add':
198
-        // Call Header
199
-        $xoops->header('admin:system/system_blocks.tpl');
200
-        // Define Stylesheet
201
-        $xoops->theme()->addStylesheet('modules/system/css/admin.css');
202
-        // Define scripts
203
-        $xoops->theme()->addScript('media/jquery/plugins/jquery.form.js');
204
-        $xoops->theme()->addScript('modules/system/js/admin.js');
205
-        $xoops->theme()->addScript('modules/system/js/blocks.js');
206
-        // Define Breadcrumb and tips
207
-        $admin_page = new \Xoops\Module\Admin();
208
-        $admin_page->addBreadcrumbLink(SystemLocale::CONTROL_PANEL, \XoopsBaseConfig::get('url') . '/admin.php', true);
209
-        $admin_page->addBreadcrumbLink(
210
-            SystemLocale::BLOCKS_ADMINISTRATION,
211
-            $system->adminVersion('blocksadmin', 'adminpath')
212
-        );
213
-        $admin_page->addBreadcrumbLink(SystemLocale::ADD_BLOCK);
214
-        $admin_page->renderBreadcrumb();
215
-        // Initialize blocks handler
216
-        $block_handler = $xoops->getHandlerBlock();
217
-        $block = $block_handler->create();
218
-        $form = $xoops->getModuleForm($block, 'block');
219
-        $form->getForm();
220
-        $form->display();
221
-        // Call Footer
222
-        $xoops->footer();
223
-        break;
224 187
 
225
-    case 'display':
226
-        // Initialize blocks handler
227
-        $block_handler = $xoops->getHandlerBlock();
228
-        // Get variable
229
-        $block_id = Request::getInt('bid', 0, 'post');
230
-        $visible = Request::getInt('visible', 0, 'post');
231
-        if ($block_id > 0) {
232
-            $block = $block_handler->get($block_id);
233
-            $block->setVar('visible', $visible);
234
-            if (!$block_handler->insertBlock($block)) {
235
-                $error = true;
188
+            $arr = array();
189
+            foreach (array_keys($blocks_arr) as $i) {
190
+                $arr[$i] = $blocks_arr[$i]->getValues();
191
+                $xoops->tpl()->appendByRef('blocks', $arr[$i]);
236 192
             }
237
-        }
238
-        break;
193
+            // Call Footer
194
+            $xoops->footer();
195
+            break;
239 196
 
240
-    case 'drag':
241
-        // Initialize blocks handler
242
-        $block_handler = $xoops->getHandlerBlock();
243
-        // Get variable
244
-        $block_id = Request::getInt('bid', 0, 'post');
245
-        $side = Request::getInt('side', 0, 'post');
246
-        if ($block_id > 0) {
247
-            $block = $block_handler->get($block_id);
248
-            $block->setVar('side', $side);
249
-            if (!$block_handler->insertBlock($block)) {
250
-                $error = true;
197
+        case 'add':
198
+            // Call Header
199
+            $xoops->header('admin:system/system_blocks.tpl');
200
+            // Define Stylesheet
201
+            $xoops->theme()->addStylesheet('modules/system/css/admin.css');
202
+            // Define scripts
203
+            $xoops->theme()->addScript('media/jquery/plugins/jquery.form.js');
204
+            $xoops->theme()->addScript('modules/system/js/admin.js');
205
+            $xoops->theme()->addScript('modules/system/js/blocks.js');
206
+            // Define Breadcrumb and tips
207
+            $admin_page = new \Xoops\Module\Admin();
208
+            $admin_page->addBreadcrumbLink(SystemLocale::CONTROL_PANEL, \XoopsBaseConfig::get('url') . '/admin.php', true);
209
+            $admin_page->addBreadcrumbLink(
210
+                SystemLocale::BLOCKS_ADMINISTRATION,
211
+                $system->adminVersion('blocksadmin', 'adminpath')
212
+            );
213
+            $admin_page->addBreadcrumbLink(SystemLocale::ADD_BLOCK);
214
+            $admin_page->renderBreadcrumb();
215
+            // Initialize blocks handler
216
+            $block_handler = $xoops->getHandlerBlock();
217
+            $block = $block_handler->create();
218
+            $form = $xoops->getModuleForm($block, 'block');
219
+            $form->getForm();
220
+            $form->display();
221
+            // Call Footer
222
+            $xoops->footer();
223
+            break;
224
+
225
+        case 'display':
226
+            // Initialize blocks handler
227
+            $block_handler = $xoops->getHandlerBlock();
228
+            // Get variable
229
+            $block_id = Request::getInt('bid', 0, 'post');
230
+            $visible = Request::getInt('visible', 0, 'post');
231
+            if ($block_id > 0) {
232
+                $block = $block_handler->get($block_id);
233
+                $block->setVar('visible', $visible);
234
+                if (!$block_handler->insertBlock($block)) {
235
+                    $error = true;
236
+                }
251 237
             }
252
-        }
253
-        break;
254
-
255
-    case 'order':
256
-        // Initialize blocks handler
257
-        $block_handler = $xoops->getHandlerBlock();
258
-        if (isset($_POST['blk'])) {
259
-            $i = 0;
260
-            foreach ($_POST['blk'] as $order) {
261
-                if ($order > 0) {
262
-                    $block = $block_handler->get($order);
263
-                    $block->setVar('weight', $i);
264
-                    if (!$block_handler->insertBlock($block)) {
265
-                        $error = true;
238
+            break;
239
+
240
+        case 'drag':
241
+            // Initialize blocks handler
242
+            $block_handler = $xoops->getHandlerBlock();
243
+            // Get variable
244
+            $block_id = Request::getInt('bid', 0, 'post');
245
+            $side = Request::getInt('side', 0, 'post');
246
+            if ($block_id > 0) {
247
+                $block = $block_handler->get($block_id);
248
+                $block->setVar('side', $side);
249
+                if (!$block_handler->insertBlock($block)) {
250
+                    $error = true;
251
+                }
252
+            }
253
+            break;
254
+
255
+        case 'order':
256
+            // Initialize blocks handler
257
+            $block_handler = $xoops->getHandlerBlock();
258
+            if (isset($_POST['blk'])) {
259
+                $i = 0;
260
+                foreach ($_POST['blk'] as $order) {
261
+                    if ($order > 0) {
262
+                        $block = $block_handler->get($order);
263
+                        $block->setVar('weight', $i);
264
+                        if (!$block_handler->insertBlock($block)) {
265
+                            $error = true;
266
+                        }
267
+                        ++$i;
266 268
                     }
267
-                    ++$i;
268 269
                 }
269 270
             }
270
-        }
271
-        exit;
272
-        break;
271
+            exit;
272
+            break;
273 273
 
274
-    case 'preview':
275
-        if (!$xoops->security()->check()) {
276
-            $xoops->redirect('admin.php?fct=blocksadmin', 3, implode('<br />', $xoops->security()->getErrors()));
277
-            exit();
278
-        }
279
-        // Initialize blocks handler
280
-        $block_handler = $xoops->getHandlerBlock();
281
-        /* @var $block XoopsBlock */
282
-        $block = $block_handler->create();
283
-        $block->setVars($_POST);
284
-        $content = isset($_POST['content_block']) ? $_POST['content_block'] : '';
285
-        $block->setVar('content', $content);
286
-        $myts = \Xoops\Core\Text\Sanitizer::getInstance();
287
-        echo '<div id="xo-preview-dialog" title="' . $block->getVar('title', 's')
288
-            . '">' . $block->getContent('s', $block->getVar('c_type')) . '</div>';
289
-        break;
290
-
291
-    case 'save':
292
-        if (!$xoops->security()->check()) {
293
-            $xoops->redirect('admin.php?fct=blocksadmin', 3, implode('<br />', $xoops->security()->getErrors()));
294
-            exit();
295
-        }
296
-        // Initialize blocks handler
297
-        $block_handler = $xoops->getHandlerBlock();
298
-        // Get avatar id
299
-        $block_id = Request::getInt('bid', 0, 'post');
300
-        if ($block_id > 0) {
301
-            $block = $block_handler->get($block_id);
302
-        } else {
274
+        case 'preview':
275
+            if (!$xoops->security()->check()) {
276
+                $xoops->redirect('admin.php?fct=blocksadmin', 3, implode('<br />', $xoops->security()->getErrors()));
277
+                exit();
278
+            }
279
+            // Initialize blocks handler
280
+            $block_handler = $xoops->getHandlerBlock();
281
+            /* @var $block XoopsBlock */
303 282
             $block = $block_handler->create();
304
-        }
305
-        $block_type = Request::getString('block_type', '', 'post');
306
-        $block->setVar('block_type', $block_type);
307
-
308
-        if (!$block->isCustom()) {
309 283
             $block->setVars($_POST);
310
-            $type = $block->getVar('block_type');
311
-            $name = $block->getVar('name');
312
-            // Save block options
313
-            $options = $_POST['options'];
314
-            if (isset($options)) {
315
-                $options_count = count($options);
316
-                if ($options_count > 0) {
317
-                    //Convert array values to comma-separated
318
-                    for ($i = 0; $i < $options_count; ++$i) {
319
-                        if (is_array($options[$i])) {
320
-                            $options[$i] = implode(',', $options[$i]);
284
+            $content = isset($_POST['content_block']) ? $_POST['content_block'] : '';
285
+            $block->setVar('content', $content);
286
+            $myts = \Xoops\Core\Text\Sanitizer::getInstance();
287
+            echo '<div id="xo-preview-dialog" title="' . $block->getVar('title', 's')
288
+                . '">' . $block->getContent('s', $block->getVar('c_type')) . '</div>';
289
+            break;
290
+
291
+        case 'save':
292
+            if (!$xoops->security()->check()) {
293
+                $xoops->redirect('admin.php?fct=blocksadmin', 3, implode('<br />', $xoops->security()->getErrors()));
294
+                exit();
295
+            }
296
+            // Initialize blocks handler
297
+            $block_handler = $xoops->getHandlerBlock();
298
+            // Get avatar id
299
+            $block_id = Request::getInt('bid', 0, 'post');
300
+            if ($block_id > 0) {
301
+                $block = $block_handler->get($block_id);
302
+            } else {
303
+                $block = $block_handler->create();
304
+            }
305
+            $block_type = Request::getString('block_type', '', 'post');
306
+            $block->setVar('block_type', $block_type);
307
+
308
+            if (!$block->isCustom()) {
309
+                $block->setVars($_POST);
310
+                $type = $block->getVar('block_type');
311
+                $name = $block->getVar('name');
312
+                // Save block options
313
+                $options = $_POST['options'];
314
+                if (isset($options)) {
315
+                    $options_count = count($options);
316
+                    if ($options_count > 0) {
317
+                        //Convert array values to comma-separated
318
+                        for ($i = 0; $i < $options_count; ++$i) {
319
+                            if (is_array($options[$i])) {
320
+                                $options[$i] = implode(',', $options[$i]);
321
+                            }
321 322
                         }
323
+                        $options = implode('|', $options);
324
+                        $block->setVar('options', $options);
322 325
                     }
323
-                    $options = implode('|', $options);
324
-                    $block->setVar('options', $options);
325 326
                 }
326
-            }
327
-        } else {
328
-            $block->setVars($_POST);
329
-            switch ($block->getVar('c_type')) {
327
+            } else {
328
+                $block->setVars($_POST);
329
+                switch ($block->getVar('c_type')) {
330 330
                 case 'H':
331 331
                     $name = SystemLocale::CUSTOM_BLOCK_HTML;
332 332
                     break;
@@ -339,7 +339,7 @@  discard block
 block discarded – undo
339 339
                 default:
340 340
                     $name = SystemLocale::CUSTOM_BLOCK_AUTO_FORMAT;
341 341
                     break;
342
-            }
342
+                }
343 343
         }
344 344
         $block->setVar('name', $name);
345 345
         $block->setVar('isactive', 1);
@@ -397,18 +397,44 @@  discard block
 block discarded – undo
397 397
         $xoops->redirect('admin.php?fct=blocksadmin', 1, XoopsLocale::S_DATABASE_UPDATED);
398 398
         break;
399 399
 
400
-    case 'edit':
401
-        // Initialize blocks handler
402
-        $block_handler = $xoops->getHandlerBlock();
403
-        // Get avatar id
404
-        $block_id = Request::getInt('bid', 0);
405
-        if ($block_id > 0) {
400
+        case 'edit':
401
+            // Initialize blocks handler
402
+            $block_handler = $xoops->getHandlerBlock();
403
+            // Get avatar id
404
+            $block_id = Request::getInt('bid', 0);
405
+            if ($block_id > 0) {
406
+                // Call Header
407
+                $xoops->header('admin:system/system_blocks.tpl');
408
+                // Define Stylesheet
409
+                $xoops->theme()->addStylesheet('modules/system/css/admin.css');
410
+                $xoops->theme()->addScript('media/jquery/plugins/jquery.form.js');
411
+                $xoops->theme()->addScript('modules/system/js/admin.js');
412
+                // Define Breadcrumb and tips
413
+                $admin_page = new \Xoops\Module\Admin();
414
+                $admin_page->addBreadcrumbLink(SystemLocale::CONTROL_PANEL, \XoopsBaseConfig::get('url') . '/admin.php', true);
415
+                $admin_page->addBreadcrumbLink(
416
+                    SystemLocale::BLOCKS_ADMINISTRATION,
417
+                    $system->adminVersion('blocksadmin', 'adminpath')
418
+                );
419
+                $admin_page->addBreadcrumbLink(SystemLocale::EDIT_BLOCK);
420
+                $admin_page->renderBreadcrumb();
421
+                $block = $block_handler->get($block_id);
422
+                /* @var $form SystemBlockForm */
423
+                $form = $xoops->getModuleForm($block, 'block');
424
+                $form->getForm();
425
+                $form->display();
426
+                // Call Footer
427
+                $xoops->footer();
428
+            } else {
429
+                $xoops->redirect('admin.php?fct=blocksadmin', 1, XoopsLocale::E_DATABASE_NOT_UPDATED);
430
+            }
431
+            break;
432
+
433
+        case 'delete':
406 434
             // Call Header
407 435
             $xoops->header('admin:system/system_blocks.tpl');
408 436
             // Define Stylesheet
409 437
             $xoops->theme()->addStylesheet('modules/system/css/admin.css');
410
-            $xoops->theme()->addScript('media/jquery/plugins/jquery.form.js');
411
-            $xoops->theme()->addScript('modules/system/js/admin.js');
412 438
             // Define Breadcrumb and tips
413 439
             $admin_page = new \Xoops\Module\Admin();
414 440
             $admin_page->addBreadcrumbLink(SystemLocale::CONTROL_PANEL, \XoopsBaseConfig::get('url') . '/admin.php', true);
@@ -416,141 +442,115 @@  discard block
 block discarded – undo
416 442
                 SystemLocale::BLOCKS_ADMINISTRATION,
417 443
                 $system->adminVersion('blocksadmin', 'adminpath')
418 444
             );
419
-            $admin_page->addBreadcrumbLink(SystemLocale::EDIT_BLOCK);
445
+            $admin_page->addBreadcrumbLink(SystemLocale::DELETE_BLOCK);
420 446
             $admin_page->renderBreadcrumb();
421
-            $block = $block_handler->get($block_id);
422
-            /* @var $form SystemBlockForm */
423
-            $form = $xoops->getModuleForm($block, 'block');
424
-            $form->getForm();
425
-            $form->display();
426
-            // Call Footer
427
-            $xoops->footer();
428
-        } else {
429
-            $xoops->redirect('admin.php?fct=blocksadmin', 1, XoopsLocale::E_DATABASE_NOT_UPDATED);
430
-        }
431
-        break;
432
-
433
-    case 'delete':
434
-        // Call Header
435
-        $xoops->header('admin:system/system_blocks.tpl');
436
-        // Define Stylesheet
437
-        $xoops->theme()->addStylesheet('modules/system/css/admin.css');
438
-        // Define Breadcrumb and tips
439
-        $admin_page = new \Xoops\Module\Admin();
440
-        $admin_page->addBreadcrumbLink(SystemLocale::CONTROL_PANEL, \XoopsBaseConfig::get('url') . '/admin.php', true);
441
-        $admin_page->addBreadcrumbLink(
442
-            SystemLocale::BLOCKS_ADMINISTRATION,
443
-            $system->adminVersion('blocksadmin', 'adminpath')
444
-        );
445
-        $admin_page->addBreadcrumbLink(SystemLocale::DELETE_BLOCK);
446
-        $admin_page->renderBreadcrumb();
447
-        // Initialize blocks handler
448
-        $block_handler = $xoops->getHandlerBlock();
449
-        // Get avatar id
450
-        $block_id = Request::getInt('bid', 0);
451
-        if ($block_id > 0) {
452
-            $block = $block_handler->get($block_id);
453
-            if ($block->getVar('block_type') === XoopsBlock::BLOCK_TYPE_SYSTEM) {
454
-                $xoops->redirect('admin.php?fct=blocksadmin', 4, SystemLocale::E_SYSTEM_BLOCKS_CANNOT_BE_DELETED);
455
-                exit();
456
-            } elseif ($block->getVar('block_type') === XoopsBlock::BLOCK_TYPE_MODULE) {
457
-                // Fix for duplicated blocks created in 2.0.9 module update
458
-                // A module block can be deleted if there is more than 1 that
459
-                // has the same func_num/show_func which is mostly likely
460
-                // be the one that was duplicated in 2.0.9
461
-                if (1 >= $count = $block_handler->countSimilarBlocks(
462
-                    $block->getVar('mid'),
463
-                    $block->getVar('func_num'),
464
-                    $block->getVar('show_func')
465
-                )) {
466
-                    $xoops->redirect('admin.php?fct=blocksadmin', 4, SystemLocale::E_THIS_BLOCK_CANNOT_BE_DELETED);
447
+            // Initialize blocks handler
448
+            $block_handler = $xoops->getHandlerBlock();
449
+            // Get avatar id
450
+            $block_id = Request::getInt('bid', 0);
451
+            if ($block_id > 0) {
452
+                $block = $block_handler->get($block_id);
453
+                if ($block->getVar('block_type') === XoopsBlock::BLOCK_TYPE_SYSTEM) {
454
+                    $xoops->redirect('admin.php?fct=blocksadmin', 4, SystemLocale::E_SYSTEM_BLOCKS_CANNOT_BE_DELETED);
467 455
                     exit();
456
+                } elseif ($block->getVar('block_type') === XoopsBlock::BLOCK_TYPE_MODULE) {
457
+                    // Fix for duplicated blocks created in 2.0.9 module update
458
+                    // A module block can be deleted if there is more than 1 that
459
+                    // has the same func_num/show_func which is mostly likely
460
+                    // be the one that was duplicated in 2.0.9
461
+                    if (1 >= $count = $block_handler->countSimilarBlocks(
462
+                        $block->getVar('mid'),
463
+                        $block->getVar('func_num'),
464
+                        $block->getVar('show_func')
465
+                    )) {
466
+                        $xoops->redirect('admin.php?fct=blocksadmin', 4, SystemLocale::E_THIS_BLOCK_CANNOT_BE_DELETED);
467
+                        exit();
468
+                    }
468 469
                 }
470
+                // Call Header
471
+                $xoops->header('admin:system/system_header.tpl');
472
+                // Display Question
473
+                echo $xoops->confirm(array(
474
+                    'op'  => 'delete_ok',
475
+                    'fct' => 'blocksadmin',
476
+                    'bid' => $block->getVar('bid')
477
+                ), 'admin.php', sprintf(SystemLocale::QF_ARE_YOU_SURE_TO_DELETE_THIS_BLOCK, $block->getVar('title')));
478
+                // Call Footer
479
+                $xoops->footer();
469 480
             }
470
-            // Call Header
471
-            $xoops->header('admin:system/system_header.tpl');
472
-            // Display Question
473
-            echo $xoops->confirm(array(
474
-                'op'  => 'delete_ok',
475
-                'fct' => 'blocksadmin',
476
-                'bid' => $block->getVar('bid')
477
-            ), 'admin.php', sprintf(SystemLocale::QF_ARE_YOU_SURE_TO_DELETE_THIS_BLOCK, $block->getVar('title')));
478
-            // Call Footer
479
-            $xoops->footer();
480
-        }
481
-        break;
481
+            break;
482 482
 
483
-    case 'delete_ok':
484
-        if (!$xoops->security()->check()) {
485
-            $xoops->redirect('admin.php?fct=blocksadmin', 3, implode('<br />', $xoops->security()->getErrors()));
486
-            exit();
487
-        }
488
-        // Initialize blocks handler
489
-        $block_handler = $xoops->getHandlerBlock();
490
-        // Get avatar id
491
-        $block_id = Request::getInt('bid', 0, 'post');
492
-        if ($block_id > 0) {
493
-            $block = $block_handler->get($block_id);
494
-            if ($block_handler->deleteBlock($block)) {
495
-                // Delete Group link
496
-                $blockmodulelink_handler = $xoops->getHandlerBlockModuleLink();
497
-                $blockmodulelink =
498
-                    $blockmodulelink_handler->getObjects(new CriteriaCompo(new Criteria('block_id', $block_id)));
499
-                foreach ($blockmodulelink as $link) {
500
-                    $blockmodulelink_handler->delete($link, true);
501
-                }
502
-                // Delete Group permission
503
-                $groupperm_handler = $xoops->getHandlerGroupPermission();
504
-                $criteria = new CriteriaCompo(new Criteria('gperm_name', 'block_read'));
505
-                $criteria->add(new Criteria('gperm_itemid', $block_id));
506
-                $groupperm = $groupperm_handler->getObjects($criteria);
507
-                /* @var $perm XoopsGroupPerm */
508
-                foreach ($groupperm as $perm) {
509
-                    $groupperm_handler->delete($perm, true);
510
-                }
511
-                // Delete template
512
-                if ($block->getVar('template') != '') {
513
-                    $tplfile_handler = $xoops->getHandlerTplFile();
514
-                    $btemplate = $tplfile_handler->find($xoops->getConfig('template_set'), 'block', $block_id);
515
-                    if (count($btemplate) > 0) {
516
-                        $tplfile_handler->deleteTpl($btemplate[0]);
483
+        case 'delete_ok':
484
+            if (!$xoops->security()->check()) {
485
+                $xoops->redirect('admin.php?fct=blocksadmin', 3, implode('<br />', $xoops->security()->getErrors()));
486
+                exit();
487
+            }
488
+            // Initialize blocks handler
489
+            $block_handler = $xoops->getHandlerBlock();
490
+            // Get avatar id
491
+            $block_id = Request::getInt('bid', 0, 'post');
492
+            if ($block_id > 0) {
493
+                $block = $block_handler->get($block_id);
494
+                if ($block_handler->deleteBlock($block)) {
495
+                    // Delete Group link
496
+                    $blockmodulelink_handler = $xoops->getHandlerBlockModuleLink();
497
+                    $blockmodulelink =
498
+                        $blockmodulelink_handler->getObjects(new CriteriaCompo(new Criteria('block_id', $block_id)));
499
+                    foreach ($blockmodulelink as $link) {
500
+                        $blockmodulelink_handler->delete($link, true);
501
+                    }
502
+                    // Delete Group permission
503
+                    $groupperm_handler = $xoops->getHandlerGroupPermission();
504
+                    $criteria = new CriteriaCompo(new Criteria('gperm_name', 'block_read'));
505
+                    $criteria->add(new Criteria('gperm_itemid', $block_id));
506
+                    $groupperm = $groupperm_handler->getObjects($criteria);
507
+                    /* @var $perm XoopsGroupPerm */
508
+                    foreach ($groupperm as $perm) {
509
+                        $groupperm_handler->delete($perm, true);
510
+                    }
511
+                    // Delete template
512
+                    if ($block->getVar('template') != '') {
513
+                        $tplfile_handler = $xoops->getHandlerTplFile();
514
+                        $btemplate = $tplfile_handler->find($xoops->getConfig('template_set'), 'block', $block_id);
515
+                        if (count($btemplate) > 0) {
516
+                            $tplfile_handler->deleteTpl($btemplate[0]);
517
+                        }
517 518
                     }
519
+                    $xoops->redirect('admin.php?fct=blocksadmin', 1, XoopsLocale::S_DATABASE_UPDATED);
518 520
                 }
519
-                $xoops->redirect('admin.php?fct=blocksadmin', 1, XoopsLocale::S_DATABASE_UPDATED);
521
+            } else {
522
+                $xoops->redirect('admin.php?fct=blocksadmin', 1, XoopsLocale::E_DATABASE_NOT_UPDATED);
520 523
             }
521
-        } else {
522
-            $xoops->redirect('admin.php?fct=blocksadmin', 1, XoopsLocale::E_DATABASE_NOT_UPDATED);
523
-        }
524
-        break;
525
-
526
-    case 'clone':
527
-        // Initialize blocks handler
528
-        $block_handler = $xoops->getHandlerBlock();
529
-        // Get avatar id
530
-        $block_id = Request::getInt('bid', 0);
531
-        if ($block_id > 0) {
532
-            // Call Header
533
-            $xoops->header('admin:system/system_blocks.tpl');
534
-            // Define Stylesheet
535
-            $xoops->theme()->addStylesheet('modules/system/css/admin.css');
536
-            // Define Breadcrumb and tips
537
-            $system_breadcrumb = new \Xoops\Module\Admin();
538
-            $system_breadcrumb->addBreadcrumbLink(
539
-                SystemLocale::BLOCKS_ADMINISTRATION,
540
-                system_adminVersion('blocksadmin', 'adminpath')
541
-            );
542
-            $system_breadcrumb->addBreadcrumbLink(SystemLocale::CLONE_BLOCK);
543
-            $system_breadcrumb->renderBreadcrumb();
544
-
545
-            $block = $block_handler->get($block_id);
546
-            /* @var $form SystemBlockForm */
547
-            $form = $xoops->getModuleForm($block, 'block');
548
-            $form->getForm('clone');
549
-            $form->display();
550
-            // Call Footer
551
-            $xoops->footer();
552
-        } else {
553
-            $xoops->redirect('admin.php?fct=blocksadmin', 1, XoopsLocale::E_DATABASE_NOT_UPDATED);
554
-        }
555
-        break;
524
+            break;
525
+
526
+        case 'clone':
527
+            // Initialize blocks handler
528
+            $block_handler = $xoops->getHandlerBlock();
529
+            // Get avatar id
530
+            $block_id = Request::getInt('bid', 0);
531
+            if ($block_id > 0) {
532
+                // Call Header
533
+                $xoops->header('admin:system/system_blocks.tpl');
534
+                // Define Stylesheet
535
+                $xoops->theme()->addStylesheet('modules/system/css/admin.css');
536
+                // Define Breadcrumb and tips
537
+                $system_breadcrumb = new \Xoops\Module\Admin();
538
+                $system_breadcrumb->addBreadcrumbLink(
539
+                    SystemLocale::BLOCKS_ADMINISTRATION,
540
+                    system_adminVersion('blocksadmin', 'adminpath')
541
+                );
542
+                $system_breadcrumb->addBreadcrumbLink(SystemLocale::CLONE_BLOCK);
543
+                $system_breadcrumb->renderBreadcrumb();
544
+
545
+                $block = $block_handler->get($block_id);
546
+                /* @var $form SystemBlockForm */
547
+                $form = $xoops->getModuleForm($block, 'block');
548
+                $form->getForm('clone');
549
+                $form->display();
550
+                // Call Footer
551
+                $xoops->footer();
552
+            } else {
553
+                $xoops->redirect('admin.php?fct=blocksadmin', 1, XoopsLocale::E_DATABASE_NOT_UPDATED);
554
+            }
555
+            break;
556 556
 }
Please login to merge, or discard this patch.