Completed
Pull Request — master (#622)
by Richard
29:20 queued 24s
created
htdocs/modules/avatars/class/form/avatar_user.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -37,8 +37,8 @@
 block discarded – undo
37 37
         $avatar_selected = $xoops->user->getVar("user_avatar", "E");
38 38
         $avatar_selected = in_array($avatar_selected, array_keys($avatar_list)) ? $avatar_selected : "blank.gif";
39 39
         $avatar_select->addOptionArray($avatar_list);
40
-		$xoops_url = \XoopsBaseConfig::get('url');
41
-		$xoops_upload_url = \XoopsBaseConfig::get('uploads-url');
40
+        $xoops_url = \XoopsBaseConfig::get('url');
41
+        $xoops_upload_url = \XoopsBaseConfig::get('uploads-url');
42 42
         $avatar_select->setExtra("onchange='showImgSelected(\"avatar\", \"user_avatar\", \"uploads\", \"\", \"" . $xoops_url . "\")'");
43 43
         $avatar_tray = new Xoops\Form\ElementTray(XoopsLocale::FILE, ' ');
44 44
         $avatar_tray->addElement($avatar_select);
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -39,11 +39,11 @@
 block discarded – undo
39 39
         $avatar_select->addOptionArray($avatar_list);
40 40
 		$xoops_url = \XoopsBaseConfig::get('url');
41 41
 		$xoops_upload_url = \XoopsBaseConfig::get('uploads-url');
42
-        $avatar_select->setExtra("onchange='showImgSelected(\"avatar\", \"user_avatar\", \"uploads\", \"\", \"" . $xoops_url . "\")'");
42
+        $avatar_select->setExtra("onchange='showImgSelected(\"avatar\", \"user_avatar\", \"uploads\", \"\", \"".$xoops_url."\")'");
43 43
         $avatar_tray = new Xoops\Form\ElementTray(XoopsLocale::FILE, ' ');
44 44
         $avatar_tray->addElement($avatar_select);
45
-        $avatar_tray->addElement(new Xoops\Form\Label('', "<a href=\"javascript:openWithSelfMain('" . $xoops_url . "/modules/avatars/popup.php','avatars',600,400);\">" . XoopsLocale::LIST_. "</a><br />"));
46
-        $avatar_tray->addElement(new Xoops\Form\Label('', "<br /><img src='" . $xoops_upload_url . "/" . $avatar_selected . "' name='avatar' id='avatar' alt='' />"));
45
+        $avatar_tray->addElement(new Xoops\Form\Label('', "<a href=\"javascript:openWithSelfMain('".$xoops_url."/modules/avatars/popup.php','avatars',600,400);\">".XoopsLocale::LIST_."</a><br />"));
46
+        $avatar_tray->addElement(new Xoops\Form\Label('', "<br /><img src='".$xoops_upload_url."/".$avatar_selected."' name='avatar' id='avatar' alt='' />"));
47 47
         if ($helper->getConfig('avatars_allowupload') == 1 && $xoops->user->getVar('posts') >= $helper->getConfig('avatars_postsrequired')) {
48 48
             $fileseltray_img = new Xoops\Form\ElementTray('<br />', '<br /><br />');
49 49
             $fileseltray_img->addElement(new Xoops\Form\File(XoopsLocale::A_UPLOAD, 'user_avatar'), false);
Please login to merge, or discard this patch.
htdocs/modules/avatars/class/form/avatar.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -40,11 +40,11 @@
 block discarded – undo
40 40
         $this->addElement(new Xoops\Form\Text(XoopsLocale::NAME, 'avatar_name', 5, 255, $obj->getVar('avatar_name', 'e')), true);
41 41
         // Upload part
42 42
         $imgtray_img = new Xoops\Form\ElementTray(XoopsLocale::FILE, '<br />');
43
-		$avatars_path = \XoopsBaseConfig::get('uploads-path') . '/avatars';
43
+        $avatars_path = \XoopsBaseConfig::get('uploads-path') . '/avatars';
44 44
         $imageselect_img = new Xoops\Form\Select(sprintf(XoopsLocale::F_FILE_EXISTS_IN, $avatars_path . '/'), 'avatar_file', $blank_img);
45 45
         $imageselect_img->addOption($blank_img, $blank_img);
46 46
         \Xoops\Core\Lists\ImageFile::setOptionsArray($imageselect_img, $avatars_path);
47
-		$xoops_upload_url = \XoopsBaseConfig::get('uploads-url');
47
+        $xoops_upload_url = \XoopsBaseConfig::get('uploads-url');
48 48
         $imageselect_img->setExtra("onchange='showImgSelected(\"xo-avatar-img\", \"avatar_file\", \"avatars\", \"\", \"" . $xoops_upload_url . "\")'");
49 49
         $imgtray_img->addElement($imageselect_img, false);
50 50
         $imgtray_img->addElement(new Xoops\Form\Label('', "<br /><img src='" . $xoops_upload_url . "/avatars/" . $blank_img . "' name='image_img' id='xo-avatar-img' alt='' />"));
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -40,14 +40,14 @@
 block discarded – undo
40 40
         $this->addElement(new Xoops\Form\Text(XoopsLocale::NAME, 'avatar_name', 5, 255, $obj->getVar('avatar_name', 'e')), true);
41 41
         // Upload part
42 42
         $imgtray_img = new Xoops\Form\ElementTray(XoopsLocale::FILE, '<br />');
43
-		$avatars_path = \XoopsBaseConfig::get('uploads-path') . '/avatars';
44
-        $imageselect_img = new Xoops\Form\Select(sprintf(XoopsLocale::F_FILE_EXISTS_IN, $avatars_path . '/'), 'avatar_file', $blank_img);
43
+		$avatars_path = \XoopsBaseConfig::get('uploads-path').'/avatars';
44
+        $imageselect_img = new Xoops\Form\Select(sprintf(XoopsLocale::F_FILE_EXISTS_IN, $avatars_path.'/'), 'avatar_file', $blank_img);
45 45
         $imageselect_img->addOption($blank_img, $blank_img);
46 46
         \Xoops\Core\Lists\ImageFile::setOptionsArray($imageselect_img, $avatars_path);
47 47
 		$xoops_upload_url = \XoopsBaseConfig::get('uploads-url');
48
-        $imageselect_img->setExtra("onchange='showImgSelected(\"xo-avatar-img\", \"avatar_file\", \"avatars\", \"\", \"" . $xoops_upload_url . "\")'");
48
+        $imageselect_img->setExtra("onchange='showImgSelected(\"xo-avatar-img\", \"avatar_file\", \"avatars\", \"\", \"".$xoops_upload_url."\")'");
49 49
         $imgtray_img->addElement($imageselect_img, false);
50
-        $imgtray_img->addElement(new Xoops\Form\Label('', "<br /><img src='" . $xoops_upload_url . "/avatars/" . $blank_img . "' name='image_img' id='xo-avatar-img' alt='' />"));
50
+        $imgtray_img->addElement(new Xoops\Form\Label('', "<br /><img src='".$xoops_upload_url."/avatars/".$blank_img."' name='image_img' id='xo-avatar-img' alt='' />"));
51 51
         $fileseltray_img = new Xoops\Form\ElementTray('<br />', '<br /><br />');
52 52
         $fileseltray_img->addElement(new Xoops\Form\File(XoopsLocale::A_UPLOAD, 'avatar_file'), false);
53 53
         // , $xoops->getModuleConfig('avatars_imagefilesize')
Please login to merge, or discard this patch.
htdocs/modules/profile/userinfo.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
  * @author          Taiwen Jiang <[email protected]>
24 24
  */
25 25
 
26
-include __DIR__ . '/header.php';
26
+include __DIR__.'/header.php';
27 27
 $xoops = Xoops::getInstance();
28 28
 include_once $xoops->path('modules/system/constants.php');
29 29
 
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
     if ($xoops->isUser()) {
33 33
         $uid = $xoops->user->getVar('uid');
34 34
     } else {
35
-        header('location: ' . \XoopsBaseConfig::get('url'));
35
+        header('location: '.\XoopsBaseConfig::get('url'));
36 36
         exit();
37 37
     }
38 38
 }
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
 
66 66
     // Redirect if not a user or not active and the current user is not admin
67 67
     if (!is_object($thisUser) || (!$thisUser->isActive() && (!$xoops->user || !$xoops->user->isAdmin()))) {
68
-        $xoops->redirect(\XoopsBaseConfig::get('url') . "/modules/" . $xoops->module->getVar('dirname', 'n'), 3, XoopsLocale::E_NO_USER_SELECTED);
68
+        $xoops->redirect(\XoopsBaseConfig::get('url')."/modules/".$xoops->module->getVar('dirname', 'n'), 3, XoopsLocale::E_NO_USER_SELECTED);
69 69
     }
70 70
 
71 71
     /**
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
     }
102 102
 
103 103
     if ($rejected) {
104
-        $xoops->redirect(\XoopsBaseConfig::get('url') . "/modules/" . $xoops->module->getVar('dirname', 'n'), 3, XoopsLocale::E_NO_ACCESS_PERMISSION);
104
+        $xoops->redirect(\XoopsBaseConfig::get('url')."/modules/".$xoops->module->getVar('dirname', 'n'), 3, XoopsLocale::E_NO_ACCESS_PERMISSION);
105 105
     }
106 106
 
107 107
     if ($xoops->isUser() && $xoops->user->isAdmin()) {
@@ -122,9 +122,9 @@  discard block
 block discarded – undo
122 122
 // Let extensions add navigation button
123 123
 //$xoops->events()->triggerEvent('core.userinfo.button', array($thisUser, &$btn));
124 124
 $response = $xoops->service("Avatar")->getAvatarEditUrl($thisUser);
125
-$link=$response->getValue();
125
+$link = $response->getValue();
126 126
 if (!empty($link)) {
127
-    $btn[] = array( 'link' => $link, 'title' => XoopsLocale::AVATAR, 'icon' => 'icon-user');
127
+    $btn[] = array('link' => $link, 'title' => XoopsLocale::AVATAR, 'icon' => 'icon-user');
128 128
     $xoops->tpl()->assign('btn', $btn);
129 129
 }
130 130
 
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
 
194 194
 if ($xoops->isActiveModule('search') && $xoops->getModuleConfig('profile_search') && $xoops->getModuleConfig('enable_search', 'search')) {
195 195
     $available_plugins = \Xoops\Module\Plugin::getPlugins('search');
196
-    $criteria = new Criteria('dirname', "('" . implode("','", array_keys($available_plugins)) . "')", 'IN');
196
+    $criteria = new Criteria('dirname', "('".implode("','", array_keys($available_plugins))."')", 'IN');
197 197
     $modules = $module_handler->getObjectsArray($criteria, true);
198 198
     $mids = array_keys($modules);
199 199
 
@@ -211,18 +211,18 @@  discard block
 block discarded – undo
211 211
                 if (is_array($results) && $count > 0) {
212 212
                     for ($i = 0; $i < $count; ++$i) {
213 213
                         if (isset($results[$i]['image']) && $results[$i]['image'] != '') {
214
-                            $results[$i]['image'] = \XoopsBaseConfig::get('url') . '/modules/' . $module->getVar('dirname', 'n') . '/' . $results[$i]['image'];
214
+                            $results[$i]['image'] = \XoopsBaseConfig::get('url').'/modules/'.$module->getVar('dirname', 'n').'/'.$results[$i]['image'];
215 215
                         } else {
216
-                            $results[$i]['image'] = \XoopsBaseConfig::get('url') . '/images/icons/posticon2.gif';
216
+                            $results[$i]['image'] = \XoopsBaseConfig::get('url').'/images/icons/posticon2.gif';
217 217
                         }
218 218
                         if (!preg_match("/^http[s]*:\/\//i", $results[$i]['link'])) {
219
-                            $results[$i]['link'] = \XoopsBaseConfig::get('url') . "/modules/" . $module->getVar('dirname', 'n') . "/" . $results[$i]['link'];
219
+                            $results[$i]['link'] = \XoopsBaseConfig::get('url')."/modules/".$module->getVar('dirname', 'n')."/".$results[$i]['link'];
220 220
                         }
221 221
                         $results[$i]['title'] = $myts->htmlSpecialChars($results[$i]['title']);
222 222
                         $results[$i]['time'] = $results[$i]['time'] ? XoopsLocale::formatTimestamp($results[$i]['time']) : '';
223 223
                     }
224 224
                     if ($count == 5) {
225
-                        $showall_link = '<a href="' . \XoopsBaseConfig::get('url') . '/search.php?action=showallbyuser&amp;mid=' . $mid . '&amp;uid=' . $thisUser->getVar('uid') . '">' . XoopsLocale::SHOW_ALL . '</a>';
225
+                        $showall_link = '<a href="'.\XoopsBaseConfig::get('url').'/search.php?action=showallbyuser&amp;mid='.$mid.'&amp;uid='.$thisUser->getVar('uid').'">'.XoopsLocale::SHOW_ALL.'</a>';
226 226
                     } else {
227 227
                         $showall_link = '';
228 228
                     }
@@ -243,4 +243,4 @@  discard block
 block discarded – undo
243 243
 $xoops->tpl()->assign('avatar', $avatar);
244 244
 $xoops->tpl()->assign('recent_activity', _PROFILE_MA_RECENTACTIVITY);
245 245
 $xoops->registry()->get('profile_breadcrumbs')->addItem(new Link(['caption' => _PROFILE_MA_USERINFO]));
246
-include __DIR__ . '/footer.php';
246
+include __DIR__.'/footer.php';
Please login to merge, or discard this patch.
htdocs/modules/profile/edituser.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
  * @author          Taiwen Jiang <[email protected]>
23 23
  */
24 24
 
25
-include __DIR__ . '/header.php';
25
+include __DIR__.'/header.php';
26 26
 $xoops = Xoops::getInstance();
27 27
 
28 28
 // If not a user, redirect
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
 
37 37
 if ($op === 'save') {
38 38
     if (!$xoops->security()->check()) {
39
-        $xoops->redirect(\XoopsBaseConfig::get('url') . "/modules/" . $xoops->module->getVar('dirname', 'n') . "/", 3, XoopsLocale::E_NO_ACTION_PERMISSION . "<br />" . implode('<br />', $xoops->security()->getErrors()));
39
+        $xoops->redirect(\XoopsBaseConfig::get('url')."/modules/".$xoops->module->getVar('dirname', 'n')."/", 3, XoopsLocale::E_NO_ACTION_PERMISSION."<br />".implode('<br />', $xoops->security()->getErrors()));
40 40
         exit();
41 41
     }
42 42
     $uid = $xoops->user->getVar('uid');
@@ -85,14 +85,14 @@  discard block
 block discarded – undo
85 85
             $profile->setVar('profile_id', $edituser->getVar('uid'));
86 86
             $profile_handler->insert($profile);
87 87
             unset($_SESSION['xoopsUserTheme']);
88
-            $xoops->redirect(\XoopsBaseConfig::get('url') . '/modules/' . $xoops->module->getVar('dirname', 'n') . '/userinfo.php?uid=' . $edituser->getVar('uid'), 2, XoopsLocale::S_YOUR_PROFILE_UPDATED);
88
+            $xoops->redirect(\XoopsBaseConfig::get('url').'/modules/'.$xoops->module->getVar('dirname', 'n').'/userinfo.php?uid='.$edituser->getVar('uid'), 2, XoopsLocale::S_YOUR_PROFILE_UPDATED);
89 89
         }
90 90
     }
91 91
 }
92 92
 
93 93
 if ($op === 'editprofile') {
94 94
     $xoops->header('module:profile/profile_editprofile.tpl');
95
-    include_once __DIR__ . '/include/forms.php';
95
+    include_once __DIR__.'/include/forms.php';
96 96
     $form = profile_getUserForm($xoops->user);
97 97
     $form->assign($xoops->tpl());
98 98
     if (!empty($stop)) {
@@ -103,4 +103,4 @@  discard block
 block discarded – undo
103 103
         new Link(['caption' => XoopsLocale::EDIT_PROFILE])
104 104
     );
105 105
 }
106
-include __DIR__ . '/footer.php';
106
+include __DIR__.'/footer.php';
Please login to merge, or discard this patch.
htdocs/modules/profile/admin/about.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
  * @author          Mamba
21 21
  */
22 22
 
23
-include __DIR__ . '/header.php';
23
+include __DIR__.'/header.php';
24 24
 
25 25
 $xoops = Xoops::getInstance();
26 26
 $xoops->header();
Please login to merge, or discard this patch.
htdocs/modules/profile/admin/deactivate.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
  * @author          Taiwen Jiang <[email protected]>
22 22
  */
23 23
 
24
-include __DIR__ . '/header.php';
24
+include __DIR__.'/header.php';
25 25
 $xoops = Xoops::getInstance();
26 26
 $xoops->header();
27 27
 
@@ -51,4 +51,4 @@  discard block
 block discarded – undo
51 51
         $message = _PROFILE_AM_USER_NOT_DEACTIVATED;
52 52
     }
53 53
 }
54
-$xoops->redirect($xoops->url('modules/profile/userinfo.php?uid=' . $user->getVar('uid')), 3, $message);
54
+$xoops->redirect($xoops->url('modules/profile/userinfo.php?uid='.$user->getVar('uid')), 3, $message);
Please login to merge, or discard this patch.
htdocs/modules/profile/admin/user.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
  * @author          Jan Pedersen
22 22
  * @author          Taiwen Jiang <[email protected]>
23 23
  */
24
-include __DIR__ . '/header.php';
24
+include __DIR__.'/header.php';
25 25
 
26 26
 $xoops = Xoops::getInstance();
27 27
 $xoops->header();
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 
52 52
     case "new":
53 53
         $xoops->loadLanguage("main", $xoops->module->getVar('dirname', 'n'));
54
-        include_once dirname(__DIR__) . '/include/forms.php';
54
+        include_once dirname(__DIR__).'/include/forms.php';
55 55
         $obj = $handler->createUser();
56 56
         $obj->setGroups(array(FixedGroups::USERS));
57 57
         $form = profile_getUserForm($obj);
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
             // If not webmaster trying to edit a webmaster - disallow
66 66
             $xoops->redirect("user.php", 3, XoopsLocale::E_NO_ACTION_PERMISSION);
67 67
         }
68
-        include_once dirname(__DIR__) . '/include/forms.php';
68
+        include_once dirname(__DIR__).'/include/forms.php';
69 69
         $form = profile_getUserForm($obj);
70 70
         $form->display();
71 71
         break;
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
             $xoops->redirect(
77 77
                 'user.php',
78 78
                 3,
79
-                XoopsLocale::E_NO_ACTION_PERMISSION . "<br />"
79
+                XoopsLocale::E_NO_ACTION_PERMISSION."<br />"
80 80
                 . implode('<br />', $xoops->security()->getErrors())
81 81
             );
82 82
             exit;
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
             }
196 196
         }
197 197
         $user->setGroups($new_groups);
198
-        include_once dirname(__DIR__) . '/include/forms.php';
198
+        include_once dirname(__DIR__).'/include/forms.php';
199 199
         echo $user->getHtmlErrors();
200 200
         $form = profile_getUserForm($user, $profile);
201 201
         $form->display();
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
                     $xoops->redirect(
223 223
                         'user.php',
224 224
                         3,
225
-                        sprintf(_PROFILE_AM_DELETEDSUCCESS, $obj->getVar('uname') . " (" . $obj->getVar('email') . ")"),
225
+                        sprintf(_PROFILE_AM_DELETEDSUCCESS, $obj->getVar('uname')." (".$obj->getVar('email').")"),
226 226
                         false
227 227
                     );
228 228
                 } else {
@@ -236,7 +236,7 @@  discard block
 block discarded – undo
236 236
             echo $xoops->confirm(
237 237
                 array('ok' => 1, 'id' => $_REQUEST['id'], 'op' => 'delete'),
238 238
                 $_SERVER['REQUEST_URI'],
239
-                sprintf(_PROFILE_AM_RUSUREDEL, $obj->getVar('uname') . " (" . $obj->getVar('email') . ")")
239
+                sprintf(_PROFILE_AM_RUSUREDEL, $obj->getVar('uname')." (".$obj->getVar('email').")")
240 240
             );
241 241
         }
242 242
         break;
Please login to merge, or discard this patch.
htdocs/modules/profile/admin/header.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,5 +19,5 @@
 block discarded – undo
19 19
  * @author          Taiwen Jiang <[email protected]>
20 20
  */
21 21
 
22
-require_once dirname(dirname(dirname(__DIR__))) . '/include/cp_header.php';
22
+require_once dirname(dirname(dirname(__DIR__))).'/include/cp_header.php';
23 23
 XoopsLoad::load('system', 'system');
Please login to merge, or discard this patch.
htdocs/modules/profile/xoops_version.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@
 block discarded – undo
44 44
 // paypal
45 45
 $modversion['paypal'] = array(
46 46
     'business'      => '[email protected]',
47
-    'item_name'     => 'Donation : ' . _PROFILE_MI_DESC,
47
+    'item_name'     => 'Donation : '._PROFILE_MI_DESC,
48 48
     'amount'        => 0,
49 49
     'currency_code' => 'USD',
50 50
 );
Please login to merge, or discard this patch.