WordPoints / hooks-api

src/includes/classes/entity/change.php

Doc Comments +15 added lines

@@ -58,8 +58,20 @@ 
 
 // this is basically a reactor
 interface WordPoints_Entity_Change_ListenerI {
+
+	/**
+	 * @return void
+	 */
 	public function created( WordPoints_Entity $entity );
+
+	/**
+	 * @return void
+	 */
 	public function updated( WordPoints_Entity $before, WordPoints_Entity $after );
+
+	/**
+	 * @return void
+	 */
 	public function deleted( WordPoints_Entity $entity );
 }
 
@@ -129,6 +141,9 @@ 
 		return true;
 	}
 
+	/**
+	 * @param string $type
+	 */
 	protected function fire_event( $type, WordPoints_Entity $entity ) {
 
 		$args = new WordPoints_Hook_Event_Args( array() );

Spacing +62 added lines, -62 removed lines

@@ -10,19 +10,19 @@ 
 // this is basicaly a router.
 class WordPoints_Entity_chang_trigger implements WordPoints_Entity_Change_ListenerI {
 
-	public function created( WordPoints_Entity $entity ) {
+	public function created(WordPoints_Entity $entity) {
 		// can multiple entities be created at once? not using insert() but via query()
 		// maybe? and how shoudl we handle that, all at once or one by one?
 
 		/** @var WordPoints_Entity_Change_ListenerI[] $listeners */
-		$listeners = wordpoints_apps()->sub_apps->get( 'entity_change_listeners' );
-		foreach ( $listeners as $listener ) {
-			$listener->created( $entity );
+		$listeners = wordpoints_apps()->sub_apps->get('entity_change_listeners');
+		foreach ($listeners as $listener) {
+			$listener->created($entity);
 		}
 	}
 
 
-	public function updated( WordPoints_Entity $before, WordPoints_Entity $after ) {
+	public function updated(WordPoints_Entity $before, WordPoints_Entity $after) {
 
 		// what if multiple entities are updated at once? do we run each one separatately?
 		// mayb ethat should be left up to the listenter.
@@ -30,7 +30,7 @@ 
 	}
 
 
-	public function deleted( WordPoints_Entity $entity ) {
+	public function deleted(WordPoints_Entity $entity) {
 
 		// what if we need information about this entitie's relationships, etc., that
 		// isn't included inthe entity object?
@@ -58,41 +58,41 @@ 
 
 // this is basically a reactor
 interface WordPoints_Entity_Change_ListenerI {
-	public function created( WordPoints_Entity $entity );
-	public function updated( WordPoints_Entity $before, WordPoints_Entity $after );
-	public function deleted( WordPoints_Entity $entity );
+	public function created(WordPoints_Entity $entity);
+	public function updated(WordPoints_Entity $before, WordPoints_Entity $after);
+	public function deleted(WordPoints_Entity $entity);
 }
 
 class WordPoints_Entity_Change_Listener_Hooks implements WordPoints_Entity_Change_ListenerI {
 
-	public function created( WordPoints_Entity $entity ) {
+	public function created(WordPoints_Entity $entity) {
 
 		// maybe we would have multuiple events with requirements for a single entity?
 		// like comment author and post commentn author targets for the same hook.
 		// but I guess taht is just one event.
 		// what about user register vs user create on MS?
-		if ( $this->matches_requirements( $entity ) ) {
-			$this->fire_event( 'add', $entity );
+		if ($this->matches_requirements($entity)) {
+			$this->fire_event('add', $entity);
 		}
 	}
 
-	public function updated( WordPoints_Entity $before, WordPoints_Entity $after ) {
+	public function updated(WordPoints_Entity $before, WordPoints_Entity $after) {
 
-		if ( $this->matches_requirements( $after ) ) {
-			if ( ! $this->matches_requirements( $before ) ) {
-				$this->fire_event( 'add', $after );
+		if ($this->matches_requirements($after)) {
+			if ( ! $this->matches_requirements($before)) {
+				$this->fire_event('add', $after);
 			}
 		} else {
-			if ( $this->matches_requirements( $before ) ) {
-				$this->fire_event( 'remove', $after );
+			if ($this->matches_requirements($before)) {
+				$this->fire_event('remove', $after);
 			}
 		}
 	}
 
-	public function deleted( WordPoints_Entity $entity ) {
+	public function deleted(WordPoints_Entity $entity) {
 
-		if ( $this->matches_requirements( $entity ) ) {
-			$this->fire_event( 'remove', $entity );
+		if ($this->matches_requirements($entity)) {
+			$this->fire_event('remove', $entity);
 		}
 	}
 
@@ -108,20 +108,20 @@ 
 	// called into play when the entity itself is deleted is moot, because the
 	// reltionships, etc., aren't even taken into account when toggle-off is called,
 	// in the points reactor. other reators might, i guess.
-	protected function matches_requirements( WordPoints_Entity $entity ) {
+	protected function matches_requirements(WordPoints_Entity $entity) {
 
 		/** @var WordPoints_Class_Registry $defaults */
-		$defaults = wordpoints_apps()->sub_apps->get( 'entity_possession_defaults' );
+		$defaults = wordpoints_apps()->sub_apps->get('entity_possession_defaults');
 
-		$defaults = $defaults->get( $entity->get_slug() );
+		$defaults = $defaults->get($entity->get_slug());
 
-		if ( ! $defaults ) {
+		if ( ! $defaults) {
 			return false;
 		}
 
 		// use conditions here?
-		foreach ( $defaults as $child => $value ) {
-			if ( $entity->get_child( $child ) !== $value ) {
+		foreach ($defaults as $child => $value) {
+			if ($entity->get_child($child) !== $value) {
 				return false;
 			}
 		}
@@ -129,13 +129,13 @@ 
 		return true;
 	}
 
-	protected function fire_event( $type, WordPoints_Entity $entity ) {
+	protected function fire_event($type, WordPoints_Entity $entity) {
 
-		$args = new WordPoints_Hook_Event_Args( array() );
-		$args->add_entity( $entity );
+		$args = new WordPoints_Hook_Event_Args(array());
+		$args->add_entity($entity);
 
 		wordpoints_hooks()->fire(
-			$type . '_entity_' . $entity->get_slug(),
+			$type.'_entity_'.$entity->get_slug(),
 			$args,
 			'toggle_on'
 		);
@@ -144,31 +144,31 @@ 
 
 class WordPoints_Entity_Change_Listener_Points implements WordPoints_Entity_Change_ListenerI {
 
-	public function created( WordPoints_Entity $entity ) {
+	public function created(WordPoints_Entity $entity) {
 
 		$this->process_entityish(
 			$entity
-			, $this->get_settings_for_entity( $entity )
+			, $this->get_settings_for_entity($entity)
 		);
 	}
 
-	protected function process_entityish( WordPoints_EntityishI $entity, $settings ) {
+	protected function process_entityish(WordPoints_EntityishI $entity, $settings) {
 
 		// possibly make this more like extension handling
-		if ( ! $this->meets_conditions( $entity, $settings['conditions'] ) ) {
+		if ( ! $this->meets_conditions($entity, $settings['conditions'])) {
 			return;
 		}
 
 		// possibly make this more like reactor handling.
-		$this->award_points( $settings );
+		$this->award_points($settings);
 
 		// only proces the attributes taht have changed.
 		// acutally, in this case, the entity was just created.
-		if ( $entity instanceof WordPoints_Entity_ParentI ) {
+		if ($entity instanceof WordPoints_Entity_ParentI) {
 
 			// this check runs on attributes only.
-			foreach ( $settings['children'] as $child_slug => $child_settings ) {
-				$this->process_entityish( $entity->get_child( $child_slug ), $child_settings );
+			foreach ($settings['children'] as $child_slug => $child_settings) {
+				$this->process_entityish($entity->get_child($child_slug), $child_settings);
 			}
 
 			// we also need to check for any children, like relationships, that have
@@ -176,7 +176,7 @@ 
 			// for this we need a list of relationships.
 			// if we do two-way relationships, we may need to have infinite-loop
 			// halding here, depending.
-			foreach ( $this->get_related_entities( $entity ) as $child_entity ) {
+			foreach ($this->get_related_entities($entity) as $child_entity) {
 				// If a comment was just created, for example, and we have conditions
 				// on the post entity, that affect the comment author, this allows
 				// us to handle those by pulling up the settings for the post entity
@@ -195,7 +195,7 @@ 
 				// as we've proposed...
 				$this->process_entityish(
 					$child_entity
-					, $this->get_entity_settings( $child_entity )
+					, $this->get_entity_settings($child_entity)
 				);
 			}
 		}
@@ -209,15 +209,15 @@ 
 	// doesn't really make sense.
 	// I think relationships can be created and deleted, but not really updated.
 	// so maybe what we need is a separate api?
-	public function updated( WordPoints_Entity $before, WordPoints_Entity $after ) {
+	public function updated(WordPoints_Entity $before, WordPoints_Entity $after) {
 
-		$settings = $this->get_settings_for_entity( $before );
+		$settings = $this->get_settings_for_entity($before);
 
 		/** @var WordPoints_Class_Registry_ChildrenI $children */
 		$children = wordpoints_entities()->children;
-		foreach ( $children->get_children_slugs( $before->get_slug() ) as $child_slug ) {
+		foreach ($children->get_children_slugs($before->get_slug()) as $child_slug) {
 			
-			if ( ! isset( $settings['children'][ $child_slug ] ) ) {
+			if ( ! isset($settings['children'][$child_slug])) {
 				continue;
 			}
 			
@@ -232,23 +232,23 @@ 
 			// but then we'll not be checking even the relationships taht are defined
 			// on the atts. so we have to decide whether those should be handled by
 			// a separate api or not.
-			if ( $before->get_the_attr_value( $child_slug ) === $after->get_the_attr_value( $child_slug ) ) {
+			if ($before->get_the_attr_value($child_slug) === $after->get_the_attr_value($child_slug)) {
 				continue;
 			}
 
 			$this->process_modified_entityish(
-				$before->get_child( $child_slug )
-				, $after->get_child( $child_slug )
-				, $settings['children'][ $child_slug ]
+				$before->get_child($child_slug)
+				, $after->get_child($child_slug)
+				, $settings['children'][$child_slug]
 			);
 		}
 	}
 
-	protected function process_modified_entityish( WordPoints_EntityishI $before, WordPoints_EntityishI $after, $settings ) {
+	protected function process_modified_entityish(WordPoints_EntityishI $before, WordPoints_EntityishI $after, $settings) {
 
-		if ( ! $this->meets_conditions( $before, $settings['conditions'] ) ) {
-			if ( $this->meets_conditions( $after, $settings['conditions'] ) ) {
-				$this->award_points( $settings );
+		if ( ! $this->meets_conditions($before, $settings['conditions'])) {
+			if ($this->meets_conditions($after, $settings['conditions'])) {
+				$this->award_points($settings);
 
 				// also need to process other eneities that are affected by this
 				// change, which may have conditions on this, i.e., that could be
@@ -265,38 +265,38 @@ 
 				// then we do indeed need to run through the children/parents.
 			}
 		} else {
-			if ( ! $this->meets_conditions( $after, $settings['conditions'] ) ) {
-				$this->remove_points( $settings );
+			if ( ! $this->meets_conditions($after, $settings['conditions'])) {
+				$this->remove_points($settings);
 			}
 		}
 	}
 
-	public function deleted( WordPoints_Entity $entity ) {
+	public function deleted(WordPoints_Entity $entity) {
 		// basically the opposite of created().
-		$this->process_entityish_reverse( $entity );
+		$this->process_entityish_reverse($entity);
 	}
 
-	protected function meets_conditions( WordPoints_EntityishI $entityish, $conditions ) {
+	protected function meets_conditions(WordPoints_EntityishI $entityish, $conditions) {
 		// use conditions api
 
 		return false;
 	}
 
-	private function award_points( $settings ) {
+	private function award_points($settings) {
 
-		$hierarchy = new WordPoints_Entity_Hierarchy( $this->eitnty );
+		$hierarchy = new WordPoints_Entity_Hierarchy($this->eitnty);
 		// todo we'll need to introudce entity array targets, possibly.
 		// how will we know how to reverse the target reltinoship chains in the UI
 		// before saving? i guess we'll need to either have a dedicated index fo taht
 		// or else juust look it up by looping through the relationships (though we'd
 		// have to remove the entity array {} part from any one-to-many relationships
 		// and maybe we'd have to add it to others?)
-		$targets = $hierarchy->get_from_hierarchy( $settings['target'] );
+		$targets = $hierarchy->get_from_hierarchy($settings['target']);
 
 		// maybe just one target, maybe several, depending.
 	}
 
-	private function get_related_entities( WordPoints_Entity $entity ) {
+	private function get_related_entities(WordPoints_Entity $entity) {
 
 		// what we need is parental conditions. Conditions that go up the chain,
 		// and look back at parent entities. This way we can handle the info about

src/includes/classes/wpdb/wrapper.php

Doc Comments +20 added lines

@@ -73,12 +73,28 @@ 
 
 
 interface WordPoints_WPDB_Query_Data {
+
+	/**
+	 * @return string
+	 */
 	public function get_table_name();
+
+	/**
+	 * @return void
+	 */
 	public function get_where_clause();
 }
 
 interface WordPoints_MySQL_Query_Parser_SimpleI {
+
+	/**
+	 * @return void
+	 */
 	public function get_table_name();
+
+	/**
+	 * @return string
+	 */
 	public function get_where_clause();
 }
 
@@ -164,6 +180,10 @@ 
 }
 
 interface WordPoints_WPDB_Query_WrapperI {
+
+	/**
+	 * @return void
+	 */
 	public function __construct( $slug, $args, $wpdb );
 	public function execute();
 

Spacing +51 added lines, -51 removed lines

@@ -11,60 +11,60 @@ 
 
 	protected $wpdb;
 
-	public function __construct( $wpdb ) {
+	public function __construct($wpdb) {
 		$this->wpdb = $wpdb;
 	}
 
-	public function __get( $name ) {
+	public function __get($name) {
 		return $this->wpdb->$name;
 	}
 
-	public function __set( $name, $value ) {
+	public function __set($name, $value) {
 		$this->wpdb->$name = $value;
 	}
 
-	public function __isset( $name ) {
-		return isset( $this->wpdb->$name );
+	public function __isset($name) {
+		return isset($this->wpdb->$name);
 	}
 
-	public function __unset( $name ) {
-		unset( $this->wpdb->$name );
+	public function __unset($name) {
+		unset($this->wpdb->$name);
 	}
 
-	public function __call( $name, $arguments ) {
+	public function __call($name, $arguments) {
 
-		$wrappers = wordpoints_apps()->sub_apps->get( 'wpdb_wrappers' );
-		$slugs = $wrappers->get_child_slugs( $name );
+		$wrappers = wordpoints_apps()->sub_apps->get('wpdb_wrappers');
+		$slugs = $wrappers->get_child_slugs($name);
 		$should_listen = $query = false;
 
 
-		switch ( $name ) {
+		switch ($name) {
 
 			case 'insert':
 //			case 'replace':
-				$query = new WordPoints_WPDB_Query_Data_Array( $this->args[0] );
+				$query = new WordPoints_WPDB_Query_Data_Array($this->args[0]);
 			break;
 
 			case 'update':
-				$query =  new WordPoints_WPDB_Query_Data_Array( $this->args[0], $this->args[2] );
+				$query = new WordPoints_WPDB_Query_Data_Array($this->args[0], $this->args[2]);
 			break;
 
 			case 'delete':
-				$query =  new WordPoints_WPDB_Query_Data_Array( $this->args[0], $this->args[1] );
+				$query = new WordPoints_WPDB_Query_Data_Array($this->args[0], $this->args[1]);
 			break;
 
 			case 'query':
-				$query =  new WordPoints_WPDB_Query_Data_SQL( $this->args[0] );
+				$query = new WordPoints_WPDB_Query_Data_SQL($this->args[0]);
 			break;
 		}
 
-		if ( $query ) {
+		if ($query) {
 			/** @var WordPoints_WPDB_Query_WrapperI $wrapper */
-			$wrapper = $wrappers->get( $name, $query );
+			$wrapper = $wrappers->get($name, $query);
 
 			$result = $wrapper->execute();
 		} else {
-			$result = call_user_func_array( array( $this->wpdb, $name ), $arguments );
+			$result = call_user_func_array(array($this->wpdb, $name), $arguments);
 		}
 
 		return $result;
@@ -84,7 +84,7 @@ 
 
 class WordPoints_MySQL_Query_Parser_Simple_Insert implements WordPoints_MySQL_Query_Parser_SimpleI {
 
-	public function __construct( $sql ) {
+	public function __construct($sql) {
 		$this->sql = $sql;
 	}
 
@@ -99,7 +99,7 @@ 
 		// columns will not be needed. then the other code can decide what to do.
 		// although I guess sense we have the tablel name we could reun the query
 		// ourselves if we need/want to.
-		if ( stripos( $this->sql, 'ON DUPLICATE KEY UPDATE' ) ) {
+		if (stripos($this->sql, 'ON DUPLICATE KEY UPDATE')) {
 
 		}
 
@@ -119,7 +119,7 @@ 
 	 */
 	protected $parser;
 
-	public function __construct( $sql ) {
+	public function __construct($sql) {
 		$this->sql = $sql;
 		$this->parser = $this->get_parser();
 	}
@@ -130,7 +130,7 @@ 
 		// of query it is.
 		// maybe the parser will actually be passed in, and the query type deterimed
 		// by teh method wrapper.
-		$parser = new WordPoints_MySQL_Query_Parser_Simple_Insert( $this->sql );
+		$parser = new WordPoints_MySQL_Query_Parser_Simple_Insert($this->sql);
 		// maybe we don't even need to parse.
 		return $parser;
 	}
@@ -149,7 +149,7 @@ 
 	protected $table_name;
 	protected $where_data;
 
-	public function __construct( $table_name, $where_data = array() ) {
+	public function __construct($table_name, $where_data = array()) {
 		$this->table_name = $table_name;
 		$this->where_data = $where_data;
 	}
@@ -164,7 +164,7 @@ 
 }
 
 interface WordPoints_WPDB_Query_WrapperI {
-	public function __construct( $slug, $args, $wpdb );
+	public function __construct($slug, $args, $wpdb);
 	public function execute();
 
 }
@@ -185,7 +185,7 @@ 
 	protected $result;
 	protected $backed_up_wpdb_vars;
 
-	public function __construct( $slug, $args, $wpdb ) {
+	public function __construct($slug, $args, $wpdb) {
 		$this->slug = $slug;
 		$this->args = $args;
 		$this->wpdb = $wpdb;
@@ -194,20 +194,20 @@ 
 
 	protected function get_query_data() {
 
-		switch ( $this->slug ) {
+		switch ($this->slug) {
 
 			case 'insert':
 				//			case 'replace':
-				return new WordPoints_WPDB_Query_Data_Array( $this->args[0] );
+				return new WordPoints_WPDB_Query_Data_Array($this->args[0]);
 
 			case 'update':
-				return new WordPoints_WPDB_Query_Data_Array( $this->args[0], $this->args[2] );
+				return new WordPoints_WPDB_Query_Data_Array($this->args[0], $this->args[2]);
 
 			case 'delete':
-				return new WordPoints_WPDB_Query_Data_Array( $this->args[0], $this->args[1] );
+				return new WordPoints_WPDB_Query_Data_Array($this->args[0], $this->args[1]);
 
 			case 'query':
-				return new WordPoints_WPDB_Query_Data_SQL( $this->args[0] );
+				return new WordPoints_WPDB_Query_Data_SQL($this->args[0]);
 		}
 
 		return false;
@@ -217,13 +217,13 @@ 
 
 		$should_listen = $this->should_listen();
 
-		if ( $should_listen ) {
+		if ($should_listen) {
 			$this->before_query();
 		}
 
-		$this->result = call_user_func_array( array( $this->wpdb, $this->slug ), $this->args );
+		$this->result = call_user_func_array(array($this->wpdb, $this->slug), $this->args);
 
-		if ( $should_listen && $this->was_successful_query() ) {
+		if ($should_listen && $this->was_successful_query()) {
 			$this->backup_wpdb_vars();
 			$this->after_query();
 			$this->restore_wpdb_vars();
@@ -252,8 +252,8 @@ 
 
 		// we could check for the availableility of eahc valu here in case of dropins
 		// or they become not available in the future.
-		foreach ( $to_backup as $property ) {
-			$this->backed_up_wpdb_vars[ $property ] = $this->wpdb->$property;
+		foreach ($to_backup as $property) {
+			$this->backed_up_wpdb_vars[$property] = $this->wpdb->$property;
 		}
 	}
 
@@ -263,7 +263,7 @@ 
 		// with the backed up result.
 		$this->wpdb->flush();
 
-		foreach ( $this->backed_up_wpdb_vars as $property => $value ) {
+		foreach ($this->backed_up_wpdb_vars as $property => $value) {
 			$this->wpdb->$property = $value;
 		}
 	}
@@ -301,18 +301,18 @@ 
 	 */
 	protected function is_entity_table() {
 
-		$this->entity = 'new entity object' . $this->data->get_table_name();
+		$this->entity = 'new entity object'.$this->data->get_table_name();
 
 		return true;
 	}
 
 	public function should_listen() {
 
-		if ( ! $this->data ) {
+		if ( ! $this->data) {
 			return false;
 		}
 
-		if ( $this->is_entity_table() ) {
+		if ($this->is_entity_table()) {
 			return false;
 		}
 
@@ -320,7 +320,7 @@ 
 	}
 
 	protected function was_successful_query() {
-		return (bool) wordpoints_posint( $not_by_ref = $this->wpdb->num_rows );
+		return (bool) wordpoints_posint($not_by_ref = $this->wpdb->num_rows);
 	}
 }
 
@@ -330,7 +330,7 @@ 
 	protected $args;
 	protected $wpdb;
 
-	public function __construct( $slug, $args, $wpdb ) {
+	public function __construct($slug, $args, $wpdb) {
 		$this->slug = $slug;
 		$this->args = $args;
 		$this->wpdb = $wpdb;
@@ -341,10 +341,10 @@ 
 		// check if this is a query that we want to listen to.
 		// if so, call execute on a particular child.
 		// otherwise, just call execute.
-		if ( $this->get_query_type() ) {
+		if ($this->get_query_type()) {
 
 		} else {
-			$result = call_user_func_array( array( $this->wpdb, $this->slug ), $this->args );
+			$result = call_user_func_array(array($this->wpdb, $this->slug), $this->args);
 		}
 
 		return $result;
@@ -369,15 +369,15 @@ 
 
 		$ids = $this->get_entity_ids();
 
-		$this->entities = new WordPoints_Entity_Array( $this->entity->get_slug() );
-		$this->entities->set_the_value( $ids );
+		$this->entities = new WordPoints_Entity_Array($this->entity->get_slug());
+		$this->entities->set_the_value($ids);
 	}
 
 	protected function get_entity_ids() {
 		$where = $this->data->get_where_clause();
-		$id_field = wordpoints_escape_mysql_identifier( $this->entity->get_id_field() );
-		$table_name = wordpoints_escape_mysql_identifier( $this->data->get_table_name() );
-		return $this->wpdb->get_col( "SELECT {$id_field} FROM {$table_name} {$where}" );
+		$id_field = wordpoints_escape_mysql_identifier($this->entity->get_id_field());
+		$table_name = wordpoints_escape_mysql_identifier($this->data->get_table_name());
+		return $this->wpdb->get_col("SELECT {$id_field} FROM {$table_name} {$where}");
 	}
 
 	protected function after_query() {
@@ -396,13 +396,13 @@ 
 		$where_clause = $this->data->get_where_clause();
 
 		// get a before snapshot, if any matching are found.
-		if ( $where_clause ) {
+		if ($where_clause) {
 
 		}
 	}
 
 	protected function after_query() {
-		$this->entity->set_the_value( $this->wpdb->insert_id );
+		$this->entity->set_the_value($this->wpdb->insert_id);
 		// I guess we invoke the api to run the action now?
 		$this->trigger_entity_create_actions();
 	}
@@ -413,7 +413,7 @@ 
 
 	protected function after_query() {
 		// I guess we invoke the api to run the action now?
-		$this->trigger_entity_delete_actions( $this->entities );
+		$this->trigger_entity_delete_actions($this->entities);
 	}
 }
 

src/includes/classes/hooks.php

Spacing +34 added lines, -34 removed lines

@@ -46,13 +46,13 @@ 
 	protected function init() {
 
 		$sub_apps = $this->sub_apps;
-		$sub_apps->register( 'router', 'WordPoints_Hook_Router' );
-		$sub_apps->register( 'actions', 'WordPoints_Hook_Actions' );
-		$sub_apps->register( 'events', 'WordPoints_Hook_Events' );
-		$sub_apps->register( 'reactors', 'WordPoints_Class_Registry_Persistent' );
-		$sub_apps->register( 'reaction_stores', 'WordPoints_Class_Registry_Children' );
-		$sub_apps->register( 'extensions', 'WordPoints_Class_Registry_Persistent' );
-		$sub_apps->register( 'conditions', 'WordPoints_Class_Registry_Children' );
+		$sub_apps->register('router', 'WordPoints_Hook_Router');
+		$sub_apps->register('actions', 'WordPoints_Hook_Actions');
+		$sub_apps->register('events', 'WordPoints_Hook_Events');
+		$sub_apps->register('reactors', 'WordPoints_Class_Registry_Persistent');
+		$sub_apps->register('reaction_stores', 'WordPoints_Class_Registry_Children');
+		$sub_apps->register('extensions', 'WordPoints_Class_Registry_Persistent');
+		$sub_apps->register('conditions', 'WordPoints_Class_Registry_Children');
 
 		parent::init();
 	}
@@ -75,8 +75,8 @@ 
 	 */
 	public function get_current_mode() {
 
-		if ( ! isset( $this->current_mode ) ) {
-			$this->current_mode = ( wordpoints_is_network_context() ? 'network' : 'standard' );
+		if ( ! isset($this->current_mode)) {
+			$this->current_mode = (wordpoints_is_network_context() ? 'network' : 'standard');
 		}
 
 		return $this->current_mode;
@@ -94,7 +94,7 @@ 
 	 *
 	 * @param string $mode The slug of the mode to set as the current mode.
 	 */
-	public function set_current_mode( $mode ) {
+	public function set_current_mode($mode) {
 		$this->current_mode = $mode;
 	}
 
@@ -107,19 +107,19 @@ 
 	 *
 	 * @return WordPoints_Hook_Reaction_StoreI|false The reaction storage object.
 	 */
-	public function get_reaction_store( $slug ) {
+	public function get_reaction_store($slug) {
 
 		$reaction_store = $this->reaction_stores->get(
 			$this->get_current_mode()
 			, $slug
 		);
 
-		if ( ! $reaction_store instanceof WordPoints_Hook_Reaction_StoreI ) {
+		if ( ! $reaction_store instanceof WordPoints_Hook_Reaction_StoreI) {
 			return false;
 		}
 
 		// Allowing access to stores out-of-context would lead to strange behavior.
-		if ( false === $reaction_store->get_context_id() ) {
+		if (false === $reaction_store->get_context_id()) {
 			return false;
 		}
 
@@ -142,19 +142,19 @@ 
 		$action_type
 	) {
 
-		foreach ( $this->reaction_stores->get_all() as $reaction_stores ) {
-			foreach ( $reaction_stores as $reaction_store ) {
+		foreach ($this->reaction_stores->get_all() as $reaction_stores) {
+			foreach ($reaction_stores as $reaction_store) {
 
-				if ( ! $reaction_store instanceof WordPoints_Hook_Reaction_StoreI ) {
+				if ( ! $reaction_store instanceof WordPoints_Hook_Reaction_StoreI) {
 					continue;
 				}
 
 				// Allowing access to stores out-of-context would lead to strange behavior.
-				if ( false === $reaction_store->get_context_id() ) {
+				if (false === $reaction_store->get_context_id()) {
 					continue;
 				}
 
-				foreach ( $reaction_store->get_reactions_to_event( $event_slug ) as $reaction ) {
+				foreach ($reaction_store->get_reactions_to_event($event_slug) as $reaction) {
 
 					$fire = new WordPoints_Hook_Fire(
 						$event_args
@@ -162,7 +162,7 @@ 
 						, $action_type
 					);
 
-					$this->fire_reaction( $fire );
+					$this->fire_reaction($fire);
 				}
 			}
 		}
@@ -175,32 +175,32 @@ 
 	 *
 	 * @param WordPoints_Hook_Fire $fire The hook fire object.
 	 */
-	protected function fire_reaction( $fire ) {
+	protected function fire_reaction($fire) {
 
 		/** @var WordPoints_Hook_Reactor $reactor */
-		$reactor = $this->reactors->get( $fire->reaction->get_reactor_slug() );
+		$reactor = $this->reactors->get($fire->reaction->get_reactor_slug());
 
-		if ( ! in_array( $fire->action_type, $reactor->get_action_types(), true ) ) {
+		if ( ! in_array($fire->action_type, $reactor->get_action_types(), true)) {
 			return;
 		}
 
-		$validator = new WordPoints_Hook_Reaction_Validator( $fire->reaction, true );
+		$validator = new WordPoints_Hook_Reaction_Validator($fire->reaction, true);
 		$validator->validate();
 
-		if ( $validator->had_errors() ) {
+		if ($validator->had_errors()) {
 			return;
 		}
 
-		unset( $validator );
+		unset($validator);
 
 		/** @var WordPoints_Hook_Extension[] $extensions */
 		$extensions = $this->extensions->get_all();
 
-		foreach ( $extensions as $extension ) {
-			if ( ! $extension->should_hit( $fire ) ) {
-				foreach ( $extensions as $ext ) {
-					if ( $ext instanceof WordPoints_Hook_Extension_Miss_ListenerI ) {
-						$ext->after_miss( $fire );
+		foreach ($extensions as $extension) {
+			if ( ! $extension->should_hit($fire)) {
+				foreach ($extensions as $ext) {
+					if ($ext instanceof WordPoints_Hook_Extension_Miss_ListenerI) {
+						$ext->after_miss($fire);
 					}
 				}
 
@@ -210,11 +210,11 @@ 
 
 		$fire->hit();
 
-		$reactor->hit( $fire );
+		$reactor->hit($fire);
 
-		foreach ( $extensions as $extension ) {
-			if ( $extension instanceof WordPoints_Hook_Extension_Hit_ListenerI ) {
-				$extension->after_hit( $fire );
+		foreach ($extensions as $extension) {
+			if ($extension instanceof WordPoints_Hook_Extension_Hit_ListenerI) {
+				$extension->after_hit($fire);
 			}
 		}
 	}

src/includes/classes/hook/extension.php

Spacing +18 added lines, -18 removed lines

@@ -65,14 +65,14 @@ 
 		WordPoints_Hook_Event_Args $event_args
 	) {
 
-		if ( ! isset( $settings[ $this->slug ] ) ) {
+		if ( ! isset($settings[$this->slug])) {
 			return $settings;
 		}
 
-		if ( ! is_array( $settings[ $this->slug ] ) ) {
+		if ( ! is_array($settings[$this->slug])) {
 
 			$validator->add_error(
-				__( 'Invalid settings format.', 'wordpoints' )
+				__('Invalid settings format.', 'wordpoints')
 				, $this->slug
 			);
 
@@ -82,13 +82,13 @@ 
 		$this->validator = $validator;
 		$this->event_args = $event_args;
 
-		$this->validator->push_field( $this->slug );
+		$this->validator->push_field($this->slug);
 
-		foreach ( $settings[ $this->slug ] as $action_type => $action_type_settings ) {
+		foreach ($settings[$this->slug] as $action_type => $action_type_settings) {
 
-			$this->validator->push_field( $action_type );
+			$this->validator->push_field($action_type);
 
-			$settings[ $this->slug ][ $action_type ] = $this->validate_action_type_settings(
+			$settings[$this->slug][$action_type] = $this->validate_action_type_settings(
 				$action_type_settings
 			);
 
@@ -103,12 +103,12 @@ 
 	/**
 	 * @since 1.0.0
 	 */
-	public function update_settings( WordPoints_Hook_ReactionI $reaction, array $settings ) {
+	public function update_settings(WordPoints_Hook_ReactionI $reaction, array $settings) {
 
-		if ( isset( $settings[ $this->slug ] ) ) {
-			$reaction->update_meta( $this->slug, $settings[ $this->slug ] );
+		if (isset($settings[$this->slug])) {
+			$reaction->update_meta($this->slug, $settings[$this->slug]);
 		} else {
-			$reaction->delete_meta( $this->slug );
+			$reaction->delete_meta($this->slug);
 		}
 	}
 
@@ -121,7 +121,7 @@ 
 	 *
 	 * @return mixed The validated settings.
 	 */
-	protected function validate_action_type_settings( $settings ) {
+	protected function validate_action_type_settings($settings) {
 		return $settings;
 	}
 
@@ -138,16 +138,16 @@ 
 	 *
 	 * @return mixed The settings for the extension, or false if none.
 	 */
-	protected function get_settings_from_fire( WordPoints_Hook_Fire $fire ) {
+	protected function get_settings_from_fire(WordPoints_Hook_Fire $fire) {
 
-		$settings = $fire->reaction->get_meta( $this->slug );
+		$settings = $fire->reaction->get_meta($this->slug);
 
-		if ( ! is_array( $settings ) ) {
+		if ( ! is_array($settings)) {
 			return $settings;
 		}
 
-		if ( isset( $settings[ $fire->action_type ] ) ) {
-			return $settings[ $fire->action_type ];
+		if (isset($settings[$fire->action_type])) {
+			return $settings[$fire->action_type];
 		} else {
 			return false;
 		}
@@ -162,7 +162,7 @@ 
 	 *
 	 * @return bool Whether the target should be hit by this hook firing.
 	 */
-	abstract public function should_hit( WordPoints_Hook_Fire $fire );
+	abstract public function should_hit(WordPoints_Hook_Fire $fire);
 
 	/**
 	 * Get the data the scripts need for the UI.

src/includes/classes/hook/extension/repeat/blocker.php

Spacing +5 added lines, -5 removed lines

@@ -22,22 +22,22 @@
 	/**
 	 * @since 1.0.0
 	 */
-	protected function validate_action_type_settings( $settings ) {
+	protected function validate_action_type_settings($settings) {
 		return (bool) $settings;
 	}
 
 	/**
 	 * @since 1.0.0
 	 */
-	public function should_hit( WordPoints_Hook_Fire $fire ) {
+	public function should_hit(WordPoints_Hook_Fire $fire) {
 
-		$block_repeats = (bool) $this->get_settings_from_fire( $fire );
+		$block_repeats = (bool) $this->get_settings_from_fire($fire);
 
-		if ( ! $block_repeats ) {
+		if ( ! $block_repeats) {
 			return true;
 		}
 
-		if ( $fire->get_matching_hits_query()->count() > 0 ) {
+		if ($fire->get_matching_hits_query()->count() > 0) {
 			return false;
 		}
 

src/includes/classes/hook/extension/miss/listenerI.php

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
 	 *
 	 * @param WordPoints_Hook_Fire $fire The fire that was a miss.
 	 */
-	public function after_miss( WordPoints_Hook_Fire $fire );
+	public function after_miss(WordPoints_Hook_Fire $fire);
 }
 
 // EOF

src/includes/classes/hook/extension/reversals.php

Spacing +17 added lines, -17 removed lines

@@ -32,36 +32,36 @@ 
 	/**
 	 * @since 1.0.0
 	 */
-	public function should_hit( WordPoints_Hook_Fire $fire ) {
+	public function should_hit(WordPoints_Hook_Fire $fire) {
 
-		if ( ! $this->get_settings_from_fire( $fire ) ) {
+		if ( ! $this->get_settings_from_fire($fire)) {
 			return true;
 		}
 
-		$ids = $this->get_hits_to_be_reversed( $fire );
+		$ids = $this->get_hits_to_be_reversed($fire);
 
-		return count( $ids ) > 0;
+		return count($ids) > 0;
 	}
 
 	/**
 	 * @since 1.0.0
 	 */
-	public function after_hit( WordPoints_Hook_Fire $fire ) {
+	public function after_hit(WordPoints_Hook_Fire $fire) {
 
-		if ( ! $this->get_settings_from_fire( $fire ) ) {
+		if ( ! $this->get_settings_from_fire($fire)) {
 			return;
 		}
 
-		foreach ( $this->get_hits_to_be_reversed( $fire ) as $id ) {
-			add_metadata( 'wordpoints_hook_hit', $id, 'reverse_fired', true );
+		foreach ($this->get_hits_to_be_reversed($fire) as $id) {
+			add_metadata('wordpoints_hook_hit', $id, 'reverse_fired', true);
 		}
 	}
 
 	/**
 	 * @since 1.0.0
 	 */
-	public function after_miss( WordPoints_Hook_Fire $fire ) {
-		$this->after_hit( $fire );
+	public function after_miss(WordPoints_Hook_Fire $fire) {
+		$this->after_hit($fire);
 	}
 
 	/**
@@ -73,12 +73,12 @@ 
 	 *
 	 * @return array The ids the hits to be reversed.
 	 */
-	protected function get_hits_to_be_reversed( WordPoints_Hook_Fire $fire ) {
+	protected function get_hits_to_be_reversed(WordPoints_Hook_Fire $fire) {
 
 		// We cache these so that we don't run the query both before and after the
 		// fire.
-		if ( isset( $fire->data[ $this->slug ]['hit_ids'] ) ) {
-			return $fire->data[ $this->slug ]['hit_ids'];
+		if (isset($fire->data[$this->slug]['hit_ids'])) {
+			return $fire->data[$this->slug]['hit_ids'];
 		}
 
 		$query = $fire->get_matching_hits_query();
@@ -86,19 +86,19 @@ 
 		$query->set_args(
 			array(
 				'fields'       => 'id',
-				'action_type'  => $this->get_settings_from_fire( $fire ),
+				'action_type'  => $this->get_settings_from_fire($fire),
 				'meta_key'     => 'reverse_fired',
 				'meta_compare' => 'NOT EXISTS',
 			)
 		);
 
-		$ids = $query->get( 'col' );
+		$ids = $query->get('col');
 
-		if ( ! $ids ) {
+		if ( ! $ids) {
 			$ids = array();
 		}
 
-		$fire->data[ $this->slug ]['hit_ids'] = $ids;
+		$fire->data[$this->slug]['hit_ids'] = $ids;
 
 		return $ids;
 	}

src/includes/classes/hook/extension/hit/listeneri.php

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
 	 *
 	 * @param WordPoints_Hook_Fire $fire The hook fire object.
 	 */
-	public function after_hit( WordPoints_Hook_Fire $fire );
+	public function after_hit(WordPoints_Hook_Fire $fire);
 }
 
 // EOF

src/includes/classes/hook/router.php

Spacing +47 added lines, -47 removed lines

@@ -80,13 +80,13 @@ 
 	/**
 	 * @since 1.0.0
 	 */
-	public function __call( $name, $args ) {
+	public function __call($name, $args) {
 
-		$this->route_action( $name, $args );
+		$this->route_action($name, $args);
 
 		// Return the first value, in case it is hooked to a filter.
 		$return = null;
-		if ( isset( $args[0] ) ) {
+		if (isset($args[0])) {
 			$return = $args[0];
 		}
 
@@ -103,9 +103,9 @@ 
 	 *                     action name and the priority.
 	 * @param array  $args The args the action was fired with.
 	 */
-	protected function route_action( $name, $args ) {
+	protected function route_action($name, $args) {
 
-		if ( ! isset( $this->action_index[ $name ] ) ) {
+		if ( ! isset($this->action_index[$name])) {
 			return;
 		}
 
@@ -113,7 +113,7 @@ 
 		// registry attempts to access the router in its own constructor. The result
 		// of attempting to do this before the router itself has been fully
 		// constructed is that the events registry gets null instead of the router.
-		if ( ! isset( $this->hooks ) ) {
+		if ( ! isset($this->hooks)) {
 
 			$hooks = wordpoints_hooks();
 
@@ -122,38 +122,38 @@ 
 			$this->actions = $hooks->actions;
 		}
 
-		foreach ( $this->action_index[ $name ]['actions'] as $slug => $data ) {
+		foreach ($this->action_index[$name]['actions'] as $slug => $data) {
 
-			if ( ! isset( $this->event_index[ $slug ] ) ) {
+			if ( ! isset($this->event_index[$slug])) {
 				continue;
 			}
 
-			$action_object = $this->actions->get( $slug, $args, $data );
+			$action_object = $this->actions->get($slug, $args, $data);
 
-			if ( ! ( $action_object instanceof WordPoints_Hook_ActionI ) ) {
+			if ( ! ($action_object instanceof WordPoints_Hook_ActionI)) {
 				continue;
 			}
 
-			if ( ! $action_object->should_fire() ) {
+			if ( ! $action_object->should_fire()) {
 				continue;
 			}
 
-			foreach ( $this->event_index[ $slug ] as $type => $events ) {
-				foreach ( $events as $event_slug => $unused ) {
+			foreach ($this->event_index[$slug] as $type => $events) {
+				foreach ($events as $event_slug => $unused) {
 
-					if ( ! $this->events->is_registered( $event_slug ) ) {
+					if ( ! $this->events->is_registered($event_slug)) {
 						continue;
 					}
 
-					$event_args = $this->events->args->get_children( $event_slug, array( $action_object ) );
+					$event_args = $this->events->args->get_children($event_slug, array($action_object));
 
-					if ( empty( $event_args ) ) {
+					if (empty($event_args)) {
 						continue;
 					}
 
-					$event_args = new WordPoints_Hook_Event_Args( $event_args );
+					$event_args = new WordPoints_Hook_Event_Args($event_args);
 
-					$this->hooks->fire( $event_slug, $event_args, $type );
+					$this->hooks->fire($event_slug, $event_args, $type);
 				}
 			}
 		}
@@ -182,56 +182,56 @@ 
 	 *        }
 	 * }
 	 */
-	public function add_action( $slug, array $args ) {
+	public function add_action($slug, array $args) {
 
 		$priority = 10;
-		if ( isset( $args['priority'] ) ) {
+		if (isset($args['priority'])) {
 			$priority = $args['priority'];
 		}
 
-		if ( ! isset( $args['action'] ) ) {
+		if ( ! isset($args['action'])) {
 			return;
 		}
 
 		$method = "{$args['action']},{$priority}";
 
-		$this->action_index[ $method ]['actions'][ $slug ] = array();
+		$this->action_index[$method]['actions'][$slug] = array();
 
 		$arg_number = 1;
 
-		if ( isset( $args['data'] ) ) {
+		if (isset($args['data'])) {
 
-			if ( isset( $args['data']['arg_index'] ) ) {
-				$arg_number = 1 + max( $args['data']['arg_index'] );
+			if (isset($args['data']['arg_index'])) {
+				$arg_number = 1 + max($args['data']['arg_index']);
 			}
 
-			if ( isset( $args['data']['requirements'] ) ) {
-				$requirements = 1 + max( array_keys( $args['data']['requirements'] ) );
+			if (isset($args['data']['requirements'])) {
+				$requirements = 1 + max(array_keys($args['data']['requirements']));
 
-				if ( $requirements > $arg_number ) {
+				if ($requirements > $arg_number) {
 					$arg_number = $requirements;
 				}
 			}
 
-			$this->action_index[ $method ]['actions'][ $slug ] = $args['data'];
+			$this->action_index[$method]['actions'][$slug] = $args['data'];
 		}
 
-		if ( isset( $args['arg_number'] ) ) {
+		if (isset($args['arg_number'])) {
 			$arg_number = $args['arg_number'];
 		}
 
 		// If this action is already being routed, and will have enough args, we
 		// don't need to hook to it again.
 		if (
-			isset( $this->action_index[ $method ]['arg_number'] )
-			&& $this->action_index[ $method ]['arg_number'] >= $arg_number
+			isset($this->action_index[$method]['arg_number'])
+			&& $this->action_index[$method]['arg_number'] >= $arg_number
 		) {
 			return;
 		}
 
-		$this->action_index[ $method ]['arg_number'] = $arg_number;
+		$this->action_index[$method]['arg_number'] = $arg_number;
 
-		add_action( $args['action'], array( $this, $method ), $priority, $arg_number );
+		add_action($args['action'], array($this, $method), $priority, $arg_number);
 	}
 
 	/**
@@ -241,20 +241,20 @@ 
 	 *
 	 * @param string $slug The action slug.
 	 */
-	public function remove_action( $slug ) {
+	public function remove_action($slug) {
 
-		foreach ( $this->action_index as $method => $data ) {
-			if ( isset( $data['actions'][ $slug ] ) ) {
+		foreach ($this->action_index as $method => $data) {
+			if (isset($data['actions'][$slug])) {
 
-				unset( $this->action_index[ $method ]['actions'][ $slug ] );
+				unset($this->action_index[$method]['actions'][$slug]);
 
-				if ( empty( $this->action_index[ $method ]['actions'] ) ) {
+				if (empty($this->action_index[$method]['actions'])) {
 
-					unset( $this->action_index[ $method ] );
+					unset($this->action_index[$method]);
 
-					list( $action, $priority ) = explode( ',', $method );
+					list($action, $priority) = explode(',', $method);
 
-					remove_action( $action, array( $this, $method ), $priority );
+					remove_action($action, array($this, $method), $priority);
 				}
 			}
 		}
@@ -269,8 +269,8 @@ 
 	 * @param string $action_slug The slug of the action.
 	 * @param string $action_type The type of action. Default is 'fire'.
 	 */
-	public function add_event_to_action( $event_slug, $action_slug, $action_type = 'fire' ) {
-		$this->event_index[ $action_slug ][ $action_type ][ $event_slug ] = true;
+	public function add_event_to_action($event_slug, $action_slug, $action_type = 'fire') {
+		$this->event_index[$action_slug][$action_type][$event_slug] = true;
 	}
 
 	/**
@@ -282,8 +282,8 @@ 
 	 * @param string $action_slug The slug of the action.
 	 * @param string $action_type The type of action. Default is 'fire'.
 	 */
-	public function remove_event_from_action( $event_slug, $action_slug, $action_type = 'fire' ) {
-		unset( $this->event_index[ $action_slug ][ $action_type ][ $event_slug ] );
+	public function remove_event_from_action($event_slug, $action_slug, $action_type = 'fire') {
+		unset($this->event_index[$action_slug][$action_type][$event_slug]);
 	}
 
 	/**
@@ -295,7 +295,7 @@ 
 	 */
 	public function get_event_index() {
 
-		if ( empty( $this->event_index ) ) {
+		if (empty($this->event_index)) {
 			wordpoints_hooks()->events;
 		}