Inspection of "Updated to 2.1.1 and gulp/grunt to gen to POT" - WordImpress/Google-Maps-Builder - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f19051...b73449 )

by Devin

created 2016-09-30 04:30 UTC

Status

Spacing +25 added lines, -25 removed lines patch added patch discarded remove patch

@@ -15,7 +15,7 @@  discard block
 block discarded – undo
  */
 
 // If this file is called directly, abort.
-if ( ! defined( 'ABSPATH' ) ) {
+if ( ! defined('ABSPATH')) {
 	exit;
 }
 
@@ -23,34 +23,34 @@  discard block
 block discarded – undo
  * Define Constants
  */
 // Plugin Folder Path
-if ( ! defined( 'GMB_PLUGIN_PATH' ) ) {
-	define( 'GMB_PLUGIN_PATH', plugin_dir_path( __FILE__ ) );
+if ( ! defined('GMB_PLUGIN_PATH')) {
+	define('GMB_PLUGIN_PATH', plugin_dir_path(__FILE__));
 }
 // Plugin Folder URL
-if ( ! defined( 'GMB_PLUGIN_URL' ) ) {
-	define( 'GMB_PLUGIN_URL', plugin_dir_url( __FILE__ ) );
+if ( ! defined('GMB_PLUGIN_URL')) {
+	define('GMB_PLUGIN_URL', plugin_dir_url(__FILE__));
 }
 // Plugin base
-if ( ! defined( 'GMB_PLUGIN_BASE' ) ) {
-	define( 'GMB_PLUGIN_BASE', plugin_basename( __FILE__ ) );
+if ( ! defined('GMB_PLUGIN_BASE')) {
+	define('GMB_PLUGIN_BASE', plugin_basename(__FILE__));
 }
 // Plugin version
-if ( ! defined( 'GMB_VERSION' ) ) {
-	define( 'GMB_VERSION', '2.1.1' );
+if ( ! defined('GMB_VERSION')) {
+	define('GMB_VERSION', '2.1.1');
 }
 // Plugin Root File
-if ( ! defined( 'GMB_PLUGIN_FILE' ) ) {
-	define( 'GMB_PLUGIN_FILE', __FILE__ );
+if ( ! defined('GMB_PLUGIN_FILE')) {
+	define('GMB_PLUGIN_FILE', __FILE__);
 }
 
 
-if ( ! class_exists( 'Google_Maps_Builder' ) ) :
+if ( ! class_exists('Google_Maps_Builder')) :
 
 	/**
 	 * Load plugin if core lib is present
 	 */
-	if ( ! file_exists( GMB_PLUGIN_PATH . 'vendor/wordimpress/maps-builder-core/core.php' ) ) {
-		add_action( 'admin_notices', 'gmb_no_core_lib' );
+	if ( ! file_exists(GMB_PLUGIN_PATH.'vendor/wordimpress/maps-builder-core/core.php')) {
+		add_action('admin_notices', 'gmb_no_core_lib');
 
 		/**
 		 * Print admin notice if no dependencies
@@ -58,10 +58,10 @@  discard block
 block discarded – undo
 		 * @uses "admin_notice" hook
 		 */
 		function gmb_no_core_lib() {
-			printf( '<div class="notice notice-error"><p>%s</p></div>', esc_html__( 'Your install of Maps Builder is missing its Composer dependencies and can not load.', 'maps-builder-pro' ) );
+			printf('<div class="notice notice-error"><p>%s</p></div>', esc_html__('Your install of Maps Builder is missing its Composer dependencies and can not load.', 'maps-builder-pro'));
 		}
 	} else {
-		require_once GMB_PLUGIN_PATH . 'vendor/wordimpress/maps-builder-core/core.php';
+		require_once GMB_PLUGIN_PATH.'vendor/wordimpress/maps-builder-core/core.php';
 
 		/**
 		 * Main Maps Builder Class
@@ -109,11 +109,11 @@  discard block
 block discarded – undo
 			 * @return    Google_Maps_Builder
 			 */
 			public static function instance() {
-				if ( ! isset( self::$instance ) && ! ( self::$instance instanceof Google_Maps_Builder ) ) {
+				if ( ! isset(self::$instance) && ! (self::$instance instanceof Google_Maps_Builder)) {
 
 					self::$instance = new Google_Maps_Builder();
 
-					add_action( 'plugins_loaded', array( self::$instance, 'load_textdomain' ) );
+					add_action('plugins_loaded', array(self::$instance, 'load_textdomain'));
 
 					self::$instance->includes();
 					self::$instance->activate = new Google_Maps_Builder_Activate();
@@ -121,17 +121,17 @@  discard block
 block discarded – undo
 					self::$instance->settings = new Google_Maps_Builder_Settings();
 					self::$instance->engine   = new Google_Maps_Builder_Engine();
 
-					register_activation_hook( __FILE__, array(
+					register_activation_hook(__FILE__, array(
 						self::$instance->activate,
 						'activation_flush_rewrites'
-					) );
+					));
 
 					// Read plugin meta
 					// Check that function get_plugin_data exists
-					if ( ! function_exists( 'get_plugin_data' ) ) {
-						require_once( ABSPATH . 'wp-admin/includes/plugin.php' );
+					if ( ! function_exists('get_plugin_data')) {
+						require_once(ABSPATH.'wp-admin/includes/plugin.php');
 					}
-					self::$instance->meta = get_plugin_data( GMB_PLUGIN_FILE, false );
+					self::$instance->meta = get_plugin_data(GMB_PLUGIN_FILE, false);
 
 				}
 
@@ -152,9 +152,9 @@  discard block
 block discarded – undo
 
 				$this->cmb2_load();
 				$this->load_files();
-				require_once GMB_PLUGIN_PATH . 'includes/class-gmb-scripts.php';
+				require_once GMB_PLUGIN_PATH.'includes/class-gmb-scripts.php';
 
-				if ( is_admin() || ( defined( 'WP_CLI' ) && WP_CLI ) ) {
+				if (is_admin() || (defined('WP_CLI') && WP_CLI)) {
 
 					$this->load_admin();
 					//Admin

Please login to merge, or discard this patch.

		@@ -15,7 +15,7 @@ discard block
		block discarded – undo
15	15	*/
16	16
17	17	// If this file is called directly, abort.
18		-if ( ! defined( 'ABSPATH' ) ) {
	18	+if ( ! defined('ABSPATH')) {
19	19	exit;
20	20	}
21	21
		@@ -23,34 +23,34 @@ discard block
		block discarded – undo
23	23	* Define Constants
24	24	*/
25	25	// Plugin Folder Path
26		-if ( ! defined( 'GMB_PLUGIN_PATH' ) ) {
27		- define( 'GMB_PLUGIN_PATH', plugin_dir_path( __FILE__ ) );
	26	+if ( ! defined('GMB_PLUGIN_PATH')) {
	27	+ define('GMB_PLUGIN_PATH', plugin_dir_path(__FILE__));
28	28	}
29	29	// Plugin Folder URL
30		-if ( ! defined( 'GMB_PLUGIN_URL' ) ) {
31		- define( 'GMB_PLUGIN_URL', plugin_dir_url( __FILE__ ) );
	30	+if ( ! defined('GMB_PLUGIN_URL')) {
	31	+ define('GMB_PLUGIN_URL', plugin_dir_url(__FILE__));
32	32	}
33	33	// Plugin base
34		-if ( ! defined( 'GMB_PLUGIN_BASE' ) ) {
35		- define( 'GMB_PLUGIN_BASE', plugin_basename( __FILE__ ) );
	34	+if ( ! defined('GMB_PLUGIN_BASE')) {
	35	+ define('GMB_PLUGIN_BASE', plugin_basename(__FILE__));
36	36	}
37	37	// Plugin version
38		-if ( ! defined( 'GMB_VERSION' ) ) {
39		- define( 'GMB_VERSION', '2.1.1' );
	38	+if ( ! defined('GMB_VERSION')) {
	39	+ define('GMB_VERSION', '2.1.1');
40	40	}
41	41	// Plugin Root File
42		-if ( ! defined( 'GMB_PLUGIN_FILE' ) ) {
43		- define( 'GMB_PLUGIN_FILE', __FILE__ );
	42	+if ( ! defined('GMB_PLUGIN_FILE')) {
	43	+ define('GMB_PLUGIN_FILE', __FILE__);
44	44	}
45	45
46	46
47		-if ( ! class_exists( 'Google_Maps_Builder' ) ) :
	47	+if ( ! class_exists('Google_Maps_Builder')) :
48	48
49	49	/**
50	50	* Load plugin if core lib is present
51	51	*/
52		- if ( ! file_exists( GMB_PLUGIN_PATH . 'vendor/wordimpress/maps-builder-core/core.php' ) ) {
53		- add_action( 'admin_notices', 'gmb_no_core_lib' );
	52	+ if ( ! file_exists(GMB_PLUGIN_PATH.'vendor/wordimpress/maps-builder-core/core.php')) {
	53	+ add_action('admin_notices', 'gmb_no_core_lib');
54	54
55	55	/**
56	56	* Print admin notice if no dependencies
		@@ -58,10 +58,10 @@ discard block
		block discarded – undo
58	58	* @uses "admin_notice" hook
59	59	*/
60	60	function gmb_no_core_lib() {
61		- printf( '<div class="notice notice-error"><p>%s</p></div>', esc_html__( 'Your install of Maps Builder is missing its Composer dependencies and can not load.', 'maps-builder-pro' ) );
	61	+ printf('<div class="notice notice-error"><p>%s</p></div>', esc_html__('Your install of Maps Builder is missing its Composer dependencies and can not load.', 'maps-builder-pro'));
62	62	}
63	63	} else {
64		- require_once GMB_PLUGIN_PATH . 'vendor/wordimpress/maps-builder-core/core.php';
	64	+ require_once GMB_PLUGIN_PATH.'vendor/wordimpress/maps-builder-core/core.php';
65	65
66	66	/**
67	67	* Main Maps Builder Class
		@@ -109,11 +109,11 @@ discard block
		block discarded – undo
109	109	* @return Google_Maps_Builder
110	110	*/
111	111	public static function instance() {
112		- if ( ! isset( self::$instance ) && ! ( self::$instance instanceof Google_Maps_Builder ) ) {
	112	+ if ( ! isset(self::$instance) && ! (self::$instance instanceof Google_Maps_Builder)) {
113	113
114	114	self::$instance = new Google_Maps_Builder();
115	115
116		- add_action( 'plugins_loaded', array( self::$instance, 'load_textdomain' ) );
	116	+ add_action('plugins_loaded', array(self::$instance, 'load_textdomain'));
117	117
118	118	self::$instance->includes();
119	119	self::$instance->activate = new Google_Maps_Builder_Activate();
		@@ -121,17 +121,17 @@ discard block
		block discarded – undo
121	121	self::$instance->settings = new Google_Maps_Builder_Settings();
122	122	self::$instance->engine = new Google_Maps_Builder_Engine();
123	123
124		- register_activation_hook( __FILE__, array(
	124	+ register_activation_hook(__FILE__, array(
125	125	self::$instance->activate,
126	126	'activation_flush_rewrites'
127		- ) );
	127	+ ));
128	128
129	129	// Read plugin meta
130	130	// Check that function get_plugin_data exists
131		- if ( ! function_exists( 'get_plugin_data' ) ) {
132		- require_once( ABSPATH . 'wp-admin/includes/plugin.php' );
	131	+ if ( ! function_exists('get_plugin_data')) {
	132	+ require_once(ABSPATH.'wp-admin/includes/plugin.php');
133	133	}
134		- self::$instance->meta = get_plugin_data( GMB_PLUGIN_FILE, false );
	134	+ self::$instance->meta = get_plugin_data(GMB_PLUGIN_FILE, false);
135	135
136	136	}
137	137
		@@ -152,9 +152,9 @@ discard block
		block discarded – undo
152	152
153	153	$this->cmb2_load();
154	154	$this->load_files();
155		- require_once GMB_PLUGIN_PATH . 'includes/class-gmb-scripts.php';
	155	+ require_once GMB_PLUGIN_PATH.'includes/class-gmb-scripts.php';
156	156
157		- if ( is_admin() \|\| ( defined( 'WP_CLI' ) && WP_CLI ) ) {
	157	+ if (is_admin() \|\| (defined('WP_CLI') && WP_CLI)) {
158	158
159	159	$this->load_admin();
160	160	//Admin

WordImpress / Google-Maps-Builder

Push — master ( f19051...b73449 )

Status

Category

Spacing +25 added lines, -25 removed lines patch added patch discarded remove patch