ModuleUserController::createFormDelete() - Code Metrics - Inspection of "Merge pull request #41 from Wolframcheg/develop" - Wolframcheg/symfotest - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b2b032...858bee )

by Pavel

created 2016-03-28 21:10 UTC

ModuleUserController::createFormDelete() A

↳ Parent: ModuleUserController

Complexity

Conditions	1
Paths	1

Size

Total Lines	14
Code Lines	10

Duplication

Lines	14
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	14
loc	14
ccs	0
cts	10
cp	0
rs	9.4285
cc	1
eloc	10
nc	1
nop	2
crap	2

<?php

namespace AppBundle\Controller\Admin;

use AppBundle\Entity\ModuleUser;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Symfony\Component\Form\Extension\Core\Type\SubmitType;
use Symfony\Component\HttpFoundation\Request;
use AppBundle\Form\ModuleUserType;

/**
 * Class ModuleUserController
 * @package AppBundle\Controller\Admin
 */
class ModuleUserController extends Controller
{
    /**
     * @Route("/admin/moduleUser/new/{idUser}", name="create_moduleUser")
     * @Template("@App/admin/moduleuser/createModuleUser.html.twig")
     */
    public function createModuleUserAction(Request $request, $idUser)
    {
        $em = $this->getDoctrine()->getManager();
        $user = $em->getRepository('AppBundle:User')
            ->find($idUser);
        $modulesUser = $em->getRepository('AppBundle:ModuleUser')
            ->findBy(['user' => $user]);

        $moduleUser = new ModuleUser();
        $form = $this->createForm(ModuleUserType::class, $moduleUser, ['user' => $user]);

        $form->handleRequest($request);

        if ($form->isValid()) {
            $user->setIsActive(true);
            $moduleUser->setUser($user);
            $user->removeChosenModule($moduleUser->getModule()->getId());
            $em->persist($moduleUser);
            $em->flush();

            return $this->redirectToRoute('user_show');
        }

        $form_delete = [];

        foreach ($modulesUser as $item) {
            $form_delete[$item->getModule()->getId()] = $this->createFormDelete($idUser, $item->getModule()->getId())->createView();
        }

        return [
                'modulesUser' => $modulesUser,
                'form_remove' => $form_delete,
                'form' => $form->createView()
        ];
    }

    /**
     * @Route("/admin/moduleUser/remove/{idUser}/{idModule}", name="remove_moduleUser")
     * @Method("DELETE")
     */
    public function removeModuleAction($idUser, $idModule)
    {
        $em = $this->getDoctrine()->getManager();
        $user = $em->getRepository('AppBundle:User')
            ->find($idUser);
        $module = $em->getRepository('AppBundle:Module')
            ->find($idModule);
        $moduleUser = $em->getRepository('AppBundle:ModuleUser')
            ->findOneBy(['user' => $user, 'module' => $module]);

        $em->remove($moduleUser);
        $em->flush();

        return $this->redirectToRoute('create_moduleUser', ['idUser' => $idUser]);
    }

    /**
     * @return \Symfony\Component\Form\Form
     */
    private function createFormDelete($idUser, $idModule)

    {
        return $this->createFormBuilder()
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ->setAction($this->generateUrl('remove_moduleUser', ['idUser' => $idUser, 'idModule' => $idModule]))
            ->setMethod('DELETE')
            ->add('submit', SubmitType::class, [
                'label' => ' ',
                'attr' => [
                    'class' => 'glyphicon glyphicon-remove btn-link',
                    'onclick' => 'return confirm("Are you sure?")'
                ]
            ])
            ->getForm();
    }
}


1			<?php
2
3			namespace AppBundle\Controller\Admin;
4
5			use AppBundle\Entity\ModuleUser;
6			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
7			use Symfony\Bundle\FrameworkBundle\Controller\Controller;
8			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
9			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
10			use Symfony\Component\Form\Extension\Core\Type\SubmitType;
11			use Symfony\Component\HttpFoundation\Request;
12			use AppBundle\Form\ModuleUserType;
13
14			/**
15			* Class ModuleUserController
16			* @package AppBundle\Controller\Admin
17			*/
18			class ModuleUserController extends Controller
19			{
20			/**
21			* @Route("/admin/moduleUser/new/{idUser}", name="create_moduleUser")
22			* @Template("@App/admin/moduleuser/createModuleUser.html.twig")
23			*/
24	1		public function createModuleUserAction(Request $request, $idUser)
25			{
26	1		$em = $this->getDoctrine()->getManager();
27	1		$user = $em->getRepository('AppBundle:User')
28	1		->find($idUser);
29	1		$modulesUser = $em->getRepository('AppBundle:ModuleUser')
30	1		->findBy(['user' => $user]);
31
32	1		$moduleUser = new ModuleUser();
33	1		$form = $this->createForm(ModuleUserType::class, $moduleUser, ['user' => $user]);
34
35	1		$form->handleRequest($request);
36
37	1		if ($form->isValid()) {
38			$user->setIsActive(true);
39			$moduleUser->setUser($user);
40			$user->removeChosenModule($moduleUser->getModule()->getId());
41			$em->persist($moduleUser);
42			$em->flush();
43
44			return $this->redirectToRoute('user_show');
45			}
46
47	1		$form_delete = [];
48
49	1		foreach ($modulesUser as $item) {
50			$form_delete[$item->getModule()->getId()] = $this->createFormDelete($idUser, $item->getModule()->getId())->createView();
51	1		}
52
53			return [
54	1		'modulesUser' => $modulesUser,
55	1		'form_remove' => $form_delete,
56	1		'form' => $form->createView()
57	1		];
58			}
59
60			/**
61			* @Route("/admin/moduleUser/remove/{idUser}/{idModule}", name="remove_moduleUser")
62			* @Method("DELETE")
63			*/
64	1		public function removeModuleAction($idUser, $idModule)
65			{
66	1		$em = $this->getDoctrine()->getManager();
67	1		$user = $em->getRepository('AppBundle:User')
68	1		->find($idUser);
69	1		$module = $em->getRepository('AppBundle:Module')
70	1		->find($idModule);
71	1		$moduleUser = $em->getRepository('AppBundle:ModuleUser')
72	1		->findOneBy(['user' => $user, 'module' => $module]);
73
74	1		$em->remove($moduleUser);
75	1		$em->flush();
76
77	1		return $this->redirectToRoute('create_moduleUser', ['idUser' => $idUser]);
78			}
79
80			/**
81			* @return \Symfony\Component\Form\Form
82			*/
83		View Code Duplication	private function createFormDelete($idUser, $idModule)
			0 ignored issues – show Duplication introduced 2016-03-18 21:25 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
84			{
85			return $this->createFormBuilder()
			0 ignored issues – show Bug introduced 2016-03-18 21:25 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Symfony\Component\Form\FormConfigBuilder` as the method `add()` does only exist in the following sub-classes of `Symfony\Component\Form\FormConfigBuilder`: `Symfony\Component\Form\FormBuilder`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
86			->setAction($this->generateUrl('remove_moduleUser', ['idUser' => $idUser, 'idModule' => $idModule]))
87			->setMethod('DELETE')
88			->add('submit', SubmitType::class, [
89			'label' => ' ',
90			'attr' => [
91			'class' => 'glyphicon glyphicon-remove btn-link',
92			'onclick' => 'return confirm("Are you sure?")'
93			]
94			])
95			->getForm();
96			}
97			}
98

Wolframcheg / symfotest

Push — master ( b2b032...858bee )

ModuleUserController::createFormDelete() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like