AppBundle\Controller\Admin\ModuleUserController

Complexity

Total Complexity

5

Size/Duplication

Total Lines	80
Duplicated Lines	17.5 %

Coupling/Cohesion

Components	1
Dependencies	8

Test Coverage

Coverage

62.22%

Importance

Changes	7
Bugs	0	Features	4

3 Methods

Rating	Name	Duplication	Size	Complexity
B	createModuleUserAction()	0	35	3
A	removeModuleAction()	0	15	1
A	createFormDelete()	14	14	1

<?php

namespace AppBundle\Controller\Admin;

use AppBundle\Entity\ModuleUser;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Symfony\Component\Form\Extension\Core\Type\SubmitType;
use Symfony\Component\HttpFoundation\Request;
use AppBundle\Form\ModuleUserType;

/**
 * Class ModuleUserController
 * @package AppBundle\Controller\Admin
 */
class ModuleUserController extends Controller
{
    /**
     * @Route("/admin/moduleUser/new/{idUser}", name="create_moduleUser")
     * @Template("@App/admin/moduleuser/createModuleUser.html.twig")
     */
    public function createModuleUserAction(Request $request, $idUser)
    {
        $em = $this->getDoctrine()->getManager();
        $user = $em->getRepository('AppBundle:User')
            ->find($idUser);
        $modulesUser = $em->getRepository('AppBundle:ModuleUser')
            ->findBy(['user' => $user]);

        $moduleUser = new ModuleUser();
        $form = $this->createForm(ModuleUserType::class, $moduleUser, ['user' => $user]);

        $form->handleRequest($request);

        if ($form->isValid()) {
            $user->setIsActive(true);
            $moduleUser->setUser($user);
            $user->removeChosenModule($moduleUser->getModule()->getId());
            $em->persist($moduleUser);
            $em->flush();

            return $this->redirectToRoute('user_show');
        }

        $form_delete = [];

        foreach ($modulesUser as $item) {
            $form_delete[$item->getModule()->getId()] = $this->createFormDelete($idUser, $item->getModule()->getId())->createView();
        }

        return [
                'modulesUser' => $modulesUser,
                'form_remove' => $form_delete,
                'form' => $form->createView()
        ];
    }

    /**
     * @Route("/admin/moduleUser/remove/{idUser}/{idModule}", name="remove_moduleUser")
     * @Method("DELETE")
     */
    public function removeModuleAction($idUser, $idModule)
    {
        $em = $this->getDoctrine()->getManager();
        $user = $em->getRepository('AppBundle:User')
            ->find($idUser);
        $module = $em->getRepository('AppBundle:Module')
            ->find($idModule);
        $moduleUser = $em->getRepository('AppBundle:ModuleUser')
            ->findOneBy(['user' => $user, 'module' => $module]);

        $em->remove($moduleUser);
        $em->flush();

        return $this->redirectToRoute('create_moduleUser', ['idUser' => $idUser]);
    }

    /**
     * @return \Symfony\Component\Form\Form
     */
    private function createFormDelete($idUser, $idModule)

This method seems to be duplicated in your project.

    {
        return $this->createFormBuilder()

It seems like you code against a specific sub-type and not the parent class Symfony\Component\Form\FormConfigBuilder as the method add() does only exist in the following sub-classes of Symfony\Component\Form\FormConfigBuilder: Symfony\Component\Form\FormBuilder. Maybe you want to instanceof check for one of these explicitly?

            ->setAction($this->generateUrl('remove_moduleUser', ['idUser' => $idUser, 'idModule' => $idModule]))
            ->setMethod('DELETE')
            ->add('submit', SubmitType::class, [
                'label' => ' ',
                'attr' => [
                    'class' => 'glyphicon glyphicon-remove btn-link',
                    'onclick' => 'return confirm("Are you sure?")'
                ]
            ])
            ->getForm();
    }
}