Werkspot / BingAdsApiBundle

Api/Client.php

Doc Comments +5 added lines, -5 removed lines

@@ -102,7 +102,7 @@ 
      * @param $timePeriod
      * @param null $fileLocation
      *
-     * @return array|string
+     * @return string
      */
     public function get(array $columns, $name = 'GeoLocationPerformanceReport', $timePeriod = ReportTimePeriod::LastWeek, $fileLocation = null)
     {
@@ -157,7 +157,7 @@ 
 
     /**
      * @param $reportRequest
-     * @param $name
+     * @param string $name
      * @param $downloadFile
      *
      * @return string
@@ -282,7 +282,7 @@ 
      * of minutes. You should stop polling and try again later if the request
      * is taking longer than an hour.
      *
-     * @param $reportRequestId
+     * @param string $reportRequestId
      *
      * @return string ReportRequestStatus
      */
@@ -316,7 +316,7 @@ 
      *
      * @param string $file zipFile we want to open
      *
-     * @return array of extracted files
+     * @return Client of extracted files
      */
     private function openZipFile($file, $delete = false)
     {
@@ -409,7 +409,7 @@ 
     /**
      * @param array $array
      * @param string $separator
-     * @param null $enclosure
+     * @param string $enclosure
      *
      * @return string
      */

Spacing +14 added lines, -14 removed lines

@@ -77,7 +77,7 @@ 
     public function setConfig($config)
     {
         $this->config = $config;
-        $this->config['cache_dir'] = $this->config['cache_dir'] . '/' . 'BingAdsApiBundle'; //<-- important for the cache clear function
+        $this->config['cache_dir'] = $this->config['cache_dir'].'/'.'BingAdsApiBundle'; //<-- important for the cache clear function
     }
 
     public function setApiDetails($refreshToken, $clientId, $secret, $redirectUri, $devToken)
@@ -249,16 +249,16 @@ 
             if ($incrementTime) {
                 switch ($count) {
                     case 31: // after 5 minutes
-                        $sleep = (1*60);
+                        $sleep = (1 * 60);
                         break;
                     case 35: // after 10 minutes
-                        $sleep = (5*60);
+                        $sleep = (5 * 60);
                         break;
                     case 40: // after 30 minutes
-                        $sleep = (15*60);
+                        $sleep = (15 * 60);
                         break;
                     case 44: // after 1,5 hours
-                        $sleep = (30*60);
+                        $sleep = (30 * 60);
                         break;
                 }
 
@@ -267,7 +267,7 @@ 
         }
 
         if ($reportRequestStatus->Status == "Error") {
-            throw new Exceptions\ReportRequestErrorException("The request failed. Try requesting the report later.\nIf the request continues to fail, contact support.", $reportRequestStatus->Status, $reportRequestId );
+            throw new Exceptions\ReportRequestErrorException("The request failed. Try requesting the report later.\nIf the request continues to fail, contact support.", $reportRequestStatus->Status, $reportRequestId);
         }
 
         return $reportRequestStatus;
@@ -372,7 +372,7 @@ 
         $totalLines = count($lines);
         $removeFrom = $totalLines - $noOfLinesToRemove;
 
-        for( $i = $removeFrom; $i < $totalLines; $i++ ) {
+        for ($i = $removeFrom; $i < $totalLines; $i++) {
             unset($lines[$i]);
         }
         return $lines;
@@ -388,7 +388,7 @@ 
     private function fixDate(array $lines, $separator = ',', $enclosure = '"')
     {
         foreach ($lines as $key => $line) {
-            $columns = str_getcsv($line, $separator );
+            $columns = str_getcsv($line, $separator);
             $isChanged = false;
             foreach ($columns as $columnKey => $column)
             {
@@ -399,7 +399,7 @@ 
                     $isChanged = true;
                 }
             }
-            if ($isChanged){
+            if ($isChanged) {
                 $lines[$key] = $this->arrayToCsvLine($columns, $separator, $enclosure);
             }
         }
@@ -417,15 +417,15 @@ 
     {
         $csvStr = "";
 
-        for( $i = 0; $i < count($array); $i++ ) {
+        for ($i = 0; $i < count($array); $i++) {
 
             if ($enclosure) {
-                $csvStr .= $enclosure . str_replace($enclosure, $enclosure.$enclosure, $array[$i]) . $enclosure;
+                $csvStr .= $enclosure.str_replace($enclosure, $enclosure.$enclosure, $array[$i]).$enclosure;
             } else {
                 $csvStr .= $array[$i];
             }
 
-            $csvStr .= ($i < count($array) - 1) ? $separator : "\r\n" ;
+            $csvStr .= ($i < count($array) - 1) ? $separator : "\r\n";
         }
         return $csvStr;
     }
@@ -487,8 +487,8 @@ 
         {
             $error = $e->detail->AdApiFaultDetail->Errors->AdApiError;
         } else if (isset($e->detail->ApiFaultDetail)) {
-            if (!empty($e->detail->ApiFaultDetail->BatchErrors)){
-                $error = $error =$e->detail->ApiFaultDetail->Errors->AdApiError;
+            if (!empty($e->detail->ApiFaultDetail->BatchErrors)) {
+                $error = $error = $e->detail->ApiFaultDetail->Errors->AdApiError;
             } elseif (!empty($e->detail->ApiFaultDetail->OperationErrors)) {
                 $error = $e->detail->ApiFaultDetail->OperationErrors->OperationError;
             }

DependencyInjection/WerkspotBingAdsApiExtension.php

Spacing +2 added lines, -2 removed lines

@@ -26,8 +26,8 @@
         $loader->load('services.yml');
 
         // Once the services definition are read, get your service and add a method call to setConfig()
-        $sillyServiceDefintion = $container->getDefinition( 'werkspot.bing_ads_api_client' );
-        $sillyServiceDefintion->addMethodCall( 'setConfig', [ $config ] );
+        $sillyServiceDefintion = $container->getDefinition('werkspot.bing_ads_api_client');
+        $sillyServiceDefintion->addMethodCall('setConfig', [$config]);
     }
 }