Werkspot / BingAdsApiBundle

Api/Client.php

Doc Comments +3 added lines, -3 removed lines

@@ -124,7 +124,7 @@ 
      * @param array $columns
      * @param string $name
      * @param $timePeriod
-     * @param null $fileLocation
+     * @param string $fileLocation
      *
      * @return array|string
      */
@@ -178,7 +178,7 @@ 
 
     /**
      * @param $reportRequest
-     * @param $name
+     * @param string $name
      * @param $downloadFile
      *
      * @throws \Exception
@@ -294,7 +294,7 @@ 
      * of minutes. You should stop polling and try again later if the request
      * is taking longer than an hour.
      *
-     * @param $reportRequestId
+     * @param string $reportRequestId
      *
      * @return string ReportRequestStatus
      */

Spacing +1 added lines, -1 removed lines

@@ -111,7 +111,7 @@
     public function setConfig($config)
     {
         $this->config = $config;
-        $this->config['cache_dir'] = $this->config['cache_dir'] . '/' . 'BingAdsApiBundle'; //<-- important for the cache clear function
+        $this->config['cache_dir'] = $this->config['cache_dir'].'/'.'BingAdsApiBundle'; //<-- important for the cache clear function
         $this->config['csv']['fixHeader']['removeColumnHeader'] = true; //-- fix till i know how to do this
     }
 

Api/Helper/Csv.php

Doc Comments +4 added lines, -4 removed lines

@@ -6,7 +6,7 @@ 
 class Csv
 {
     /**
-     * @param array $lines
+     * @param string[] $lines
      * @param bool $includingColumnHeaders
      * @param int $fileHeaders
      * @param int $columnHeaders
@@ -28,7 +28,7 @@ 
     }
 
     /**
-     * @param array $lines
+     * @param string[] $lines
      * @param int   $noOfLinesToRemove
      *
      * @return array
@@ -48,7 +48,7 @@ 
     }
 
     /**
-     * @param array $lines
+     * @param string[] $lines
      * @param string $separator
      * @param string $enclosure
      *
@@ -77,7 +77,7 @@ 
     /**
      * @param array $array
      * @param string $separator
-     * @param null $enclosure
+     * @param string $enclosure
      *
      * @return string
      */

Spacing +1 added lines, -1 removed lines

@@ -87,7 +87,7 @@
 
         for ($i = 0; $i < count($array); ++$i) {
             if ($enclosure) {
-                $csvStr .= $enclosure . str_replace($enclosure, $enclosure . $enclosure, $array[$i]) . $enclosure;
+                $csvStr .= $enclosure.str_replace($enclosure, $enclosure.$enclosure, $array[$i]).$enclosure;
             } else {
                 $csvStr .= $array[$i];
             }

Api/Helper/File.php

Doc Comments +1 added lines, -1 removed lines

@@ -75,7 +75,7 @@
 
     /**
      * @param string $file zipFile we want to open
-     * @param null $extractTo
+     * @param boolean $extractTo
      * @param bool $delete
      *
      * @throws Exception

Api/Report/BaseReport.php

Doc Comments +1 added lines, -1 removed lines

@@ -64,7 +64,7 @@
      * @param array|null $columns
      * @param string|null $timePeriod (See BingAds SDK documentation)
      *
-     * @return mixed
+     * @return ReportRequest
      */
     public function getRequest(array $columns = null, $timePeriod = null)
     {

Tests/Api/ClientTest.php

Doc Comments +1 added lines

@@ -61,6 +61,7 @@
     }
 
     /**
+     * @param integer $code
      * @return Mockery\MockInterface
      */
     private function runClientSoapException($code)

Tests/Api/Report/GeoLocationPerformanceReportTest.php

Doc Comments +3 added lines

@@ -276,6 +276,9 @@
         return $apiClient;
     }
 
+    /**
+     * @param integer $code
+     */
     private function generateSoapFault($code)
     {
         $message = "an error message {$code}";

Spacing +6 added lines, -6 removed lines

@@ -68,7 +68,7 @@ 
             $this->getTimeHelperMock()
         );
         $result = $apiClient->get(['TimePeriod', 'AccountName', 'AdGroupId'], 'GeoLocationPerformanceReport', ReportTimePeriod::LastWeek);
-        $this->assertEquals([ASSETS_DIR . 'report.csv'], $result);
+        $this->assertEquals([ASSETS_DIR.'report.csv'], $result);
     }
 
     public function testGeoLocationPerformanceReportMoveFile()
@@ -81,12 +81,12 @@ 
             $this->getCsvHelperMock(),
             $this->getTimeHelperMock()
         );
-        $result = $apiClient->get(['TimePeriod', 'AccountName', 'AdGroupId'], 'GeoLocationPerformanceReport', ReportTimePeriod::LastWeek, ASSETS_DIR . 'test.csv');
-        $this->assertEquals(ASSETS_DIR . 'test.csv', $result);
+        $result = $apiClient->get(['TimePeriod', 'AccountName', 'AdGroupId'], 'GeoLocationPerformanceReport', ReportTimePeriod::LastWeek, ASSETS_DIR.'test.csv');
+        $this->assertEquals(ASSETS_DIR.'test.csv', $result);
 
         //--Move File back
         $fileSystem = new Filesystem();
-        $fileSystem->rename(ASSETS_DIR . 'test.csv', ASSETS_DIR . 'report.csv');
+        $fileSystem->rename(ASSETS_DIR.'test.csv', ASSETS_DIR.'report.csv');
     }
 
     public function testGetRefreshToken()
@@ -224,7 +224,7 @@ 
             ->once()
             ->shouldReceive('unZip')
             ->with('/tmp/report.zip')
-            ->andReturn([ASSETS_DIR . 'report.csv'])
+            ->andReturn([ASSETS_DIR.'report.csv'])
             ->once();
 
         return $zipHelperMock;
@@ -235,7 +235,7 @@ 
      */
     private function getCsvHelperMock()
     {
-        $lines = file(ASSETS_DIR . 'report.csv');
+        $lines = file(ASSETS_DIR.'report.csv');
         $csvHelperMock = Mockery::mock(Helper\Csv::class);
         $csvHelperMock
             ->shouldReceive('removeHeaders')

Tests/Api/Helper/FileTest.php

Spacing +8 added lines, -8 removed lines

@@ -25,10 +25,10 @@ 
 
     public function testGetFile()
     {
-        $nonExistingFile = ASSETS_DIR . 'iDoNotExist.txt';
-        $existingFile = ASSETS_DIR . 'report.csv';
+        $nonExistingFile = ASSETS_DIR.'iDoNotExist.txt';
+        $existingFile = ASSETS_DIR.'report.csv';
         $onlineFile = 'http://google.com/test.txt';
-        $file = ASSETS_DIR . 'example.txt';
+        $file = ASSETS_DIR.'example.txt';
 
         $mock = new MockHandler([new Response(200, [])]);
         $handler = HandlerStack::create($mock);
@@ -54,7 +54,7 @@ 
     public function testDownload()
     {
         $url = 'http://example.com';
-        $file = ASSETS_DIR . 'example.txt';
+        $file = ASSETS_DIR.'example.txt';
 
         $clientMock = Mockery::mock(Client::class);
         $clientMock
@@ -82,14 +82,14 @@ 
 
     public function testUnZip()
     {
-        $file = ASSETS_DIR . 'test.zip';
+        $file = ASSETS_DIR.'test.zip';
 
-        $this->fileSystem->copy(ASSETS_DIR . 'report.zip', $file);
+        $this->fileSystem->copy(ASSETS_DIR.'report.zip', $file);
 
         $fileHelper = new File();
         $files = $fileHelper->unZip($file);
 
-        $this->assertEquals($files, [ASSETS_DIR . '0039202.csv']);
+        $this->assertEquals($files, [ASSETS_DIR.'0039202.csv']);
 
         //-- Remove the files created by this test
         foreach ($files as $file) {
@@ -102,7 +102,7 @@ 
      */
     public function testCorruptUnZip()
     {
-        $file = ASSETS_DIR . 'corrupt.zip';
+        $file = ASSETS_DIR.'corrupt.zip';
         $fileHelper = new File();
         $fileHelper->unZip($file, false);
     }

DependencyInjection/WerkspotBingAdsApiExtension.php

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
         $configuration = new Configuration();
         $config = $this->processConfiguration($configuration, $configs);
 
-        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
+        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
         $loader->load('services.yml');
 
         // Once the services definition are read, get your service and add a method call to setConfig()