Completed
Pull Request — trunk (#838)
by Andrew
06:40
created
includes/CMB2.php 1 patch
Spacing   +74 added lines, -74 removed lines patch added patch discarded remove patch
@@ -123,19 +123,19 @@  discard block
 block discarded – undo
123 123
 	 */
124 124
 	public function __construct( $config, $object_id = 0 ) {
125 125
 
126
-		if ( empty( $config['id'] ) ) {
126
+		if ( empty( $config[ 'id' ] ) ) {
127 127
 			wp_die( esc_html__( 'Metabox configuration is required to have an ID parameter.', 'cmb2' ) );
128 128
 		}
129 129
 
130 130
 		$this->meta_box = wp_parse_args( $config, $this->mb_defaults );
131
-		$this->meta_box['fields'] = array();
131
+		$this->meta_box[ 'fields' ] = array();
132 132
 
133 133
 		$this->object_id( $object_id );
134 134
 		$this->mb_object_type();
135
-		$this->cmb_id = $config['id'];
135
+		$this->cmb_id = $config[ 'id' ];
136 136
 
137
-		if ( ! empty( $config['fields'] ) && is_array( $config['fields'] ) ) {
138
-			$this->add_fields( $config['fields'] );
137
+		if ( ! empty( $config[ 'fields' ] ) && is_array( $config[ 'fields' ] ) ) {
138
+			$this->add_fields( $config[ 'fields' ] );
139 139
 		}
140 140
 
141 141
 		CMB2_Boxes::add( $this );
@@ -243,17 +243,17 @@  discard block
 block discarded – undo
243 243
 
244 244
 			// Include the postbox wrapper if we have no title, unless that property is set to false.
245 245
 			if ( empty( $this->prop( 'title' ) ) && empty( $this->prop( 'remove_box_wrap' ) ) ) {
246
-				$context[] = 'postbox cmb2-context-wrap-no-title';
246
+				$context[ ] = 'postbox cmb2-context-wrap-no-title';
247 247
 			}
248 248
 
249 249
 			// Include a generic context wrapper.
250
-			$context[] = 'cmb2-context-wrap';
250
+			$context[ ] = 'cmb2-context-wrap';
251 251
 
252 252
 			// Include a context-type based context wrapper.
253
-			$context[] = 'cmb2-context-wrap-' . $this->prop( 'context' );
253
+			$context[ ] = 'cmb2-context-wrap-' . $this->prop( 'context' );
254 254
 
255 255
 			// Include an ID based context wrapper as well.
256
-			$context[] = 'cmb2-context-wrap-' . $this->prop( 'id' );
256
+			$context[ ] = 'cmb2-context-wrap-' . $this->prop( 'id' );
257 257
 
258 258
 			// And merge all the classes back into the array.
259 259
 			$classes = array_merge( $classes, $context );
@@ -332,22 +332,22 @@  discard block
 block discarded – undo
332 332
 	 * @return mixed CMB2_Field object if successful.
333 333
 	 */
334 334
 	public function render_field( $field_args ) {
335
-		$field_args['context'] = $this->prop( 'context' );
335
+		$field_args[ 'context' ] = $this->prop( 'context' );
336 336
 
337
-		if ( 'group' == $field_args['type'] ) {
337
+		if ( 'group' == $field_args[ 'type' ] ) {
338 338
 
339
-			if ( ! isset( $field_args['show_names'] ) ) {
340
-				$field_args['show_names'] = $this->prop( 'show_names' );
339
+			if ( ! isset( $field_args[ 'show_names' ] ) ) {
340
+				$field_args[ 'show_names' ] = $this->prop( 'show_names' );
341 341
 			}
342 342
 			$field = $this->render_group( $field_args );
343 343
 
344
-		} elseif ( 'hidden' == $field_args['type'] && $this->get_field( $field_args )->should_show() ) {
344
+		} elseif ( 'hidden' == $field_args[ 'type' ] && $this->get_field( $field_args )->should_show() ) {
345 345
 			// Save rendering for after the metabox
346 346
 			$field = $this->add_hidden_field( $field_args );
347 347
 
348 348
 		} else {
349 349
 
350
-			$field_args['show_names'] = $this->prop( 'show_names' );
350
+			$field_args[ 'show_names' ] = $this->prop( 'show_names' );
351 351
 
352 352
 			// Render default fields
353 353
 			$field = $this->get_field( $field_args )->render_field();
@@ -363,7 +363,7 @@  discard block
 block discarded – undo
363 363
 	 */
364 364
 	public function render_group( $args ) {
365 365
 
366
-		if ( ! isset( $args['id'], $args['fields'] ) || ! is_array( $args['fields'] ) ) {
366
+		if ( ! isset( $args[ 'id' ], $args[ 'fields' ] ) || ! is_array( $args[ 'fields' ] ) ) {
367 367
 			return;
368 368
 		}
369 369
 
@@ -473,15 +473,15 @@  discard block
 block discarded – undo
473 473
 			<div class="inside cmb-td cmb-nested cmb-field-list">';
474 474
 				// Loop and render repeatable group fields
475 475
 				foreach ( array_values( $field_group->args( 'fields' ) ) as $field_args ) {
476
-					if ( 'hidden' == $field_args['type'] ) {
476
+					if ( 'hidden' == $field_args[ 'type' ] ) {
477 477
 
478 478
 						// Save rendering for after the metabox
479 479
 						$this->add_hidden_field( $field_args, $field_group );
480 480
 
481 481
 					} else {
482 482
 
483
-						$field_args['show_names'] = $field_group->args( 'show_names' );
484
-						$field_args['context']    = $field_group->args( 'context' );
483
+						$field_args[ 'show_names' ] = $field_group->args( 'show_names' );
484
+						$field_args[ 'context' ]    = $field_group->args( 'context' );
485 485
 
486 486
 						$field = $this->get_field( $field_args, $field_group )->render_field();
487 487
 					}
@@ -510,7 +510,7 @@  discard block
 block discarded – undo
510 510
 	 * @param CMB2_Field|null $field_group CMB2_Field group field object
511 511
 	 */
512 512
 	public function add_hidden_field( $field_args, $field_group = null ) {
513
-		if ( isset( $field_args['field_args'] ) ) {
513
+		if ( isset( $field_args[ 'field_args' ] ) ) {
514 514
 			// For back-compatibility.
515 515
 			$field = new CMB2_Field( $field_args );
516 516
 		} else {
@@ -523,7 +523,7 @@  discard block
 block discarded – undo
523 523
 			$type->iterator = $field_group->index;
524 524
 		}
525 525
 
526
-		$this->hidden_fields[] = $type;
526
+		$this->hidden_fields[ ] = $type;
527 527
 
528 528
 		return $field;
529 529
 	}
@@ -626,11 +626,11 @@  discard block
 block discarded – undo
626 626
 	 */
627 627
 	public function process_field( $field_args ) {
628 628
 
629
-		switch ( $field_args['type'] ) {
629
+		switch ( $field_args[ 'type' ] ) {
630 630
 
631 631
 			case 'group':
632 632
 				if ( $this->save_group( $field_args ) ) {
633
-					$this->updated[] = $field_args['id'];
633
+					$this->updated[ ] = $field_args[ 'id' ];
634 634
 				}
635 635
 
636 636
 				break;
@@ -644,7 +644,7 @@  discard block
 block discarded – undo
644 644
 				$field = $this->get_new_field( $field_args );
645 645
 
646 646
 				if ( $field->save_field_from_data( $this->data_to_save ) ) {
647
-					$this->updated[] = $field->id();
647
+					$this->updated[ ] = $field->id();
648 648
 				}
649 649
 
650 650
 				break;
@@ -711,7 +711,7 @@  discard block
 block discarded – undo
711 711
 	 * @return mixed        Return of CMB2_Field::update_data()
712 712
 	 */
713 713
 	public function save_group( $args ) {
714
-		if ( ! isset( $args['id'], $args['fields'] ) || ! is_array( $args['fields'] ) ) {
714
+		if ( ! isset( $args[ 'id' ], $args[ 'fields' ] ) || ! is_array( $args[ 'fields' ] ) ) {
715 715
 			return;
716 716
 		}
717 717
 
@@ -740,7 +740,7 @@  discard block
 block discarded – undo
740 740
 		$field_group->data_to_save = $this->data_to_save;
741 741
 
742 742
 		foreach ( array_values( $field_group->fields() ) as $field_args ) {
743
-			if ( 'title' === $field_args['type'] ) {
743
+			if ( 'title' === $field_args[ 'type' ] ) {
744 744
 				// Don't process title fields
745 745
 				continue;
746 746
 			}
@@ -763,16 +763,16 @@  discard block
 block discarded – undo
763 763
 						$_new_val = array();
764 764
 						foreach ( $new_val as $group_index => $grouped_data ) {
765 765
 							// Add the supporting data to the $saved array stack
766
-							$saved[ $field_group->index ][ $grouped_data['supporting_field_id'] ][] = $grouped_data['supporting_field_value'];
766
+							$saved[ $field_group->index ][ $grouped_data[ 'supporting_field_id' ] ][ ] = $grouped_data[ 'supporting_field_value' ];
767 767
 							// Reset var to the actual value
768
-							$_new_val[ $group_index ] = $grouped_data['value'];
768
+							$_new_val[ $group_index ] = $grouped_data[ 'value' ];
769 769
 						}
770 770
 						$new_val = $_new_val;
771 771
 					} else {
772 772
 						// Add the supporting data to the $saved array stack
773
-						$saved[ $field_group->index ][ $new_val['supporting_field_id'] ] = $new_val['supporting_field_value'];
773
+						$saved[ $field_group->index ][ $new_val[ 'supporting_field_id' ] ] = $new_val[ 'supporting_field_value' ];
774 774
 						// Reset var to the actual value
775
-						$new_val = $new_val['value'];
775
+						$new_val = $new_val[ 'value' ];
776 776
 					}
777 777
 				}
778 778
 
@@ -786,7 +786,7 @@  discard block
 block discarded – undo
786 786
 
787 787
 				// Compare values and add to `$updated` array
788 788
 				if ( $is_updated || $is_removed ) {
789
-					$this->updated[] = $base_id . '::' . $field_group->index . '::' . $sub_id;
789
+					$this->updated[ ] = $base_id . '::' . $field_group->index . '::' . $sub_id;
790 790
 				}
791 791
 
792 792
 				// Add to `$saved` array
@@ -823,22 +823,22 @@  discard block
 block discarded – undo
823 823
 		// Try to get our object ID from the global space
824 824
 		switch ( $this->object_type() ) {
825 825
 			case 'user':
826
-				$object_id = isset( $_REQUEST['user_id'] ) ? $_REQUEST['user_id'] : $object_id;
827
-				$object_id = ! $object_id && 'user-new.php' != $pagenow && isset( $GLOBALS['user_ID'] ) ? $GLOBALS['user_ID'] : $object_id;
826
+				$object_id = isset( $_REQUEST[ 'user_id' ] ) ? $_REQUEST[ 'user_id' ] : $object_id;
827
+				$object_id = ! $object_id && 'user-new.php' != $pagenow && isset( $GLOBALS[ 'user_ID' ] ) ? $GLOBALS[ 'user_ID' ] : $object_id;
828 828
 				break;
829 829
 
830 830
 			case 'comment':
831
-				$object_id = isset( $_REQUEST['c'] ) ? $_REQUEST['c'] : $object_id;
832
-				$object_id = ! $object_id && isset( $GLOBALS['comments']->comment_ID ) ? $GLOBALS['comments']->comment_ID : $object_id;
831
+				$object_id = isset( $_REQUEST[ 'c' ] ) ? $_REQUEST[ 'c' ] : $object_id;
832
+				$object_id = ! $object_id && isset( $GLOBALS[ 'comments' ]->comment_ID ) ? $GLOBALS[ 'comments' ]->comment_ID : $object_id;
833 833
 				break;
834 834
 
835 835
 			case 'term':
836
-				$object_id = isset( $_REQUEST['tag_ID'] ) ? $_REQUEST['tag_ID'] : $object_id;
836
+				$object_id = isset( $_REQUEST[ 'tag_ID' ] ) ? $_REQUEST[ 'tag_ID' ] : $object_id;
837 837
 				break;
838 838
 
839 839
 			default:
840
-				$object_id = isset( $GLOBALS['post']->ID ) ? $GLOBALS['post']->ID : $object_id;
841
-				$object_id = isset( $_REQUEST['post'] ) ? $_REQUEST['post'] : $object_id;
840
+				$object_id = isset( $GLOBALS[ 'post' ]->ID ) ? $GLOBALS[ 'post' ]->ID : $object_id;
841
+				$object_id = isset( $_REQUEST[ 'post' ] ) ? $_REQUEST[ 'post' ] : $object_id;
842 842
 				break;
843 843
 		}
844 844
 
@@ -909,7 +909,7 @@  discard block
 block discarded – undo
909 909
 	 * @return boolean True/False
910 910
 	 */
911 911
 	public function is_options_page_mb() {
912
-		return ( isset( $this->meta_box['show_on']['key'] ) && 'options-page' === $this->meta_box['show_on']['key'] || array_key_exists( 'options-page', $this->meta_box['show_on'] ) );
912
+		return ( isset( $this->meta_box[ 'show_on' ][ 'key' ] ) && 'options-page' === $this->meta_box[ 'show_on' ][ 'key' ] || array_key_exists( 'options-page', $this->meta_box[ 'show_on' ] ) );
913 913
 	}
914 914
 
915 915
 	/**
@@ -996,7 +996,7 @@  discard block
 block discarded – undo
996 996
 			return $field;
997 997
 		}
998 998
 
999
-		$field_id = is_string( $field ) ? $field : $field['id'];
999
+		$field_id = is_string( $field ) ? $field : $field[ 'id' ];
1000 1000
 
1001 1001
 		$parent_field_id = ! empty( $field_group ) ? $field_group->id() : '';
1002 1002
 		$ids = $this->get_field_ids( $field_id, $parent_field_id );
@@ -1032,16 +1032,16 @@  discard block
 block discarded – undo
1032 1032
 		if ( $field_group && ( $sub_field_id || 0 === $sub_field_id ) ) {
1033 1033
 
1034 1034
 			// Update the fields array w/ any modified properties inherited from the group field
1035
-			$this->meta_box['fields'][ $field_id ]['fields'][ $sub_field_id ] = $field_args;
1035
+			$this->meta_box[ 'fields' ][ $field_id ][ 'fields' ][ $sub_field_id ] = $field_args;
1036 1036
 
1037 1037
 			return $this->get_default_args( $field_args, $field_group );
1038 1038
 		}
1039 1039
 
1040 1040
 		if ( is_array( $field_args ) ) {
1041
-			$this->meta_box['fields'][ $field_id ] = array_merge( $field_args, $this->meta_box['fields'][ $field_id ] );
1041
+			$this->meta_box[ 'fields' ][ $field_id ] = array_merge( $field_args, $this->meta_box[ 'fields' ][ $field_id ] );
1042 1042
 		}
1043 1043
 
1044
-		return $this->get_default_args( $this->meta_box['fields'][ $field_id ] );
1044
+		return $this->get_default_args( $this->meta_box[ 'fields' ][ $field_id ] );
1045 1045
 	}
1046 1046
 
1047 1047
 	/**
@@ -1091,8 +1091,8 @@  discard block
 block discarded – undo
1091 1091
 
1092 1092
 			$sub_fields = false;
1093 1093
 			if ( array_key_exists( 'fields', $field ) ) {
1094
-				$sub_fields = $field['fields'];
1095
-				unset( $field['fields'] );
1094
+				$sub_fields = $field[ 'fields' ];
1095
+				unset( $field[ 'fields' ] );
1096 1096
 			}
1097 1097
 
1098 1098
 			$field_id = $parent_field_id
@@ -1117,26 +1117,26 @@  discard block
 block discarded – undo
1117 1117
 			return false;
1118 1118
 		}
1119 1119
 
1120
-		if ( 'oembed' === $field['type'] ) {
1120
+		if ( 'oembed' === $field[ 'type' ] ) {
1121 1121
 			// Initiate oembed Ajax hooks
1122 1122
 			cmb2_ajax();
1123 1123
 		}
1124 1124
 
1125
-		if ( isset( $field['column'] ) && false !== $field['column'] ) {
1125
+		if ( isset( $field[ 'column' ] ) && false !== $field[ 'column' ] ) {
1126 1126
 			$field = $this->define_field_column( $field );
1127 1127
 		}
1128 1128
 
1129
-		if ( isset( $field['taxonomy'] ) && ! empty( $field['remove_default'] ) ) {
1130
-			$this->tax_metaboxes_to_remove[ $field['taxonomy'] ] = $field['taxonomy'];
1129
+		if ( isset( $field[ 'taxonomy' ] ) && ! empty( $field[ 'remove_default' ] ) ) {
1130
+			$this->tax_metaboxes_to_remove[ $field[ 'taxonomy' ] ] = $field[ 'taxonomy' ];
1131 1131
 		}
1132 1132
 
1133 1133
 		$this->_add_field_to_array(
1134 1134
 			$field,
1135
-			$this->meta_box['fields'],
1135
+			$this->meta_box[ 'fields' ],
1136 1136
 			$position
1137 1137
 		);
1138 1138
 
1139
-		return $field['id'];
1139
+		return $field[ 'id' ];
1140 1140
 	}
1141 1141
 
1142 1142
 	/**
@@ -1148,10 +1148,10 @@  discard block
 block discarded – undo
1148 1148
 	protected function define_field_column( array $field ) {
1149 1149
 		$this->has_columns = true;
1150 1150
 
1151
-		$column = is_array( $field['column'] ) ? $field['column'] : array();
1151
+		$column = is_array( $field[ 'column' ] ) ? $field[ 'column' ] : array();
1152 1152
 
1153
-		$field['column'] = wp_parse_args( $column, array(
1154
-			'name'     => isset( $field['name'] ) ? $field['name'] : '',
1153
+		$field[ 'column' ] = wp_parse_args( $column, array(
1154
+			'name'     => isset( $field[ 'name' ] ) ? $field[ 'name' ] : '',
1155 1155
 			'position' => false,
1156 1156
 		) );
1157 1157
 
@@ -1167,27 +1167,27 @@  discard block
 block discarded – undo
1167 1167
 	 * @return mixed                   Array of parent/field ids or false
1168 1168
 	 */
1169 1169
 	public function add_group_field( $parent_field_id, array $field, $position = 0 ) {
1170
-		if ( ! array_key_exists( $parent_field_id, $this->meta_box['fields'] ) ) {
1170
+		if ( ! array_key_exists( $parent_field_id, $this->meta_box[ 'fields' ] ) ) {
1171 1171
 			return false;
1172 1172
 		}
1173 1173
 
1174
-		$parent_field = $this->meta_box['fields'][ $parent_field_id ];
1174
+		$parent_field = $this->meta_box[ 'fields' ][ $parent_field_id ];
1175 1175
 
1176
-		if ( 'group' !== $parent_field['type'] ) {
1176
+		if ( 'group' !== $parent_field[ 'type' ] ) {
1177 1177
 			return false;
1178 1178
 		}
1179 1179
 
1180
-		if ( ! isset( $parent_field['fields'] ) ) {
1181
-			$this->meta_box['fields'][ $parent_field_id ]['fields'] = array();
1180
+		if ( ! isset( $parent_field[ 'fields' ] ) ) {
1181
+			$this->meta_box[ 'fields' ][ $parent_field_id ][ 'fields' ] = array();
1182 1182
 		}
1183 1183
 
1184 1184
 		$this->_add_field_to_array(
1185 1185
 			$field,
1186
-			$this->meta_box['fields'][ $parent_field_id ]['fields'],
1186
+			$this->meta_box[ 'fields' ][ $parent_field_id ][ 'fields' ],
1187 1187
 			$position
1188 1188
 		);
1189 1189
 
1190
-		return array( $parent_field_id, $field['id'] );
1190
+		return array( $parent_field_id, $field[ 'id' ] );
1191 1191
 	}
1192 1192
 
1193 1193
 	/**
@@ -1199,9 +1199,9 @@  discard block
 block discarded – undo
1199 1199
 	 */
1200 1200
 	protected function _add_field_to_array( $field, &$fields, $position = 0 ) {
1201 1201
 		if ( $position ) {
1202
-			CMB2_Utils::array_insert( $fields, array( $field['id'] => $field ), $position );
1202
+			CMB2_Utils::array_insert( $fields, array( $field[ 'id' ] => $field ), $position );
1203 1203
 		} else {
1204
-			$fields[ $field['id'] ] = $field;
1204
+			$fields[ $field[ 'id' ] ] = $field;
1205 1205
 		}
1206 1206
 	}
1207 1207
 
@@ -1224,15 +1224,15 @@  discard block
 block discarded – undo
1224 1224
 		unset( $this->fields[ implode( '', $ids ) ] );
1225 1225
 
1226 1226
 		if ( ! $sub_field_id ) {
1227
-			unset( $this->meta_box['fields'][ $field_id ] );
1227
+			unset( $this->meta_box[ 'fields' ][ $field_id ] );
1228 1228
 			return true;
1229 1229
 		}
1230 1230
 
1231
-		if ( isset( $this->fields[ $field_id ]->args['fields'][ $sub_field_id ] ) ) {
1232
-			unset( $this->fields[ $field_id ]->args['fields'][ $sub_field_id ] );
1231
+		if ( isset( $this->fields[ $field_id ]->args[ 'fields' ][ $sub_field_id ] ) ) {
1232
+			unset( $this->fields[ $field_id ]->args[ 'fields' ][ $sub_field_id ] );
1233 1233
 		}
1234
-		if ( isset( $this->meta_box['fields'][ $field_id ]['fields'][ $sub_field_id ] ) ) {
1235
-			unset( $this->meta_box['fields'][ $field_id ]['fields'][ $sub_field_id ] );
1234
+		if ( isset( $this->meta_box[ 'fields' ][ $field_id ][ 'fields' ][ $sub_field_id ] ) ) {
1235
+			unset( $this->meta_box[ 'fields' ][ $field_id ][ 'fields' ][ $sub_field_id ] );
1236 1236
 		}
1237 1237
 		return true;
1238 1238
 	}
@@ -1256,11 +1256,11 @@  discard block
 block discarded – undo
1256 1256
 		list( $field_id, $sub_field_id ) = $ids;
1257 1257
 
1258 1258
 		if ( ! $sub_field_id ) {
1259
-			$this->meta_box['fields'][ $field_id ][ $property ] = $value;
1259
+			$this->meta_box[ 'fields' ][ $field_id ][ $property ] = $value;
1260 1260
 			return $field_id;
1261 1261
 		}
1262 1262
 
1263
-		$this->meta_box['fields'][ $field_id ]['fields'][ $sub_field_id ][ $property ] = $value;
1263
+		$this->meta_box[ 'fields' ][ $field_id ][ 'fields' ][ $sub_field_id ][ $property ] = $value;
1264 1264
 		return $field_id;
1265 1265
 	}
1266 1266
 
@@ -1274,7 +1274,7 @@  discard block
 block discarded – undo
1274 1274
 	public function get_field_ids( $field_id, $parent_field_id = '' ) {
1275 1275
 		$sub_field_id = $parent_field_id ? $field_id : '';
1276 1276
 		$field_id     = $parent_field_id ? $parent_field_id : $field_id;
1277
-		$fields       =& $this->meta_box['fields'];
1277
+		$fields       = & $this->meta_box[ 'fields' ];
1278 1278
 
1279 1279
 		if ( ! array_key_exists( $field_id, $fields ) ) {
1280 1280
 			$field_id = $this->search_old_school_array( $field_id, $fields );
@@ -1288,12 +1288,12 @@  discard block
 block discarded – undo
1288 1288
 			return array( $field_id, $sub_field_id );
1289 1289
 		}
1290 1290
 
1291
-		if ( 'group' !== $fields[ $field_id ]['type'] ) {
1291
+		if ( 'group' !== $fields[ $field_id ][ 'type' ] ) {
1292 1292
 			return false;
1293 1293
 		}
1294 1294
 
1295
-		if ( ! array_key_exists( $sub_field_id, $fields[ $field_id ]['fields'] ) ) {
1296
-			$sub_field_id = $this->search_old_school_array( $sub_field_id, $fields[ $field_id ]['fields'] );
1295
+		if ( ! array_key_exists( $sub_field_id, $fields[ $field_id ][ 'fields' ] ) ) {
1296
+			$sub_field_id = $this->search_old_school_array( $sub_field_id, $fields[ $field_id ][ 'fields' ] );
1297 1297
 		}
1298 1298
 
1299 1299
 		return false === $sub_field_id ? false : array( $field_id, $sub_field_id );
Please login to merge, or discard this patch.