Completed
Pull Request — trunk (#541)
by Justin
06:39
created
example-functions.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
 	$cmb_demo = new_cmb2_box( array(
79 79
 		'id'              => $prefix . 'metabox',
80 80
 		'title'           => __( 'Test Metabox', 'cmb2' ),
81
-		'object_types'    => array( 'page', ), // Post type
81
+		'object_types'    => array( 'page',), // Post type
82 82
 		// 'show_on_cb'   => 'yourprefix_show_if_front_page', // function should return a bool value
83 83
 		// 'context'      => 'normal',
84 84
 		// 'priority'     => 'high',
@@ -322,7 +322,7 @@  discard block
 block discarded – undo
322 322
 		'desc'    => __( 'field description (optional)', 'cmb2' ),
323 323
 		'id'      => $prefix . 'wysiwyg',
324 324
 		'type'    => 'wysiwyg',
325
-		'options' => array( 'textarea_rows' => 5, ),
325
+		'options' => array( 'textarea_rows' => 5,),
326 326
 	) );
327 327
 
328 328
 	$cmb_demo->add_field( array(
@@ -374,11 +374,11 @@  discard block
 block discarded – undo
374 374
 	$cmb_about_page = new_cmb2_box( array(
375 375
 		'id'           => $prefix . 'metabox',
376 376
 		'title'        => __( 'About Page Metabox', 'cmb2' ),
377
-		'object_types' => array( 'page', ), // Post type
377
+		'object_types' => array( 'page',), // Post type
378 378
 		'context'      => 'normal',
379 379
 		'priority'     => 'high',
380 380
 		'show_names'   => true, // Show field names on the left
381
-		'show_on'      => array( 'id' => array( 2, ) ), // Specific post IDs to display this metabox
381
+		'show_on'      => array( 'id' => array( 2,) ), // Specific post IDs to display this metabox
382 382
 	) );
383 383
 
384 384
 	$cmb_about_page->add_field( array(
@@ -403,7 +403,7 @@  discard block
 block discarded – undo
403 403
 	$cmb_group = new_cmb2_box( array(
404 404
 		'id'           => $prefix . 'metabox',
405 405
 		'title'        => __( 'Repeating Field Group', 'cmb2' ),
406
-		'object_types' => array( 'page', ),
406
+		'object_types' => array( 'page',),
407 407
 	) );
408 408
 
409 409
 	// $group_field_id is the field id string, so in this case: $prefix . 'demo'
Please login to merge, or discard this patch.
includes/CMB2_Hookup_Base.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
 			return;
55 55
 		}
56 56
 
57
-		self::$hooks_completed[] = $key;
57
+		self::$hooks_completed[ ] = $key;
58 58
 		add_filter( $action, $hook, $priority, $accepted_args );
59 59
 	}
60 60
 
Please login to merge, or discard this patch.
includes/CMB2_hookup.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
 	 * @return array           Modified array of classes
258 258
 	 */
259 259
 	public function close_metabox_class( $classes ) {
260
-		$classes[] = 'closed';
260
+		$classes[ ] = 'closed';
261 261
 		return $classes;
262 262
 	}
263 263
 
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
 	public function user_new_metabox( $section ) {
278 278
 		if ( $section == $this->cmb->prop( 'new_user_section' ) ) {
279 279
 			$object_id = $this->cmb->object_id();
280
-			$this->cmb->object_id( isset( $_REQUEST['user_id'] ) ? $_REQUEST['user_id'] : $object_id );
280
+			$this->cmb->object_id( isset( $_REQUEST[ 'user_id' ] ) ? $_REQUEST[ 'user_id' ] : $object_id );
281 281
 			$this->user_metabox();
282 282
 		}
283 283
 	}
@@ -428,7 +428,7 @@  discard block
 block discarded – undo
428 428
 		if ( $this->taxonomy_can_save( $taxonomy ) ) {
429 429
 
430 430
 			foreach ( $this->cmb->prop( 'fields' ) as $field ) {
431
-				$data_to_delete[ $field['id'] ] = '';
431
+				$data_to_delete[ $field[ 'id' ] ] = '';
432 432
 			}
433 433
 
434 434
 			$this->cmb->save_fields( $term_id, 'term', $data_to_delete );
Please login to merge, or discard this patch.
includes/CMB2_REST.php 2 patches
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
 	/**
153 153
 	 * Handler for updating custom field data.
154 154
 	 * @since  2.2.0
155
-	 * @param  mixed    $value    The value of the field
155
+	 * @param  mixed    $values    The value of the field
156 156
 	 * @param  object   $object   The object from the response
157 157
 	 * @param  string   $field_id Name of field
158 158
 	 * @return bool|int
@@ -233,6 +233,9 @@  discard block
 block discarded – undo
233 233
 		return $protected;
234 234
 	}
235 235
 
236
+	/**
237
+	 * @param string $field_id
238
+	 */
236 239
 	public function field_can_update( $field_id ) {
237 240
 
238 241
 		$field        = $this->cmb->get_field( $field_id );
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -120,18 +120,18 @@  discard block
 block discarded – undo
120 120
 
121 121
 	protected function declare_read_write_fields() {
122 122
 		foreach ( $this->cmb->prop( 'fields' ) as $field ) {
123
-			$show_in_rest = isset( $field['show_in_rest'] ) ? $field['show_in_rest'] : null;
123
+			$show_in_rest = isset( $field[ 'show_in_rest' ] ) ? $field[ 'show_in_rest' ] : null;
124 124
 
125 125
 			if ( false === $show_in_rest ) {
126 126
 				continue;
127 127
 			}
128 128
 
129 129
 			if ( $this->can_read( $show_in_rest ) ) {
130
-				$this->read_fields[] = $field['id'];
130
+				$this->read_fields[ ] = $field[ 'id' ];
131 131
 			}
132 132
 
133 133
 			if ( $this->can_write( $show_in_rest ) ) {
134
-				$this->write_fields[] = $field['id'];
134
+				$this->write_fields[ ] = $field[ 'id' ];
135 135
 			}
136 136
 
137 137
 		}
@@ -159,14 +159,14 @@  discard block
 block discarded – undo
159 159
 	 */
160 160
 	public static function get_restable_field_values( $object, $field_id, $request ) {
161 161
 		$values = array();
162
-		if ( ! isset( $object['id'] ) ) {
162
+		if ( ! isset( $object[ 'id' ] ) ) {
163 163
 			return;
164 164
 		}
165 165
 
166 166
 		foreach ( self::$boxes as $cmb_id => $rest_box ) {
167 167
 			foreach ( $rest_box->read_fields as $field_id ) {
168 168
 				$field = $rest_box->cmb->get_field( $field_id );
169
-				$field->object_id = $object['id'];
169
+				$field->object_id = $object[ 'id' ];
170 170
 
171 171
 				// TODO: test other object types (users, comments, etc)
172 172
 				if ( isset( $object->type ) ) {
@@ -205,8 +205,8 @@  discard block
 block discarded – undo
205 205
 				continue;
206 206
 			}
207 207
 
208
-			$rest_box->cmb->object_id( $data['object_id'] );
209
-			$rest_box->cmb->object_type( $data['object_type'] );
208
+			$rest_box->cmb->object_id( $data[ 'object_id' ] );
209
+			$rest_box->cmb->object_type( $data[ 'object_type' ] );
210 210
 
211 211
 			// TODO: Test since refactor.
212 212
 			$updated[ $cmb_id ] = $rest_box->sanitize_box_values( $values );
@@ -304,8 +304,8 @@  discard block
 block discarded – undo
304 304
 		} elseif ( isset( $object->comment_ID ) ) {
305 305
 			$object_id   = intval( $object->comment_ID );
306 306
 			$object_type = 'comment';
307
-		} elseif ( is_array( $object ) && isset( $object['term_id'] ) ) {
308
-			$object_id   = intval( $object['term_id'] );
307
+		} elseif ( is_array( $object ) && isset( $object[ 'term_id' ] ) ) {
308
+			$object_id   = intval( $object[ 'term_id' ] );
309 309
 			$object_type = 'term';
310 310
 		} elseif ( isset( $object->term_id ) ) {
311 311
 			$object_id   = intval( $object->term_id );
Please login to merge, or discard this patch.
includes/CMB2_REST_Controller.php 2 patches
Doc Comments   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -94,7 +94,6 @@  discard block
 block discarded – undo
94 94
 	 *
95 95
 	 * @since 2.2.0
96 96
 	 *
97
-	 * @param  mixed $data
98 97
 	 * @return array $data
99 98
 	 */
100 99
 	public function prepare_item( $post ) {
@@ -107,7 +106,7 @@  discard block
 block discarded – undo
107 106
 	 * @since  2.2.0
108 107
 	 *
109 108
 	 * @param  mixed $cb Callable function/method.
110
-	 * @return mixed     Results of output buffer after calling function/method.
109
+	 * @return string     Results of output buffer after calling function/method.
111 110
 	 */
112 111
 	public function get_cb_results( $cb ) {
113 112
 		$args = func_get_args();
@@ -142,6 +141,9 @@  discard block
 block discarded – undo
142 141
 		return apply_filters( 'cmb2_rest_prepare', rest_ensure_response( $data ), $this->request, $this );
143 142
 	}
144 143
 
144
+	/**
145
+	 * @param string $request_type
146
+	 */
145 147
 	protected function initiate_rest_read_box( $request, $request_type ) {
146 148
 		$this->initiate_rest_box( $request, $request_type );
147 149
 
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
 	 * @return array $data
129 129
 	 */
130 130
 	public function prepare_item_for_response( $data, $request = null ) {
131
-		$data = $this->filter_response_by_context( $data, $this->request['context'] );
131
+		$data = $this->filter_response_by_context( $data, $this->request[ 'context' ] );
132 132
 
133 133
 		/**
134 134
 		 * Filter the prepared CMB2 item response.
@@ -170,16 +170,16 @@  discard block
 block discarded – undo
170 170
 
171 171
 	public function initiate_request( $request, $request_type ) {
172 172
 		$this->request = $request;
173
-		$this->request['context'] = isset( $this->request['context'] ) && ! empty( $this->request['context'] )
174
-			? $this->request['context']
173
+		$this->request[ 'context' ] = isset( $this->request[ 'context' ] ) && ! empty( $this->request[ 'context' ] )
174
+			? $this->request[ 'context' ]
175 175
 			: 'view';
176 176
 
177
-		if ( isset( $_REQUEST['object_id'] ) ) {
178
-			$this->object_id = absint( $_REQUEST['object_id'] );
177
+		if ( isset( $_REQUEST[ 'object_id' ] ) ) {
178
+			$this->object_id = absint( $_REQUEST[ 'object_id' ] );
179 179
 		}
180 180
 
181
-		if ( isset( $_REQUEST['object_type'] ) ) {
182
-			$this->object_type = absint( $_REQUEST['object_type'] );
181
+		if ( isset( $_REQUEST[ 'object_type' ] ) ) {
182
+			$this->object_type = absint( $_REQUEST[ 'object_type' ] );
183 183
 		}
184 184
 
185 185
 		self::$request_type = self::$request_type ? self::$request_type : $request_type;
Please login to merge, or discard this patch.
includes/CMB2_REST_Controller_Boxes.php 2 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -100,7 +100,6 @@
 block discarded – undo
100 100
 	 *
101 101
 	 * @since 2.2.0
102 102
 	 *
103
-	 * @param CMB2 $cmb
104 103
 	 * @return array
105 104
 	 */
106 105
 	public function get_rest_box() {
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
 		foreach ( CMB2_REST::$boxes as $this->rest_box ) {
71 71
 			if ( $this->rest_box->rest_read ) {
72 72
 				$rest_box = $this->get_rest_box();
73
-				$boxes_data[ $this->rest_box->cmb->cmb_id ] = $this->server->response_to_data( $rest_box, isset( $_GET['_embed'] ) );
73
+				$boxes_data[ $this->rest_box->cmb->cmb_id ] = $this->server->response_to_data( $rest_box, isset( $_GET[ '_embed' ] ) );
74 74
 			}
75 75
 		}
76 76
 
@@ -110,9 +110,9 @@  discard block
 block discarded – undo
110 110
 
111 111
 		$boxes_data = $cmb->meta_box;
112 112
 
113
-		if ( isset( $_REQUEST['_rendered'] ) && '/cmb2/v1/boxes' !== CMB2_REST_Controller::get_intial_route() ) {
114
-			$boxes_data['form_open'] = $this->get_cb_results( array( $cmb, 'render_form_open' ) );
115
-			$boxes_data['form_close'] = $this->get_cb_results( array( $cmb, 'render_form_close' ) );
113
+		if ( isset( $_REQUEST[ '_rendered' ] ) && '/cmb2/v1/boxes' !== CMB2_REST_Controller::get_intial_route() ) {
114
+			$boxes_data[ 'form_open' ] = $this->get_cb_results( array( $cmb, 'render_form_open' ) );
115
+			$boxes_data[ 'form_close' ] = $this->get_cb_results( array( $cmb, 'render_form_close' ) );
116 116
 
117 117
 			global $wp_scripts, $wp_styles;
118 118
 			$before_css = $wp_styles->queue;
@@ -120,15 +120,15 @@  discard block
 block discarded – undo
120 120
 
121 121
 			CMB2_JS::enqueue();
122 122
 
123
-			$boxes_data['js_dependencies'] = array_values( array_diff( $wp_scripts->queue, $before_js ) );
124
-			$boxes_data['css_dependencies'] = array_values( array_diff( $wp_styles->queue, $before_css ) );
123
+			$boxes_data[ 'js_dependencies' ] = array_values( array_diff( $wp_scripts->queue, $before_js ) );
124
+			$boxes_data[ 'css_dependencies' ] = array_values( array_diff( $wp_styles->queue, $before_css ) );
125 125
 		}
126 126
 
127 127
 		// TODO: look into 'embed' parameter.
128 128
 		// http://demo.wp-api.org/wp-json/wp/v2/posts?_embed
129
-		unset( $boxes_data['fields'] );
129
+		unset( $boxes_data[ 'fields' ] );
130 130
 		// Handle callable properties.
131
-		unset( $boxes_data['show_on_cb'] );
131
+		unset( $boxes_data[ 'show_on_cb' ] );
132 132
 
133 133
 		$response = rest_ensure_response( $boxes_data );
134 134
 
Please login to merge, or discard this patch.
includes/CMB2_REST_Controller_Fields.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -67,11 +67,11 @@  discard block
 block discarded – undo
67 67
 
68 68
 		$fields = array();
69 69
 		foreach ( $this->rest_box->cmb->prop( 'fields', array() ) as $field ) {
70
-			$field_id = $field['id'];
70
+			$field_id = $field[ 'id' ];
71 71
 			$rest_field = $this->get_rest_field( $field_id );
72 72
 
73 73
 			if ( ! is_wp_error( $rest_field ) ) {
74
-				$fields[ $field_id ] = $this->server->response_to_data( $rest_field, isset( $_GET['_embed'] ) );
74
+				$fields[ $field_id ] = $this->server->response_to_data( $rest_field, isset( $_GET[ '_embed' ] ) );
75 75
 			} else {
76 76
 				$fields[ $field_id ] = array( 'error' => $rest_field->get_error_message() );
77 77
 			}
@@ -165,11 +165,11 @@  discard block
 block discarded – undo
165 165
 			}
166 166
 		}
167 167
 
168
-		if ( isset( $_REQUEST['_rendered'] ) ) {
169
-			$field_data['rendered'] = $rendered;
168
+		if ( isset( $_REQUEST[ '_rendered' ] ) ) {
169
+			$field_data[ 'rendered' ] = $rendered;
170 170
 		}
171 171
 
172
-		$field_data['value'] = $field->get_data();
172
+		$field_data[ 'value' ] = $field->get_data();
173 173
 
174 174
 		return $field_data;
175 175
 	}
@@ -190,14 +190,14 @@  discard block
 block discarded – undo
190 190
 		);
191 191
 
192 192
 		// TODO ?
193
-		error_log( '$this->request[context]: '. print_r( $this->request['context'], true ) );
194
-		error_log( 'CMB2_REST_Controller::get_intial_route(): '. print_r( CMB2_REST_Controller::get_intial_route(), true ) );
195
-		error_log( '$match: '. print_r( 'box_read' === CMB2_REST_Controller::get_intial_request_type(), true ) );
193
+		error_log( '$this->request[context]: ' . print_r( $this->request[ 'context' ], true ) );
194
+		error_log( 'CMB2_REST_Controller::get_intial_route(): ' . print_r( CMB2_REST_Controller::get_intial_route(), true ) );
195
+		error_log( '$match: ' . print_r( 'box_read' === CMB2_REST_Controller::get_intial_request_type(), true ) );
196 196
 
197 197
 
198 198
 		// Don't embed boxes when looking at boxes route.
199 199
 		if ( '/cmb2/v1/boxes' !== CMB2_REST_Controller::get_intial_route() ) {
200
-			$links['up']['embeddable'] = true;
200
+			$links[ 'up' ][ 'embeddable' ] = true;
201 201
 		}
202 202
 
203 203
 		return $links;
Please login to merge, or discard this patch.
includes/CMB2_Field.php 1 patch
Spacing   +72 added lines, -72 removed lines patch added patch discarded remove patch
@@ -131,21 +131,21 @@  discard block
 block discarded – undo
131 131
 	 */
132 132
 	public function __construct( $args ) {
133 133
 
134
-		if ( ! empty( $args['group_field'] ) ) {
135
-			$this->group       = $args['group_field'];
134
+		if ( ! empty( $args[ 'group_field' ] ) ) {
135
+			$this->group       = $args[ 'group_field' ];
136 136
 			$this->object_id   = $this->group->object_id;
137 137
 			$this->object_type = $this->group->object_type;
138 138
 			$this->cmb_id      = $this->group->cmb_id;
139 139
 		} else {
140
-			$this->object_id   = isset( $args['object_id'] ) && '_' !== $args['object_id'] ? $args['object_id'] : 0;
141
-			$this->object_type = isset( $args['object_type'] ) ? $args['object_type'] : 'post';
140
+			$this->object_id   = isset( $args[ 'object_id' ] ) && '_' !== $args[ 'object_id' ] ? $args[ 'object_id' ] : 0;
141
+			$this->object_type = isset( $args[ 'object_type' ] ) ? $args[ 'object_type' ] : 'post';
142 142
 
143
-			if ( isset( $args['cmb_id'] ) ) {
144
-				$this->cmb_id = $args['cmb_id'];
143
+			if ( isset( $args[ 'cmb_id' ] ) ) {
144
+				$this->cmb_id = $args[ 'cmb_id' ];
145 145
 			}
146 146
 		}
147 147
 
148
-		$this->args = $this->_set_field_defaults( $args['field_args'] );
148
+		$this->args = $this->_set_field_defaults( $args[ 'field_args' ] );
149 149
 
150 150
 		if ( $this->object_id ) {
151 151
 			$this->value = $this->get_data();
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
 	 * @return mixed             Value of field argument
161 161
 	 */
162 162
 	public function __call( $name, $arguments ) {
163
-		$key = isset( $arguments[0] ) ? $arguments[0] : false;
163
+		$key = isset( $arguments[ 0 ] ) ? $arguments[ 0 ] : false;
164 164
 		return $this->args( $name, $key );
165 165
 	}
166 166
 
@@ -231,9 +231,9 @@  discard block
 block discarded – undo
231 231
 	 */
232 232
 	public function get_data( $field_id = '', $args = array() ) {
233 233
 		if ( $field_id ) {
234
-			$args['field_id'] = $field_id;
234
+			$args[ 'field_id' ] = $field_id;
235 235
 		} else if ( $this->group ) {
236
-			$args['field_id'] = $this->group->id();
236
+			$args[ 'field_id' ] = $this->group->id();
237 237
 		}
238 238
 
239 239
 		$a = $this->data_args( $args );
@@ -274,13 +274,13 @@  discard block
 block discarded – undo
274 274
 		 *
275 275
 		 * @since 2.0.0
276 276
 		 */
277
-		$data = apply_filters( "cmb2_override_{$a['field_id']}_meta_value", $data, $this->object_id, $a, $this );
277
+		$data = apply_filters( "cmb2_override_{$a[ 'field_id' ]}_meta_value", $data, $this->object_id, $a, $this );
278 278
 
279 279
 		// If no override, get value normally
280 280
 		if ( 'cmb2_field_no_override_val' === $data ) {
281
-			$data = 'options-page' === $a['type']
282
-				? cmb2_options( $a['id'] )->get( $a['field_id'] )
283
-				: get_metadata( $a['type'], $a['id'], $a['field_id'], ( $a['single'] || $a['repeat'] ) );
281
+			$data = 'options-page' === $a[ 'type' ]
282
+				? cmb2_options( $a[ 'id' ] )->get( $a[ 'field_id' ] )
283
+				: get_metadata( $a[ 'type' ], $a[ 'id' ], $a[ 'field_id' ], ( $a[ 'single' ] || $a[ 'repeat' ] ) );
284 284
 		}
285 285
 
286 286
 		if ( $this->group ) {
@@ -302,7 +302,7 @@  discard block
 block discarded – undo
302 302
 	public function update_data( $new_value, $single = true ) {
303 303
 		$a = $this->data_args( array( 'single' => $single ) );
304 304
 
305
-		$a['value'] = $a['repeat'] ? array_values( $new_value ) : $new_value;
305
+		$a[ 'value' ] = $a[ 'repeat' ] ? array_values( $new_value ) : $new_value;
306 306
 
307 307
 		/**
308 308
 		 * Filter whether to override saving of meta value.
@@ -338,7 +338,7 @@  discard block
 block discarded – undo
338 338
 		 *
339 339
 		 * @since 2.0.0
340 340
 		 */
341
-		$override = apply_filters( "cmb2_override_{$a['field_id']}_meta_save", $override, $a, $this->args(), $this );
341
+		$override = apply_filters( "cmb2_override_{$a[ 'field_id' ]}_meta_save", $override, $a, $this->args(), $this );
342 342
 
343 343
 		// If override, return that
344 344
 		if ( null !== $override ) {
@@ -346,22 +346,22 @@  discard block
 block discarded – undo
346 346
 		}
347 347
 
348 348
 		// Options page handling (or temp data store)
349
-		if ( 'options-page' === $a['type'] || empty( $a['id'] ) ) {
350
-			return cmb2_options( $a['id'] )->update( $a['field_id'], $a['value'], false, $a['single'] );
349
+		if ( 'options-page' === $a[ 'type' ] || empty( $a[ 'id' ] ) ) {
350
+			return cmb2_options( $a[ 'id' ] )->update( $a[ 'field_id' ], $a[ 'value' ], false, $a[ 'single' ] );
351 351
 		}
352 352
 
353 353
 		// Add metadata if not single
354
-		if ( ! $a['single'] ) {
355
-			return add_metadata( $a['type'], $a['id'], $a['field_id'], $a['value'], false );
354
+		if ( ! $a[ 'single' ] ) {
355
+			return add_metadata( $a[ 'type' ], $a[ 'id' ], $a[ 'field_id' ], $a[ 'value' ], false );
356 356
 		}
357 357
 
358 358
 		// Delete meta if we have an empty array
359
-		if ( is_array( $a['value'] ) && empty( $a['value'] ) ) {
360
-			return delete_metadata( $a['type'], $a['id'], $a['field_id'], $this->value );
359
+		if ( is_array( $a[ 'value' ] ) && empty( $a[ 'value' ] ) ) {
360
+			return delete_metadata( $a[ 'type' ], $a[ 'id' ], $a[ 'field_id' ], $this->value );
361 361
 		}
362 362
 
363 363
 		// Update metadata
364
-		return update_metadata( $a['type'], $a['id'], $a['field_id'], $a['value'] );
364
+		return update_metadata( $a[ 'type' ], $a[ 'id' ], $a[ 'field_id' ], $a[ 'value' ] );
365 365
 	}
366 366
 
367 367
 	/**
@@ -411,19 +411,19 @@  discard block
 block discarded – undo
411 411
 		 * @param array $field_args All field arguments
412 412
 		 * @param CMB2_Field object $field This field object
413 413
 		 */
414
-		$override = apply_filters( "cmb2_override_{$a['field_id']}_meta_remove", $override, $a, $this->args(), $this );
414
+		$override = apply_filters( "cmb2_override_{$a[ 'field_id' ]}_meta_remove", $override, $a, $this->args(), $this );
415 415
 
416 416
 		// If no override, remove as usual
417 417
 		if ( null !== $override ) {
418 418
 			return $override;
419 419
 		}
420 420
 		// Option page handling
421
-		elseif ( 'options-page' === $a['type'] || empty( $a['id'] ) ) {
422
-			return cmb2_options( $a['id'] )->remove( $a['field_id'] );
421
+		elseif ( 'options-page' === $a[ 'type' ] || empty( $a[ 'id' ] ) ) {
422
+			return cmb2_options( $a[ 'id' ] )->remove( $a[ 'field_id' ] );
423 423
 		}
424 424
 
425 425
 		// Remove metadata
426
-		return delete_metadata( $a['type'], $a['id'], $a['field_id'], $old );
426
+		return delete_metadata( $a[ 'type' ], $a[ 'id' ], $a[ 'field_id' ], $old );
427 427
 	}
428 428
 
429 429
 	/**
@@ -895,7 +895,7 @@  discard block
 block discarded – undo
895 895
 
896 896
 		foreach ( $conditional_classes as $class => $condition ) {
897 897
 			if ( $condition ) {
898
-				$classes[] = $class;
898
+				$classes[ ] = $class;
899 899
 			}
900 900
 		}
901 901
 
@@ -904,7 +904,7 @@  discard block
 block discarded – undo
904 904
 		}
905 905
 
906 906
 		if ( $added_classes ) {
907
-			$classes[] = esc_attr( $added_classes );
907
+			$classes[ ] = esc_attr( $added_classes );
908 908
 		}
909 909
 
910 910
 		/**
@@ -1006,10 +1006,10 @@  discard block
 block discarded – undo
1006 1006
 	public function string( $text_key, $fallback ) {
1007 1007
 		// If null, populate with our field strings values.
1008 1008
 		if ( null === $this->strings ) {
1009
-			$this->strings = (array) $this->args['text'];
1009
+			$this->strings = (array) $this->args[ 'text' ];
1010 1010
 
1011
-			if ( is_callable( $this->args['text_cb'] ) ) {
1012
-				$strings = call_user_func( $this->args['text_cb'], $this );
1011
+			if ( is_callable( $this->args[ 'text_cb' ] ) ) {
1012
+				$strings = call_user_func( $this->args[ 'text_cb' ], $this );
1013 1013
 
1014 1014
 				if ( $strings && is_array( $strings ) ) {
1015 1015
 					$this->strings += $strings;
@@ -1043,10 +1043,10 @@  discard block
 block discarded – undo
1043 1043
 			return $this->field_options;
1044 1044
 		}
1045 1045
 
1046
-		$this->field_options = (array) $this->args['options'];
1046
+		$this->field_options = (array) $this->args[ 'options' ];
1047 1047
 
1048
-		if ( is_callable( $this->args['options_cb'] ) ) {
1049
-			$options = call_user_func( $this->args['options_cb'], $this );
1048
+		if ( is_callable( $this->args[ 'options_cb' ] ) ) {
1049
+			$options = call_user_func( $this->args[ 'options_cb' ], $this );
1050 1050
 
1051 1051
 			if ( $options && is_array( $options ) ) {
1052 1052
 				$this->field_options += $options;
@@ -1067,7 +1067,7 @@  discard block
 block discarded – undo
1067 1067
 	 */
1068 1068
 	public function add_js_dependencies( $dependencies = array() ) {
1069 1069
 		foreach ( (array) $dependencies as $dependency ) {
1070
-			$this->args['js_dependencies'][ $dependency ] = $dependency;
1070
+			$this->args[ 'js_dependencies' ][ $dependency ] = $dependency;
1071 1071
 		}
1072 1072
 
1073 1073
 		CMB2_JS::add_dependencies( $dependencies );
@@ -1081,17 +1081,17 @@  discard block
 block discarded – undo
1081 1081
 	 * @return mixed  Default field value
1082 1082
 	 */
1083 1083
 	public function get_default() {
1084
-		if ( null !== $this->args['default'] ) {
1085
-			return $this->args['default'];
1084
+		if ( null !== $this->args[ 'default' ] ) {
1085
+			return $this->args[ 'default' ];
1086 1086
 		}
1087 1087
 
1088
-		$param = is_callable( $this->args['default_cb'] ) ? 'default_cb' : 'default';
1088
+		$param = is_callable( $this->args[ 'default_cb' ] ) ? 'default_cb' : 'default';
1089 1089
 		$default = $this->get_param_callback_result( $param, false );
1090 1090
 
1091 1091
 		// Allow a filter override of the default value
1092
-		$this->args['default'] = apply_filters( 'cmb2_default_filter', $default, $this );
1092
+		$this->args[ 'default' ] = apply_filters( 'cmb2_default_filter', $default, $this );
1093 1093
 
1094
-		return $this->args['default'];
1094
+		return $this->args[ 'default' ];
1095 1095
 	}
1096 1096
 
1097 1097
 	/**
@@ -1118,70 +1118,70 @@  discard block
 block discarded – undo
1118 1118
 			'default_cb'        => '',
1119 1119
 			'select_all_button' => true,
1120 1120
 			'multiple'          => false,
1121
-			'repeatable'        => isset( $args['type'] ) && 'group' == $args['type'],
1121
+			'repeatable'        => isset( $args[ 'type' ] ) && 'group' == $args[ 'type' ],
1122 1122
 			'inline'            => false,
1123 1123
 			'on_front'          => true,
1124 1124
 			'show_names'        => true,
1125 1125
 			'date_format'       => 'm\/d\/Y',
1126 1126
 			'time_format'       => 'h:i A',
1127
-			'description'       => isset( $args['desc'] ) ? $args['desc'] : '',
1128
-			'preview_size'      => 'file' == $args['type'] ? array( 350, 350 ) : array( 50, 50 ),
1127
+			'description'       => isset( $args[ 'desc' ] ) ? $args[ 'desc' ] : '',
1128
+			'preview_size'      => 'file' == $args[ 'type' ] ? array( 350, 350 ) : array( 50, 50 ),
1129 1129
 			'render_row_cb'     => array( $this, 'render_field_callback' ),
1130
-			'label_cb'          => 'title' != $args['type'] ? array( $this, 'label' ) : '',
1130
+			'label_cb'          => 'title' != $args[ 'type' ] ? array( $this, 'label' ) : '',
1131 1131
 			'show_in_rest'      => null,
1132 1132
 			'js_dependencies'   => array(),
1133 1133
 		) );
1134 1134
 
1135 1135
 		// default param can be passed a callback as well
1136
-		if ( is_callable( $args['default'] ) ) {
1137
-			$args['default_cb'] = $args['default'];
1138
-			$args['default'] = null;
1136
+		if ( is_callable( $args[ 'default' ] ) ) {
1137
+			$args[ 'default_cb' ] = $args[ 'default' ];
1138
+			$args[ 'default' ] = null;
1139 1139
 		}
1140 1140
 
1141
-		$args['repeatable'] = $args['repeatable'] && ! $this->repeatable_exception( $args['type'] );
1142
-		$args['inline']     = $args['inline'] || false !== stripos( $args['type'], '_inline' );
1141
+		$args[ 'repeatable' ] = $args[ 'repeatable' ] && ! $this->repeatable_exception( $args[ 'type' ] );
1142
+		$args[ 'inline' ]     = $args[ 'inline' ] || false !== stripos( $args[ 'type' ], '_inline' );
1143 1143
 
1144 1144
 		// options param can be passed a callback as well
1145
-		if ( is_callable( $args['options'] ) ) {
1146
-			$args['options_cb'] = $args['options'];
1147
-			$args['options'] = array();
1145
+		if ( is_callable( $args[ 'options' ] ) ) {
1146
+			$args[ 'options_cb' ] = $args[ 'options' ];
1147
+			$args[ 'options' ] = array();
1148 1148
 		}
1149 1149
 
1150
-		$args['options']    = 'group' == $args['type'] ? wp_parse_args( $args['options'], array(
1150
+		$args[ 'options' ] = 'group' == $args[ 'type' ] ? wp_parse_args( $args[ 'options' ], array(
1151 1151
 			'add_button'    => __( 'Add Group', 'cmb2' ),
1152 1152
 			'remove_button' => __( 'Remove Group', 'cmb2' ),
1153
-		) ) : $args['options'];
1153
+		) ) : $args[ 'options' ];
1154 1154
 
1155
-		$args['_id']        = $args['id'];
1156
-		$args['_name']      = $args['id'];
1155
+		$args[ '_id' ]        = $args[ 'id' ];
1156
+		$args[ '_name' ]      = $args[ 'id' ];
1157 1157
 
1158 1158
 		if ( $this->group ) {
1159 1159
 
1160
-			$args['id']    = $this->group->args( 'id' ) . '_' . $this->group->index . '_' . $args['id'];
1161
-			$args['_name'] = $this->group->args( 'id' ) . '[' . $this->group->index . '][' . $args['_name'] . ']';
1160
+			$args[ 'id' ]    = $this->group->args( 'id' ) . '_' . $this->group->index . '_' . $args[ 'id' ];
1161
+			$args[ '_name' ] = $this->group->args( 'id' ) . '[' . $this->group->index . '][' . $args[ '_name' ] . ']';
1162 1162
 		}
1163 1163
 
1164
-		if ( 'wysiwyg' == $args['type'] ) {
1165
-			$args['id'] = strtolower( str_ireplace( '-', '_', $args['id'] ) );
1166
-			$args['options']['textarea_name'] = $args['_name'];
1164
+		if ( 'wysiwyg' == $args[ 'type' ] ) {
1165
+			$args[ 'id' ] = strtolower( str_ireplace( '-', '_', $args[ 'id' ] ) );
1166
+			$args[ 'options' ][ 'textarea_name' ] = $args[ '_name' ];
1167 1167
 		}
1168 1168
 
1169 1169
 		$option_types = apply_filters( 'cmb2_all_or_nothing_types', array( 'select', 'radio', 'radio_inline', 'taxonomy_select', 'taxonomy_radio', 'taxonomy_radio_inline' ), $this );
1170 1170
 
1171
-		if ( in_array( $args['type'], $option_types, true ) ) {
1171
+		if ( in_array( $args[ 'type' ], $option_types, true ) ) {
1172 1172
 
1173
-			$args['show_option_none'] = isset( $args['show_option_none'] ) ? $args['show_option_none'] : null;
1174
-			$args['show_option_none'] = true === $args['show_option_none'] ? __( 'None', 'cmb2' ) : $args['show_option_none'];
1173
+			$args[ 'show_option_none' ] = isset( $args[ 'show_option_none' ] ) ? $args[ 'show_option_none' ] : null;
1174
+			$args[ 'show_option_none' ] = true === $args[ 'show_option_none' ] ? __( 'None', 'cmb2' ) : $args[ 'show_option_none' ];
1175 1175
 
1176
-			if ( null === $args['show_option_none'] ) {
1177
-				$off_by_default = in_array( $args['type'], array( 'select', 'radio', 'radio_inline' ), true );
1178
-				$args['show_option_none'] = $off_by_default ? false : __( 'None', 'cmb2' );
1176
+			if ( null === $args[ 'show_option_none' ] ) {
1177
+				$off_by_default = in_array( $args[ 'type' ], array( 'select', 'radio', 'radio_inline' ), true );
1178
+				$args[ 'show_option_none' ] = $off_by_default ? false : __( 'None', 'cmb2' );
1179 1179
 			}
1180 1180
 
1181 1181
 		}
1182 1182
 
1183
-		$args['has_supporting_data'] = in_array(
1184
-			$args['type'],
1183
+		$args[ 'has_supporting_data' ] = in_array(
1184
+			$args[ 'type' ],
1185 1185
 			array(
1186 1186
 				// CMB2_Sanitize::_save_file_id_value()/CMB2_Sanitize::_get_group_file_value_array()
1187 1187
 				'file',
@@ -1213,10 +1213,10 @@  discard block
 block discarded – undo
1213 1213
 			'cmb_id'      => $this->cmb_id,
1214 1214
 		);
1215 1215
 
1216
-		if ( isset( $field_args['field_args'] ) ) {
1216
+		if ( isset( $field_args[ 'field_args' ] ) ) {
1217 1217
 			$args = wp_parse_args( $field_args, $args );
1218 1218
 		} else {
1219
-			$args['field_args'] = wp_parse_args( $field_args, $this->args );
1219
+			$args[ 'field_args' ] = wp_parse_args( $field_args, $this->args );
1220 1220
 		}
1221 1221
 
1222 1222
 		return new CMB2_Field( $args );
Please login to merge, or discard this patch.