Completed
Pull Request — trunk (#541)
by Justin
06:39
created
includes/CMB2_Types.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -162,7 +162,7 @@
 block discarded – undo
162 162
 	 * @return string               String of attributes for form element
163 163
 	 */
164 164
 	public function concat_attrs( $attrs, $attr_exclude = array() ) {
165
-		$attr_exclude[] = 'rendered';
165
+		$attr_exclude[ ] = 'rendered';
166 166
 		$attributes = '';
167 167
 		foreach ( $attrs as $attr => $val ) {
168 168
 			$excluded = in_array( $attr, (array) $attr_exclude, true );
Please login to merge, or discard this patch.
includes/types/CMB2_Type_Text.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -50,12 +50,12 @@
 block discarded – undo
50 50
 			'js_dependencies' => array(),
51 51
 		), $args );
52 52
 
53
-		if ( ! empty( $a['js_dependencies'] ) ) {
54
-			$this->field->add_js_dependencies( $a['js_dependencies'] );
53
+		if ( ! empty( $a[ 'js_dependencies' ] ) ) {
54
+			$this->field->add_js_dependencies( $a[ 'js_dependencies' ] );
55 55
 		}
56 56
 
57 57
 		return $this->rendered(
58
-			sprintf( '<input%s/>%s', $this->concat_attrs( $a, array( 'desc', 'js_dependencies' ) ), $a['desc'] )
58
+			sprintf( '<input%s/>%s', $this->concat_attrs( $a, array( 'desc', 'js_dependencies' ) ), $a[ 'desc' ] )
59 59
 		);
60 60
 	}
61 61
 }
Please login to merge, or discard this patch.
includes/types/CMB2_Type_File.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 		$output     = '';
22 22
 
23 23
 		// if options array and 'url' => false, then hide the url field
24
-		$input_type = array_key_exists( 'url', $options ) && false === $options['url'] ? 'hidden' : 'text';
24
+		$input_type = array_key_exists( 'url', $options ) && false === $options[ 'url' ] ? 'hidden' : 'text';
25 25
 
26 26
 		$output .= parent::render( array(
27 27
 			'type'  => $input_type,
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 				if ( $_id_value ) {
72 72
 					$image = wp_get_attachment_image( $_id_value, $img_size, null, array( 'class' => 'cmb-file-field-image' ) );
73 73
 				} else {
74
-					$size = is_array( $img_size ) ? $img_size[0] : 350;
74
+					$size = is_array( $img_size ) ? $img_size[ 0 ] : 350;
75 75
 					$image = '<img style="max-width: ' . absint( $size ) . 'px; width: 100%; height: auto;" src="' . $meta_value . '" alt="" />';
76 76
 				}
77 77
 
Please login to merge, or discard this patch.
includes/CMB2.php 2 patches
Doc Comments   +4 added lines, -3 removed lines patch added patch discarded remove patch
@@ -409,6 +409,7 @@  discard block
 block discarded – undo
409 409
 	 * Add a hidden field to the list of hidden fields to be rendered later
410 410
 	 * @since 2.0.0
411 411
 	 * @param array  $field_args Array of field arguments to be passed to CMB2_Field
412
+	 * @param CMB2_Field $field_group
412 413
 	 */
413 414
 	public function add_hidden_field( $field_args, $field_group = null ) {
414 415
 		if ( isset( $field_args['field_args'] ) ) {
@@ -610,7 +611,7 @@  discard block
 block discarded – undo
610 611
 	/**
611 612
 	 * Save a repeatable group
612 613
 	 * @since  1.x.x
613
-	 * @param  array $field_group CMB2_Field group field object
614
+	 * @param  CMB2_Field $field_group CMB2_Field group field object
614 615
 	 * @return mixed              Return of CMB2_Field::update_data()
615 616
 	 */
616 617
 	public function save_group_field( $field_group ) {
@@ -910,7 +911,7 @@  discard block
 block discarded – undo
910 911
 	 * @param  mixed  $field_id     Field (or group field) ID
911 912
 	 * @param  mixed  $field_args   Array of field arguments
912 913
 	 * @param  mixed  $sub_field_id Sub field ID (if field_group exists)
913
-	 * @param  mixed  $field_group  If a sub-field, will be the parent group CMB2_Field object
914
+	 * @param  CMB2_Field|null  $field_group  If a sub-field, will be the parent group CMB2_Field object
914 915
 	 * @return array                Array of CMB2_Field arguments
915 916
 	 */
916 917
 	public function get_field_args( $field_id, $field_args, $sub_field_id, $field_group ) {
@@ -997,7 +998,7 @@  discard block
 block discarded – undo
997 998
 	 * @since  2.0.0
998 999
 	 * @param  array  $field           Metabox field config array
999 1000
 	 * @param  int    $position        (optional) Position of metabox. 1 for first, etc
1000
-	 * @return mixed                   Field id or false
1001
+	 * @return string                   Field id or false
1001 1002
 	 */
1002 1003
 	public function add_field( array $field, $position = 0 ) {
1003 1004
 		if ( ! is_array( $field ) || ! array_key_exists( 'id', $field ) ) {
Please login to merge, or discard this patch.
Spacing   +63 added lines, -63 removed lines patch added patch discarded remove patch
@@ -119,19 +119,19 @@  discard block
 block discarded – undo
119 119
 	 */
120 120
 	public function __construct( $meta_box, $object_id = 0 ) {
121 121
 
122
-		if ( empty( $meta_box['id'] ) ) {
122
+		if ( empty( $meta_box[ 'id' ] ) ) {
123 123
 			wp_die( __( 'Metabox configuration is required to have an ID parameter', 'cmb2' ) );
124 124
 		}
125 125
 
126 126
 		$this->meta_box = wp_parse_args( $meta_box, $this->mb_defaults );
127
-		$this->meta_box['fields'] = array();
127
+		$this->meta_box[ 'fields' ] = array();
128 128
 
129 129
 		$this->object_id( $object_id );
130 130
 		$this->mb_object_type();
131
-		$this->cmb_id = $meta_box['id'];
131
+		$this->cmb_id = $meta_box[ 'id' ];
132 132
 
133
-		if ( ! empty( $meta_box['fields'] ) && is_array( $meta_box['fields'] ) ) {
134
-			$this->add_fields( $meta_box['fields'] );
133
+		if ( ! empty( $meta_box[ 'fields' ] ) && is_array( $meta_box[ 'fields' ] ) ) {
134
+			$this->add_fields( $meta_box[ 'fields' ] );
135 135
 		}
136 136
 
137 137
 		CMB2_Boxes::add( $this );
@@ -262,22 +262,22 @@  discard block
 block discarded – undo
262 262
 	 * @return mixed CMB2_Field object if successful.
263 263
 	 */
264 264
 	public function render_field( $field_args ) {
265
-		$field_args['context'] = $this->prop( 'context' );
265
+		$field_args[ 'context' ] = $this->prop( 'context' );
266 266
 
267
-		if ( 'group' == $field_args['type'] ) {
267
+		if ( 'group' == $field_args[ 'type' ] ) {
268 268
 
269
-			if ( ! isset( $field_args['show_names'] ) ) {
270
-				$field_args['show_names'] = $this->prop( 'show_names' );
269
+			if ( ! isset( $field_args[ 'show_names' ] ) ) {
270
+				$field_args[ 'show_names' ] = $this->prop( 'show_names' );
271 271
 			}
272 272
 			$field = $this->render_group( $field_args );
273 273
 
274
-		} elseif ( 'hidden' == $field_args['type'] && $this->get_field( $field_args )->should_show() ) {
274
+		} elseif ( 'hidden' == $field_args[ 'type' ] && $this->get_field( $field_args )->should_show() ) {
275 275
 			// Save rendering for after the metabox
276 276
 			$field = $this->add_hidden_field( $field_args );
277 277
 
278 278
 		} else {
279 279
 
280
-			$field_args['show_names'] = $this->prop( 'show_names' );
280
+			$field_args[ 'show_names' ] = $this->prop( 'show_names' );
281 281
 
282 282
 			// Render default fields
283 283
 			$field = $this->get_field( $field_args )->render_field();
@@ -293,7 +293,7 @@  discard block
 block discarded – undo
293 293
 	 */
294 294
 	public function render_group( $args ) {
295 295
 
296
-		if ( ! isset( $args['id'], $args['fields'] ) || ! is_array( $args['fields'] ) ) {
296
+		if ( ! isset( $args[ 'id' ], $args[ 'fields' ] ) || ! is_array( $args[ 'fields' ] ) ) {
297 297
 			return;
298 298
 		}
299 299
 
@@ -375,15 +375,15 @@  discard block
 block discarded – undo
375 375
 			<div class="inside cmb-td cmb-nested cmb-field-list">';
376 376
 				// Loop and render repeatable group fields
377 377
 				foreach ( array_values( $field_group->args( 'fields' ) ) as $field_args ) {
378
-					if ( 'hidden' == $field_args['type'] ) {
378
+					if ( 'hidden' == $field_args[ 'type' ] ) {
379 379
 
380 380
 						// Save rendering for after the metabox
381 381
 						$this->add_hidden_field( $field_args, $field_group );
382 382
 
383 383
 					} else {
384 384
 
385
-						$field_args['show_names'] = $field_group->args( 'show_names' );
386
-						$field_args['context']    = $field_group->args( 'context' );
385
+						$field_args[ 'show_names' ] = $field_group->args( 'show_names' );
386
+						$field_args[ 'context' ]    = $field_group->args( 'context' );
387 387
 
388 388
 						$field = $this->get_field( $field_args, $field_group )->render_field();
389 389
 					}
@@ -411,14 +411,14 @@  discard block
 block discarded – undo
411 411
 	 * @param array  $field_args Array of field arguments to be passed to CMB2_Field
412 412
 	 */
413 413
 	public function add_hidden_field( $field_args, $field_group = null ) {
414
-		if ( isset( $field_args['field_args'] ) ) {
414
+		if ( isset( $field_args[ 'field_args' ] ) ) {
415 415
 			// For back-compatibility.
416 416
 			$field = new CMB2_Field( $field_args );
417 417
 		} else {
418 418
 			$field = $this->get_new_field( $field_args, $field_group );
419 419
 		}
420 420
 
421
-		$this->hidden_fields[] = new CMB2_Types( $field );
421
+		$this->hidden_fields[ ] = new CMB2_Types( $field );
422 422
 
423 423
 		return $field;
424 424
 	}
@@ -515,11 +515,11 @@  discard block
 block discarded – undo
515 515
 	 */
516 516
 	public function process_field( $field_args ) {
517 517
 
518
-		switch ( $field_args['type'] ) {
518
+		switch ( $field_args[ 'type' ] ) {
519 519
 
520 520
 			case 'group':
521 521
 				if ( $this->save_group( $field_args ) ) {
522
-					$this->updated[] = $field_args['id'];
522
+					$this->updated[ ] = $field_args[ 'id' ];
523 523
 				}
524 524
 
525 525
 				break;
@@ -533,7 +533,7 @@  discard block
 block discarded – undo
533 533
 				$field = $this->get_new_field( $field_args );
534 534
 
535 535
 				if ( $field->save_field_from_data( $this->data_to_save ) ) {
536
-					$this->updated[] = $field->id();
536
+					$this->updated[ ] = $field->id();
537 537
 				}
538 538
 
539 539
 				break;
@@ -600,7 +600,7 @@  discard block
 block discarded – undo
600 600
 	 * @return mixed        Return of CMB2_Field::update_data()
601 601
 	 */
602 602
 	public function save_group( $args ) {
603
-		if ( ! isset( $args['id'], $args['fields'] ) || ! is_array( $args['fields'] ) ) {
603
+		if ( ! isset( $args[ 'id' ], $args[ 'fields' ] ) || ! is_array( $args[ 'fields' ] ) ) {
604 604
 			return;
605 605
 		}
606 606
 
@@ -648,16 +648,16 @@  discard block
 block discarded – undo
648 648
 						$_new_val = array();
649 649
 						foreach ( $new_val as $group_index => $grouped_data ) {
650 650
 							// Add the supporting data to the $saved array stack
651
-							$saved[ $field_group->index ][ $grouped_data['supporting_field_id'] ][] = $grouped_data['supporting_field_value'];
651
+							$saved[ $field_group->index ][ $grouped_data[ 'supporting_field_id' ] ][ ] = $grouped_data[ 'supporting_field_value' ];
652 652
 							// Reset var to the actual value
653
-							$_new_val[ $group_index ] = $grouped_data['value'];
653
+							$_new_val[ $group_index ] = $grouped_data[ 'value' ];
654 654
 						}
655 655
 						$new_val = $_new_val;
656 656
 					} else {
657 657
 						// Add the supporting data to the $saved array stack
658
-						$saved[ $field_group->index ][ $new_val['supporting_field_id'] ] = $new_val['supporting_field_value'];
658
+						$saved[ $field_group->index ][ $new_val[ 'supporting_field_id' ] ] = $new_val[ 'supporting_field_value' ];
659 659
 						// Reset var to the actual value
660
-						$new_val = $new_val['value'];
660
+						$new_val = $new_val[ 'value' ];
661 661
 					}
662 662
 				}
663 663
 
@@ -670,7 +670,7 @@  discard block
 block discarded – undo
670 670
 				$is_removed = ( empty( $new_val ) && ! empty( $old_val ) );
671 671
 				// Compare values and add to `$updated` array
672 672
 				if ( $is_updated || $is_removed ) {
673
-					$this->updated[] = $base_id . '::' . $field_group->index . '::' . $sub_id;
673
+					$this->updated[ ] = $base_id . '::' . $field_group->index . '::' . $sub_id;
674 674
 				}
675 675
 
676 676
 				// Add to `$saved` array
@@ -705,22 +705,22 @@  discard block
 block discarded – undo
705 705
 		// Try to get our object ID from the global space
706 706
 		switch ( $this->object_type() ) {
707 707
 			case 'user':
708
-				$object_id = isset( $_REQUEST['user_id'] ) ? $_REQUEST['user_id'] : $object_id;
709
-				$object_id = ! $object_id && 'user-new.php' != $pagenow && isset( $GLOBALS['user_ID'] ) ? $GLOBALS['user_ID'] : $object_id;
708
+				$object_id = isset( $_REQUEST[ 'user_id' ] ) ? $_REQUEST[ 'user_id' ] : $object_id;
709
+				$object_id = ! $object_id && 'user-new.php' != $pagenow && isset( $GLOBALS[ 'user_ID' ] ) ? $GLOBALS[ 'user_ID' ] : $object_id;
710 710
 				break;
711 711
 
712 712
 			case 'comment':
713
-				$object_id = isset( $_REQUEST['c'] ) ? $_REQUEST['c'] : $object_id;
714
-				$object_id = ! $object_id && isset( $GLOBALS['comments']->comment_ID ) ? $GLOBALS['comments']->comment_ID : $object_id;
713
+				$object_id = isset( $_REQUEST[ 'c' ] ) ? $_REQUEST[ 'c' ] : $object_id;
714
+				$object_id = ! $object_id && isset( $GLOBALS[ 'comments' ]->comment_ID ) ? $GLOBALS[ 'comments' ]->comment_ID : $object_id;
715 715
 				break;
716 716
 
717 717
 			case 'term':
718
-				$object_id = isset( $_REQUEST['tag_ID'] ) ? $_REQUEST['tag_ID'] : $object_id;
718
+				$object_id = isset( $_REQUEST[ 'tag_ID' ] ) ? $_REQUEST[ 'tag_ID' ] : $object_id;
719 719
 				break;
720 720
 
721 721
 			default:
722
-				$object_id = isset( $GLOBALS['post']->ID ) ? $GLOBALS['post']->ID : $object_id;
723
-				$object_id = isset( $_REQUEST['post'] ) ? $_REQUEST['post'] : $object_id;
722
+				$object_id = isset( $GLOBALS[ 'post' ]->ID ) ? $GLOBALS[ 'post' ]->ID : $object_id;
723
+				$object_id = isset( $_REQUEST[ 'post' ] ) ? $_REQUEST[ 'post' ] : $object_id;
724 724
 				break;
725 725
 		}
726 726
 
@@ -796,7 +796,7 @@  discard block
 block discarded – undo
796 796
 	 * @return boolean True/False
797 797
 	 */
798 798
 	public function is_options_page_mb() {
799
-		return ( isset( $this->meta_box['show_on']['key'] ) && 'options-page' === $this->meta_box['show_on']['key'] || array_key_exists( 'options-page', $this->meta_box['show_on'] ) );
799
+		return ( isset( $this->meta_box[ 'show_on' ][ 'key' ] ) && 'options-page' === $this->meta_box[ 'show_on' ][ 'key' ] || array_key_exists( 'options-page', $this->meta_box[ 'show_on' ] ) );
800 800
 	}
801 801
 
802 802
 	/**
@@ -883,7 +883,7 @@  discard block
 block discarded – undo
883 883
 			return $field;
884 884
 		}
885 885
 
886
-		$field_id = is_string( $field ) ? $field : $field['id'];
886
+		$field_id = is_string( $field ) ? $field : $field[ 'id' ];
887 887
 
888 888
 		$parent_field_id = ! empty( $field_group ) ? $field_group->id() : '';
889 889
 		$ids = $this->get_field_ids( $field_id, $parent_field_id, true );
@@ -919,16 +919,16 @@  discard block
 block discarded – undo
919 919
 		if ( $field_group && ( $sub_field_id || 0 === $sub_field_id ) ) {
920 920
 
921 921
 			// Update the fields array w/ any modified properties inherited from the group field
922
-			$this->meta_box['fields'][ $field_id ]['fields'][ $sub_field_id ] = $field_args;
922
+			$this->meta_box[ 'fields' ][ $field_id ][ 'fields' ][ $sub_field_id ] = $field_args;
923 923
 
924 924
 			return $this->get_default_args( $field_args, $field_group );
925 925
 		}
926 926
 
927 927
 		if ( is_array( $field_args ) ) {
928
-			$this->meta_box['fields'][ $field_id ] = array_merge( $field_args, $this->meta_box['fields'][ $field_id ] );
928
+			$this->meta_box[ 'fields' ][ $field_id ] = array_merge( $field_args, $this->meta_box[ 'fields' ][ $field_id ] );
929 929
 		}
930 930
 
931
-		return $this->get_default_args( $this->meta_box['fields'][ $field_id ] );
931
+		return $this->get_default_args( $this->meta_box[ 'fields' ][ $field_id ] );
932 932
 	}
933 933
 
934 934
 	/**
@@ -978,8 +978,8 @@  discard block
 block discarded – undo
978 978
 
979 979
 			$sub_fields = false;
980 980
 			if ( array_key_exists( 'fields', $field ) ) {
981
-				$sub_fields = $field['fields'];
982
-				unset( $field['fields'] );
981
+				$sub_fields = $field[ 'fields' ];
982
+				unset( $field[ 'fields' ] );
983 983
 			}
984 984
 
985 985
 			$field_id = $parent_field_id
@@ -1004,18 +1004,18 @@  discard block
 block discarded – undo
1004 1004
 			return false;
1005 1005
 		}
1006 1006
 
1007
-		if ( 'oembed' === $field['type'] ) {
1007
+		if ( 'oembed' === $field[ 'type' ] ) {
1008 1008
 			// Initiate oembed Ajax hooks
1009 1009
 			cmb2_ajax();
1010 1010
 		}
1011 1011
 
1012 1012
 		$this->_add_field_to_array(
1013 1013
 			$field,
1014
-			$this->meta_box['fields'],
1014
+			$this->meta_box[ 'fields' ],
1015 1015
 			$position
1016 1016
 		);
1017 1017
 
1018
-		return $field['id'];
1018
+		return $field[ 'id' ];
1019 1019
 	}
1020 1020
 
1021 1021
 	/**
@@ -1027,27 +1027,27 @@  discard block
 block discarded – undo
1027 1027
 	 * @return mixed                   Array of parent/field ids or false
1028 1028
 	 */
1029 1029
 	public function add_group_field( $parent_field_id, array $field, $position = 0 ) {
1030
-		if ( ! array_key_exists( $parent_field_id, $this->meta_box['fields'] ) ) {
1030
+		if ( ! array_key_exists( $parent_field_id, $this->meta_box[ 'fields' ] ) ) {
1031 1031
 			return false;
1032 1032
 		}
1033 1033
 
1034
-		$parent_field = $this->meta_box['fields'][ $parent_field_id ];
1034
+		$parent_field = $this->meta_box[ 'fields' ][ $parent_field_id ];
1035 1035
 
1036
-		if ( 'group' !== $parent_field['type'] ) {
1036
+		if ( 'group' !== $parent_field[ 'type' ] ) {
1037 1037
 			return false;
1038 1038
 		}
1039 1039
 
1040
-		if ( ! isset( $parent_field['fields'] ) ) {
1041
-			$this->meta_box['fields'][ $parent_field_id ]['fields'] = array();
1040
+		if ( ! isset( $parent_field[ 'fields' ] ) ) {
1041
+			$this->meta_box[ 'fields' ][ $parent_field_id ][ 'fields' ] = array();
1042 1042
 		}
1043 1043
 
1044 1044
 		$this->_add_field_to_array(
1045 1045
 			$field,
1046
-			$this->meta_box['fields'][ $parent_field_id ]['fields'],
1046
+			$this->meta_box[ 'fields' ][ $parent_field_id ][ 'fields' ],
1047 1047
 			$position
1048 1048
 		);
1049 1049
 
1050
-		return array( $parent_field_id, $field['id'] );
1050
+		return array( $parent_field_id, $field[ 'id' ] );
1051 1051
 	}
1052 1052
 
1053 1053
 	/**
@@ -1059,9 +1059,9 @@  discard block
 block discarded – undo
1059 1059
 	 */
1060 1060
 	protected function _add_field_to_array( $field, &$fields, $position = 0 ) {
1061 1061
 		if ( $position ) {
1062
-			cmb2_utils()->array_insert( $fields, array( $field['id'] => $field ), $position );
1062
+			cmb2_utils()->array_insert( $fields, array( $field[ 'id' ] => $field ), $position );
1063 1063
 		} else {
1064
-			$fields[ $field['id'] ] = $field;
1064
+			$fields[ $field[ 'id' ] ] = $field;
1065 1065
 		}
1066 1066
 	}
1067 1067
 
@@ -1084,15 +1084,15 @@  discard block
 block discarded – undo
1084 1084
 		unset( $this->fields[ implode( '', $ids ) ] );
1085 1085
 
1086 1086
 		if ( ! $sub_field_id ) {
1087
-			unset( $this->meta_box['fields'][ $field_id ] );
1087
+			unset( $this->meta_box[ 'fields' ][ $field_id ] );
1088 1088
 			return true;
1089 1089
 		}
1090 1090
 
1091
-		if ( isset( $this->fields[ $field_id ]->args['fields'][ $sub_field_id ] ) ) {
1092
-			unset( $this->fields[ $field_id ]->args['fields'][ $sub_field_id ] );
1091
+		if ( isset( $this->fields[ $field_id ]->args[ 'fields' ][ $sub_field_id ] ) ) {
1092
+			unset( $this->fields[ $field_id ]->args[ 'fields' ][ $sub_field_id ] );
1093 1093
 		}
1094
-		if ( isset( $this->meta_box['fields'][ $field_id ]['fields'][ $sub_field_id ] ) ) {
1095
-			unset( $this->meta_box['fields'][ $field_id ]['fields'][ $sub_field_id ] );
1094
+		if ( isset( $this->meta_box[ 'fields' ][ $field_id ][ 'fields' ][ $sub_field_id ] ) ) {
1095
+			unset( $this->meta_box[ 'fields' ][ $field_id ][ 'fields' ][ $sub_field_id ] );
1096 1096
 		}
1097 1097
 		return true;
1098 1098
 	}
@@ -1116,11 +1116,11 @@  discard block
 block discarded – undo
1116 1116
 		list( $field_id, $sub_field_id ) = $ids;
1117 1117
 
1118 1118
 		if ( ! $sub_field_id ) {
1119
-			$this->meta_box['fields'][ $field_id ][ $property ] = $value;
1119
+			$this->meta_box[ 'fields' ][ $field_id ][ $property ] = $value;
1120 1120
 			return $field_id;
1121 1121
 		}
1122 1122
 
1123
-		$this->meta_box['fields'][ $field_id ]['fields'][ $sub_field_id ][ $property ] = $value;
1123
+		$this->meta_box[ 'fields' ][ $field_id ][ 'fields' ][ $sub_field_id ][ $property ] = $value;
1124 1124
 		return $field_id;
1125 1125
 	}
1126 1126
 
@@ -1134,7 +1134,7 @@  discard block
 block discarded – undo
1134 1134
 	public function get_field_ids( $field_id, $parent_field_id = '' ) {
1135 1135
 		$sub_field_id = $parent_field_id ? $field_id : '';
1136 1136
 		$field_id     = $parent_field_id ? $parent_field_id : $field_id;
1137
-		$fields       =& $this->meta_box['fields'];
1137
+		$fields       = & $this->meta_box[ 'fields' ];
1138 1138
 
1139 1139
 		if ( ! array_key_exists( $field_id, $fields ) ) {
1140 1140
 			$field_id = $this->search_old_school_array( $field_id, $fields );
@@ -1148,12 +1148,12 @@  discard block
 block discarded – undo
1148 1148
 			return array( $field_id, $sub_field_id );
1149 1149
 		}
1150 1150
 
1151
-		if ( 'group' !== $fields[ $field_id ]['type'] ) {
1151
+		if ( 'group' !== $fields[ $field_id ][ 'type' ] ) {
1152 1152
 			return false;
1153 1153
 		}
1154 1154
 
1155
-		if ( ! array_key_exists( $sub_field_id, $fields[ $field_id ]['fields'] ) ) {
1156
-			$sub_field_id = $this->search_old_school_array( $sub_field_id, $fields[ $field_id ]['fields'] );
1155
+		if ( ! array_key_exists( $sub_field_id, $fields[ $field_id ][ 'fields' ] ) ) {
1156
+			$sub_field_id = $this->search_old_school_array( $sub_field_id, $fields[ $field_id ][ 'fields' ] );
1157 1157
 		}
1158 1158
 
1159 1159
 		return false === $sub_field_id ? false : array( $field_id, $sub_field_id );
Please login to merge, or discard this patch.
includes/CMB2_Field.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -735,7 +735,7 @@  discard block
 block discarded – undo
735 735
 	 * Return a formatted timestamp for a field
736 736
 	 * @since  2.0.0
737 737
 	 * @param  string $format     Either date_format or time_format
738
-	 * @param  string $meta_value Optional meta value to check
738
+	 * @param  integer $meta_value Optional meta value to check
739 739
 	 * @return string             Formatted date
740 740
 	 */
741 741
 	public function get_timestamp_format( $format = 'date_format', $meta_value = 0 ) {
@@ -1007,7 +1007,7 @@  discard block
 block discarded – undo
1007 1007
 	 * Retrieve options args. Calls options_cb if it exists.
1008 1008
 	 * @since  2.0.0
1009 1009
 	 * @param  string  $key Specific option to retrieve
1010
-	 * @return array        Array of options
1010
+	 * @return string        Array of options
1011 1011
 	 */
1012 1012
 	public function options( $key = '' ) {
1013 1013
 		if ( ! empty( $this->field_options ) ) {
Please login to merge, or discard this patch.
Spacing   +72 added lines, -72 removed lines patch added patch discarded remove patch
@@ -131,21 +131,21 @@  discard block
 block discarded – undo
131 131
 	 */
132 132
 	public function __construct( $args ) {
133 133
 
134
-		if ( ! empty( $args['group_field'] ) ) {
135
-			$this->group       = $args['group_field'];
134
+		if ( ! empty( $args[ 'group_field' ] ) ) {
135
+			$this->group       = $args[ 'group_field' ];
136 136
 			$this->object_id   = $this->group->object_id;
137 137
 			$this->object_type = $this->group->object_type;
138 138
 			$this->cmb_id      = $this->group->cmb_id;
139 139
 		} else {
140
-			$this->object_id   = isset( $args['object_id'] ) && '_' !== $args['object_id'] ? $args['object_id'] : 0;
141
-			$this->object_type = isset( $args['object_type'] ) ? $args['object_type'] : 'post';
140
+			$this->object_id   = isset( $args[ 'object_id' ] ) && '_' !== $args[ 'object_id' ] ? $args[ 'object_id' ] : 0;
141
+			$this->object_type = isset( $args[ 'object_type' ] ) ? $args[ 'object_type' ] : 'post';
142 142
 
143
-			if ( isset( $args['cmb_id'] ) ) {
144
-				$this->cmb_id = $args['cmb_id'];
143
+			if ( isset( $args[ 'cmb_id' ] ) ) {
144
+				$this->cmb_id = $args[ 'cmb_id' ];
145 145
 			}
146 146
 		}
147 147
 
148
-		$this->args = $this->_set_field_defaults( $args['field_args'] );
148
+		$this->args = $this->_set_field_defaults( $args[ 'field_args' ] );
149 149
 
150 150
 		if ( $this->object_id ) {
151 151
 			$this->value = $this->get_data();
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
 	 * @return mixed             Value of field argument
161 161
 	 */
162 162
 	public function __call( $name, $arguments ) {
163
-		$key = isset( $arguments[0] ) ? $arguments[0] : false;
163
+		$key = isset( $arguments[ 0 ] ) ? $arguments[ 0 ] : false;
164 164
 		return $this->args( $name, $key );
165 165
 	}
166 166
 
@@ -231,9 +231,9 @@  discard block
 block discarded – undo
231 231
 	 */
232 232
 	public function get_data( $field_id = '', $args = array() ) {
233 233
 		if ( $field_id ) {
234
-			$args['field_id'] = $field_id;
234
+			$args[ 'field_id' ] = $field_id;
235 235
 		} else if ( $this->group ) {
236
-			$args['field_id'] = $this->group->id();
236
+			$args[ 'field_id' ] = $this->group->id();
237 237
 		}
238 238
 
239 239
 		$a = $this->data_args( $args );
@@ -274,13 +274,13 @@  discard block
 block discarded – undo
274 274
 		 *
275 275
 		 * @since 2.0.0
276 276
 		 */
277
-		$data = apply_filters( "cmb2_override_{$a['field_id']}_meta_value", $data, $this->object_id, $a, $this );
277
+		$data = apply_filters( "cmb2_override_{$a[ 'field_id' ]}_meta_value", $data, $this->object_id, $a, $this );
278 278
 
279 279
 		// If no override, get value normally
280 280
 		if ( 'cmb2_field_no_override_val' === $data ) {
281
-			$data = 'options-page' === $a['type']
282
-				? cmb2_options( $a['id'] )->get( $a['field_id'] )
283
-				: get_metadata( $a['type'], $a['id'], $a['field_id'], ( $a['single'] || $a['repeat'] ) );
281
+			$data = 'options-page' === $a[ 'type' ]
282
+				? cmb2_options( $a[ 'id' ] )->get( $a[ 'field_id' ] )
283
+				: get_metadata( $a[ 'type' ], $a[ 'id' ], $a[ 'field_id' ], ( $a[ 'single' ] || $a[ 'repeat' ] ) );
284 284
 		}
285 285
 
286 286
 		if ( $this->group ) {
@@ -302,7 +302,7 @@  discard block
 block discarded – undo
302 302
 	public function update_data( $new_value, $single = true ) {
303 303
 		$a = $this->data_args( array( 'single' => $single ) );
304 304
 
305
-		$a['value'] = $a['repeat'] ? array_values( $new_value ) : $new_value;
305
+		$a[ 'value' ] = $a[ 'repeat' ] ? array_values( $new_value ) : $new_value;
306 306
 
307 307
 		/**
308 308
 		 * Filter whether to override saving of meta value.
@@ -338,7 +338,7 @@  discard block
 block discarded – undo
338 338
 		 *
339 339
 		 * @since 2.0.0
340 340
 		 */
341
-		$override = apply_filters( "cmb2_override_{$a['field_id']}_meta_save", $override, $a, $this->args(), $this );
341
+		$override = apply_filters( "cmb2_override_{$a[ 'field_id' ]}_meta_save", $override, $a, $this->args(), $this );
342 342
 
343 343
 		// If override, return that
344 344
 		if ( null !== $override ) {
@@ -346,22 +346,22 @@  discard block
 block discarded – undo
346 346
 		}
347 347
 
348 348
 		// Options page handling (or temp data store)
349
-		if ( 'options-page' === $a['type'] || empty( $a['id'] ) ) {
350
-			return cmb2_options( $a['id'] )->update( $a['field_id'], $a['value'], false, $a['single'] );
349
+		if ( 'options-page' === $a[ 'type' ] || empty( $a[ 'id' ] ) ) {
350
+			return cmb2_options( $a[ 'id' ] )->update( $a[ 'field_id' ], $a[ 'value' ], false, $a[ 'single' ] );
351 351
 		}
352 352
 
353 353
 		// Add metadata if not single
354
-		if ( ! $a['single'] ) {
355
-			return add_metadata( $a['type'], $a['id'], $a['field_id'], $a['value'], false );
354
+		if ( ! $a[ 'single' ] ) {
355
+			return add_metadata( $a[ 'type' ], $a[ 'id' ], $a[ 'field_id' ], $a[ 'value' ], false );
356 356
 		}
357 357
 
358 358
 		// Delete meta if we have an empty array
359
-		if ( is_array( $a['value'] ) && empty( $a['value'] ) ) {
360
-			return delete_metadata( $a['type'], $a['id'], $a['field_id'], $this->value );
359
+		if ( is_array( $a[ 'value' ] ) && empty( $a[ 'value' ] ) ) {
360
+			return delete_metadata( $a[ 'type' ], $a[ 'id' ], $a[ 'field_id' ], $this->value );
361 361
 		}
362 362
 
363 363
 		// Update metadata
364
-		return update_metadata( $a['type'], $a['id'], $a['field_id'], $a['value'] );
364
+		return update_metadata( $a[ 'type' ], $a[ 'id' ], $a[ 'field_id' ], $a[ 'value' ] );
365 365
 	}
366 366
 
367 367
 	/**
@@ -411,19 +411,19 @@  discard block
 block discarded – undo
411 411
 		 * @param array $field_args All field arguments
412 412
 		 * @param CMB2_Field object $field This field object
413 413
 		 */
414
-		$override = apply_filters( "cmb2_override_{$a['field_id']}_meta_remove", $override, $a, $this->args(), $this );
414
+		$override = apply_filters( "cmb2_override_{$a[ 'field_id' ]}_meta_remove", $override, $a, $this->args(), $this );
415 415
 
416 416
 		// If no override, remove as usual
417 417
 		if ( null !== $override ) {
418 418
 			return $override;
419 419
 		}
420 420
 		// Option page handling
421
-		elseif ( 'options-page' === $a['type'] || empty( $a['id'] ) ) {
422
-			return cmb2_options( $a['id'] )->remove( $a['field_id'] );
421
+		elseif ( 'options-page' === $a[ 'type' ] || empty( $a[ 'id' ] ) ) {
422
+			return cmb2_options( $a[ 'id' ] )->remove( $a[ 'field_id' ] );
423 423
 		}
424 424
 
425 425
 		// Remove metadata
426
-		return delete_metadata( $a['type'], $a['id'], $a['field_id'], $old );
426
+		return delete_metadata( $a[ 'type' ], $a[ 'id' ], $a[ 'field_id' ], $old );
427 427
 	}
428 428
 
429 429
 	/**
@@ -895,7 +895,7 @@  discard block
 block discarded – undo
895 895
 
896 896
 		foreach ( $conditional_classes as $class => $condition ) {
897 897
 			if ( $condition ) {
898
-				$classes[] = $class;
898
+				$classes[ ] = $class;
899 899
 			}
900 900
 		}
901 901
 
@@ -904,7 +904,7 @@  discard block
 block discarded – undo
904 904
 		}
905 905
 
906 906
 		if ( $added_classes ) {
907
-			$classes[] = esc_attr( $added_classes );
907
+			$classes[ ] = esc_attr( $added_classes );
908 908
 		}
909 909
 
910 910
 		/**
@@ -1006,10 +1006,10 @@  discard block
 block discarded – undo
1006 1006
 	public function string( $text_key, $fallback ) {
1007 1007
 		// If null, populate with our field strings values.
1008 1008
 		if ( null === $this->strings ) {
1009
-			$this->strings = (array) $this->args['text'];
1009
+			$this->strings = (array) $this->args[ 'text' ];
1010 1010
 
1011
-			if ( is_callable( $this->args['text_cb'] ) ) {
1012
-				$strings = call_user_func( $this->args['text_cb'], $this );
1011
+			if ( is_callable( $this->args[ 'text_cb' ] ) ) {
1012
+				$strings = call_user_func( $this->args[ 'text_cb' ], $this );
1013 1013
 
1014 1014
 				if ( $strings && is_array( $strings ) ) {
1015 1015
 					$this->strings += $strings;
@@ -1043,10 +1043,10 @@  discard block
 block discarded – undo
1043 1043
 			return $this->field_options;
1044 1044
 		}
1045 1045
 
1046
-		$this->field_options = (array) $this->args['options'];
1046
+		$this->field_options = (array) $this->args[ 'options' ];
1047 1047
 
1048
-		if ( is_callable( $this->args['options_cb'] ) ) {
1049
-			$options = call_user_func( $this->args['options_cb'], $this );
1048
+		if ( is_callable( $this->args[ 'options_cb' ] ) ) {
1049
+			$options = call_user_func( $this->args[ 'options_cb' ], $this );
1050 1050
 
1051 1051
 			if ( $options && is_array( $options ) ) {
1052 1052
 				$this->field_options += $options;
@@ -1067,7 +1067,7 @@  discard block
 block discarded – undo
1067 1067
 	 */
1068 1068
 	public function add_js_dependencies( $dependencies = array() ) {
1069 1069
 		foreach ( (array) $dependencies as $dependency ) {
1070
-			$this->args['js_dependencies'][ $dependency ] = $dependency;
1070
+			$this->args[ 'js_dependencies' ][ $dependency ] = $dependency;
1071 1071
 		}
1072 1072
 
1073 1073
 		CMB2_JS::add_dependencies( $dependencies );
@@ -1081,17 +1081,17 @@  discard block
 block discarded – undo
1081 1081
 	 * @return mixed  Default field value
1082 1082
 	 */
1083 1083
 	public function get_default() {
1084
-		if ( null !== $this->args['default'] ) {
1085
-			return $this->args['default'];
1084
+		if ( null !== $this->args[ 'default' ] ) {
1085
+			return $this->args[ 'default' ];
1086 1086
 		}
1087 1087
 
1088
-		$param = is_callable( $this->args['default_cb'] ) ? 'default_cb' : 'default';
1088
+		$param = is_callable( $this->args[ 'default_cb' ] ) ? 'default_cb' : 'default';
1089 1089
 		$default = $this->get_param_callback_result( $param, false );
1090 1090
 
1091 1091
 		// Allow a filter override of the default value
1092
-		$this->args['default'] = apply_filters( 'cmb2_default_filter', $default, $this );
1092
+		$this->args[ 'default' ] = apply_filters( 'cmb2_default_filter', $default, $this );
1093 1093
 
1094
-		return $this->args['default'];
1094
+		return $this->args[ 'default' ];
1095 1095
 	}
1096 1096
 
1097 1097
 	/**
@@ -1118,70 +1118,70 @@  discard block
 block discarded – undo
1118 1118
 			'default_cb'        => '',
1119 1119
 			'select_all_button' => true,
1120 1120
 			'multiple'          => false,
1121
-			'repeatable'        => isset( $args['type'] ) && 'group' == $args['type'],
1121
+			'repeatable'        => isset( $args[ 'type' ] ) && 'group' == $args[ 'type' ],
1122 1122
 			'inline'            => false,
1123 1123
 			'on_front'          => true,
1124 1124
 			'show_names'        => true,
1125 1125
 			'date_format'       => 'm\/d\/Y',
1126 1126
 			'time_format'       => 'h:i A',
1127
-			'description'       => isset( $args['desc'] ) ? $args['desc'] : '',
1128
-			'preview_size'      => 'file' == $args['type'] ? array( 350, 350 ) : array( 50, 50 ),
1127
+			'description'       => isset( $args[ 'desc' ] ) ? $args[ 'desc' ] : '',
1128
+			'preview_size'      => 'file' == $args[ 'type' ] ? array( 350, 350 ) : array( 50, 50 ),
1129 1129
 			'render_row_cb'     => array( $this, 'render_field_callback' ),
1130
-			'label_cb'          => 'title' != $args['type'] ? array( $this, 'label' ) : '',
1130
+			'label_cb'          => 'title' != $args[ 'type' ] ? array( $this, 'label' ) : '',
1131 1131
 			'show_in_rest'      => null,
1132 1132
 			'js_dependencies'   => array(),
1133 1133
 		) );
1134 1134
 
1135 1135
 		// default param can be passed a callback as well
1136
-		if ( is_callable( $args['default'] ) ) {
1137
-			$args['default_cb'] = $args['default'];
1138
-			$args['default'] = null;
1136
+		if ( is_callable( $args[ 'default' ] ) ) {
1137
+			$args[ 'default_cb' ] = $args[ 'default' ];
1138
+			$args[ 'default' ] = null;
1139 1139
 		}
1140 1140
 
1141
-		$args['repeatable'] = $args['repeatable'] && ! $this->repeatable_exception( $args['type'] );
1142
-		$args['inline']     = $args['inline'] || false !== stripos( $args['type'], '_inline' );
1141
+		$args[ 'repeatable' ] = $args[ 'repeatable' ] && ! $this->repeatable_exception( $args[ 'type' ] );
1142
+		$args[ 'inline' ]     = $args[ 'inline' ] || false !== stripos( $args[ 'type' ], '_inline' );
1143 1143
 
1144 1144
 		// options param can be passed a callback as well
1145
-		if ( is_callable( $args['options'] ) ) {
1146
-			$args['options_cb'] = $args['options'];
1147
-			$args['options'] = array();
1145
+		if ( is_callable( $args[ 'options' ] ) ) {
1146
+			$args[ 'options_cb' ] = $args[ 'options' ];
1147
+			$args[ 'options' ] = array();
1148 1148
 		}
1149 1149
 
1150
-		$args['options']    = 'group' == $args['type'] ? wp_parse_args( $args['options'], array(
1150
+		$args[ 'options' ] = 'group' == $args[ 'type' ] ? wp_parse_args( $args[ 'options' ], array(
1151 1151
 			'add_button'    => __( 'Add Group', 'cmb2' ),
1152 1152
 			'remove_button' => __( 'Remove Group', 'cmb2' ),
1153
-		) ) : $args['options'];
1153
+		) ) : $args[ 'options' ];
1154 1154
 
1155
-		$args['_id']        = $args['id'];
1156
-		$args['_name']      = $args['id'];
1155
+		$args[ '_id' ]        = $args[ 'id' ];
1156
+		$args[ '_name' ]      = $args[ 'id' ];
1157 1157
 
1158 1158
 		if ( $this->group ) {
1159 1159
 
1160
-			$args['id']    = $this->group->args( 'id' ) . '_' . $this->group->index . '_' . $args['id'];
1161
-			$args['_name'] = $this->group->args( 'id' ) . '[' . $this->group->index . '][' . $args['_name'] . ']';
1160
+			$args[ 'id' ]    = $this->group->args( 'id' ) . '_' . $this->group->index . '_' . $args[ 'id' ];
1161
+			$args[ '_name' ] = $this->group->args( 'id' ) . '[' . $this->group->index . '][' . $args[ '_name' ] . ']';
1162 1162
 		}
1163 1163
 
1164
-		if ( 'wysiwyg' == $args['type'] ) {
1165
-			$args['id'] = strtolower( str_ireplace( '-', '_', $args['id'] ) );
1166
-			$args['options']['textarea_name'] = $args['_name'];
1164
+		if ( 'wysiwyg' == $args[ 'type' ] ) {
1165
+			$args[ 'id' ] = strtolower( str_ireplace( '-', '_', $args[ 'id' ] ) );
1166
+			$args[ 'options' ][ 'textarea_name' ] = $args[ '_name' ];
1167 1167
 		}
1168 1168
 
1169 1169
 		$option_types = apply_filters( 'cmb2_all_or_nothing_types', array( 'select', 'radio', 'radio_inline', 'taxonomy_select', 'taxonomy_radio', 'taxonomy_radio_inline' ), $this );
1170 1170
 
1171
-		if ( in_array( $args['type'], $option_types, true ) ) {
1171
+		if ( in_array( $args[ 'type' ], $option_types, true ) ) {
1172 1172
 
1173
-			$args['show_option_none'] = isset( $args['show_option_none'] ) ? $args['show_option_none'] : null;
1174
-			$args['show_option_none'] = true === $args['show_option_none'] ? __( 'None', 'cmb2' ) : $args['show_option_none'];
1173
+			$args[ 'show_option_none' ] = isset( $args[ 'show_option_none' ] ) ? $args[ 'show_option_none' ] : null;
1174
+			$args[ 'show_option_none' ] = true === $args[ 'show_option_none' ] ? __( 'None', 'cmb2' ) : $args[ 'show_option_none' ];
1175 1175
 
1176
-			if ( null === $args['show_option_none'] ) {
1177
-				$off_by_default = in_array( $args['type'], array( 'select', 'radio', 'radio_inline' ), true );
1178
-				$args['show_option_none'] = $off_by_default ? false : __( 'None', 'cmb2' );
1176
+			if ( null === $args[ 'show_option_none' ] ) {
1177
+				$off_by_default = in_array( $args[ 'type' ], array( 'select', 'radio', 'radio_inline' ), true );
1178
+				$args[ 'show_option_none' ] = $off_by_default ? false : __( 'None', 'cmb2' );
1179 1179
 			}
1180 1180
 
1181 1181
 		}
1182 1182
 
1183
-		$args['has_supporting_data'] = in_array(
1184
-			$args['type'],
1183
+		$args[ 'has_supporting_data' ] = in_array(
1184
+			$args[ 'type' ],
1185 1185
 			array(
1186 1186
 				// CMB2_Sanitize::_save_file_id_value()/CMB2_Sanitize::_get_group_file_value_array()
1187 1187
 				'file',
@@ -1213,10 +1213,10 @@  discard block
 block discarded – undo
1213 1213
 			'cmb_id'      => $this->cmb_id,
1214 1214
 		);
1215 1215
 
1216
-		if ( isset( $field_args['field_args'] ) ) {
1216
+		if ( isset( $field_args[ 'field_args' ] ) ) {
1217 1217
 			$args = wp_parse_args( $field_args, $args );
1218 1218
 		} else {
1219
-			$args['field_args'] = wp_parse_args( $field_args, $this->args );
1219
+			$args[ 'field_args' ] = wp_parse_args( $field_args, $this->args );
1220 1220
 		}
1221 1221
 
1222 1222
 		return new CMB2_Field( $args );
Please login to merge, or discard this patch.
includes/CMB2_Utils.php 2 patches
Spacing   +20 added lines, -21 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
 		$dir = wp_upload_dir();
31 31
 
32 32
 		// Is URL in uploads directory?
33
-		if ( false === strpos( $img_url, $dir['baseurl'] . '/' ) ) {
33
+		if ( false === strpos( $img_url, $dir[ 'baseurl' ] . '/' ) ) {
34 34
 			return false;
35 35
 		}
36 36
 
@@ -55,8 +55,8 @@  discard block
 block discarded – undo
55 55
 
56 56
 			foreach ( $query->posts as $post_id ) {
57 57
 				$meta = wp_get_attachment_metadata( $post_id );
58
-				$original_file       = basename( $meta['file'] );
59
-				$cropped_image_files = isset( $meta['sizes'] ) ? wp_list_pluck( $meta['sizes'], 'file' ) : array();
58
+				$original_file       = basename( $meta[ 'file' ] );
59
+				$cropped_image_files = isset( $meta[ 'sizes' ] ) ? wp_list_pluck( $meta[ 'sizes' ], 'file' ) : array();
60 60
 				if ( $original_file === $file || in_array( $file, $cropped_image_files ) ) {
61 61
 					$attachment_id = $post_id;
62 62
 					break;
@@ -140,8 +140,7 @@  discard block
 block discarded – undo
140 140
 		}
141 141
 
142 142
 		return $this->is_valid_time_stamp( $string )
143
-			? (int) $string :
144
-			strtotime( (string) $string );
143
+			? (int) $string : strtotime( (string) $string );
145 144
 	}
146 145
 
147 146
 	/**
@@ -172,7 +171,7 @@  discard block
 block discarded – undo
172 171
 	 * @param  mixed $value Value to check
173 172
 	 * @return bool         True or false
174 173
 	 */
175
-	public function notempty( $value ){
174
+	public function notempty( $value ) {
176 175
 		return null !== $value && '' !== $value && false !== $value;
177 176
 	}
178 177
 
@@ -322,24 +321,24 @@  discard block
 block discarded – undo
322 321
 
323 322
 		// order is relevant here, since the replacement will be done sequentially.
324 323
 		$supported_options = array(
325
-			'd' => 'dd',  // Day, leading 0
326
-			'j' => 'd',   // Day, no 0
327
-			'z' => 'o',   // Day of the year, no leading zeroes,
324
+			'd' => 'dd', // Day, leading 0
325
+			'j' => 'd', // Day, no 0
326
+			'z' => 'o', // Day of the year, no leading zeroes,
328 327
 			// 'D' => 'D',   // Day name short, not sure how it'll work with translations
329 328
 			// 'l' => 'DD',  // Day name full, idem before
330
-			'm' => 'mm',  // Month of the year, leading 0
331
-			'n' => 'm',   // Month of the year, no leading 0
329
+			'm' => 'mm', // Month of the year, leading 0
330
+			'n' => 'm', // Month of the year, no leading 0
332 331
 			// 'M' => 'M',   // Month, Short name
333 332
 			// 'F' => 'MM',  // Month, full name,
334
-			'y' => 'y',   // Year, two digit
335
-			'Y' => 'yy',  // Year, full
336
-			'H' => 'HH',  // Hour with leading 0 (24 hour)
337
-			'G' => 'H',   // Hour with no leading 0 (24 hour)
338
-			'h' => 'hh',  // Hour with leading 0 (12 hour)
339
-			'g' => 'h',   // Hour with no leading 0 (12 hour),
340
-			'i' => 'mm',  // Minute with leading 0,
341
-			's' => 'ss',  // Second with leading 0,
342
-			'a' => 'tt',  // am/pm
333
+			'y' => 'y', // Year, two digit
334
+			'Y' => 'yy', // Year, full
335
+			'H' => 'HH', // Hour with leading 0 (24 hour)
336
+			'G' => 'H', // Hour with no leading 0 (24 hour)
337
+			'h' => 'hh', // Hour with leading 0 (12 hour)
338
+			'g' => 'h', // Hour with no leading 0 (12 hour),
339
+			'i' => 'mm', // Minute with leading 0,
340
+			's' => 'ss', // Second with leading 0,
341
+			'a' => 'tt', // am/pm
343 342
 			'A' => 'TT'   // AM/PM
344 343
 		);
345 344
 
@@ -360,7 +359,7 @@  discard block
 block discarded – undo
360 359
 	 * @return string Modified value
361 360
 	 */
362 361
 	public function wrap_escaped_chars( $value ) {
363
-		return "&#39;" . str_replace( '\\', '', $value[0] ) . "&#39;";
362
+		return "&#39;" . str_replace( '\\', '', $value[ 0 ] ) . "&#39;";
364 363
 	}
365 364
 
366 365
 	/**
Please login to merge, or discard this patch.
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -115,7 +115,8 @@  discard block
 block discarded – undo
115 115
 			$tzstring = '';
116 116
 		}
117 117
 
118
-		if ( empty( $tzstring ) ) { // Create a UTC+- zone if no timezone string exists
118
+		if ( empty( $tzstring ) ) {
119
+// Create a UTC+- zone if no timezone string exists
119 120
 			if ( 0 == $current_offset ) {
120 121
 				$tzstring = 'UTC+0';
121 122
 			} elseif ( $current_offset < 0 ) {
@@ -172,7 +173,7 @@  discard block
 block discarded – undo
172 173
 	 * @param  mixed $value Value to check
173 174
 	 * @return bool         True or false
174 175
 	 */
175
-	public function notempty( $value ){
176
+	public function notempty( $value ) {
176 177
 		return null !== $value && '' !== $value && false !== $value;
177 178
 	}
178 179
 
Please login to merge, or discard this patch.
includes/types/CMB2_Type_Taxonomy_Select.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@
 block discarded – undo
15 15
 	public function render() {
16 16
 		$names = $this->get_object_terms();
17 17
 
18
-		$saved_term  = is_wp_error( $names ) || empty( $names ) ? $this->field->get_default() : $names[key( $names )]->slug;
18
+		$saved_term  = is_wp_error( $names ) || empty( $names ) ? $this->field->get_default() : $names[ key( $names ) ]->slug;
19 19
 		$terms       = $this->get_terms();
20 20
 		$options     = '';
21 21
 		$option_none = $this->field->args( 'show_option_none' );
Please login to merge, or discard this patch.
includes/types/CMB2_Type_Title.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
 		), $this->args );
30 30
 
31 31
 		return $this->rendered(
32
-			sprintf( '<%1$s %2$s>%3$s</%1$s>%4$s', $a['tag'], $this->concat_attrs( $a, array( 'tag', 'name', 'desc' ) ), $a['name'], $a['desc'] )
32
+			sprintf( '<%1$s %2$s>%3$s</%1$s>%4$s', $a[ 'tag' ], $this->concat_attrs( $a, array( 'tag', 'name', 'desc' ) ), $a[ 'name' ], $a[ 'desc' ] )
33 33
 		);
34 34
 	}
35 35
 
Please login to merge, or discard this patch.