| @@ -118,19 +118,19 @@ discard block | ||
| 118 | 118 | */ | 
| 119 | 119 |  	public function __construct( $meta_box, $object_id = 0 ) { | 
| 120 | 120 | |
| 121 | -		if ( empty( $meta_box['id'] ) ) { | |
| 121 | +		if ( empty( $meta_box[ 'id' ] ) ) { | |
| 122 | 122 | wp_die( __( 'Metabox configuration is required to have an ID parameter', 'cmb2' ) ); | 
| 123 | 123 | } | 
| 124 | 124 | |
| 125 | 125 | $this->meta_box = wp_parse_args( $meta_box, $this->mb_defaults ); | 
| 126 | - $this->meta_box['fields'] = array(); | |
| 126 | + $this->meta_box[ 'fields' ] = array(); | |
| 127 | 127 | |
| 128 | 128 | $this->object_id( $object_id ); | 
| 129 | 129 | $this->mb_object_type(); | 
| 130 | - $this->cmb_id = $meta_box['id']; | |
| 130 | + $this->cmb_id = $meta_box[ 'id' ]; | |
| 131 | 131 | |
| 132 | -		if ( ! empty( $meta_box['fields'] ) && is_array( $meta_box['fields'] ) ) { | |
| 133 | - $this->add_fields( $meta_box['fields'] ); | |
| 132 | +		if ( ! empty( $meta_box[ 'fields' ] ) && is_array( $meta_box[ 'fields' ] ) ) { | |
| 133 | + $this->add_fields( $meta_box[ 'fields' ] ); | |
| 134 | 134 | } | 
| 135 | 135 | |
| 136 | 136 | CMB2_Boxes::add( $this ); | 
| @@ -261,16 +261,16 @@ discard block | ||
| 261 | 261 | * @return mixed CMB2_Field object if successful. | 
| 262 | 262 | */ | 
| 263 | 263 |  	public function render_field( $field_args ) { | 
| 264 | - $field_args['context'] = $this->prop( 'context' ); | |
| 264 | + $field_args[ 'context' ] = $this->prop( 'context' ); | |
| 265 | 265 | |
| 266 | -		if ( 'group' == $field_args['type'] ) { | |
| 266 | +		if ( 'group' == $field_args[ 'type' ] ) { | |
| 267 | 267 | |
| 268 | -			if ( ! isset( $field_args['show_names'] ) ) { | |
| 269 | - $field_args['show_names'] = $this->prop( 'show_names' ); | |
| 268 | +			if ( ! isset( $field_args[ 'show_names' ] ) ) { | |
| 269 | + $field_args[ 'show_names' ] = $this->prop( 'show_names' ); | |
| 270 | 270 | } | 
| 271 | 271 | $field = $this->render_group( $field_args ); | 
| 272 | 272 | |
| 273 | -		} elseif ( 'hidden' == $field_args['type'] && $this->get_field( $field_args )->should_show() ) { | |
| 273 | +		} elseif ( 'hidden' == $field_args[ 'type' ] && $this->get_field( $field_args )->should_show() ) { | |
| 274 | 274 | // Save rendering for after the metabox | 
| 275 | 275 | $field = $this->add_hidden_field( array( | 
| 276 | 276 | 'field_args' => $field_args, | 
| @@ -280,7 +280,7 @@ discard block | ||
| 280 | 280 | |
| 281 | 281 |  		} else { | 
| 282 | 282 | |
| 283 | - $field_args['show_names'] = $this->prop( 'show_names' ); | |
| 283 | + $field_args[ 'show_names' ] = $this->prop( 'show_names' ); | |
| 284 | 284 | |
| 285 | 285 | // Render default fields | 
| 286 | 286 | $field = $this->get_field( $field_args )->render_field(); | 
| @@ -296,7 +296,7 @@ discard block | ||
| 296 | 296 | */ | 
| 297 | 297 |  	public function render_group( $args ) { | 
| 298 | 298 | |
| 299 | -		if ( ! isset( $args['id'], $args['fields'] ) || ! is_array( $args['fields'] ) ) { | |
| 299 | +		if ( ! isset( $args[ 'id' ], $args[ 'fields' ] ) || ! is_array( $args[ 'fields' ] ) ) { | |
| 300 | 300 | return; | 
| 301 | 301 | } | 
| 302 | 302 | |
| @@ -378,7 +378,7 @@ discard block | ||
| 378 | 378 | <div class="inside cmb-td cmb-nested cmb-field-list">'; | 
| 379 | 379 | // Loop and render repeatable group fields | 
| 380 | 380 |  				foreach ( array_values( $field_group->args( 'fields' ) ) as $field_args ) { | 
| 381 | -					if ( 'hidden' == $field_args['type'] ) { | |
| 381 | +					if ( 'hidden' == $field_args[ 'type' ] ) { | |
| 382 | 382 | |
| 383 | 383 | // Save rendering for after the metabox | 
| 384 | 384 | $this->add_hidden_field( array( | 
| @@ -388,8 +388,8 @@ discard block | ||
| 388 | 388 | |
| 389 | 389 |  					} else { | 
| 390 | 390 | |
| 391 | - $field_args['show_names'] = $field_group->args( 'show_names' ); | |
| 392 | - $field_args['context'] = $field_group->args( 'context' ); | |
| 391 | + $field_args[ 'show_names' ] = $field_group->args( 'show_names' ); | |
| 392 | + $field_args[ 'context' ] = $field_group->args( 'context' ); | |
| 393 | 393 | |
| 394 | 394 | $field = $this->get_field( $field_args, $field_group )->render_field(); | 
| 395 | 395 | } | 
| @@ -418,7 +418,7 @@ discard block | ||
| 418 | 418 | */ | 
| 419 | 419 |  	public function add_hidden_field( $args ) { | 
| 420 | 420 | $field = new CMB2_Field( $args ); | 
| 421 | - $this->hidden_fields[] = new CMB2_Types( $field ); | |
| 421 | + $this->hidden_fields[ ] = new CMB2_Types( $field ); | |
| 422 | 422 | |
| 423 | 423 | return $field; | 
| 424 | 424 | } | 
| @@ -557,7 +557,7 @@ discard block | ||
| 557 | 557 | */ | 
| 558 | 558 |  	public function process_field( $field_args ) { | 
| 559 | 559 | |
| 560 | -		switch ( $field_args['type'] ) { | |
| 560 | +		switch ( $field_args[ 'type' ] ) { | |
| 561 | 561 | |
| 562 | 562 | case 'group': | 
| 563 | 563 | $this->save_group( $field_args ); | 
| @@ -577,7 +577,7 @@ discard block | ||
| 577 | 577 | ) ); | 
| 578 | 578 | |
| 579 | 579 |  				if ( $field->save_field_from_data( $this->data_to_save ) ) { | 
| 580 | - $this->updated[] = $field->id(); | |
| 580 | + $this->updated[ ] = $field->id(); | |
| 581 | 581 | } | 
| 582 | 582 | |
| 583 | 583 | break; | 
| @@ -590,11 +590,11 @@ discard block | ||
| 590 | 590 | */ | 
| 591 | 591 |  	public function save_group( $args ) { | 
| 592 | 592 | |
| 593 | -		if ( ! isset( $args['id'], $args['fields'], $this->data_to_save[ $args['id'] ] ) || ! is_array( $args['fields'] ) ) { | |
| 593 | +		if ( ! isset( $args[ 'id' ], $args[ 'fields' ], $this->data_to_save[ $args[ 'id' ] ] ) || ! is_array( $args[ 'fields' ] ) ) { | |
| 594 | 594 | return; | 
| 595 | 595 | } | 
| 596 | 596 | |
| 597 | - $field_group = new CMB2_Field( array( | |
| 597 | + $field_group = new CMB2_Field( array( | |
| 598 | 598 | 'field_args' => $args, | 
| 599 | 599 | 'object_type' => $this->object_type(), | 
| 600 | 600 | 'object_id' => $this->object_id(), | 
| @@ -629,16 +629,16 @@ discard block | ||
| 629 | 629 | $_new_val = array(); | 
| 630 | 630 |  						foreach ( $new_val as $group_index => $grouped_data ) { | 
| 631 | 631 | // Add the supporting data to the $saved array stack | 
| 632 | - $saved[ $field_group->index ][ $grouped_data['supporting_field_id'] ][] = $grouped_data['supporting_field_value']; | |
| 632 | + $saved[ $field_group->index ][ $grouped_data[ 'supporting_field_id' ] ][ ] = $grouped_data[ 'supporting_field_value' ]; | |
| 633 | 633 | // Reset var to the actual value | 
| 634 | - $_new_val[ $group_index ] = $grouped_data['value']; | |
| 634 | + $_new_val[ $group_index ] = $grouped_data[ 'value' ]; | |
| 635 | 635 | } | 
| 636 | 636 | $new_val = $_new_val; | 
| 637 | 637 |  					} else { | 
| 638 | 638 | // Add the supporting data to the $saved array stack | 
| 639 | - $saved[ $field_group->index ][ $new_val['supporting_field_id'] ] = $new_val['supporting_field_value']; | |
| 639 | + $saved[ $field_group->index ][ $new_val[ 'supporting_field_id' ] ] = $new_val[ 'supporting_field_value' ]; | |
| 640 | 640 | // Reset var to the actual value | 
| 641 | - $new_val = $new_val['value']; | |
| 641 | + $new_val = $new_val[ 'value' ]; | |
| 642 | 642 | } | 
| 643 | 643 | } | 
| 644 | 644 | |
| @@ -651,7 +651,7 @@ discard block | ||
| 651 | 651 | $is_removed = ( empty( $new_val ) && ! empty( $old_val ) ); | 
| 652 | 652 | // Compare values and add to `$updated` array | 
| 653 | 653 |  				if ( $is_updated || $is_removed ) { | 
| 654 | - $this->updated[] = $base_id . '::' . $field_group->index . '::' . $sub_id; | |
| 654 | + $this->updated[ ] = $base_id . '::' . $field_group->index . '::' . $sub_id; | |
| 655 | 655 | } | 
| 656 | 656 | |
| 657 | 657 | // Add to `$saved` array | 
| @@ -686,22 +686,22 @@ discard block | ||
| 686 | 686 | // Try to get our object ID from the global space | 
| 687 | 687 |  		switch ( $this->object_type() ) { | 
| 688 | 688 | case 'user': | 
| 689 | - $object_id = isset( $_REQUEST['user_id'] ) ? $_REQUEST['user_id'] : $object_id; | |
| 690 | - $object_id = ! $object_id && 'user-new.php' != $pagenow && isset( $GLOBALS['user_ID'] ) ? $GLOBALS['user_ID'] : $object_id; | |
| 689 | + $object_id = isset( $_REQUEST[ 'user_id' ] ) ? $_REQUEST[ 'user_id' ] : $object_id; | |
| 690 | + $object_id = ! $object_id && 'user-new.php' != $pagenow && isset( $GLOBALS[ 'user_ID' ] ) ? $GLOBALS[ 'user_ID' ] : $object_id; | |
| 691 | 691 | break; | 
| 692 | 692 | |
| 693 | 693 | case 'comment': | 
| 694 | - $object_id = isset( $_REQUEST['c'] ) ? $_REQUEST['c'] : $object_id; | |
| 695 | - $object_id = ! $object_id && isset( $GLOBALS['comments']->comment_ID ) ? $GLOBALS['comments']->comment_ID : $object_id; | |
| 694 | + $object_id = isset( $_REQUEST[ 'c' ] ) ? $_REQUEST[ 'c' ] : $object_id; | |
| 695 | + $object_id = ! $object_id && isset( $GLOBALS[ 'comments' ]->comment_ID ) ? $GLOBALS[ 'comments' ]->comment_ID : $object_id; | |
| 696 | 696 | break; | 
| 697 | 697 | |
| 698 | 698 | case 'term': | 
| 699 | - $object_id = isset( $_REQUEST['tag_ID'] ) ? $_REQUEST['tag_ID'] : $object_id; | |
| 699 | + $object_id = isset( $_REQUEST[ 'tag_ID' ] ) ? $_REQUEST[ 'tag_ID' ] : $object_id; | |
| 700 | 700 | break; | 
| 701 | 701 | |
| 702 | 702 | default: | 
| 703 | - $object_id = isset( $GLOBALS['post']->ID ) ? $GLOBALS['post']->ID : $object_id; | |
| 704 | - $object_id = isset( $_REQUEST['post'] ) ? $_REQUEST['post'] : $object_id; | |
| 703 | + $object_id = isset( $GLOBALS[ 'post' ]->ID ) ? $GLOBALS[ 'post' ]->ID : $object_id; | |
| 704 | + $object_id = isset( $_REQUEST[ 'post' ] ) ? $_REQUEST[ 'post' ] : $object_id; | |
| 705 | 705 | break; | 
| 706 | 706 | } | 
| 707 | 707 | |
| @@ -773,7 +773,7 @@ discard block | ||
| 773 | 773 | * @return boolean True/False | 
| 774 | 774 | */ | 
| 775 | 775 |  	public function is_options_page_mb() { | 
| 776 | - return ( isset( $this->meta_box['show_on']['key'] ) && 'options-page' === $this->meta_box['show_on']['key'] || array_key_exists( 'options-page', $this->meta_box['show_on'] ) ); | |
| 776 | + return ( isset( $this->meta_box[ 'show_on' ][ 'key' ] ) && 'options-page' === $this->meta_box[ 'show_on' ][ 'key' ] || array_key_exists( 'options-page', $this->meta_box[ 'show_on' ] ) ); | |
| 777 | 777 | } | 
| 778 | 778 | |
| 779 | 779 | /** | 
| @@ -839,7 +839,7 @@ discard block | ||
| 839 | 839 | return $field; | 
| 840 | 840 | } | 
| 841 | 841 | |
| 842 | - $field_id = is_string( $field ) ? $field : $field['id']; | |
| 842 | + $field_id = is_string( $field ) ? $field : $field[ 'id' ]; | |
| 843 | 843 | |
| 844 | 844 | $parent_field_id = ! empty( $field_group ) ? $field_group->id() : ''; | 
| 845 | 845 | $ids = $this->get_field_ids( $field_id, $parent_field_id, true ); | 
| @@ -875,7 +875,7 @@ discard block | ||
| 875 | 875 |  		if ( $field_group && ( $sub_field_id || 0 === $sub_field_id ) ) { | 
| 876 | 876 | |
| 877 | 877 | // Update the fields array w/ any modified properties inherited from the group field | 
| 878 | - $this->meta_box['fields'][ $field_id ]['fields'][ $sub_field_id ] = $field_args; | |
| 878 | + $this->meta_box[ 'fields' ][ $field_id ][ 'fields' ][ $sub_field_id ] = $field_args; | |
| 879 | 879 | |
| 880 | 880 | return array( | 
| 881 | 881 | 'field_args' => $field_args, | 
| @@ -885,11 +885,11 @@ discard block | ||
| 885 | 885 | } | 
| 886 | 886 | |
| 887 | 887 |  		if ( is_array( $field_args ) ) { | 
| 888 | - $this->meta_box['fields'][ $field_id ] = array_merge( $field_args, $this->meta_box['fields'][ $field_id ] ); | |
| 888 | + $this->meta_box[ 'fields' ][ $field_id ] = array_merge( $field_args, $this->meta_box[ 'fields' ][ $field_id ] ); | |
| 889 | 889 | } | 
| 890 | 890 | |
| 891 | 891 | return array( | 
| 892 | - 'field_args' => $this->meta_box['fields'][ $field_id ], | |
| 892 | + 'field_args' => $this->meta_box[ 'fields' ][ $field_id ], | |
| 893 | 893 | 'object_type' => $this->object_type(), | 
| 894 | 894 | 'object_id' => $this->object_id(), | 
| 895 | 895 | ); | 
| @@ -906,8 +906,8 @@ discard block | ||
| 906 | 906 | |
| 907 | 907 | $sub_fields = false; | 
| 908 | 908 |  			if ( array_key_exists( 'fields', $field ) ) { | 
| 909 | - $sub_fields = $field['fields']; | |
| 910 | - unset( $field['fields'] ); | |
| 909 | + $sub_fields = $field[ 'fields' ]; | |
| 910 | + unset( $field[ 'fields' ] ); | |
| 911 | 911 | } | 
| 912 | 912 | |
| 913 | 913 | $field_id = $parent_field_id | 
| @@ -934,11 +934,11 @@ discard block | ||
| 934 | 934 | |
| 935 | 935 | $this->_add_field_to_array( | 
| 936 | 936 | $field, | 
| 937 | - $this->meta_box['fields'], | |
| 937 | + $this->meta_box[ 'fields' ], | |
| 938 | 938 | $position | 
| 939 | 939 | ); | 
| 940 | 940 | |
| 941 | - return $field['id']; | |
| 941 | + return $field[ 'id' ]; | |
| 942 | 942 | } | 
| 943 | 943 | |
| 944 | 944 | /** | 
| @@ -950,27 +950,27 @@ discard block | ||
| 950 | 950 | * @return mixed Array of parent/field ids or false | 
| 951 | 951 | */ | 
| 952 | 952 |  	public function add_group_field( $parent_field_id, array $field, $position = 0 ) { | 
| 953 | -		if ( ! array_key_exists( $parent_field_id, $this->meta_box['fields'] ) ) { | |
| 953 | +		if ( ! array_key_exists( $parent_field_id, $this->meta_box[ 'fields' ] ) ) { | |
| 954 | 954 | return false; | 
| 955 | 955 | } | 
| 956 | 956 | |
| 957 | - $parent_field = $this->meta_box['fields'][ $parent_field_id ]; | |
| 957 | + $parent_field = $this->meta_box[ 'fields' ][ $parent_field_id ]; | |
| 958 | 958 | |
| 959 | -		if ( 'group' !== $parent_field['type'] ) { | |
| 959 | +		if ( 'group' !== $parent_field[ 'type' ] ) { | |
| 960 | 960 | return false; | 
| 961 | 961 | } | 
| 962 | 962 | |
| 963 | -		if ( ! isset( $parent_field['fields'] ) ) { | |
| 964 | - $this->meta_box['fields'][ $parent_field_id ]['fields'] = array(); | |
| 963 | +		if ( ! isset( $parent_field[ 'fields' ] ) ) { | |
| 964 | + $this->meta_box[ 'fields' ][ $parent_field_id ][ 'fields' ] = array(); | |
| 965 | 965 | } | 
| 966 | 966 | |
| 967 | 967 | $this->_add_field_to_array( | 
| 968 | 968 | $field, | 
| 969 | - $this->meta_box['fields'][ $parent_field_id ]['fields'], | |
| 969 | + $this->meta_box[ 'fields' ][ $parent_field_id ][ 'fields' ], | |
| 970 | 970 | $position | 
| 971 | 971 | ); | 
| 972 | 972 | |
| 973 | - return array( $parent_field_id, $field['id'] ); | |
| 973 | + return array( $parent_field_id, $field[ 'id' ] ); | |
| 974 | 974 | } | 
| 975 | 975 | |
| 976 | 976 | /** | 
| @@ -982,9 +982,9 @@ discard block | ||
| 982 | 982 | */ | 
| 983 | 983 |  	protected function _add_field_to_array( $field, &$fields, $position = 0 ) { | 
| 984 | 984 |  		if ( $position ) { | 
| 985 | - cmb2_utils()->array_insert( $fields, array( $field['id'] => $field ), $position ); | |
| 985 | + cmb2_utils()->array_insert( $fields, array( $field[ 'id' ] => $field ), $position ); | |
| 986 | 986 |  		} else { | 
| 987 | - $fields[ $field['id'] ] = $field; | |
| 987 | + $fields[ $field[ 'id' ] ] = $field; | |
| 988 | 988 | } | 
| 989 | 989 | } | 
| 990 | 990 | |
| @@ -1007,15 +1007,15 @@ discard block | ||
| 1007 | 1007 | unset( $this->fields[ implode( '', $ids ) ] ); | 
| 1008 | 1008 | |
| 1009 | 1009 |  		if ( ! $sub_field_id ) { | 
| 1010 | - unset( $this->meta_box['fields'][ $field_id ] ); | |
| 1010 | + unset( $this->meta_box[ 'fields' ][ $field_id ] ); | |
| 1011 | 1011 | return true; | 
| 1012 | 1012 | } | 
| 1013 | 1013 | |
| 1014 | -		if ( isset( $this->fields[ $field_id ]->args['fields'][ $sub_field_id ] ) ) { | |
| 1015 | - unset( $this->fields[ $field_id ]->args['fields'][ $sub_field_id ] ); | |
| 1014 | +		if ( isset( $this->fields[ $field_id ]->args[ 'fields' ][ $sub_field_id ] ) ) { | |
| 1015 | + unset( $this->fields[ $field_id ]->args[ 'fields' ][ $sub_field_id ] ); | |
| 1016 | 1016 | } | 
| 1017 | -		if ( isset( $this->meta_box['fields'][ $field_id ]['fields'][ $sub_field_id ] ) ) { | |
| 1018 | - unset( $this->meta_box['fields'][ $field_id ]['fields'][ $sub_field_id ] ); | |
| 1017 | +		if ( isset( $this->meta_box[ 'fields' ][ $field_id ][ 'fields' ][ $sub_field_id ] ) ) { | |
| 1018 | + unset( $this->meta_box[ 'fields' ][ $field_id ][ 'fields' ][ $sub_field_id ] ); | |
| 1019 | 1019 | } | 
| 1020 | 1020 | return true; | 
| 1021 | 1021 | } | 
| @@ -1039,11 +1039,11 @@ discard block | ||
| 1039 | 1039 | list( $field_id, $sub_field_id ) = $ids; | 
| 1040 | 1040 | |
| 1041 | 1041 |  		if ( ! $sub_field_id ) { | 
| 1042 | - $this->meta_box['fields'][ $field_id ][ $property ] = $value; | |
| 1042 | + $this->meta_box[ 'fields' ][ $field_id ][ $property ] = $value; | |
| 1043 | 1043 | return $field_id; | 
| 1044 | 1044 | } | 
| 1045 | 1045 | |
| 1046 | - $this->meta_box['fields'][ $field_id ]['fields'][ $sub_field_id ][ $property ] = $value; | |
| 1046 | + $this->meta_box[ 'fields' ][ $field_id ][ 'fields' ][ $sub_field_id ][ $property ] = $value; | |
| 1047 | 1047 | return $field_id; | 
| 1048 | 1048 | } | 
| 1049 | 1049 | |
| @@ -1057,7 +1057,7 @@ discard block | ||
| 1057 | 1057 |  	public function get_field_ids( $field_id, $parent_field_id = '' ) { | 
| 1058 | 1058 | $sub_field_id = $parent_field_id ? $field_id : ''; | 
| 1059 | 1059 | $field_id = $parent_field_id ? $parent_field_id : $field_id; | 
| 1060 | - $fields =& $this->meta_box['fields']; | |
| 1060 | + $fields = & $this->meta_box[ 'fields' ]; | |
| 1061 | 1061 | |
| 1062 | 1062 |  		if ( ! array_key_exists( $field_id, $fields ) ) { | 
| 1063 | 1063 | $field_id = $this->search_old_school_array( $field_id, $fields ); | 
| @@ -1071,12 +1071,12 @@ discard block | ||
| 1071 | 1071 | return array( $field_id, $sub_field_id ); | 
| 1072 | 1072 | } | 
| 1073 | 1073 | |
| 1074 | -		if ( 'group' !== $fields[ $field_id ]['type'] ) { | |
| 1074 | +		if ( 'group' !== $fields[ $field_id ][ 'type' ] ) { | |
| 1075 | 1075 | return false; | 
| 1076 | 1076 | } | 
| 1077 | 1077 | |
| 1078 | -		if ( ! array_key_exists( $sub_field_id, $fields[ $field_id ]['fields'] ) ) { | |
| 1079 | - $sub_field_id = $this->search_old_school_array( $sub_field_id, $fields[ $field_id ]['fields'] ); | |
| 1078 | +		if ( ! array_key_exists( $sub_field_id, $fields[ $field_id ][ 'fields' ] ) ) { | |
| 1079 | + $sub_field_id = $this->search_old_school_array( $sub_field_id, $fields[ $field_id ][ 'fields' ] ); | |
| 1080 | 1080 | } | 
| 1081 | 1081 | |
| 1082 | 1082 | return false === $sub_field_id ? false : array( $field_id, $sub_field_id ); |