Completed
Pull Request — trunk (#606)
by
unknown
04:28
created
includes/CMB2_Types.php 2 patches
Spacing   +63 added lines, -63 removed lines patch added patch discarded remove patch
@@ -198,8 +198,8 @@  discard block
 block discarded – undo
198 198
 	 */
199 199
 	public function concat_items( $args = array() ) {
200 200
 
201
-		$method = isset( $args['method'] ) ? $args['method'] : 'select_option';
202
-		unset( $args['method'] );
201
+		$method = isset( $args[ 'method' ] ) ? $args[ 'method' ] : 'select_option';
202
+		unset( $args[ 'method' ] );
203 203
 
204 204
 		$value = $this->field->escaped_value()
205 205
 			? $this->field->escaped_value()
@@ -217,15 +217,15 @@  discard block
 block discarded – undo
217 217
 			// Clone args & modify for just this item
218 218
 			$a = $args;
219 219
 
220
-			$a['value'] = $opt_value;
221
-			$a['label'] = $opt_label;
220
+			$a[ 'value' ] = $opt_value;
221
+			$a[ 'label' ] = $opt_label;
222 222
 
223 223
 			// Check if this option is the value of the input
224 224
 			if ( is_array( $value ) && in_array( $opt_value, $value ) ) {
225
-				$a['checked'] = 'checked';
225
+				$a[ 'checked' ] = 'checked';
226 226
 			}
227 227
 			else if ( $value == $opt_value ) {
228
-				$a['checked'] = 'checked';
228
+				$a[ 'checked' ] = 'checked';
229 229
 			}
230 230
 
231 231
 			$concatenated_items .= $this->$method( $a, $i++ );
@@ -241,7 +241,7 @@  discard block
 block discarded – undo
241 241
 	 * @return string       Generated option element html
242 242
 	 */
243 243
 	public function select_option( $args = array() ) {
244
-		return sprintf( "\t" . '<option value="%s" %s>%s</option>', $args['value'], selected( isset( $args['checked'] ) && $args['checked'], true, false ), $args['label'] ) . "\n";
244
+		return sprintf( "\t" . '<option value="%s" %s>%s</option>', $args[ 'value' ], selected( isset( $args[ 'checked' ] ) && $args[ 'checked' ], true, false ), $args[ 'label' ] ) . "\n";
245 245
 	}
246 246
 
247 247
 	/**
@@ -261,7 +261,7 @@  discard block
 block discarded – undo
261 261
 			'label' => '',
262 262
 		) );
263 263
 
264
-		return sprintf( "\t" . '<li><input%s/> <label for="%s">%s</label></li>' . "\n", $this->concat_attrs( $a, array( 'label' ) ), $a['id'], $a['label'] );
264
+		return sprintf( "\t" . '<li><input%s/> <label for="%s">%s</label></li>' . "\n", $this->concat_attrs( $a, array( 'label' ) ), $a[ 'id' ], $a[ 'label' ] );
265 265
 	}
266 266
 
267 267
 	/**
@@ -273,10 +273,10 @@  discard block
 block discarded – undo
273 273
 	 */
274 274
 	public function list_input_checkbox( $args, $i ) {
275 275
 		$saved_value = $this->field->escaped_value();
276
-		if ( is_array( $saved_value ) && in_array( $args['value'], $saved_value ) ) {
277
-			$args['checked'] = 'checked';
276
+		if ( is_array( $saved_value ) && in_array( $args[ 'value' ], $saved_value ) ) {
277
+			$args[ 'checked' ] = 'checked';
278 278
 		}
279
-		$args['type'] = 'checkbox';
279
+		$args[ 'type' ] = 'checkbox';
280 280
 		return $this->list_input( $args, $i );
281 281
 	}
282 282
 
@@ -427,11 +427,11 @@  discard block
 block discarded – undo
427 427
 			'js_dependencies' => array(),
428 428
 		) );
429 429
 
430
-		if ( ! empty( $a['js_dependencies'] ) ) {
431
-			CMB2_JS::add_dependencies( $a['js_dependencies'] );
430
+		if ( ! empty( $a[ 'js_dependencies' ] ) ) {
431
+			CMB2_JS::add_dependencies( $a[ 'js_dependencies' ] );
432 432
 		}
433 433
 
434
-		return sprintf( '<input%s/>%s', $this->concat_attrs( $a, array( 'desc', 'js_dependencies' ) ), $a['desc'] );
434
+		return sprintf( '<input%s/>%s', $this->concat_attrs( $a, array( 'desc', 'js_dependencies' ) ), $a[ 'desc' ] );
435 435
 	}
436 436
 
437 437
 	/**
@@ -450,7 +450,7 @@  discard block
 block discarded – undo
450 450
 			'value' => $this->field->escaped_value( 'esc_textarea' ),
451 451
 			'desc'  => $this->_desc( true ),
452 452
 		) );
453
-		return sprintf( '<textarea%s>%s</textarea>%s', $this->concat_attrs( $a, array( 'desc', 'value' ) ), $a['value'], $a['desc'] );
453
+		return sprintf( '<textarea%s>%s</textarea>%s', $this->concat_attrs( $a, array( 'desc', 'value' ) ), $a[ 'value' ], $a[ 'desc' ] );
454 454
 	}
455 455
 
456 456
 	/**
@@ -501,8 +501,8 @@  discard block
 block discarded – undo
501 501
 			'options' => $this->field->options(),
502 502
 		) );
503 503
 
504
-		wp_editor( $a['value'], $a['id'], $a['options'] );
505
-		echo $a['desc'];
504
+		wp_editor( $a[ 'value' ], $a[ 'id' ], $a[ 'options' ] );
505
+		echo $a[ 'desc' ];
506 506
 	}
507 507
 
508 508
 	public function text_date( $args = array() ) {
@@ -513,7 +513,7 @@  discard block
 block discarded – undo
513 513
 			'js_dependencies' => array( 'jquery-ui-core', 'jquery-ui-datepicker' ),
514 514
 		) );
515 515
 
516
-		if ( false === strpos( $args['class'], 'timepicker' ) ) {
516
+		if ( false === strpos( $args[ 'class' ], 'timepicker' ) ) {
517 517
 			$this->parse_picker_options( 'date' );
518 518
 		}
519 519
 
@@ -545,34 +545,34 @@  discard block
 block discarded – undo
545 545
 			'timepicker' => array(),
546 546
 		) );
547 547
 
548
-		if ( empty( $args['value'] ) ) {
549
-			$args['value'] = $this->field->escaped_value();
548
+		if ( empty( $args[ 'value' ] ) ) {
549
+			$args[ 'value' ] = $this->field->escaped_value();
550 550
 			// This will be used if there is a select_timezone set for this field
551 551
 			$tz_offset = $this->field->field_timezone_offset();
552 552
 			if ( ! empty( $tz_offset ) ) {
553
-				$args['value'] -= $tz_offset;
553
+				$args[ 'value' ] -= $tz_offset;
554 554
 			}
555 555
 		}
556 556
 
557
-		$has_good_value = ! empty( $args['value'] ) && ! is_array( $args['value'] );
557
+		$has_good_value = ! empty( $args[ 'value' ] ) && ! is_array( $args[ 'value' ] );
558 558
 
559
-		$date_args = wp_parse_args( $args['datepicker'], array(
559
+		$date_args = wp_parse_args( $args[ 'datepicker' ], array(
560 560
 			'class' => 'cmb2-text-small cmb2-datepicker',
561 561
 			'name'  => $this->_name( '[date]' ),
562 562
 			'id'    => $this->_id( '_date' ),
563
-			'value' => $has_good_value ? $this->field->get_timestamp_format( 'date_format', $args['value'] ) : '',
563
+			'value' => $has_good_value ? $this->field->get_timestamp_format( 'date_format', $args[ 'value' ] ) : '',
564 564
 			'desc'  => '',
565 565
 		) );
566 566
 
567 567
 		// Let's get the date-format, and set it up as a data attr for the field.
568 568
 		$date_args = $this->parse_picker_options( 'date', $date_args );
569 569
 
570
-		$time_args = wp_parse_args( $args['timepicker'], array(
570
+		$time_args = wp_parse_args( $args[ 'timepicker' ], array(
571 571
 			'class' => 'cmb2-timepicker text-time',
572 572
 			'name'  => $this->_name( '[time]' ),
573 573
 			'id'    => $this->_id( '_time' ),
574
-			'value' => $has_good_value ? $this->field->get_timestamp_format( 'time_format', $args['value'] ) : '',
575
-			'desc'  => $args['desc'],
574
+			'value' => $has_good_value ? $this->field->get_timestamp_format( 'time_format', $args[ 'value' ] ) : '',
575
+			'desc'  => $args[ 'desc' ],
576 576
 			'js_dependencies' => array( 'jquery-ui-core', 'jquery-ui-datepicker', 'jquery-ui-datetimepicker' ),
577 577
 		) );
578 578
 
@@ -590,12 +590,12 @@  discard block
 block discarded – undo
590 590
 			'select_timezone'         => array(),
591 591
 		) );
592 592
 
593
-		$args['value'] = $this->field->escaped_value();
594
-		if ( is_array( $args['value'] ) ) {
595
-			$args['value'] = '';
593
+		$args[ 'value' ] = $this->field->escaped_value();
594
+		if ( is_array( $args[ 'value' ] ) ) {
595
+			$args[ 'value' ] = '';
596 596
 		}
597 597
 
598
-		$datetime = maybe_unserialize( $args['value'] );
598
+		$datetime = maybe_unserialize( $args[ 'value' ] );
599 599
 		$value = $tzstring = '';
600 600
 
601 601
 		if ( $datetime && $datetime instanceof DateTime ) {
@@ -604,24 +604,24 @@  discard block
 block discarded – undo
604 604
 			$value    = $datetime->getTimestamp();
605 605
 		}
606 606
 
607
-		$timestamp_args = wp_parse_args( $args['text_datetime_timestamp'], array(
607
+		$timestamp_args = wp_parse_args( $args[ 'text_datetime_timestamp' ], array(
608 608
 			'desc'  => '',
609 609
 			'value' => $value,
610 610
 		) );
611 611
 
612
-		$timezone_args = wp_parse_args( $args['select_timezone'], array(
612
+		$timezone_args = wp_parse_args( $args[ 'select_timezone' ], array(
613 613
 			'class'   => 'cmb2_select cmb2-select-timezone',
614 614
 			'name'    => $this->_name( '[timezone]' ),
615 615
 			'id'      => $this->_id( '_timezone' ),
616 616
 			'options' => wp_timezone_choice( $tzstring ),
617
-			'desc'    => $args['desc'],
617
+			'desc'    => $args[ 'desc' ],
618 618
 		) );
619 619
 
620 620
 		return $this->text_datetime_timestamp( $timestamp_args ) . "\n" . $this->select( $timezone_args );
621 621
 	}
622 622
 
623 623
 	public function select_timezone() {
624
-		$this->field->args['default'] = $this->field->args( 'default' )
624
+		$this->field->args[ 'default' ] = $this->field->args( 'default' )
625 625
 			? $this->field->args( 'default' )
626 626
 			: cmb2_utils()->timezone_string();
627 627
 
@@ -663,7 +663,7 @@  discard block
 block discarded – undo
663 663
 			'desc'  => $this->_desc( true ),
664 664
 		) );
665 665
 
666
-		return sprintf( '<%1$s class="%2$s">%3$s</%1$s>%4$s', $a['tag'], $a['class'], $a['name'], $a['desc'] );
666
+		return sprintf( '<%1$s class="%2$s">%3$s</%1$s>%4$s', $a[ 'tag' ], $a[ 'class' ], $a[ 'name' ], $a[ 'desc' ] );
667 667
 	}
668 668
 
669 669
 	public function select( $args = array() ) {
@@ -676,7 +676,7 @@  discard block
 block discarded – undo
676 676
 		) );
677 677
 
678 678
 		$attrs = $this->concat_attrs( $a, array( 'desc', 'options' ) );
679
-		return sprintf( '<select%s>%s</select>%s', $attrs, $a['options'], $a['desc'] );
679
+		return sprintf( '<select%s>%s</select>%s', $attrs, $a[ 'options' ], $a[ 'desc' ] );
680 680
 	}
681 681
 
682 682
 	public function multiselect( $args = array() ) {
@@ -686,7 +686,7 @@  discard block
 block discarded – undo
686 686
 			'name'     => $this->_name(),
687 687
 		) );
688 688
 
689
-		$a['name'] = $a['name'] . '[]';
689
+		$a[ 'name' ] = $a[ 'name' ] . '[]';
690 690
 
691 691
 		return $this->select( $a );
692 692
 	}
@@ -694,11 +694,11 @@  discard block
 block discarded – undo
694 694
 	public function taxonomy_select() {
695 695
 
696 696
 		$names      = $this->get_object_terms();
697
-		$saved_term = is_wp_error( $names ) || empty( $names ) ? $this->field->args( 'default' ) : $names[key( $names )]->slug;
697
+		$saved_term = is_wp_error( $names ) || empty( $names ) ? $this->field->args( 'default' ) : $names[ key( $names ) ]->slug;
698 698
 		$terms      = get_terms( $this->field->args( 'taxonomy' ), 'hide_empty=0' );
699 699
 		$options    = '';
700 700
 
701
-		$option_none  = $this->field->args( 'show_option_none' );
701
+		$option_none = $this->field->args( 'show_option_none' );
702 702
 		if ( ! empty( $option_none ) ) {
703 703
 			$option_none_value = apply_filters( 'cmb2_taxonomy_select_default_value', '' );
704 704
 			$option_none_value = apply_filters( "cmb2_taxonomy_select_{$this->_id()}_default_value", $option_none_value );
@@ -728,7 +728,7 @@  discard block
 block discarded – undo
728 728
 			'desc'    => $this->_desc( true ),
729 729
 		) );
730 730
 
731
-		return sprintf( '<ul class="%s">%s</ul>%s', $a['class'], $a['options'], $a['desc'] );
731
+		return sprintf( '<ul class="%s">%s</ul>%s', $a[ 'class' ], $a[ 'options' ], $a[ 'desc' ] );
732 732
 	}
733 733
 
734 734
 	public function radio_inline() {
@@ -763,7 +763,7 @@  discard block
 block discarded – undo
763 763
 			: $is_checked;
764 764
 
765 765
 		if ( $is_checked ) {
766
-			$defaults['checked'] = 'checked';
766
+			$defaults[ 'checked' ] = 'checked';
767 767
 		}
768 768
 
769 769
 		$args = $this->parse_args( $args, 'checkbox', $defaults );
@@ -773,14 +773,14 @@  discard block
 block discarded – undo
773 773
 
774 774
 	public function taxonomy_radio() {
775 775
 		$names      = $this->get_object_terms();
776
-		$saved_term = is_wp_error( $names ) || empty( $names ) ? $this->field->args( 'default' ) : $names[key( $names )]->slug;
776
+		$saved_term = is_wp_error( $names ) || empty( $names ) ? $this->field->args( 'default' ) : $names[ key( $names ) ]->slug;
777 777
 		$terms      = get_terms( $this->field->args( 'taxonomy' ), 'hide_empty=0' );
778 778
 		$options    = ''; $i = 1;
779 779
 
780 780
 		if ( ! $terms ) {
781 781
 			$options .= sprintf( '<li><label>%s</label></li>', esc_html( $this->_text( 'no_terms_text', __( 'No terms', 'cmb2' ) ) ) );
782 782
 		} else {
783
-			$option_none  = $this->field->args( 'show_option_none' );
783
+			$option_none = $this->field->args( 'show_option_none' );
784 784
 			if ( ! empty( $option_none ) ) {
785 785
 				$option_none_value = apply_filters( "cmb2_taxonomy_radio_{$this->_id()}_default_value", apply_filters( 'cmb2_taxonomy_radio_default_value', '' ) );
786 786
 				$args = array(
@@ -788,7 +788,7 @@  discard block
 block discarded – undo
788 788
 					'label' => $option_none,
789 789
 				);
790 790
 				if ( $saved_term == $option_none_value ) {
791
-					$args['checked'] = 'checked';
791
+					$args[ 'checked' ] = 'checked';
792 792
 				}
793 793
 				$options .= $this->list_input( $args, $i );
794 794
 				$i++;
@@ -801,7 +801,7 @@  discard block
 block discarded – undo
801 801
 				);
802 802
 
803 803
 				if ( $saved_term == $term->slug ) {
804
-					$args['checked'] = 'checked';
804
+					$args[ 'checked' ] = 'checked';
805 805
 				}
806 806
 				$options .= $this->list_input( $args, $i );
807 807
 				$i++;
@@ -838,7 +838,7 @@  discard block
 block discarded – undo
838 838
 				);
839 839
 
840 840
 				if ( is_array( $saved_terms ) && in_array( $term->slug, $saved_terms ) ) {
841
-					$args['checked'] = 'checked';
841
+					$args[ 'checked' ] = 'checked';
842 842
 				}
843 843
 				$options .= $this->list_input( $args, $i );
844 844
 				$i++;
@@ -943,7 +943,7 @@  discard block
 block discarded – undo
943 943
 		$query_args = $this->field->args( 'query_args' );
944 944
 
945 945
 		// if options array and 'url' => false, then hide the url field
946
-		$input_type = array_key_exists( 'url', $options ) && false === $options['url'] ? 'hidden' : 'text';
946
+		$input_type = array_key_exists( 'url', $options ) && false === $options[ 'url' ] ? 'hidden' : 'text';
947 947
 
948 948
 		echo $this->input( array(
949 949
 			'type'  => $input_type,
@@ -964,8 +964,8 @@  discard block
 block discarded – undo
964 964
 		// Reset field args for attachment ID
965 965
 		$args = $this->field->args();
966 966
 		// If we're looking at a file in a group, we need to get the non-prefixed id
967
-		$args['id'] = ( $this->field->group ? $this->field->args( '_id' ) : $cached_id ) . '_id';
968
-		unset( $args['_id'], $args['_name'] );
967
+		$args[ 'id' ] = ( $this->field->group ? $this->field->args( '_id' ) : $cached_id ) . '_id';
968
+		unset( $args[ '_id' ], $args[ '_name' ] );
969 969
 
970 970
 		// And get new field object
971 971
 		$this->field = new CMB2_Field( array(
@@ -997,7 +997,7 @@  discard block
 block discarded – undo
997 997
 				if ( $_id_value ) {
998 998
 					$image = wp_get_attachment_image( $_id_value, $img_size, null, array( 'class' => 'cmb-file-field-image' ) );
999 999
 				} else {
1000
-					$size = is_array( $img_size ) ? $img_size[0] : 350;
1000
+					$size = is_array( $img_size ) ? $img_size[ 0 ] : 350;
1001 1001
 					$image = '<img style="max-width: ' . absint( $size ) . 'px; width: 100%; height: auto;" src="' . $meta_value . '" alt="" />';
1002 1002
 				}
1003 1003
 
@@ -1028,11 +1028,11 @@  discard block
 block discarded – undo
1028 1028
 	 */
1029 1029
 	public function img_status_output( $args ) {
1030 1030
 		printf( '<%1$s class="img-status">%2$s<p class="cmb2-remove-wrapper"><a href="#" class="cmb2-remove-file-button"%3$s>%4$s</a></p>%5$s</%1$s>',
1031
-			$args['tag'],
1032
-			$args['image'],
1033
-			isset( $args['cached_id'] ) ? ' rel="' . $args['cached_id'] . '"' : '',
1031
+			$args[ 'tag' ],
1032
+			$args[ 'image' ],
1033
+			isset( $args[ 'cached_id' ] ) ? ' rel="' . $args[ 'cached_id' ] . '"' : '',
1034 1034
 			esc_html( $this->_text( 'remove_image_text', __( 'Remove Image', 'cmb2' ) ) ),
1035
-			isset( $args['id_input'] ) ? $args['id_input'] : ''
1035
+			isset( $args[ 'id_input' ] ) ? $args[ 'id_input' ] : ''
1036 1036
 		);
1037 1037
 	}
1038 1038
 
@@ -1044,14 +1044,14 @@  discard block
 block discarded – undo
1044 1044
 	 */
1045 1045
 	public function file_status_output( $args ) {
1046 1046
 		printf( '<%1$s class="file-status"><span>%2$s <strong>%3$s</strong></span>&nbsp;&nbsp; (<a href="%4$s" target="_blank" rel="external">%5$s</a> / <a href="#" class="cmb2-remove-file-button"%6$s>%7$s</a>)%8$s</%1$s>',
1047
-			$args['tag'],
1047
+			$args[ 'tag' ],
1048 1048
 			esc_html( $this->_text( 'file_text', __( 'File:', 'cmb2' ) ) ),
1049
-			$this->get_file_name_from_path( $args['value'] ),
1050
-			$args['value'],
1049
+			$this->get_file_name_from_path( $args[ 'value' ] ),
1050
+			$args[ 'value' ],
1051 1051
 			esc_html( $this->_text( 'file_download_text', __( 'Download', 'cmb2' ) ) ),
1052
-			isset( $args['cached_id'] ) ? ' rel="' . $args['cached_id'] . '"' : '',
1052
+			isset( $args[ 'cached_id' ] ) ? ' rel="' . $args[ 'cached_id' ] . '"' : '',
1053 1053
 			esc_html( $this->_text( 'remove_text', __( 'Remove', 'cmb2' ) ) ),
1054
-			isset( $args['id_input'] ) ? $args['id_input'] : ''
1054
+			isset( $args[ 'id_input' ] ) ? $args[ 'id_input' ] : ''
1055 1055
 		);
1056 1056
 	}
1057 1057
 
@@ -1073,8 +1073,8 @@  discard block
 block discarded – undo
1073 1073
 			if ( $update ) {
1074 1074
 				$atts = $this->field->args( 'attributes' );
1075 1075
 			} else {
1076
-				$atts = isset( $args['attributes'] )
1077
-					? $args['attributes']
1076
+				$atts = isset( $args[ 'attributes' ] )
1077
+					? $args[ 'attributes' ]
1078 1078
 					: $atts;
1079 1079
 			}
1080 1080
 
@@ -1090,7 +1090,7 @@  discard block
 block discarded – undo
1090 1090
 		}
1091 1091
 
1092 1092
 		if ( $update ) {
1093
-			$this->field->args['attributes'] = $atts;
1093
+			$this->field->args[ 'attributes' ] = $atts;
1094 1094
 		}
1095 1095
 
1096 1096
 		return array_merge( $args, $atts );
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -223,8 +223,7 @@
 block discarded – undo
223 223
 			// Check if this option is the value of the input
224 224
 			if ( is_array( $value ) && in_array( $opt_value, $value ) ) {
225 225
 				$a['checked'] = 'checked';
226
-			}
227
-			else if ( $value == $opt_value ) {
226
+			} else if ( $value == $opt_value ) {
228 227
 				$a['checked'] = 'checked';
229 228
 			}
230 229
 
Please login to merge, or discard this patch.