Issues in BookingOptions.php (master) - Issues in master - WeareJH/Flexitime - Measure and Improve Code Quality continuously with Scrutinizer

Issues (164)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/JhFlexiTime/Options/BookingOptions.php (1 issue)

Labels

Bug 1

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace JhFlexiTime\Options;

use Zend\Stdlib\AbstractOptions;

/**
 * Class BookingOptions
 * @package JhFlexiTime\Options
 * @author Aydin Hassan <[email protected]>
 */
class BookingOptions extends AbstractOptions implements BookingOptionsInterface
{

    /**
     * @var false|string
     */
    protected $minStartTime = false;

    /**
     * @var false|string
     */
    protected $maxStartTime = false;

    /**
     * @var false|string
     */
    protected $minEndTime = false;

    /**
     * @var false|string
     */
    protected $maxEndTime = false;

    /**
     * @return bool|string
     */
    public function getMinStartTime()
    {
        return $this->minStartTime;
    }

        /**
     * @return bool|string
     */
    public function getMaxStartTime()
    {
        return $this->maxStartTime;
    }

    /**
     * @return bool|string
     */
    public function getMinEndTime()
    {
        return $this->minEndTime;
    }

    /**
     * @return bool|string
     */
    public function getMaxEndTime()
    {
        return $this->maxEndTime;
    }

    /**
     * @param string $key
     * @param string|false $value
     * @throws \InvalidArgumentException
     * @throws \BadMethodCallException
     */
    public function __set($key, $value)
    {
        $property = lcfirst(str_replace(' ', '', ucwords(str_replace('_', ' ', $key))));
        if (property_exists($this, $property)) {

            if ($this->validateTime($value)) {

                $this->$property = $value;
            } else {
                throw new \InvalidArgumentException(sprintf("%s should be a 24 hour time in the format HH:MM", $key));
            }
        } else {
            throw new \BadMethodCallException(
                sprintf('The option "%s" is not a valid property', $key)
            );
        }
    }

    /**
     * @param string $time
     * @return bool
     */
    public function validateTime($time)
    {
        if ($time === false) {
            return true;
        }

        if (preg_match("/(2[0-3]|[01][0-9]):[0-5][0-9]/", $time)) {
            return true;
        }

        return false;
    }
}


1			<?php
2
3			namespace JhFlexiTime\Options;
4
5			use Zend\Stdlib\AbstractOptions;
6
7			/**
8			* Class BookingOptions
9			* @package JhFlexiTime\Options
10			* @author Aydin Hassan <[email protected]>
11			*/
12			class BookingOptions extends AbstractOptions implements BookingOptionsInterface
13			{
14
15			/**
16			* @var false\|string
17			*/
18			protected $minStartTime = false;
19
20			/**
21			* @var false\|string
22			*/
23			protected $maxStartTime = false;
24
25			/**
26			* @var false\|string
27			*/
28			protected $minEndTime = false;
29
30			/**
31			* @var false\|string
32			*/
33			protected $maxEndTime = false;
34
35			/**
36			* @return bool\|string
37			*/
38			public function getMinStartTime()
39			{
40			return $this->minStartTime;
41			}
42
43			/**
44			* @return bool\|string
45			*/
46			public function getMaxStartTime()
47			{
48			return $this->maxStartTime;
49			}
50
51			/**
52			* @return bool\|string
53			*/
54			public function getMinEndTime()
55			{
56			return $this->minEndTime;
57			}
58
59			/**
60			* @return bool\|string
61			*/
62			public function getMaxEndTime()
63			{
64			return $this->maxEndTime;
65			}
66
67			/**
68			* @param string $key
69			* @param string\|false $value
70			* @throws \InvalidArgumentException
71			* @throws \BadMethodCallException
72			*/
73			public function __set($key, $value)
74			{
75			$property = lcfirst(str_replace(' ', '', ucwords(str_replace('_', ' ', $key))));
76			if (property_exists($this, $property)) {
77
78			if ($this->validateTime($value)) {
			0 ignored issues – show Bug introduced 2016-12-14 12:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$value` defined by parameter `$value` on line 73 can also be of type `false`; however, `JhFlexiTime\Options\BookingOptions::validateTime()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
79			$this->$property = $value;
80			} else {
81			throw new \InvalidArgumentException(sprintf("%s should be a 24 hour time in the format HH:MM", $key));
82			}
83			} else {
84			throw new \BadMethodCallException(
85			sprintf('The option "%s" is not a valid property', $key)
86			);
87			}
88			}
89
90			/**
91			* @param string $time
92			* @return bool
93			*/
94			public function validateTime($time)
95			{
96			if ($time === false) {
97			return true;
98			}
99
100			if (preg_match("/(2[0-3]\|[01][0-9]):[0-5][0-9]/", $time)) {
101			return true;
102			}
103
104			return false;
105			}
106			}
107

WeareJH / Flexitime

Issues (164)

Security Analysis not enabled

src/JhFlexiTime/Options/BookingOptions.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like