JhFlexiTime\Options\BookingOptions

Complexity

Total Complexity

10

Size/Duplication

Total Lines	95
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	getMinStartTime()	0	4	1
A	getMaxStartTime()	0	4	1
A	getMinEndTime()	0	4	1
A	getMaxEndTime()	0	4	1
A	__set()	0	16	3
A	validateTime()	0	12	3

<?php

namespace JhFlexiTime\Options;

use Zend\Stdlib\AbstractOptions;

/**
 * Class BookingOptions
 * @package JhFlexiTime\Options
 * @author Aydin Hassan <aydin@wearejh.com>
 */
class BookingOptions extends AbstractOptions implements BookingOptionsInterface
{

    /**
     * @var false|string
     */
    protected $minStartTime = false;

    /**
     * @var false|string
     */
    protected $maxStartTime = false;

    /**
     * @var false|string
     */
    protected $minEndTime = false;

    /**
     * @var false|string
     */
    protected $maxEndTime = false;

    /**
     * @return bool|string
     */
    public function getMinStartTime()
    {
        return $this->minStartTime;
    }

        /**
     * @return bool|string
     */
    public function getMaxStartTime()
    {
        return $this->maxStartTime;
    }

    /**
     * @return bool|string
     */
    public function getMinEndTime()
    {
        return $this->minEndTime;
    }

    /**
     * @return bool|string
     */
    public function getMaxEndTime()
    {
        return $this->maxEndTime;
    }

    /**
     * @param string $key
     * @param string|false $value
     * @throws \InvalidArgumentException
     * @throws \BadMethodCallException
     */
    public function __set($key, $value)
    {
        $property = lcfirst(str_replace(' ', '', ucwords(str_replace('_', ' ', $key))));
        if (property_exists($this, $property)) {

            if ($this->validateTime($value)) {

It seems like $value defined by parameter $value on line 73 can also be of type false; however, JhFlexiTime\Options\BookingOptions::validateTime() does only seem to accept string, maybe add an additional type check?

                $this->$property = $value;
            } else {
                throw new \InvalidArgumentException(sprintf("%s should be a 24 hour time in the format HH:MM", $key));
            }
        } else {
            throw new \BadMethodCallException(
                sprintf('The option "%s" is not a valid property', $key)
            );
        }
    }

    /**
     * @param string $time
     * @return bool
     */
    public function validateTime($time)
    {
        if ($time === false) {
            return true;
        }

        if (preg_match("/(2[0-3]|[01][0-9]):[0-5][0-9]/", $time)) {
            return true;
        }

        return false;
    }
}