BalanceRepositoryFactory::createService()   A
last analyzed

Complexity

Conditions 1
Paths 1

Size

Total Lines 7
Code Lines 4

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
c 0
b 0
f 0
dl 0
loc 7
rs 9.4285
cc 1
eloc 4
nc 1
nop 1
1
<?php
2
namespace JhFlexiTime\Repository\Factory;
3
 
4
use JhFlexiTime\Repository\BalanceRepository;
5
use Zend\ServiceManager\FactoryInterface;
6
use Zend\ServiceManager\ServiceLocatorInterface;
7
8
/**
9
 * Class BalanceRepositoryFactory
10
 * @package JhFlexiTime\Repository\Factory
11
 * @author Aydin Hassan <[email protected]>
12
 */
13
class BalanceRepositoryFactory implements FactoryInterface
14
{
15
    /**
16
     * @param \Zend\ServiceManager\ServiceLocatorInterface $serviceLocator
17
     * @return \JhFlexiTime\Repository\BalanceRepository
18
     */
19
    public function createService(ServiceLocatorInterface $serviceLocator)
20
    {
21
        return new BalanceRepository(
22
            $serviceLocator->get('JhFlexiTime\ObjectManager')->getRepository('JhFlexiTime\Entity\RunningBalance'),
23
            $serviceLocator->get('JhFlexiTime\ObjectManager')
0 ignored issues
show
Documentation introduced by
$serviceLocator->get('Jh...xiTime\\ObjectManager') is of type object|array, but the function expects a object<Doctrine\Common\Persistence\ObjectManager>.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
24
        );
25
    }
26
}
27