BalanceRepositoryFactory - Code Metrics - WeareJH/Flexitime - Measure and Improve Code Quality continuously with Scrutinizer

BalanceRepositoryFactory A
last analyzed 2016-12-14 12:13 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	14
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

Metric	Value
wmc	1
c	0
b	0
f	0
lcom	0
cbo	2
dl	0
loc	14
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
A	createService()	0	7	1

<?php
namespace JhFlexiTime\Repository\Factory;
 
use JhFlexiTime\Repository\BalanceRepository;
use Zend\ServiceManager\FactoryInterface;
use Zend\ServiceManager\ServiceLocatorInterface;

/**
 * Class BalanceRepositoryFactory
 * @package JhFlexiTime\Repository\Factory
 * @author Aydin Hassan <[email protected]>
 */
class BalanceRepositoryFactory implements FactoryInterface
{
    /**
     * @param \Zend\ServiceManager\ServiceLocatorInterface $serviceLocator
     * @return \JhFlexiTime\Repository\BalanceRepository
     */
    public function createService(ServiceLocatorInterface $serviceLocator)
    {
        return new BalanceRepository(
            $serviceLocator->get('JhFlexiTime\ObjectManager')->getRepository('JhFlexiTime\Entity\RunningBalance'),
            $serviceLocator->get('JhFlexiTime\ObjectManager')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );
    }
}


1			<?php
2			namespace JhFlexiTime\Repository\Factory;
3
4			use JhFlexiTime\Repository\BalanceRepository;
5			use Zend\ServiceManager\FactoryInterface;
6			use Zend\ServiceManager\ServiceLocatorInterface;
7
8			/**
9			* Class BalanceRepositoryFactory
10			* @package JhFlexiTime\Repository\Factory
11			* @author Aydin Hassan <[email protected]>
12			*/
13			class BalanceRepositoryFactory implements FactoryInterface
14			{
15			/**
16			* @param \Zend\ServiceManager\ServiceLocatorInterface $serviceLocator
17			* @return \JhFlexiTime\Repository\BalanceRepository
18			*/
19			public function createService(ServiceLocatorInterface $serviceLocator)
20			{
21			return new BalanceRepository(
22			$serviceLocator->get('JhFlexiTime\ObjectManager')->getRepository('JhFlexiTime\Entity\RunningBalance'),
23			$serviceLocator->get('JhFlexiTime\ObjectManager')
			0 ignored issues – show Documentation introduced 2016-12-14 12:09 UTC by Report Bug Copy Issue Report `$serviceLocator->get('Jh...xiTime\\ObjectManager')` is of type `object\|array`, but the function expects a `object<Doctrine\Common\Persistence\ObjectManager>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
24			);
25			}
26			}
27

WeareJH / Flexitime

BalanceRepositoryFactory A last analyzed 2016-12-14 12:13 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like

BalanceRepositoryFactory A
last analyzed 2016-12-14 12:13 UTC