Wabel / zoho-crm-copy-db

src/ZohoCopyDatabaseCommand.php

Doc Comments -1 removed lines

@@ -45,7 +45,6 @@
     /**
      * @param ZohoDatabaseCopier                $zohoDatabaseCopier
      * @param \Wabel\Zoho\CRM\AbstractZohoDao[] $zohoDaos           The list of Zoho DAOs to copy
-     * @param Lock                              $lock               A lock that can be used to avoid running the same command twice at the same time
      */
     public function __construct(ZohoDatabaseCopier $zohoDatabaseCopier, ZohoDatabaseSyncZoho $zohoDatabaseSync, array $zohoDaos, Lock $lockCopy = null, Lock $lockSync = null)
     {

Spacing +4 added lines, -4 removed lines

@@ -62,7 +62,7 @@ 
         $this
             ->setName('zoho:copy-db')
             ->setDescription('Copies the Zoho database in local DB tables and synchronize Zoho CRM from the Zoho database.')
-            ->addArgument("action",  InputArgument::REQUIRED, "Specify 'copy' or 'sync'")
+            ->addArgument("action", InputArgument::REQUIRED, "Specify 'copy' or 'sync'")
             ->addOption("reset", "r", InputOption::VALUE_NONE, 'Get a fresh copy of Zoho (rather than doing incremental copy)')
             ->addOption("trigger", "t", InputOption::VALUE_NONE, 'Create or update the triggers');
     }
@@ -88,7 +88,7 @@ 
      * @param InputInterface $input
      * @param OutputInterface $output
      */
-    private function copyDb(InputInterface $input, OutputInterface $output){
+    private function copyDb(InputInterface $input, OutputInterface $output) {
         try {
             if ($this->lockCopy) {
                 $this->lockCopy->acquireLock();
@@ -102,7 +102,7 @@ 
 
             $forceCreateTrigger = false;
 
-            if($input->getOption('trigger')){
+            if ($input->getOption('trigger')) {
                 $forceCreateTrigger = true;
             }
             $twoWaysSync = true;
@@ -127,7 +127,7 @@ 
      * @param InputInterface $input
      * @param OutputInterface $output
      */
-    private function syncDb(InputInterface $input, OutputInterface $output){
+    private function syncDb(InputInterface $input, OutputInterface $output) {
         try {
             if ($this->lockSync) {
                 $this->lockSync->acquireLock();

src/ZohoDatabaseSyncZoho.php

Doc Comments -1 removed lines

@@ -30,7 +30,6 @@
     private $logger;
 
     /**
-     * @param \Wabel\Zoho\CRM\AbstractZohoDao[] $zohoDaos           The list of Zoho DAOs to copy
      * @param Connection $connection
      *
      */

Unused Use Statements -2 removed lines

@@ -7,8 +7,6 @@
 use Psr\Log\NullLogger;
 use Wabel\Zoho\CRM\AbstractZohoDao;
 use Wabel\Zoho\CRM\ZohoBeanInterface;
-use Wabel\Zoho\CRM\Exception\ZohoCRMException;
-use Wabel\Zoho\CRM\Exception\ZohoCRMResponseException;
 use function Stringy\create as s;
 
 /**

Indentation +7 added lines, -7 removed lines

@@ -46,10 +46,10 @@ 
     }
 
 /**
-     *
-     * @param AbstractZohoDao $zohoDao
-     * @return array
-     */
+ *
+ * @param AbstractZohoDao $zohoDao
+ * @return array
+ */
     private function findMethodValues(AbstractZohoDao $zohoDao){
         $fieldsMatching = array();
         foreach ($zohoDao->getFields() as $fieldsDescriptor) {
@@ -96,9 +96,9 @@ 
                         if (in_array($columnName,['id','uid'])) {
                             continue;
                         }else{
-                           if($columnValue){
-                               $zohoBean->{$fieldsMatching[$columnName]['setter']}($columnValue);
-                           }
+                            if($columnValue){
+                                $zohoBean->{$fieldsMatching[$columnName]['setter']}($columnValue);
+                            }
                         }
 
                     }

Spacing +18 added lines, -18 removed lines

@@ -50,7 +50,7 @@ 
      * @param AbstractZohoDao $zohoDao
      * @return array
      */
-    private function findMethodValues(AbstractZohoDao $zohoDao){
+    private function findMethodValues(AbstractZohoDao $zohoDao) {
         $fieldsMatching = array();
         foreach ($zohoDao->getFields() as $fieldsDescriptor) {
             foreach (array_values($fieldsDescriptor) as $fieldDescriptor) {
@@ -68,14 +68,14 @@ 
      * @param AbstractZohoDao $zohoDao
      * @param string $localTable
      */
-    public function pushDataToZoho(AbstractZohoDao $zohoDao, $localTable, $update = false){
+    public function pushDataToZoho(AbstractZohoDao $zohoDao, $localTable, $update = false) {
 
             $fieldsMatching = $this->findMethodValues($zohoDao);
             $tableName = $this->getTableName($zohoDao);
             $rowsDeleted = [];
             $statement = $this->connection->createQueryBuilder();
             $statement->select('zcrm.*');
-            if($update){
+            if ($update) {
                 $statement->addSelect('l.field_name as updated_fieldname');
             }
             $statement->from($localTable, 'l')
@@ -91,25 +91,25 @@ 
                 $beanClassName = $zohoDao->getBeanClassName();
                 /* @var $zohoBean ZohoBeanInterface */
                 $zohoBean = new $beanClassName();
-                if(!$update){
+                if (!$update) {
                     foreach ($row as $columnName => $columnValue) {
-                        if (in_array($columnName,['id','uid'])) {
+                        if (in_array($columnName, ['id', 'uid'])) {
                             continue;
-                        }else{
-                           if($columnValue){
+                        } else {
+                           if ($columnValue) {
                                $zohoBean->{$fieldsMatching[$columnName]['setter']}($columnValue);
                            }
                         }
 
                     }
-                    $zohoBeans[$row['uid']] =  $zohoBean;
+                    $zohoBeans[$row['uid']] = $zohoBean;
                     $rowsDeleted[] = $row['uid'];
-                } else{
+                } else {
                     $columnName = $row['updated_fieldname'];
                     $zohoBean->setZohoId($row['id']);
-                    if (in_array($columnName,['uid'])) {
+                    if (in_array($columnName, ['uid'])) {
                         continue;
-                    }else{
+                    } else {
                         $zohoBean->{$fieldsMatching[$columnName]['setter']}($row[$columnName]);
                         $zohoBeans[] = $zohoBean;
                         $rowsDeleted[] = $row['uid'];
@@ -117,9 +117,9 @@ 
                 }
             }
             $zohoDao->save($zohoBeans);
-            if(!$update){
+            if (!$update) {
                 foreach ($zohoBeans as $uid => $zohoBean) {
-                    $this->connection->update($tableName, [ 'id'=>$zohoBean->getZohoId(),'lastActivityTime'=> date("Y-m-d H:i:s") ], ['uid'=>$uid ]);
+                    $this->connection->update($tableName, ['id'=>$zohoBean->getZohoId(), 'lastActivityTime'=> date("Y-m-d H:i:s")], ['uid'=>$uid]);
                 }
             }
             $statementDelete = $this->connection->prepare('delete from '.$localTable.' where uid in ( :rowsDeleted)');
@@ -133,7 +133,7 @@ 
      * @param AbstractZohoDao $zohoDao
      * @param string $localTable
      */
-    public function deleteDataToZoho(AbstractZohoDao $zohoDao, $localTable){
+    public function deleteDataToZoho(AbstractZohoDao $zohoDao, $localTable) {
         $tableName = $this->getTableName($zohoDao);
         $statement = $this->connection->createQueryBuilder();
         $statement->select('l.id')
@@ -145,7 +145,7 @@ 
         $results = $statement->execute();
         while ($row = $results->fetch()) {
             $zohoDao->delete($row['id']);
-            $this->connection->delete($localTable, ['table_name' => $tableName,'id' => $row['id']]);
+            $this->connection->delete($localTable, ['table_name' => $tableName, 'id' => $row['id']]);
         }
 }
     
@@ -153,7 +153,7 @@ 
      * Run inserted rows to Zoho : local_insert.
      * @param AbstractZohoDao $zohoDao
      */
-    public function pushInsertedRows(AbstractZohoDao $zohoDao){
+    public function pushInsertedRows(AbstractZohoDao $zohoDao) {
         return $this->pushDataToZoho($zohoDao, 'local_insert');
     }
 
@@ -161,7 +161,7 @@ 
      * Run updated rows to Zoho : local_update.
      * @param AbstractZohoDao $zohoDao
      */
-    public function pushUpdatedRows(AbstractZohoDao $zohoDao){
+    public function pushUpdatedRows(AbstractZohoDao $zohoDao) {
         $this->pushDataToZoho($zohoDao, 'local_update', true);
     }
 
@@ -169,7 +169,7 @@ 
      * Run deleted rows to Zoho : local_delete.
      * @param AbstractZohoDao $zohoDao
      */
-    public function pushDeletedRows(AbstractZohoDao $zohoDao){
+    public function pushDeletedRows(AbstractZohoDao $zohoDao) {
         $this->deleteDataToZoho($zohoDao, 'local_delete');
     }
 

Braces +2 added lines, -2 removed lines

@@ -95,7 +95,7 @@ 
                     foreach ($row as $columnName => $columnValue) {
                         if (in_array($columnName,['id','uid'])) {
                             continue;
-                        }else{
+                        } else{
                            if($columnValue){
                                $zohoBean->{$fieldsMatching[$columnName]['setter']}($columnValue);
                            }
@@ -109,7 +109,7 @@ 
                     $zohoBean->setZohoId($row['id']);
                     if (in_array($columnName,['uid'])) {
                         continue;
-                    }else{
+                    } else{
                         $zohoBean->{$fieldsMatching[$columnName]['setter']}($row[$columnName]);
                         $zohoBeans[] = $zohoBean;
                         $rowsDeleted[] = $row['uid'];

src/ZohoDatabaseCopier.php

Spacing +4 added lines, -4 removed lines

@@ -244,7 +244,7 @@ 
             $data = [];
             $types = [];
             foreach ($table->getColumns() as $column) {
-                if (in_array($column->getName(),['id','uid'])) {
+                if (in_array($column->getName(), ['id', 'uid'])) {
                     continue;
                 }
                 else {
@@ -285,12 +285,12 @@ 
         $sqlStatementUid = 'select uid from '.$this->connection->quoteIdentifier($tableName).' where id = :id';
         foreach ($deletedRecordIds as $id) {
             $uid = $this->connection->fetchColumn($sqlStatementUid, ['id' => $id]);
-            $this->connection->delete($tableName, [ 'id' => $id ]);
+            $this->connection->delete($tableName, ['id' => $id]);
             if ($twoWaysSync) {
                 // TODO: we could detect if there are changes to be updated to the server and try to warn with a log message
                 // Also, let's remove the newly created field (because of the trigger) to avoid looping back to Zoho
-                $this->connection->delete('local_delete', [ 'table_name' => $tableName, 'id' => $id ]);
-                $this->connection->delete('local_update', [ 'table_name' => $tableName, 'uid' => $uid ]);
+                $this->connection->delete('local_delete', ['table_name' => $tableName, 'id' => $id]);
+                $this->connection->delete('local_update', ['table_name' => $tableName, 'uid' => $uid]);
             }
         }
 

Braces +1 added lines, -2 removed lines

@@ -246,8 +246,7 @@
             foreach ($table->getColumns() as $column) {
                 if (in_array($column->getName(),['id','uid'])) {
                     continue;
-                }
-                else {
+                } else {
                     $field = $fieldsByName[$column->getName()];
                     $getterName = $field['getter'];
                     $data[$column->getName()] = $record->$getterName();

src/LocalChangesTracker.php

Spacing +2 added lines, -2 removed lines

@@ -50,9 +50,9 @@
         $localDelete = $schema->createTable("local_delete");
         $localDelete->addColumn("table_name", 'string', ['length' => 100]);
         $localDelete->addColumn("uid", 'integer');
-        $localDelete->addColumn("id",  'string', ['length' => 100]);
+        $localDelete->addColumn("id", 'string', ['length' => 100]);
         $localDelete->setPrimaryKey(array("table_name", "uid"));
-        $localDelete->addUniqueIndex(['id','table_name']);
+        $localDelete->addUniqueIndex(['id', 'table_name']);
 
         $dbalTableDiffService = new DbalTableDiffService($this->connection, $this->logger);
         $dbalTableDiffService->createOrUpdateTable($localUpdate);