Completed
Push — 2.0 ( b41061...5f8063 )
by Raphaël
03:13 queued 01:37
created
src/ZohoDatabaseHelper.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -16,6 +16,7 @@
 block discarded – undo
16 16
      * Computes the name of the table based on the DAO plural module name.
17 17
      *
18 18
      * @param AbstractZohoDao $dao
19
+     * @param string $prefix
19 20
      *
20 21
      * @return string
21 22
      */
Please login to merge, or discard this patch.
src/ZohoDatabaseCopier.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,6 @@
 block discarded – undo
6 6
 use Psr\Log\LoggerInterface;
7 7
 use Psr\Log\NullLogger;
8 8
 use Wabel\Zoho\CRM\AbstractZohoDao;
9
-use Wabel\Zoho\CRM\Request\Response;
10 9
 
11 10
 /**
12 11
  * This class is in charge of synchronizing one table of your database with Zoho records.
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -129,9 +129,9 @@
 block discarded – undo
129 129
             // Let's get the last modification date:
130 130
             $tableDetail = $this->connection->getSchemaManager()->listTableDetails($tableName);
131 131
             //We use createdTime instead of lastActivityTime when the field doesn't exist in order to follow changes.
132
-            if($tableDetail->hasColumn('lastActivityTime')){
132
+            if ($tableDetail->hasColumn('lastActivityTime')) {
133 133
                 $lastActivityTime = $this->connection->fetchColumn('SELECT MAX(lastActivityTime) FROM '.$tableName);
134
-            } else{
134
+            } else {
135 135
                 $lastActivityTime = $this->connection->fetchColumn('SELECT MAX(createdTime) FROM '.$tableName);
136 136
             }
137 137
             if ($lastActivityTime !== null) {
Please login to merge, or discard this patch.
src/ZohoDatabaseModelSync.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -7,7 +7,6 @@
 block discarded – undo
7 7
 use Psr\Log\LoggerInterface;
8 8
 use Psr\Log\NullLogger;
9 9
 use Wabel\Zoho\CRM\AbstractZohoDao;
10
-use Wabel\Zoho\CRM\Request\Response;
11 10
 
12 11
 /**
13 12
  * This class is in charge of synchronizing one table MODEL with Zoho.
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -86,15 +86,15 @@  discard block
 block discarded – undo
86 86
 
87 87
         $flatFields = ZohoDatabaseHelper::getFlatFields($dao->getFields());
88 88
         //@Temporary fix to use Mysql5.7 not strict
89
-        $table->addColumn('uid', 'string', ['length' => 36,'notnull'=>false]);
90
-        $table->addColumn('id', 'string', ['length' => 100,'notnull'=>false]);
89
+        $table->addColumn('uid', 'string', ['length' => 36, 'notnull'=>false]);
90
+        $table->addColumn('id', 'string', ['length' => 100, 'notnull'=>false]);
91 91
         $table->addUniqueIndex(['id']);
92 92
         $table->setPrimaryKey(['uid']);
93 93
 
94 94
         foreach ($flatFields as $field) {
95 95
             $columnName = $field['name'];
96 96
             //It seems sometime we can have the same field twice in the list of fields from the API.
97
-            if($table->hasColumn($columnName)){
97
+            if ($table->hasColumn($columnName)) {
98 98
                 continue;
99 99
             }
100 100
 
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
         $table = $schema->createTable($tableName);
203 203
 
204 204
         $flatFields = $users->getUserFields();
205
-        $table->addColumn('id', 'string', ['length' => 100,'notnull'=>false]);
205
+        $table->addColumn('id', 'string', ['length' => 100, 'notnull'=>false]);
206 206
         $table->setPrimaryKey(['id']);
207 207
         foreach ($flatFields as $field) {
208 208
             if (in_array($field, ['id'])) {
Please login to merge, or discard this patch.
src/LocalChangesTracker.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
         $localDelete = $schema->createTable('local_delete');
50 50
         $localDelete->addColumn('table_name', 'string', ['length' => 100]);
51 51
         $localDelete->addColumn('uid', 'string', ['length' => 36]);
52
-        $localDelete->addColumn('id', 'string', ['length' => 100,'notnull'=>false]);
52
+        $localDelete->addColumn('id', 'string', ['length' => 100, 'notnull'=>false]);
53 53
         $localDelete->setPrimaryKey(array('table_name', 'uid'));
54 54
         $localDelete->addUniqueIndex(['id', 'table_name']);
55 55
 
Please login to merge, or discard this patch.
src/ZohoSyncDatabaseCommand.php 2 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -194,7 +194,6 @@
 block discarded – undo
194 194
     
195 195
     /**
196 196
      * Regerate Zoho Daos
197
-     * @param InputInterface $input
198 197
      * @param OutputInterface $output
199 198
      */
200 199
     private function regenerateZohoDao(OutputInterface $output)
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
         $this->zohoDatabaseModelSync = $zohoDatabaseModelSync;
100 100
         $this->zohoDatabaseCopier = $zohoDatabaseCopier;
101 101
         $this->zohoDatabaseSync = $zohoDatabaseSync;
102
-        $this->zohoEntitiesGenerator =  $zohoEntitiesGenerator;
102
+        $this->zohoEntitiesGenerator = $zohoEntitiesGenerator;
103 103
         $this->zohoClient = $zohoClient;
104 104
         $this->pathZohoDaos = $pathZohoDaos;
105 105
         $this->namespaceZohoDaos = $namespaceZohoDaos;
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
      */
190 190
     private function getListFieldName(AbstractZohoDao $zohoDao)
191 191
     {
192
-        $fieldNames= array();
192
+        $fieldNames = array();
193 193
         foreach ($zohoDao->getFields() as $fieldsDescriptor) {
194 194
             foreach (array_values($fieldsDescriptor) as $fieldDescriptor) {
195 195
                 $fieldNames[] = $fieldDescriptor['name'];
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
             $zohoDao = new $daoFullClassName($this->zohoClient);
214 214
             //To have more module which is use time of modification (createdTime or lastActivityTime).
215 215
             //use an array of Excluded Dao by full namespace
216
-            if (($this->excludedZohoDao && in_array(get_class($zohoDao),$this->excludedZohoDao)) || !in_array('createdTime', $this->getListFieldName($zohoDao))) {
216
+            if (($this->excludedZohoDao && in_array(get_class($zohoDao), $this->excludedZohoDao)) || !in_array('createdTime', $this->getListFieldName($zohoDao))) {
217 217
                 continue;
218 218
             }
219 219
             $this->zohoDaos [] = $zohoDao;
Please login to merge, or discard this patch.
src/ZohoDatabasePusher.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
             $this->logger = $logger;
47 47
         }
48 48
         $this->apiLimitInsertUpdateDelete = $apiLimitInsertUpdateDelete;
49
-        if($apiLimitInsertUpdateDelete === null){
49
+        if ($apiLimitInsertUpdateDelete === null) {
50 50
             $this->apiLimitInsertUpdateDelete = 100;
51 51
         }
52 52
     }
@@ -129,8 +129,8 @@  discard block
 block discarded – undo
129 129
         //To optimize your API usage, get maximum 200 records with each request and insert, update or delete maximum 100 records with each request.
130 130
         $offsetTodo = 0;
131 131
         $doneBeans = 0;
132
-        while($doneBeans < $countItems){
133
-            $zohoBeansToSend = array_slice($zohoBeans,$offsetTodo,$this->apiLimitInsertUpdateDelete,true);
132
+        while ($doneBeans < $countItems) {
133
+            $zohoBeansToSend = array_slice($zohoBeans, $offsetTodo, $this->apiLimitInsertUpdateDelete, true);
134 134
             $offsetTodo += $this->apiLimitInsertUpdateDelete;
135 135
             $doneBeans += count($zohoBeansToSend);
136 136
         }
@@ -143,13 +143,13 @@  discard block
 block discarded – undo
143 143
                     // ID not exist we can update the new row with the Zoho ID
144 144
                     $this->connection->beginTransaction();
145 145
                     $this->connection->update($tableName, ['id' => $zohoBean->getZohoId()], ['uid' => $uid]);
146
-                    $this->connection->delete('local_insert', ['table_name'=>$tableName, 'uid' => $uid ]);
146
+                    $this->connection->delete('local_insert', ['table_name'=>$tableName, 'uid' => $uid]);
147 147
                     $this->connection->commit();
148 148
                 } else {
149 149
                     //ID already exist we need to delete the duplicate row.
150 150
                     $this->connection->beginTransaction();
151
-                    $this->connection->delete($tableName, ['uid' => $uid ]);
152
-                    $this->connection->delete('local_insert', ['table_name'=>$tableName, 'uid' => $uid ]);
151
+                    $this->connection->delete($tableName, ['uid' => $uid]);
152
+                    $this->connection->delete('local_insert', ['table_name'=>$tableName, 'uid' => $uid]);
153 153
                     $this->connection->commit();
154 154
                 }
155 155
             }
Please login to merge, or discard this patch.