Wabel / certain-api-wrapper

tests/Wabel/Services/DetectAppointmentsChangingsServiceTest.php

Spacing +28 added lines, -28 removed lines

@@ -29,7 +29,7 @@ 
      * Personal Object to test
      * @return array
      */
-    private function personalAppointment(){
+    private function personalAppointment() {
         return [
                     "appointmentId"=> 52,
                     "startDate"=> "2015-16-07 11:00:00",
@@ -68,23 +68,23 @@ 
 
     protected function setUp()
     {
-        $certainApiClient =  new CertainApiClient(null,getenv('username'),getenv('password'),getenv('accountCode'));
-        $this->certainApiService  = new CertainApiService($certainApiClient);
+        $certainApiClient = new CertainApiClient(null, getenv('username'), getenv('password'), getenv('accountCode'));
+        $this->certainApiService = new CertainApiService($certainApiClient);
         $this->appointmentsCertain = new AppointmentsCertain($this->certainApiService);
-        $this->certainAppointmentsList = $this->appointmentsCertain->get(getenv('eventCode'),['start_index'=>0,'max_results'=>10])->getResults()->appointments;
+        $this->certainAppointmentsList = $this->appointmentsCertain->get(getenv('eventCode'), ['start_index'=>0, 'max_results'=>10])->getResults()->appointments;
     }
 
-    public function testDetectChangings(){
+    public function testDetectChangings() {
         $detectService = new DetectAppointmentsChangingsService($this->appointmentsCertain);
         $oldAppointments = $this->certainAppointmentsList;
         $currentAppoiments = $oldAppointments;
         unset($currentAppoiments[0]);
         unset($currentAppoiments[1]);
-        $hasChanged = $detectService->hasChanged($oldAppointments,$currentAppoiments);
+        $hasChanged = $detectService->hasChanged($oldAppointments, $currentAppoiments);
         $this->assertTrue($hasChanged);
     }
 
-    public function testGetListChangings(){
+    public function testGetListChangings() {
         $detectService = new DetectAppointmentsChangingsService($this->appointmentsCertain);
         $oldAppointments = $this->certainAppointmentsList;
         $currentAppoiments = $oldAppointments;
@@ -94,14 +94,14 @@ 
         unset($currentAppoiments[0]);
         unset($currentAppoiments[1]);
         unset($currentAppoiments[4]);
-        $changings = $detectService->getListChangings($oldAppointments,$currentAppoiments);
-        $this->assertEquals(3,count($changings));
-        $this->assertContains($delete1,$changings);
-        $this->assertContains($delete2,$changings);
-        $this->assertContains($delete3,$changings);
+        $changings = $detectService->getListChangings($oldAppointments, $currentAppoiments);
+        $this->assertEquals(3, count($changings));
+        $this->assertContains($delete1, $changings);
+        $this->assertContains($delete2, $changings);
+        $this->assertContains($delete3, $changings);
     }
 
-    public function testDetectDeleteOrUpdated(){
+    public function testDetectDeleteOrUpdated() {
         $detectService = new DetectAppointmentsChangingsService($this->appointmentsCertain);
         $oldAppointments = $this->certainAppointmentsList;
         $oldAppointments[10] = $this->personalAppointment();
@@ -113,19 +113,19 @@ 
         $update1 = $currentAppoiments[10];
         $currentAppoiments[10]["startDate"] = "2015-17-07 12:00:00";
         $currentAppoiments[10]["endDate"] = "2015-17-07 12:30:00";
-        $changings = $detectService->getListChangings($oldAppointments,$currentAppoiments);
-        $listDetected = $detectService->detectDeleteOrUpdatedOrInserted($currentAppoiments,$changings);
-        $this->assertEquals(3,count($changings));
-        $this->assertArrayHasKey('deleted',$listDetected);
-        $this->assertArrayHasKey('updated',$listDetected);
-        $this->assertEquals(2,count($listDetected['deleted']));
-        $this->assertEquals(1,count($listDetected['updated']));
-        $this->assertContains($delete1,$listDetected['deleted']);
-        $this->assertContains($delete2,$listDetected['deleted']);
-        $this->assertContains($update1,$listDetected['updated']);
+        $changings = $detectService->getListChangings($oldAppointments, $currentAppoiments);
+        $listDetected = $detectService->detectDeleteOrUpdatedOrInserted($currentAppoiments, $changings);
+        $this->assertEquals(3, count($changings));
+        $this->assertArrayHasKey('deleted', $listDetected);
+        $this->assertArrayHasKey('updated', $listDetected);
+        $this->assertEquals(2, count($listDetected['deleted']));
+        $this->assertEquals(1, count($listDetected['updated']));
+        $this->assertContains($delete1, $listDetected['deleted']);
+        $this->assertContains($delete2, $listDetected['deleted']);
+        $this->assertContains($update1, $listDetected['updated']);
     }
 
-    public function testDetectAppointmentsChangings(){
+    public function testDetectAppointmentsChangings() {
         $detectService = new DetectAppointmentsChangingsService($this->appointmentsCertain);
         $oldAppointments = $this->certainAppointmentsList;
         $oldAppointments[10] = $this->personalAppointment();
@@ -141,10 +141,10 @@ 
         $update1['dateDetectChanges'] = $time;
         $currentAppoiments[10]["startDate"] = "2015-17-07 12:00:00";
         $currentAppoiments[10]["endDate"] = "2015-17-07 12:30:00";
-        $listDetected = $detectService->detectAppointmentsChangings($oldAppointments,$currentAppoiments,$time);
-        $this->assertContains($delete1,$listDetected['deleted']);
-        $this->assertContains($delete2,$listDetected['deleted']);
-        $this->assertContains($update1,$listDetected['updated']);
+        $listDetected = $detectService->detectAppointmentsChangings($oldAppointments, $currentAppoiments, $time);
+        $this->assertContains($delete1, $listDetected['deleted']);
+        $this->assertContains($delete2, $listDetected['deleted']);
+        $this->assertContains($update1, $listDetected['updated']);
     }
 
 }
\ No newline at end of file

src/Commands/DetectAppointmentsChangingCommand.php

Spacing +14 added lines, -14 removed lines

@@ -36,7 +36,7 @@ 
      * @param CertainListener[] $listeners
      * @param null $name
      */
-    public function __construct(DetectAppointmentsChangingsService $detectAppointmentsChangingsService,$dirPathHistoryAppointments, array $listeners=[],$name=null)
+    public function __construct(DetectAppointmentsChangingsService $detectAppointmentsChangingsService, $dirPathHistoryAppointments, array $listeners = [], $name = null)
     {
         parent::__construct($name);
         $this->detectAppointmentsChangingsService = $detectAppointmentsChangingsService;
@@ -53,44 +53,44 @@ 
 Request Certain to get appointments and detect changes between to request
 EOT
             );
-        $this->addArgument('eventCode',InputArgument::REQUIRED,'Specify the eventCode from Certain');
+        $this->addArgument('eventCode', InputArgument::REQUIRED, 'Specify the eventCode from Certain');
     }
 
     public function execute(InputInterface $input, OutputInterface $output)
     {
         $eventCode = $input->getArgument('eventCode');
         //That permits to stop the followings instructions when we are makings changes on Certain.
-        if($eventCode){
+        if ($eventCode) {
             $output->writeln('Detect changes - Run.');
             //Get the online appointments.
             $appointmentsNewCertain = $this->detectAppointmentsChangingsService->getCurrentAppoiments($eventCode);
             $appointmentsNew = DetectAppointmentsChangingsService::recursiveArrayObjectToFullArray($appointmentsNewCertain);
             //Get the last saved appointments to get old data.
-            $appointmentsOldHistoryFilePath = FileChangesHelper::getTheLastAppointmentsSaved($eventCode,$this->dirPathHistoryAppointments);
-            if(!$appointmentsOldHistoryFilePath){
+            $appointmentsOldHistoryFilePath = FileChangesHelper::getTheLastAppointmentsSaved($eventCode, $this->dirPathHistoryAppointments);
+            if (!$appointmentsOldHistoryFilePath) {
                 //No files so it's the first time we attempt to synchronize.
                 $appointmentsOld = [];
-            }else{
+            }else {
                 //Get the last old appointments data.
                 $appointmentsOldHistory = FileChangesHelper::getJsonContentFromFile($appointmentsOldHistoryFilePath);
                 $appointmentsOld = DetectAppointmentsChangingsService::recursiveArrayObjectToFullArray($appointmentsOldHistory);
             }
             //Check if they are changes.
             $timestamp = time();
-            $listChangings = $this->detectAppointmentsChangingsService->detectAppointmentsChangings($appointmentsOld,$appointmentsNew,$timestamp);
-            if(!$appointmentsOld || ((isset($listChangings['updated']) && !empty($listChangings['updated']))
-                || (isset($listChangings['deleted']) && !empty($listChangings['deleted'])))){
+            $listChangings = $this->detectAppointmentsChangingsService->detectAppointmentsChangings($appointmentsOld, $appointmentsNew, $timestamp);
+            if (!$appointmentsOld || ((isset($listChangings['updated']) && !empty($listChangings['updated']))
+                || (isset($listChangings['deleted']) && !empty($listChangings['deleted'])))) {
                 //Changes? So we save the new online appointments
-                FileChangesHelper::saveAppointmentsFileByHistory($this->dirPathHistoryAppointments.'/appointments_'.$eventCode.'.json',json_encode($appointmentsNew));
+                FileChangesHelper::saveAppointmentsFileByHistory($this->dirPathHistoryAppointments.'/appointments_'.$eventCode.'.json', json_encode($appointmentsNew));
                 $output->writeln('Detect changes - Save Changes');
-            }else{
+            }else {
                 $output->writeln('Detect changes - No Changes');
             }
-            foreach ($this->listeners as $listener){
+            foreach ($this->listeners as $listener) {
                 //Run Listener. For instance,Here we can use ChangingsToFileListeners to save the changes in file.
-                $listener->run($eventCode,$listChangings);
+                $listener->run($eventCode, $listChangings);
             }
-        }else{
+        }else {
             $output->writeln('Detect changes - Stop.');
         }
     }

src/Services/DetectAppointmentsChangingsService.php

Spacing +35 added lines, -35 removed lines

@@ -23,14 +23,14 @@ 
      * @param null|int $maxResult
      * @return mixed
      */
-    public function getCurrentAppoiments($eventCode,$start=null,$maxResult=null){
-        if(!$start){
+    public function getCurrentAppoiments($eventCode, $start = null, $maxResult = null) {
+        if (!$start) {
             $start = 0;
         }
-        if(!$maxResult){
+        if (!$maxResult) {
             $maxResult = 999999;
         }
-        return $this->certainAppointmentsList = $this->appointmentsCertain->get($eventCode,['start_index'=>$start,'max_results'=>$maxResult])->getResults()->appointments;
+        return $this->certainAppointmentsList = $this->appointmentsCertain->get($eventCode, ['start_index'=>$start, 'max_results'=>$maxResult])->getResults()->appointments;
     }
 
     /**
@@ -38,21 +38,21 @@ 
      * @param array $appointmentsNew
      * @return bool
      */
-    public function hasChanged(array $appointmentsOld,array $appointmentsNew){
+    public function hasChanged(array $appointmentsOld, array $appointmentsNew) {
         $hasChanged = false;
         $appointmentsOld = self::recursiveArrayObjectToFullArray($appointmentsOld);
         $appointmentsNew = self::recursiveArrayObjectToFullArray($appointmentsNew);
         //Has change by update or delete
-        foreach ($appointmentsOld as $appointmentOld){
-            if(!in_array($appointmentOld,$appointmentsNew)){
+        foreach ($appointmentsOld as $appointmentOld) {
+            if (!in_array($appointmentOld, $appointmentsNew)) {
                 $hasChanged = true;
                 break;
             }
         }
         //Has changes by insertion or update
-        if(!$hasChanged){
-            foreach ($appointmentsNew as $appointmentNew){
-                if(!in_array($appointmentNew,$appointmentsOld)){
+        if (!$hasChanged) {
+            foreach ($appointmentsNew as $appointmentNew) {
+                if (!in_array($appointmentNew, $appointmentsOld)) {
                     $hasChanged = true;
                     break;
                 }
@@ -66,7 +66,7 @@ 
      * @return array
      */
     public static  function objectToArray($object) {
-        if(is_object($object)){
+        if (is_object($object)) {
 
             return (array) $object;
         }
@@ -77,7 +77,7 @@ 
      * @param $appointments
      * @return array
      */
-    public static function recursiveArrayObjectToFullArray($appointments){
+    public static function recursiveArrayObjectToFullArray($appointments) {
         return json_decode(json_encode($appointments), true);
     }
 
@@ -88,8 +88,8 @@ 
      */
     private function arrayRecursiveDiff(array $arrayOlds, array $arrayNews) {
         $difference = [];
-        foreach($arrayOlds as $key => $arrayOld){
-            if(!in_array($arrayOld,$arrayNews)){
+        foreach ($arrayOlds as $key => $arrayOld) {
+            if (!in_array($arrayOld, $arrayNews)) {
                 $difference[$key] = $arrayOld;
             }
         }
@@ -104,9 +104,9 @@ 
      */
     private function arrayRecursiveDiffNew(array $arrayOlds, array $arrayNews, array $existedUpdateOrDelete) {
         $difference = [];
-        foreach($arrayNews as $key => $arrayNew){
-            if(!in_array($arrayNew,$arrayOlds)
-                && !in_array(self::recursiveArrayObjectToFullArray($arrayNew), $existedUpdateOrDelete)){
+        foreach ($arrayNews as $key => $arrayNew) {
+            if (!in_array($arrayNew, $arrayOlds)
+                && !in_array(self::recursiveArrayObjectToFullArray($arrayNew), $existedUpdateOrDelete)) {
                 $difference[$key] = $arrayNew;
             }
         }
@@ -118,13 +118,13 @@ 
      * @param array $appointmentsNew
      * @return array
      */
-    public function getListChangings(array $appointmentsOld,array $appointmentsNew){
+    public function getListChangings(array $appointmentsOld, array $appointmentsNew) {
         $appointmentsOld = self::recursiveArrayObjectToFullArray($appointmentsOld);
         $appointmentsNew = self::recursiveArrayObjectToFullArray($appointmentsNew);
         $changesListUpdateOrDelete = [];
         $changesListInsert = [];
-        if($this->hasChanged($appointmentsOld,$appointmentsNew)){
-            $changesListUpdateOrDelete = self::recursiveArrayObjectToFullArray($this->arrayRecursiveDiff($appointmentsOld,$appointmentsNew));
+        if ($this->hasChanged($appointmentsOld, $appointmentsNew)) {
+            $changesListUpdateOrDelete = self::recursiveArrayObjectToFullArray($this->arrayRecursiveDiff($appointmentsOld, $appointmentsNew));
             $changesListInsert = self::recursiveArrayObjectToFullArray($this->arrayRecursiveDiffNew($appointmentsOld, $appointmentsNew, $changesListUpdateOrDelete));
         }
         $changesList = array_merge($changesListUpdateOrDelete, $changesListInsert);
@@ -137,27 +137,27 @@ 
      * @param array $changingsDetected
      * @return array ['deleted'=>[],'updated'=>[]]
      */
-    public function detectDeleteOrUpdatedOrInserted(array $currentAppointments, array $changingsDetected){
+    public function detectDeleteOrUpdatedOrInserted(array $currentAppointments, array $changingsDetected) {
         $delete = [];
         $update = [];
         $insert = [];
         //@Todo: Detect Fields has changed
         $appointmentsNew = self::recursiveArrayObjectToFullArray($currentAppointments);
         $changings = self::recursiveArrayObjectToFullArray($changingsDetected);
-        foreach ($changings as $changing){
+        foreach ($changings as $changing) {
             $registration = $changing['registration']['regCode'];
             $registrationTarget = $changing['targetRegistration']['regCode'];
-            foreach ($appointmentsNew as $currentAppointment){
+            foreach ($appointmentsNew as $currentAppointment) {
                 $registrationCurrent = $currentAppointment['registration']['regCode'];
                 $registrationTargetCurrent = $currentAppointment['targetRegistration']['regCode'];
-                if(in_array($registration,[$registrationCurrent,$registrationTargetCurrent])
-                    && in_array($registrationTarget,[$registrationCurrent,$registrationTargetCurrent])
-                    && !in_array($changing,$update) && !in_array($changing,$delete)) {
+                if (in_array($registration, [$registrationCurrent, $registrationTargetCurrent])
+                    && in_array($registrationTarget, [$registrationCurrent, $registrationTargetCurrent])
+                    && !in_array($changing, $update) && !in_array($changing, $delete)) {
                     $update[] = $changing;
                     break;
                 }
             }
-            if(!in_array($changing,$update) && !in_array($changing,$delete)){
+            if (!in_array($changing, $update) && !in_array($changing, $delete)) {
                 $delete[] = $changing;
             }
             $insert[] = $changing;
@@ -175,8 +175,8 @@ 
      * @param $timestamp
      * @return array
      */
-    public static function insertDateTimeChanges(array $appointments,$timestamp){
-        foreach ($appointments as $key => $appointment){
+    public static function insertDateTimeChanges(array $appointments, $timestamp) {
+        foreach ($appointments as $key => $appointment) {
             $appointments[$key]['dateDetectChanges'] = $timestamp;
         }
         return $appointments;
@@ -188,12 +188,12 @@ 
      * @param string $timestamp
      * @return array ['deleted'=>[],'updated'=>[]]
      */
-    public function detectAppointmentsChangings(array $appointmentsOld,array $appointmentsNew,$timestamp){
-        $changings = $this->getListChangings($appointmentsOld,$appointmentsNew);
-        $changesList = $this->detectDeleteOrUpdatedOrInserted($appointmentsNew,$changings);
-        $changesList['inserted'] = self::insertDateTimeChanges($changesList['inserted'],$timestamp);
-        $changesList['updated'] = self::insertDateTimeChanges($changesList['updated'],$timestamp);
-        $changesList['deleted'] = self::insertDateTimeChanges($changesList['deleted'],$timestamp);
+    public function detectAppointmentsChangings(array $appointmentsOld, array $appointmentsNew, $timestamp) {
+        $changings = $this->getListChangings($appointmentsOld, $appointmentsNew);
+        $changesList = $this->detectDeleteOrUpdatedOrInserted($appointmentsNew, $changings);
+        $changesList['inserted'] = self::insertDateTimeChanges($changesList['inserted'], $timestamp);
+        $changesList['updated'] = self::insertDateTimeChanges($changesList['updated'], $timestamp);
+        $changesList['deleted'] = self::insertDateTimeChanges($changesList['deleted'], $timestamp);
         return $changesList;
     }