DetectAppointmentsChangingsService::insertDateTimeChanges() - Code Metrics - Inspection of "Get Insert Element from Certain" - Wabel/certain-api-wrapper - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1)

by Raphaël

created 2018-03-19 17:55 UTC

insertDateTimeChanges() A

↳ Parent: DetectAppointmentsChangingsService

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	4
nc	2
nop	2

<?php

namespace Wabel\CertainAPI\Services;

use Wabel\CertainAPI\Ressources\AppointmentsCertain;

class DetectAppointmentsChangingsService
{

    /**
     * @var AppointmentsCertain
     */
    private $appointmentsCertain;

    public function __construct(AppointmentsCertain $appointmentsCertain)
    {
        $this->appointmentsCertain = $appointmentsCertain;
    }

    /**
     * @param $eventCode
     * @param null|int $start
     * @param null|int $maxResult
     * @return mixed
     */
    public function getCurrentAppoiments($eventCode,$start=null,$maxResult=null){
        if(!$start){
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            $start = 0;
        }
        if(!$maxResult){
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            $maxResult = 999999;
        }
        return $this->certainAppointmentsList = $this->appointmentsCertain->get($eventCode,['start_index'=>$start,'max_results'=>$maxResult])->getResults()->appointments;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * @param array $appointmentsOld
     * @param array $appointmentsNew
     * @return bool
     */
    public function hasChanged(array $appointmentsOld,array $appointmentsNew){
        $hasChanged = false;
        $appointmentsOld = self::recursiveArrayObjectToFullArray($appointmentsOld);
        $appointmentsNew = self::recursiveArrayObjectToFullArray($appointmentsNew);
        //Has change by update or delete
        foreach ($appointmentsOld as $appointmentOld){
            if(!in_array($appointmentOld,$appointmentsNew)){
                $hasChanged = true;
                break;
            }
        }
        //Has changes by insertion or update
        if(!$hasChanged){
            foreach ($appointmentsNew as $appointmentNew){
                if(!in_array($appointmentNew,$appointmentsOld)){
                    $hasChanged = true;
                    break;
                }
            }
        }
        return $hasChanged;
    }

    /**
     * @param $object
     * @return array
     */
    public static  function objectToArray($object) {
        if(is_object($object)){

            return (array) $object;
        }
        return $object;
    }

    /**
     * @param $appointments
     * @return array
     */
    public static function recursiveArrayObjectToFullArray($appointments){
        return json_decode(json_encode($appointments), true);
    }

    /**
     * @param array $arrayOlds
     * @param array $arrayNews
     * @return array
     */
    private function arrayRecursiveDiff(array $arrayOlds, array $arrayNews) {
        $difference = [];
        foreach($arrayOlds as $key => $arrayOld){
            if(!in_array($arrayOld,$arrayNews)){
                $difference[$key] = $arrayOld;
            }
        }
        return $difference;
    }

    /**
     * @param array $arrayOlds
     * @param array $arrayNews
     * @param array $existedUpdateOrDelete
     * @return array
     */
    private function arrayRecursiveDiffNew(array $arrayOlds, array $arrayNews, array $existedUpdateOrDelete) {
        $difference = [];
        foreach($arrayNews as $key => $arrayNew){
            if(!in_array($arrayNew,$arrayOlds)
                && !in_array(self::recursiveArrayObjectToFullArray($arrayNew), $existedUpdateOrDelete)){
                $difference[$key] = $arrayNew;
            }
        }
        return $difference;
    }

    /**
     * @param array $appointmentsOld
     * @param array $appointmentsNew
     * @return array
     */
    public function getListChangings(array $appointmentsOld,array $appointmentsNew){
        $appointmentsOld = self::recursiveArrayObjectToFullArray($appointmentsOld);
        $appointmentsNew = self::recursiveArrayObjectToFullArray($appointmentsNew);
        $changesListUpdateOrDelete = [];
        $changesListInsert = [];
        if($this->hasChanged($appointmentsOld,$appointmentsNew)){
            $changesListUpdateOrDelete = self::recursiveArrayObjectToFullArray($this->arrayRecursiveDiff($appointmentsOld,$appointmentsNew));
            $changesListInsert = self::recursiveArrayObjectToFullArray($this->arrayRecursiveDiffNew($appointmentsOld, $appointmentsNew, $changesListUpdateOrDelete));
        }
        $changesList = array_merge($changesListUpdateOrDelete, $changesListInsert);
        return $changesList;
    }

    /**
     *
     * @param array $currentAppointments
     * @param array $changingsDetected
     * @return array ['deleted'=>[],'updated'=>[]]
     */
    public function detectDeleteOrUpdatedOrInserted(array $currentAppointments, array $changingsDetected){
        $delete = [];
        $update = [];
        $insert = [];
        //@Todo: Detect Fields has changed
        $appointmentsNew = self::recursiveArrayObjectToFullArray($currentAppointments);
        $changings = self::recursiveArrayObjectToFullArray($changingsDetected);
        foreach ($changings as $changing){
            $registration = $changing['registration']['regCode'];
            $registrationTarget = $changing['targetRegistration']['regCode'];
            foreach ($appointmentsNew as $currentAppointment){
                $registrationCurrent = $currentAppointment['registration']['regCode'];
                $registrationTargetCurrent = $currentAppointment['targetRegistration']['regCode'];
                if(in_array($registration,[$registrationCurrent,$registrationTargetCurrent])
                    && in_array($registrationTarget,[$registrationCurrent,$registrationTargetCurrent])
                    && !in_array($changing,$update) && !in_array($changing,$delete)) {
                    $update[] = $changing;
                    break;
                }
            }
            if(!in_array($changing,$update) && !in_array($changing,$delete)){
                $delete[] = $changing;
            }
            $insert[] = $changing;

        }
        return [
            'deleted' => $delete,
            'updated' => $update,
            '$insert' => $insert
        ];
    }

    /**
     * @param array $appointments
     * @param $timestamp
     * @return array
     */
    public static function insertDateTimeChanges(array $appointments,$timestamp){
        foreach ($appointments as $key => $appointment){
            $appointments[$key]['dateDetectChanges'] = $timestamp;
        }
        return $appointments;
    }

    /**
     * @param array $appointmentsOld
     * @param array $appointmentsNew
     * @param string $timestamp
     * @return array ['deleted'=>[],'updated'=>[]]
     */
    public function detectAppointmentsChangings(array $appointmentsOld,array $appointmentsNew,$timestamp){
        $changings = $this->getListChangings($appointmentsOld,$appointmentsNew);
        $changesList = $this->detectDeleteOrUpdatedOrInserted($appointmentsNew,$changings);
        $changesList['inserted'] = self::insertDateTimeChanges($changesList['inserted'],$timestamp);
        $changesList['updated'] = self::insertDateTimeChanges($changesList['updated'],$timestamp);
        $changesList['deleted'] = self::insertDateTimeChanges($changesList['deleted'],$timestamp);
        return $changesList;
    }

}

1			<?php
2
3			namespace Wabel\CertainAPI\Services;
4
5			use Wabel\CertainAPI\Ressources\AppointmentsCertain;
6
7			class DetectAppointmentsChangingsService
8			{
9
10			/**
11			* @var AppointmentsCertain
12			*/
13			private $appointmentsCertain;
14
15			public function __construct(AppointmentsCertain $appointmentsCertain)
16			{
17			$this->appointmentsCertain = $appointmentsCertain;
18			}
19
20			/**
21			* @param $eventCode
22			* @param null\|int $start
23			* @param null\|int $maxResult
24			* @return mixed
25			*/
26			public function getCurrentAppoiments($eventCode,$start=null,$maxResult=null){
27			if(!$start){
			0 ignored issues – show Bug Best Practice introduced 2017-09-07 12:49 UTC by Report Bug Copy Issue Report The expression `$start` of type `null\|integer` is loosely compared to `false`; this is ambiguous if the integer can be zero. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
28			$start = 0;
29			}
30			if(!$maxResult){
			0 ignored issues – show Bug Best Practice introduced 2017-09-08 17:01 UTC by Report Bug Copy Issue Report The expression `$maxResult` of type `null\|integer` is loosely compared to `false`; this is ambiguous if the integer can be zero. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
31			$maxResult = 999999;
32			}
33			return $this->certainAppointmentsList = $this->appointmentsCertain->get($eventCode,['start_index'=>$start,'max_results'=>$maxResult])->getResults()->appointments;
			0 ignored issues – show Bug introduced 2017-09-07 12:49 UTC by Report Bug Copy Issue Report The property `certainAppointmentsList` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
34			}
35
36			/**
37			* @param array $appointmentsOld
38			* @param array $appointmentsNew
39			* @return bool
40			*/
41			public function hasChanged(array $appointmentsOld,array $appointmentsNew){
42			$hasChanged = false;
43			$appointmentsOld = self::recursiveArrayObjectToFullArray($appointmentsOld);
44			$appointmentsNew = self::recursiveArrayObjectToFullArray($appointmentsNew);
45			//Has change by update or delete
46			foreach ($appointmentsOld as $appointmentOld){
47			if(!in_array($appointmentOld,$appointmentsNew)){
48			$hasChanged = true;
49			break;
50			}
51			}
52			//Has changes by insertion or update
53			if(!$hasChanged){
54			foreach ($appointmentsNew as $appointmentNew){
55			if(!in_array($appointmentNew,$appointmentsOld)){
56			$hasChanged = true;
57			break;
58			}
59			}
60			}
61			return $hasChanged;
62			}
63
64			/**
65			* @param $object
66			* @return array
67			*/
68			public static function objectToArray($object) {
69			if(is_object($object)){
70
71			return (array) $object;
72			}
73			return $object;
74			}
75
76			/**
77			* @param $appointments
78			* @return array
79			*/
80			public static function recursiveArrayObjectToFullArray($appointments){
81			return json_decode(json_encode($appointments), true);
82			}
83
84			/**
85			* @param array $arrayOlds
86			* @param array $arrayNews
87			* @return array
88			*/
89			private function arrayRecursiveDiff(array $arrayOlds, array $arrayNews) {
90			$difference = [];
91			foreach($arrayOlds as $key => $arrayOld){
92			if(!in_array($arrayOld,$arrayNews)){
93			$difference[$key] = $arrayOld;
94			}
95			}
96			return $difference;
97			}
98
99			/**
100			* @param array $arrayOlds
101			* @param array $arrayNews
102			* @param array $existedUpdateOrDelete
103			* @return array
104			*/
105			private function arrayRecursiveDiffNew(array $arrayOlds, array $arrayNews, array $existedUpdateOrDelete) {
106			$difference = [];
107			foreach($arrayNews as $key => $arrayNew){
108			if(!in_array($arrayNew,$arrayOlds)
109			&& !in_array(self::recursiveArrayObjectToFullArray($arrayNew), $existedUpdateOrDelete)){
110			$difference[$key] = $arrayNew;
111			}
112			}
113			return $difference;
114			}
115
116			/**
117			* @param array $appointmentsOld
118			* @param array $appointmentsNew
119			* @return array
120			*/
121			public function getListChangings(array $appointmentsOld,array $appointmentsNew){
122			$appointmentsOld = self::recursiveArrayObjectToFullArray($appointmentsOld);
123			$appointmentsNew = self::recursiveArrayObjectToFullArray($appointmentsNew);
124			$changesListUpdateOrDelete = [];
125			$changesListInsert = [];
126			if($this->hasChanged($appointmentsOld,$appointmentsNew)){
127			$changesListUpdateOrDelete = self::recursiveArrayObjectToFullArray($this->arrayRecursiveDiff($appointmentsOld,$appointmentsNew));
128			$changesListInsert = self::recursiveArrayObjectToFullArray($this->arrayRecursiveDiffNew($appointmentsOld, $appointmentsNew, $changesListUpdateOrDelete));
129			}
130			$changesList = array_merge($changesListUpdateOrDelete, $changesListInsert);
131			return $changesList;
132			}
133
134			/**
135			*
136			* @param array $currentAppointments
137			* @param array $changingsDetected
138			* @return array ['deleted'=>[],'updated'=>[]]
139			*/
140			public function detectDeleteOrUpdatedOrInserted(array $currentAppointments, array $changingsDetected){
141			$delete = [];
142			$update = [];
143			$insert = [];
144			//@Todo: Detect Fields has changed
145			$appointmentsNew = self::recursiveArrayObjectToFullArray($currentAppointments);
146			$changings = self::recursiveArrayObjectToFullArray($changingsDetected);
147			foreach ($changings as $changing){
148			$registration = $changing['registration']['regCode'];
149			$registrationTarget = $changing['targetRegistration']['regCode'];
150			foreach ($appointmentsNew as $currentAppointment){
151			$registrationCurrent = $currentAppointment['registration']['regCode'];
152			$registrationTargetCurrent = $currentAppointment['targetRegistration']['regCode'];
153			if(in_array($registration,[$registrationCurrent,$registrationTargetCurrent])
154			&& in_array($registrationTarget,[$registrationCurrent,$registrationTargetCurrent])
155			&& !in_array($changing,$update) && !in_array($changing,$delete)) {
156			$update[] = $changing;
157			break;
158			}
159			}
160			if(!in_array($changing,$update) && !in_array($changing,$delete)){
161			$delete[] = $changing;
162			}
163			$insert[] = $changing;
164
165			}
166			return [
167			'deleted' => $delete,
168			'updated' => $update,
169			'$insert' => $insert
170			];
171			}
172
173			/**
174			* @param array $appointments
175			* @param $timestamp
176			* @return array
177			*/
178			public static function insertDateTimeChanges(array $appointments,$timestamp){
179			foreach ($appointments as $key => $appointment){
180			$appointments[$key]['dateDetectChanges'] = $timestamp;
181			}
182			return $appointments;
183			}
184
185			/**
186			* @param array $appointmentsOld
187			* @param array $appointmentsNew
188			* @param string $timestamp
189			* @return array ['deleted'=>[],'updated'=>[]]
190			*/
191			public function detectAppointmentsChangings(array $appointmentsOld,array $appointmentsNew,$timestamp){
192			$changings = $this->getListChangings($appointmentsOld,$appointmentsNew);
193			$changesList = $this->detectDeleteOrUpdatedOrInserted($appointmentsNew,$changings);
194			$changesList['inserted'] = self::insertDateTimeChanges($changesList['inserted'],$timestamp);
195			$changesList['updated'] = self::insertDateTimeChanges($changesList['updated'],$timestamp);
196			$changesList['deleted'] = self::insertDateTimeChanges($changesList['deleted'],$timestamp);
197			return $changesList;
198			}
199
200			}

Wabel / certain-api-wrapper

Pull Request — master (#1)

insertDateTimeChanges() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like