Wabel / certain-api-wrapper

src/Listeners/ChangingsToFileListeners.php

Doc Comments +1 added lines, -1 removed lines

@@ -51,7 +51,7 @@
 
 
     /**
-     * @param sring $filePath
+     * @param string $filePath
      * @param array $element
      * @return void
      */

Spacing +15 added lines, -15 removed lines

@@ -29,22 +29,22 @@ 
      * @param array $elements
      * @return void
      */
-    public function run($eventCode,array $elements)
+    public function run($eventCode, array $elements)
     {
-        if(isset($elements['updated'])){
-            foreach ($elements['updated'] as $element){
-                if(!is_array($element)){
+        if (isset($elements['updated'])) {
+            foreach ($elements['updated'] as $element) {
+                if (!is_array($element)) {
                     $element = [$element];
                 }
-                $this->updateUpdateListFile($eventCode,$element);
+                $this->updateUpdateListFile($eventCode, $element);
             }
         }
-        if(isset($elements['deleted'])){
-            foreach ($elements['deleted'] as $element){
-                if(!is_array($element)){
+        if (isset($elements['deleted'])) {
+            foreach ($elements['deleted'] as $element) {
+                if (!is_array($element)) {
                     $element = [$element];
                 }
-                $this->updateDeleteListFile($eventCode,$element);
+                $this->updateDeleteListFile($eventCode, $element);
             }
         }
     }
@@ -55,10 +55,10 @@ 
      * @param array $element
      * @return void
      */
-    private function updateFile($filePath,array $element){
+    private function updateFile($filePath, array $element) {
         $content = FileChangesHelper::getJsonContentFromFile($filePath);
         $content[] = $element;
-        FileChangesHelper::writeFile($filePath,json_encode($content));
+        FileChangesHelper::writeFile($filePath, json_encode($content));
     }
 
     /**
@@ -66,10 +66,10 @@ 
      * @param array $element
      * @return void
      */
-    private function updateUpdateListFile($eventCode,array $element){
+    private function updateUpdateListFile($eventCode, array $element) {
         FileChangesHelper::createDirectory($this->dirPathChangings);
         $fileName = 'update_'.$eventCode.'.json';
-        $this->updateFile($this->dirPathChangings.'/'.$fileName,$element);
+        $this->updateFile($this->dirPathChangings.'/'.$fileName, $element);
     }
 
     /**
@@ -77,9 +77,9 @@ 
      * @param array $element
      * @return void
      */
-    private function updateDeleteListFile($eventCode,array $element){
+    private function updateDeleteListFile($eventCode, array $element) {
         FileChangesHelper::createDirectory($this->dirPathChangings);
         $fileName = 'delete_'.$eventCode.'.json';
-        $this->updateFile($this->dirPathChangings.'/'.$fileName,$element);
+        $this->updateFile($this->dirPathChangings.'/'.$fileName, $element);
     }
 }
\ No newline at end of file

src/Services/DetectAppointmentsChangingsService.php

Doc Comments +1 added lines, -1 removed lines

@@ -18,7 +18,7 @@
     }
 
     /**
-     * @param $eventCode
+     * @param string $eventCode
      * @param null|int $start
      * @param null|int $maxResult
      * @return mixed

Spacing +25 added lines, -25 removed lines

@@ -23,14 +23,14 @@ 
      * @param null|int $maxResult
      * @return mixed
      */
-    public function getCurrentAppoiments($eventCode,$start=null,$maxResult=null){
-        if(!$start){
+    public function getCurrentAppoiments($eventCode, $start = null, $maxResult = null) {
+        if (!$start) {
             $start = 0;
         }
-        if(!$maxResult){
-            $maxResult = $this->appointmentsCertain->get($eventCode,['start_index'=>0,'max_results'=>1])->getMaxResults();
+        if (!$maxResult) {
+            $maxResult = $this->appointmentsCertain->get($eventCode, ['start_index'=>0, 'max_results'=>1])->getMaxResults();
         }
-        return $this->certainAppointmentsList = $this->appointmentsCertain->get($eventCode,['start_index'=>$start,'max_results'=>$maxResult])->getResults()->appointments;
+        return $this->certainAppointmentsList = $this->appointmentsCertain->get($eventCode, ['start_index'=>$start, 'max_results'=>$maxResult])->getResults()->appointments;
     }
 
     /**
@@ -38,12 +38,12 @@ 
      * @param array $appointmentsNew
      * @return bool
      */
-    public function hasChanged(array $appointmentsOld,array $appointmentsNew){
+    public function hasChanged(array $appointmentsOld, array $appointmentsNew) {
         $hasChanged = false;
         $appointmentsOld = self::recursiveArrayObjectToFullArray($appointmentsOld);
         $appointmentsNew = self::recursiveArrayObjectToFullArray($appointmentsNew);
-        foreach ($appointmentsOld as $appointmentOld){
-            if(!in_array($appointmentOld,$appointmentsNew)){
+        foreach ($appointmentsOld as $appointmentOld) {
+            if (!in_array($appointmentOld, $appointmentsNew)) {
                 $hasChanged = true;
                 break;
             }
@@ -56,7 +56,7 @@ 
      * @return array
      */
     public static  function objectToArray($object) {
-        if(is_object($object)){
+        if (is_object($object)) {
 
             return (array) $object;
         }
@@ -67,7 +67,7 @@ 
      * @param $appointments
      * @return array
      */
-    public static function recursiveArrayObjectToFullArray($appointments){
+    public static function recursiveArrayObjectToFullArray($appointments) {
         return json_decode(json_encode($appointments), true);
     }
 
@@ -78,8 +78,8 @@ 
      */
     private function arrayRecursiveDiff(array $arrayOlds, array $arrayNews) {
         $difference = [];
-        foreach($arrayOlds as $key => $arrayOld){
-            if(!in_array($arrayOld,$arrayNews)){
+        foreach ($arrayOlds as $key => $arrayOld) {
+            if (!in_array($arrayOld, $arrayNews)) {
                 $difference[$key] = $arrayOld;
             }
         }
@@ -91,12 +91,12 @@ 
      * @param array $appointmentsNew
      * @return array
      */
-    public function getListChangings(array $appointmentsOld,array $appointmentsNew){
+    public function getListChangings(array $appointmentsOld, array $appointmentsNew) {
         $appointmentsOld = self::recursiveArrayObjectToFullArray($appointmentsOld);
         $appointmentsNew = self::recursiveArrayObjectToFullArray($appointmentsNew);
         $changesList = [];
-        if($this->hasChanged($appointmentsOld,$appointmentsNew)){
-            $changesList = self::recursiveArrayObjectToFullArray($this->arrayRecursiveDiff($appointmentsOld,$appointmentsNew));
+        if ($this->hasChanged($appointmentsOld, $appointmentsNew)) {
+            $changesList = self::recursiveArrayObjectToFullArray($this->arrayRecursiveDiff($appointmentsOld, $appointmentsNew));
         }
         return $changesList;
     }
@@ -107,26 +107,26 @@ 
      * @param array $changingsDetected
      * @return array ['deleted'=>[],'updated'=>[]]
      */
-    public function detectDeleteOrUpdated(array $currentAppointments,array $changingsDetected){
+    public function detectDeleteOrUpdated(array $currentAppointments, array $changingsDetected) {
         $delete = [];
         $update = [];
         //@Todo: Detect Fields has changed
         $appointmentsNew = self::recursiveArrayObjectToFullArray($currentAppointments);
         $changings = self::recursiveArrayObjectToFullArray($changingsDetected);
-        foreach ($changings as $changing){
+        foreach ($changings as $changing) {
             $registration = $changing['registration']['regCode'];
             $registrationTarget = $changing['targetRegistration']['regCode'];
-            foreach ($appointmentsNew as $currentAppointment){
+            foreach ($appointmentsNew as $currentAppointment) {
                 $registrationCurrent = $currentAppointment['registration']['regCode'];
                 $registrationTargetCurrent = $currentAppointment['targetRegistration']['regCode'];
-                if(in_array($registration,[$registrationCurrent,$registrationTargetCurrent])
-                    && in_array($registrationTarget,[$registrationCurrent,$registrationTargetCurrent])
-                    && !in_array($changing,$update) && !in_array($changing,$delete)) {
+                if (in_array($registration, [$registrationCurrent, $registrationTargetCurrent])
+                    && in_array($registrationTarget, [$registrationCurrent, $registrationTargetCurrent])
+                    && !in_array($changing, $update) && !in_array($changing, $delete)) {
                     $update[] = $changing;
                     break;
                 }
             }
-            if(!in_array($changing,$update) && !in_array($changing,$delete)){
+            if (!in_array($changing, $update) && !in_array($changing, $delete)) {
                 $delete[] = $changing;
             }
         }
@@ -141,9 +141,9 @@ 
      * @param array $appointmentsNew
      * @return array ['deleted'=>[],'updated'=>[]]
      */
-    public function detectAppointmentsChangings(array $appointmentsOld,array $appointmentsNew){
-        $changings = $this->getListChangings($appointmentsOld,$appointmentsNew);
-        $changesList = $this->detectDeleteOrUpdated($appointmentsNew,$changings);
+    public function detectAppointmentsChangings(array $appointmentsOld, array $appointmentsNew) {
+        $changings = $this->getListChangings($appointmentsOld, $appointmentsNew);
+        $changesList = $this->detectDeleteOrUpdated($appointmentsNew, $changings);
         return $changesList;
     }
 

src/Commands/DetectAppointmentsChangingCommand.php

Spacing +14 added lines, -14 removed lines

@@ -47,7 +47,7 @@ 
      * @param CertainListener[] $listeners
      * @param null $name
      */
-    public function __construct(DetectAppointmentsChangingsService $detectAppointmentsChangingsService,$filePathEventToCheck,$dirPathHistoryAppointments,$fileLockAuthorizeRun, array $listeners=[],$name=null)
+    public function __construct(DetectAppointmentsChangingsService $detectAppointmentsChangingsService, $filePathEventToCheck, $dirPathHistoryAppointments, $fileLockAuthorizeRun, array $listeners = [], $name = null)
     {
         parent::__construct($name);
         $this->detectAppointmentsChangingsService = $detectAppointmentsChangingsService;
@@ -72,40 +72,40 @@ 
     {
         $eventCode = null;
         //Get the EventCode we need to check.
-        if($this->filePathEventToCheck && file_exists($this->filePathEventToCheck)){
+        if ($this->filePathEventToCheck && file_exists($this->filePathEventToCheck)) {
             $eventCode = FileChangesHelper::getContentFile($this->filePathEventToCheck);
         }
         //That permits to stop the followings instructions when we are makings changes on Certain.
-        if(!file_exists($this->fileLockAuthorizeRun.'/detect_appointments_changes.lock') && $eventCode){
+        if (!file_exists($this->fileLockAuthorizeRun.'/detect_appointments_changes.lock') && $eventCode) {
             $output->writeln('Detect changes - Run.');
             //Get the online appointments.
             $appointmentsNewCertain = $this->detectAppointmentsChangingsService->getCurrentAppoiments($eventCode);
             $appointmentsNew = DetectAppointmentsChangingsService::recursiveArrayObjectToFullArray($appointmentsNewCertain);
             //Get the last saved appointments to get old data.
-            $appointmentsOldHistoryFilePath = FileChangesHelper::getTheLastAppointmentsSaved($eventCode,$this->dirPathHistoryAppointments);
-            if(!$appointmentsOldHistoryFilePath){
+            $appointmentsOldHistoryFilePath = FileChangesHelper::getTheLastAppointmentsSaved($eventCode, $this->dirPathHistoryAppointments);
+            if (!$appointmentsOldHistoryFilePath) {
                 //No files so it's the first time we attempt to synchronize.
                 $appointmentsOld = [];
-            }else{
+            }else {
                 //Get the last old appointments data.
                 $appointmentsOldHistory = FileChangesHelper::getJsonContentFromFile($appointmentsOldHistoryFilePath);
                 $appointmentsOld = DetectAppointmentsChangingsService::recursiveArrayObjectToFullArray($appointmentsOldHistory);
             }
             //Check if they are changes.
-            $listChangings = $this->detectAppointmentsChangingsService->detectAppointmentsChangings($appointmentsOld,$appointmentsNew);
-            if(!$appointmentsOld || ((isset($listChangings['updated']) && !empty($listChangings['updated']))
-                || (isset($listChangings['deleted']) && !empty($listChangings['deleted'])))){
+            $listChangings = $this->detectAppointmentsChangingsService->detectAppointmentsChangings($appointmentsOld, $appointmentsNew);
+            if (!$appointmentsOld || ((isset($listChangings['updated']) && !empty($listChangings['updated']))
+                || (isset($listChangings['deleted']) && !empty($listChangings['deleted'])))) {
                 //Changes? So we save the new online appointments
-                FileChangesHelper::saveAppointmentsFileByHistory($this->dirPathHistoryAppointments.'/appointments_'.$eventCode.'.json',json_encode($appointmentsNew));
+                FileChangesHelper::saveAppointmentsFileByHistory($this->dirPathHistoryAppointments.'/appointments_'.$eventCode.'.json', json_encode($appointmentsNew));
                 $output->writeln('Detect changes - Save Changes');
-            }else{
+            }else {
                 $output->writeln('Detect changes - No Changes');
             }
-            foreach ($this->listeners as $listener){
+            foreach ($this->listeners as $listener) {
                 //Run Listener. For instance,Here we can use ChangingsToFileListeners to save the changes in file.
-                $listener->run($eventCode,$listChangings);
+                $listener->run($eventCode, $listChangings);
             }
-        }else{
+        }else {
             $output->writeln('Detect changes - Stop.');
         }
     }

Braces +3 added lines, -3 removed lines

@@ -86,7 +86,7 @@ 
             if(!$appointmentsOldHistoryFilePath){
                 //No files so it's the first time we attempt to synchronize.
                 $appointmentsOld = [];
-            }else{
+            } else{
                 //Get the last old appointments data.
                 $appointmentsOldHistory = FileChangesHelper::getJsonContentFromFile($appointmentsOldHistoryFilePath);
                 $appointmentsOld = DetectAppointmentsChangingsService::recursiveArrayObjectToFullArray($appointmentsOldHistory);
@@ -98,14 +98,14 @@ 
                 //Changes? So we save the new online appointments
                 FileChangesHelper::saveAppointmentsFileByHistory($this->dirPathHistoryAppointments.'/appointments_'.$eventCode.'.json',json_encode($appointmentsNew));
                 $output->writeln('Detect changes - Save Changes');
-            }else{
+            } else{
                 $output->writeln('Detect changes - No Changes');
             }
             foreach ($this->listeners as $listener){
                 //Run Listener. For instance,Here we can use ChangingsToFileListeners to save the changes in file.
                 $listener->run($eventCode,$listChangings);
             }
-        }else{
+        } else{
             $output->writeln('Detect changes - Stop.');
         }
     }

src/Helpers/FileChangesHelper.php

Spacing +14 added lines, -14 removed lines

@@ -10,8 +10,8 @@ 
      * @param $dirPath
      * @return bool
      */
-    public static function createDirectory($dirPath){
-        if(!file_exists($dirPath)){
+    public static function createDirectory($dirPath) {
+        if (!file_exists($dirPath)) {
             return mkdir($dirPath, 0775, true, null);
         }
         return false;
@@ -23,7 +23,7 @@ 
      * @param string $msg
      * @return void
      */
-    public static function writeFile($path,$msg){
+    public static function writeFile($path, $msg) {
         $f = fopen($path, "w+");
         fwrite($f, $msg);
         fclose($f);
@@ -35,15 +35,15 @@ 
      * @param string $contents
      * @return void
      */
-    public static function saveAppointmentsFileByHistory($filePath,$contents){
+    public static function saveAppointmentsFileByHistory($filePath, $contents) {
         $time = time();
         $file = pathinfo($filePath);
         $fileNamebase = $file['filename'];
         $filePath = $file['dirname'].'/'.$fileNamebase.'_'.$time.'.json';
-        if(!file_exists($filePath)){
-            self::writeFile($filePath,'');
+        if (!file_exists($filePath)) {
+            self::writeFile($filePath, '');
         }
-        self::writeFile($filePath,$contents);
+        self::writeFile($filePath, $contents);
     }
 
     /**
@@ -51,9 +51,9 @@ 
      * @param $path
      * @return string
      */
-    public static function getContentFile($path){
-        if(!file_exists($path)){
-            self::writeFile($path,'');
+    public static function getContentFile($path) {
+        if (!file_exists($path)) {
+            self::writeFile($path, '');
         }
         $handle = fopen($path, "rb");
         if (FALSE === $handle) {
@@ -72,7 +72,7 @@ 
      * @param string $path
      * @return mixed
      */
-    public static function getJsonContentFromFile($path){
+    public static function getJsonContentFromFile($path) {
         $contents = self::getContentFile($path);
         return json_decode($contents, true);
     }
@@ -83,7 +83,7 @@ 
      * @param string $pathDir
      * @return array
      */
-    public static function getFilesListHistoryAppointmentsByEventCode($eventCode,$pathDir){
+    public static function getFilesListHistoryAppointmentsByEventCode($eventCode, $pathDir) {
         $fileList = array();
         $files = glob($pathDir.'/appointments_'.$eventCode.'_*.json');
         foreach ($files as $file) {
@@ -100,8 +100,8 @@ 
      * @param string $pathDir
      * @return string
      */
-    public static function getTheLastAppointmentsSaved($eventCode,$pathDir){
-        $fileList = self::getFilesListHistoryAppointmentsByEventCode($eventCode,$pathDir);
+    public static function getTheLastAppointmentsSaved($eventCode, $pathDir) {
+        $fileList = self::getFilesListHistoryAppointmentsByEventCode($eventCode, $pathDir);
         return array_shift($fileList);
     }
 }
\ No newline at end of file

tests/bootstrap.php

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 if (file_exists(__DIR__.'/../vendor/autoload.php')) {
     require_once __DIR__.'/../vendor/autoload.php';
-} else {
+}else {
     require_once __DIR__.'/../../../../vendor/autoload.php';
 }
\ No newline at end of file

tests/Wabel/Services/DetectAppointmentsChangingsServiceTest.php

Spacing +28 added lines, -28 removed lines

@@ -29,7 +29,7 @@ 
      * Personal Object to test
      * @return array
      */
-    private function personalAppointment(){
+    private function personalAppointment() {
         return [
                     "appointmentId"=> 52,
                     "startDate"=> "2015-16-07 11:00:00",
@@ -68,23 +68,23 @@ 
 
     protected function setUp()
     {
-        $certainApiClient =  new CertainApiClient(null,$GLOBALS['username'],$GLOBALS['password'],$GLOBALS['accountCode']);
-        $this->certainApiService  = new CertainApiService($certainApiClient);
+        $certainApiClient = new CertainApiClient(null, $GLOBALS['username'], $GLOBALS['password'], $GLOBALS['accountCode']);
+        $this->certainApiService = new CertainApiService($certainApiClient);
         $this->appointmentsCertain = new AppointmentsCertain($this->certainApiService);
-        $this->certainAppointmentsList = $this->appointmentsCertain->get($GLOBALS['eventCode'],['start_index'=>0,'max_results'=>10])->getResults()->appointments;
+        $this->certainAppointmentsList = $this->appointmentsCertain->get($GLOBALS['eventCode'], ['start_index'=>0, 'max_results'=>10])->getResults()->appointments;
     }
 
-    public function testDetectChangings(){
+    public function testDetectChangings() {
         $detectService = new DetectAppointmentsChangingsService($this->appointmentsCertain);
         $oldAppointments = $this->certainAppointmentsList;
         $currentAppoiments = $oldAppointments;
         unset($currentAppoiments[0]);
         unset($currentAppoiments[1]);
-        $hasChanged = $detectService->hasChanged($oldAppointments,$currentAppoiments);
+        $hasChanged = $detectService->hasChanged($oldAppointments, $currentAppoiments);
         $this->assertTrue($hasChanged);
     }
 
-    public function testGetListChangings(){
+    public function testGetListChangings() {
         $detectService = new DetectAppointmentsChangingsService($this->appointmentsCertain);
         $oldAppointments = $this->certainAppointmentsList;
         $currentAppoiments = $oldAppointments;
@@ -94,14 +94,14 @@ 
         unset($currentAppoiments[0]);
         unset($currentAppoiments[1]);
         unset($currentAppoiments[4]);
-        $changings = $detectService->getListChangings($oldAppointments,$currentAppoiments);
-        $this->assertEquals(3,count($changings));
-        $this->assertContains($delete1,$changings);
-        $this->assertContains($delete2,$changings);
-        $this->assertContains($delete3,$changings);
+        $changings = $detectService->getListChangings($oldAppointments, $currentAppoiments);
+        $this->assertEquals(3, count($changings));
+        $this->assertContains($delete1, $changings);
+        $this->assertContains($delete2, $changings);
+        $this->assertContains($delete3, $changings);
     }
 
-    public function testDetectDeleteOrUpdated(){
+    public function testDetectDeleteOrUpdated() {
         $detectService = new DetectAppointmentsChangingsService($this->appointmentsCertain);
         $oldAppointments = $this->certainAppointmentsList;
         $oldAppointments[10] = $this->personalAppointment();
@@ -113,19 +113,19 @@ 
         $update1 = $currentAppoiments[10];
         $currentAppoiments[10]["startDate"] = "2015-17-07 12:00:00";
         $currentAppoiments[10]["endDate"] = "2015-17-07 12:30:00";
-        $changings = $detectService->getListChangings($oldAppointments,$currentAppoiments);
-        $listDetected = $detectService->detectDeleteOrUpdated($currentAppoiments,$changings);
-        $this->assertEquals(3,count($changings));
-        $this->assertArrayHasKey('deleted',$listDetected);
-        $this->assertArrayHasKey('updated',$listDetected);
-        $this->assertEquals(2,count($listDetected['deleted']));
-        $this->assertEquals(1,count($listDetected['updated']));
-        $this->assertContains($delete1,$listDetected['deleted']);
-        $this->assertContains($delete2,$listDetected['deleted']);
-        $this->assertContains($update1,$listDetected['updated']);
+        $changings = $detectService->getListChangings($oldAppointments, $currentAppoiments);
+        $listDetected = $detectService->detectDeleteOrUpdated($currentAppoiments, $changings);
+        $this->assertEquals(3, count($changings));
+        $this->assertArrayHasKey('deleted', $listDetected);
+        $this->assertArrayHasKey('updated', $listDetected);
+        $this->assertEquals(2, count($listDetected['deleted']));
+        $this->assertEquals(1, count($listDetected['updated']));
+        $this->assertContains($delete1, $listDetected['deleted']);
+        $this->assertContains($delete2, $listDetected['deleted']);
+        $this->assertContains($update1, $listDetected['updated']);
     }
 
-    public function testDetectAppointmentsChangings(){
+    public function testDetectAppointmentsChangings() {
         $detectService = new DetectAppointmentsChangingsService($this->appointmentsCertain);
         $oldAppointments = $this->certainAppointmentsList;
         $oldAppointments[10] = $this->personalAppointment();
@@ -137,10 +137,10 @@ 
         $update1 = $currentAppoiments[10];
         $currentAppoiments[10]["startDate"] = "2015-17-07 12:00:00";
         $currentAppoiments[10]["endDate"] = "2015-17-07 12:30:00";
-        $listDetected = $detectService->detectAppointmentsChangings($oldAppointments,$currentAppoiments);
-        $this->assertContains($delete1,$listDetected['deleted']);
-        $this->assertContains($delete2,$listDetected['deleted']);
-        $this->assertContains($update1,$listDetected['updated']);
+        $listDetected = $detectService->detectAppointmentsChangings($oldAppointments, $currentAppoiments);
+        $this->assertContains($delete1, $listDetected['deleted']);
+        $this->assertContains($delete2, $listDetected['deleted']);
+        $this->assertContains($update1, $listDetected['updated']);
     }
 
 }
\ No newline at end of file