Issues in TacticianBus.php (master) - Issues in master - WZRDFRMK/framework - Measure and Improve Code Quality continuously with Scrutinizer

Issues (25)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Messaging/TacticianBus.php (7 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace WZRD\Messaging;

use InvalidArgumentException;
use League\Tactician\CommandBus as BaseTacticianBus;
use League\Tactician\Handler\CommandHandlerMiddleware;
use League\Tactician\Handler\CommandNameExtractor\ClassNameExtractor;
use League\Tactician\Handler\Locator\InMemoryLocator;
use League\Tactician\Handler\MethodNameInflector\HandleInflector;
use League\Tactician\Plugins\LockingMiddleware;
use ReflectionParameter;
use WZRD\Contracts\Messaging\Bus as BusContract;
use WZRD\Contracts\Messaging\Handler as HandlerContract;
use WZRD\Contracts\Messaging\Message as MessageContract;

class TacticianBus extends BaseTacticianBus implements BusContract
{
    /**
     * Build the bus.
     *
     * @param Middleware[] $middleware
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     */
    public function __construct(array $middlewares = [])
    {
        $this->init        = false;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->middlewares = $middlewares;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->locator     = new InMemoryLocator();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->extractor   = new ClassNameExtractor();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->inflector   = new HandleInflector();
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Dispatch a message to its appropriate handler.
     *
     * @param WZRD\Contracts\Messaging\Message $message
     */
    public function dispatch(MessageContract $message)
    {
        if (!$this->init) {
            $this->init = true;
            parent::__construct(array_merge($this->middlewares, [
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
                new LockingMiddleware(),
                new CommandHandlerMiddleware($this->extractor, $this->locator, $this->inflector),
            ]));
        }

        return $this->handle($message);
    }

    /**
     * Subscribes the handler to this bus.
     *
     * @param WZRD\Contracts\Messaging\Handler $handler
     */
    public function subscribe(HandlerContract $handler)
    {
        if (!($handler instanceof Handler)) {
            throw new InvalidArgumentException("Handler must extends WZRD\Messaging\Hanlder");
        }

        $handle_parameter_reflection = new ReflectionParameter([get_class($handler), 'process'], 0);

        $expected_message = $handle_parameter_reflection->getClass()->name;

        $this->locator->addHandler($handler, $expected_message);
    }
}


1			<?php
2
3			namespace WZRD\Messaging;
4
5			use InvalidArgumentException;
6			use League\Tactician\CommandBus as BaseTacticianBus;
7			use League\Tactician\Handler\CommandHandlerMiddleware;
8			use League\Tactician\Handler\CommandNameExtractor\ClassNameExtractor;
9			use League\Tactician\Handler\Locator\InMemoryLocator;
10			use League\Tactician\Handler\MethodNameInflector\HandleInflector;
11			use League\Tactician\Plugins\LockingMiddleware;
12			use ReflectionParameter;
13			use WZRD\Contracts\Messaging\Bus as BusContract;
14			use WZRD\Contracts\Messaging\Handler as HandlerContract;
15			use WZRD\Contracts\Messaging\Message as MessageContract;
16
17			class TacticianBus extends BaseTacticianBus implements BusContract
18			{
19			/**
20			* Build the bus.
21			*
22			* @param Middleware[] $middleware
			0 ignored issues – show Documentation introduced 2016-02-18 10:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$middleware`. Did you maybe mean `$middlewares`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
23			*/
24			public function __construct(array $middlewares = [])
25			{
26			$this->init = false;
			0 ignored issues – show Bug introduced 2016-02-18 10:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `init` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
27			$this->middlewares = $middlewares;
			0 ignored issues – show Bug introduced 2016-02-18 10:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `middlewares` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
28			$this->locator = new InMemoryLocator();
			0 ignored issues – show Bug introduced 2016-02-18 10:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `locator` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
29			$this->extractor = new ClassNameExtractor();
			0 ignored issues – show Bug introduced 2016-02-18 10:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `extractor` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
30			$this->inflector = new HandleInflector();
			0 ignored issues – show Bug introduced 2016-02-18 10:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `inflector` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
31			}
32
33			/**
34			* Dispatch a message to its appropriate handler.
35			*
36			* @param WZRD\Contracts\Messaging\Message $message
37			*/
38			public function dispatch(MessageContract $message)
39			{
40			if (!$this->init) {
41			$this->init = true;
42			parent::__construct(array_merge($this->middlewares, [
			0 ignored issues – show Comprehensibility Bug introduced 2016-02-18 10:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you call parent on a different method (`__construct()` instead of `dispatch()`). Are you sure this is correct? If so, you might want to change this to `$this->__construct()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
43			new LockingMiddleware(),
44			new CommandHandlerMiddleware($this->extractor, $this->locator, $this->inflector),
45			]));
46			}
47
48			return $this->handle($message);
49			}
50
51			/**
52			* Subscribes the handler to this bus.
53			*
54			* @param WZRD\Contracts\Messaging\Handler $handler
55			*/
56			public function subscribe(HandlerContract $handler)
57			{
58			if (!($handler instanceof Handler)) {
59			throw new InvalidArgumentException("Handler must extends WZRD\Messaging\Hanlder");
60			}
61
62			$handle_parameter_reflection = new ReflectionParameter([get_class($handler), 'process'], 0);
63
64			$expected_message = $handle_parameter_reflection->getClass()->name;
65
66			$this->locator->addHandler($handler, $expected_message);
67			}
68			}
69

WZRDFRMK / framework

Issues (25)

Security Analysis no request data

src/Messaging/TacticianBus.php (7 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like