TacticianBus::__construct()   A
last analyzed

Complexity

Conditions 1
Paths 1

Size

Total Lines 8
Code Lines 6

Duplication

Lines 0
Ratio 0 %

Importance

Changes 1
Bugs 0 Features 1
Metric Value
c 1
b 0
f 1
dl 0
loc 8
rs 9.4285
cc 1
eloc 6
nc 1
nop 1
1
<?php
2
3
namespace WZRD\Messaging;
4
5
use InvalidArgumentException;
6
use League\Tactician\CommandBus as BaseTacticianBus;
7
use League\Tactician\Handler\CommandHandlerMiddleware;
8
use League\Tactician\Handler\CommandNameExtractor\ClassNameExtractor;
9
use League\Tactician\Handler\Locator\InMemoryLocator;
10
use League\Tactician\Handler\MethodNameInflector\HandleInflector;
11
use League\Tactician\Plugins\LockingMiddleware;
12
use ReflectionParameter;
13
use WZRD\Contracts\Messaging\Bus as BusContract;
14
use WZRD\Contracts\Messaging\Handler as HandlerContract;
15
use WZRD\Contracts\Messaging\Message as MessageContract;
16
17
class TacticianBus extends BaseTacticianBus implements BusContract
18
{
19
    /**
20
     * Build the bus.
21
     *
22
     * @param Middleware[] $middleware
0 ignored issues
show
Documentation introduced by
There is no parameter named $middleware. Did you maybe mean $middlewares?

This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit.

Consider the following example. The parameter $ireland is not defined by the method finale(...).

/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}

The most likely cause is that the parameter was changed, but the annotation was not.

Loading history...
23
     */
24
    public function __construct(array $middlewares = [])
25
    {
26
        $this->init        = false;
0 ignored issues
show
Bug introduced by
The property init does not exist. Did you maybe forget to declare it?

In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code:

class MyClass { }

$x = new MyClass();
$x->foo = true;

Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion:

class MyClass {
    public $foo;
}

$x = new MyClass();
$x->foo = true;
Loading history...
27
        $this->middlewares = $middlewares;
0 ignored issues
show
Bug introduced by
The property middlewares does not exist. Did you maybe forget to declare it?

In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code:

class MyClass { }

$x = new MyClass();
$x->foo = true;

Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion:

class MyClass {
    public $foo;
}

$x = new MyClass();
$x->foo = true;
Loading history...
28
        $this->locator     = new InMemoryLocator();
0 ignored issues
show
Bug introduced by
The property locator does not exist. Did you maybe forget to declare it?

In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code:

class MyClass { }

$x = new MyClass();
$x->foo = true;

Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion:

class MyClass {
    public $foo;
}

$x = new MyClass();
$x->foo = true;
Loading history...
29
        $this->extractor   = new ClassNameExtractor();
0 ignored issues
show
Bug introduced by
The property extractor does not exist. Did you maybe forget to declare it?

In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code:

class MyClass { }

$x = new MyClass();
$x->foo = true;

Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion:

class MyClass {
    public $foo;
}

$x = new MyClass();
$x->foo = true;
Loading history...
30
        $this->inflector   = new HandleInflector();
0 ignored issues
show
Bug introduced by
The property inflector does not exist. Did you maybe forget to declare it?

In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code:

class MyClass { }

$x = new MyClass();
$x->foo = true;

Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion:

class MyClass {
    public $foo;
}

$x = new MyClass();
$x->foo = true;
Loading history...
31
    }
32
33
    /**
34
     * Dispatch a message to its appropriate handler.
35
     *
36
     * @param WZRD\Contracts\Messaging\Message $message
37
     */
38
    public function dispatch(MessageContract $message)
39
    {
40
        if (!$this->init) {
41
            $this->init = true;
42
            parent::__construct(array_merge($this->middlewares, [
0 ignored issues
show
Comprehensibility Bug introduced by
It seems like you call parent on a different method (__construct() instead of dispatch()). Are you sure this is correct? If so, you might want to change this to $this->__construct().

This check looks for a call to a parent method whose name is different than the method from which it is called.

Consider the following code:

class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}

The getFirstName() method in the Son calls the wrong method in the parent class.

Loading history...
43
                new LockingMiddleware(),
44
                new CommandHandlerMiddleware($this->extractor, $this->locator, $this->inflector),
45
            ]));
46
        }
47
48
        return $this->handle($message);
49
    }
50
51
    /**
52
     * Subscribes the handler to this bus.
53
     *
54
     * @param WZRD\Contracts\Messaging\Handler $handler
55
     */
56
    public function subscribe(HandlerContract $handler)
57
    {
58
        if (!($handler instanceof Handler)) {
59
            throw new InvalidArgumentException("Handler must extends WZRD\Messaging\Hanlder");
60
        }
61
62
        $handle_parameter_reflection = new ReflectionParameter([get_class($handler), 'process'], 0);
63
64
        $expected_message = $handle_parameter_reflection->getClass()->name;
65
66
        $this->locator->addHandler($handler, $expected_message);
67
    }
68
}
69