Completed
Pull Request — master (#374)
by Leny
28:15 queued 21:44
created
Bundle/CoreBundle/Entity/Link.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,6 @@
 block discarded – undo
6 6
 use Symfony\Component\Validator\Constraints as Assert;
7 7
 use Symfony\Component\Validator\Context\ExecutionContextInterface;
8 8
 use Symfony\Component\Validator\Mapping\ClassMetadata;
9
-use Victoire\Bundle\PageBundle\Entity\Page;
10 9
 
11 10
 /**
12 11
  * Victoire Link.
Please login to merge, or discard this patch.
Bundle/FormBundle/Form/Type/LinkType.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -105,7 +105,7 @@
 block discarded – undo
105 105
      *
106 106
      * @param                                    $linkType
107 107
      * @param                                    $locale
108
-     * @param FormBuilderInterface|FormInterface $form
108
+     * @param FormInterface $form
109 109
      * @param FormBuilderInterface               $builder
110 110
      */
111 111
     protected function manageLinkTypeRelatedFields($linkType, $locale, $form, FormBuilderInterface $builder)
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
                 'choices_as_values'              => true,
68 68
                 'vic_vic_widget_form_group_attr' => ['class' => 'vic-form-group viewReference-type page-type url-type route-type attachedWidget-type'],
69 69
             ])
70
-            ->addEventListener(FormEvents::PRE_SET_DATA, function (FormEvent $event) use ($builder) {
70
+            ->addEventListener(FormEvents::PRE_SET_DATA, function(FormEvent $event) use ($builder) {
71 71
                 $data = $event->getData();
72 72
                 $form = $event->getForm();
73 73
                 if ($data) {
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
             });
80 80
 
81 81
         $builder
82
-            ->addEventListener(FormEvents::PRE_SUBMIT, function (FormEvent $event) use ($builder) {
82
+            ->addEventListener(FormEvents::PRE_SUBMIT, function(FormEvent $event) use ($builder) {
83 83
                 $form = $event->getForm();
84 84
                 $data = $event->getData();
85 85
                 $locale = isset($data['locale']) ? $data['locale'] : null;
Please login to merge, or discard this patch.
Bundle/PageBundle/EventSubscriber/PageSubscriber.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Victoire\Bundle\PageBundle\EventSubscriber;
4 4
 
5 5
 use Doctrine\Common\EventSubscriber;
6
-use Doctrine\Common\Util\ClassUtils;
7 6
 use Doctrine\ORM\EntityManager;
8 7
 use Doctrine\ORM\Event\LifecycleEventArgs;
9 8
 use Doctrine\ORM\Event\LoadClassMetadataEventArgs;
Please login to merge, or discard this patch.
Bundle/ViewReferenceBundle/Connector/ViewReferenceManager.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
     /**
35 35
      * This method save a tree of viewReferences.
36 36
      *
37
-     * @param array     $viewReferences
37
+     * @param \Victoire\Bundle\CoreBundle\Entity\WebViewInterface[]     $viewReferences
38 38
      * @param string    $parentId
39 39
      * @param string    $parentLocale
40 40
      * @param bool      $reset
Please login to merge, or discard this patch.
Bundle/ViewReferenceBundle/Helper/ViewReferenceHelper.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@
 block discarded – undo
59 59
     }
60 60
 
61 61
     /**
62
-     * @param [] $tree
62
+     * @param WebViewInterface[] $tree
63 63
      */
64 64
     public function buildViewReferenceRecursively($tree, EntityManager $entityManager)
65 65
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,6 @@
 block discarded – undo
8 8
 use Victoire\Bundle\BusinessPageBundle\Entity\BusinessPage;
9 9
 use Victoire\Bundle\CoreBundle\Entity\View;
10 10
 use Victoire\Bundle\CoreBundle\Entity\WebViewInterface;
11
-use Victoire\Bundle\CoreBundle\Repository\ViewRepository;
12 11
 use Victoire\Bundle\ViewReferenceBundle\Builder\ViewReferenceBuilder;
13 12
 
14 13
 /**
Please login to merge, or discard this patch.
Bundle/WidgetMapBundle/Warmer/WidgetDataWarmer.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,6 @@
 block discarded – undo
13 13
 use Victoire\Bundle\CoreBundle\Entity\View;
14 14
 use Victoire\Bundle\PageBundle\Entity\Page;
15 15
 use Victoire\Bundle\ViewReferenceBundle\Connector\ViewReferenceRepository;
16
-use Victoire\Bundle\ViewReferenceBundle\ViewReference\BusinessPageReference;
17 16
 use Victoire\Bundle\ViewReferenceBundle\ViewReference\ViewReference;
18 17
 use Victoire\Bundle\WidgetBundle\Entity\Traits\LinkTrait;
19 18
 use Victoire\Bundle\WidgetBundle\Entity\Widget;
Please login to merge, or discard this patch.
Bundle/CoreBundle/Exception/IdentifierNotDefinedException.php 1 patch
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1,10 +1,10 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * Created by PhpStorm.
4
- * User: lenybernard
5
- * Date: 24/03/2016
6
- * Time: 21:58
7
- */
3
+     * Created by PhpStorm.
4
+     * User: lenybernard
5
+     * Date: 24/03/2016
6
+     * Time: 21:58
7
+     */
8 8
 
9 9
 namespace Victoire\Bundle\CoreBundle\Exception;
10 10
 
Please login to merge, or discard this patch.
Bundle/CoreBundle/Repository/ViewRepository.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@
 block discarded – undo
114 114
 
115 115
         foreach ($localizedViewReferences as $locale => $_viewReferences) {
116 116
             //the query builder
117
-            $queryBuilder = $this->createQueryBuilder('page');;
117
+            $queryBuilder = $this->createQueryBuilder('page'); ;
118 118
 
119 119
             $pageIds = [];
120 120
             foreach ($_viewReferences as $viewReference) {
Please login to merge, or discard this patch.
Bundle/ViewReferenceBundle/Connector/ViewReferenceRepository.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
         $references = $this->repository->getResults($refsId);
89 89
         foreach ($references as $reference) {
90 90
             if ($transform === true) {
91
-                $transformViewReferenceFn = function ($parentViewReference) use (&$transformViewReferenceFn, $keepChildren) {
91
+                $transformViewReferenceFn = function($parentViewReference) use (&$transformViewReferenceFn, $keepChildren) {
92 92
                     $transformer = ViewReferenceManager::findTransformerFromElement($parentViewReference);
93 93
                     $reference = $transformer->transform($parentViewReference);
94 94
                     if ($keepChildren) {
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
     {
153 153
         $viewsReferences = [];
154 154
 
155
-        $decoratorFn = function ($depth, $char0 = '└', $char = '─') {
155
+        $decoratorFn = function($depth, $char0 = '└', $char = '─') {
156 156
             $decorator = $char0;
157 157
             for ($i = 0; $i <= $depth; $i++) {
158 158
                 $decorator .= $char;
Please login to merge, or discard this patch.