1 | <?php |
||||||
2 | |||||||
3 | namespace VGirol\JsonApiAssert\Laravel; |
||||||
4 | |||||||
5 | use Illuminate\Support\Arr; |
||||||
6 | use Illuminate\Testing\Assert; |
||||||
0 ignored issues
–
show
|
|||||||
7 | use Illuminate\Testing\TestResponse as IlluminateTestResponse; |
||||||
8 | |||||||
9 | class TestResponse extends IlluminateTestResponse |
||||||
10 | { |
||||||
11 | public const ERROR_STATUS = 'Expected status code %d but received %d.'; |
||||||
12 | |||||||
13 | 12 | public function assertStatus($status) |
|||||
14 | { |
||||||
15 | 12 | $actual = $this->getStatusCode(); |
|||||
0 ignored issues
–
show
The method
getStatusCode() does not exist on VGirol\JsonApiAssert\Laravel\TestResponse . Since you implemented __call , consider adding a @method annotation.
(
Ignorable by Annotation
)
If this is a false-positive, you can also ignore this issue in your code via the
![]() |
|||||||
16 | |||||||
17 | 12 | $message = sprintf(self::ERROR_STATUS, $status, $actual); |
|||||
18 | 12 | if ($actual >= 300) { |
|||||
19 | 6 | $data = $this->baseResponse->getData(true); |
|||||
20 | 6 | if (Arr::exists($data, 'errors')) { |
|||||
21 | 6 | $errors = Arr::get($data, 'errors'); |
|||||
22 | 6 | if (count($errors)) { |
|||||
0 ignored issues
–
show
It seems like
$errors can also be of type null ; however, parameter $value of count() does only seem to accept Countable|array , maybe add an additional type check?
(
Ignorable by Annotation
)
If this is a false-positive, you can also ignore this issue in your code via the
![]() |
|||||||
23 | 6 | $error = Arr::first($errors); |
|||||
24 | 6 | if (Arr::exists($error, 'details')) { |
|||||
25 | 6 | $message .= "\n" . Arr::get($error, 'details'); |
|||||
26 | } |
||||||
27 | } |
||||||
28 | } |
||||||
29 | } |
||||||
30 | |||||||
31 | 12 | Assert::assertSame( |
|||||
32 | 12 | $actual, |
|||||
33 | 12 | $status, |
|||||
34 | 12 | $message |
|||||
35 | ); |
||||||
36 | |||||||
37 | 3 | return $this; |
|||||
38 | } |
||||||
39 | } |
||||||
40 |
Let?s assume that you have a directory layout like this:
and let?s assume the following content of
Bar.php
:If both files
OtherDir/Foo.php
andSomeDir/Foo.php
are loaded in the same runtime, you will see a PHP error such as the following:PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php
However, as
OtherDir/Foo.php
does not necessarily have to be loaded and the error is only triggered if it is loaded beforeOtherDir/Bar.php
, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: