TestResponse   A
last analyzed

Complexity

Total Complexity 5

Size/Duplication

Total Lines 29
Duplicated Lines 0 %

Test Coverage

Coverage 100%

Importance

Changes 1
Bugs 0 Features 0
Metric Value
wmc 5
eloc 17
c 1
b 0
f 0
dl 0
loc 29
ccs 16
cts 16
cp 1
rs 10

1 Method

Rating   Name   Duplication   Size   Complexity  
A assertStatus() 0 25 5
1
<?php
2
3
namespace VGirol\JsonApiAssert\Laravel;
4
5
use Illuminate\Support\Arr;
6
use Illuminate\Testing\Assert;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, VGirol\JsonApiAssert\Laravel\Assert. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
7
use Illuminate\Testing\TestResponse as IlluminateTestResponse;
8
9
class TestResponse extends IlluminateTestResponse
10
{
11
    public const ERROR_STATUS = 'Expected status code %d but received %d.';
12
13 12
    public function assertStatus($status)
14
    {
15 12
        $actual = $this->getStatusCode();
0 ignored issues
show
Bug introduced by
The method getStatusCode() does not exist on VGirol\JsonApiAssert\Laravel\TestResponse. Since you implemented __call, consider adding a @method annotation. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

15
        /** @scrutinizer ignore-call */ 
16
        $actual = $this->getStatusCode();
Loading history...
16
17 12
        $message = sprintf(self::ERROR_STATUS, $status, $actual);
18 12
        if ($actual >= 300) {
19 6
            $data = $this->baseResponse->getData(true);
20 6
            if (Arr::exists($data, 'errors')) {
21 6
                $errors = Arr::get($data, 'errors');
22 6
                if (count($errors)) {
0 ignored issues
show
Bug introduced by
It seems like $errors can also be of type null; however, parameter $value of count() does only seem to accept Countable|array, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

22
                if (count(/** @scrutinizer ignore-type */ $errors)) {
Loading history...
23 6
                    $error = Arr::first($errors);
24 6
                    if (Arr::exists($error, 'details')) {
25 6
                        $message .= "\n" . Arr::get($error, 'details');
26
                    }
27
                }
28
            }
29
        }
30
31 12
        Assert::assertSame(
32 12
            $actual,
33 12
            $status,
34 12
            $message
35
        );
36
37 3
        return $this;
38
    }
39
}
40