AmbassadorService::createEntityByFormData() - Code Metrics - Inspection of "BandController refactoring with ambassador members..." - VAPC/RockParade-API - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 21a45d...334091 )

by Petr

created 2016-09-19 01:27 UTC

AmbassadorService::createEntityByFormData() A

↳ Parent: AmbassadorService

Complexity

Conditions	3
Paths	3

Size

Total Lines	14
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3.1406

Importance

Changes

Metric	Value
dl	0
loc	14
ccs	6
cts	8
cp	0.75
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	9
nc	3
nop	2
crap	3.1406

<?php

namespace AppBundle\Service\Ambassador;

use AppBundle\Entity\Band;
use AppBundle\Entity\BandMember;
use AppBundle\Entity\Infrasctucture\Ambassador;
use AppBundle\Entity\Infrasctucture\AmbassadorMemberRepository;
use AppBundle\Entity\Infrasctucture\AmbassadorRepository;
use AppBundle\Entity\User;
use AppBundle\Exception\FormTypeNotSupported;
use AppBundle\Form\AbstractFormType;
use AppBundle\Form\Ambassador\AmbassadorFormType;
use AppBundle\Form\Ambassador\AmbassadorMemberFormType;
use AppBundle\Service\Entity\BandService;
use AppBundle\Service\Entity\Infrastructure\EntityCreatorInterface;
use Doctrine\ORM\EntityManager;

/**
 * @author Vehsamrak
 */
class AmbassadorService implements EntityCreatorInterface
{

    /** @var EntityManager */
    private $entityManager;

    /** @var BandService */
    private $bandService;

    public function __construct(EntityManager $entityManager, BandService $bandService)
function someFunction(ManagerRegistry $registry) {
    $em = $registry->getManager();
    $em->getConnection()->beginTransaction();
    try {
        // Do something.
        $em->getConnection()->commit();
    } catch (\Exception $ex) {
        $em->getConnection()->rollback();
        $em->close();

        throw $ex;
    }
}
    {
        $this->entityManager = $entityManager;
        $this->bandService = $bandService;
    }

    public function createEntityByFormData(AbstractFormType $formType, User $creator)
    {
        if ($formType instanceof AmbassadorFormType) {
            $entity = $this->createAmbassador($formType, $creator);
        } elseif ($formType instanceof AmbassadorMemberFormType) {
            $entity = $this->createAmbassadorMember($formType);
        } else {
            throw new FormTypeNotSupported(get_class($formType));
        }

        $this->entityManager->flush($entity);

        return $entity;
    }

    private function getOrCreateMemberByAmbassadorAndUserLogin(
        Ambassador $ambassador,
        $memberLogin,
        $memberShortDescription = '',
        $memberDescription = ''
    ) {
        $user = $this->entityManager->getRepository(User::class)->findOneByLogin($memberLogin);
        /** @var AmbassadorMemberRepository $repository */
        $repository = $this->entityManager->getRepository($ambassador->getMemberClass());

        return $repository->getOrCreateByAmbassadorAndUser(
            $ambassador,
            $user,
            $memberShortDescription,
            $memberDescription
        );

    }

    private function createAmbassador(AmbassadorFormType $formType, User $creator)
    {
        $ambassadorName = $formType->name;
        $ambassadorDescription = $formType->description;
        $ambassadorMemberLogins = (array) $formType->members;

        /** @var Ambassador $ambassador */
        $entityClass = $formType->getEntityClassName();
        $ambassador = new $entityClass($ambassadorName, $creator, $ambassadorDescription);
        /** @var AmbassadorRepository $repository */
        $repository = $this->entityManager->getRepository($entityClass);
        $repository->persist($ambassador);

        if ($ambassador instanceof Band) {
            $ambassador->addMember($this->bandService->createBandMemberFromCreator($ambassador, $creator));

            foreach ($ambassadorMemberLogins as $memberData) {
                $memberLogin = $memberData['login'];
                $memberShortDescription = $memberData['short_description'];
                $memberDescription = $memberData['description'] ?? '';

                /** @var BandMember $member */
                $member = $this->getOrCreateMemberByAmbassadorAndUserLogin(
                    $ambassador,
                    $memberLogin,
                    $memberShortDescription,
                    $memberDescription
                );

                $ambassador->addMember($member);
            }
        }

        return $ambassador;
    }

    private function createAmbassadorMember(AmbassadorMemberFormType $formType)
    {
        $ambassadorId = $formType->ambassador;
        /** @var AmbassadorRepository $ambassadorRepository */
        $ambassadorRepository = $this->entityManager->getRepository($formType->getEntityClassName());
        $ambassador = $ambassadorRepository->findOneById($ambassadorId);

        return $this->getOrCreateMemberByAmbassadorAndUserLogin(
            $ambassador,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $formType->login,
            $formType->shortDescription,
            $formType->description
        );
    }
}


1		<?php
2
3		namespace AppBundle\Service\Ambassador;
4
5		use AppBundle\Entity\Band;
6		use AppBundle\Entity\BandMember;
7		use AppBundle\Entity\Infrasctucture\Ambassador;
8		use AppBundle\Entity\Infrasctucture\AmbassadorMemberRepository;
9		use AppBundle\Entity\Infrasctucture\AmbassadorRepository;
10		use AppBundle\Entity\User;
11		use AppBundle\Exception\FormTypeNotSupported;
12		use AppBundle\Form\AbstractFormType;
13		use AppBundle\Form\Ambassador\AmbassadorFormType;
14		use AppBundle\Form\Ambassador\AmbassadorMemberFormType;
15		use AppBundle\Service\Entity\BandService;
16		use AppBundle\Service\Entity\Infrastructure\EntityCreatorInterface;
17		use Doctrine\ORM\EntityManager;
18
19		/**
20		* @author Vehsamrak
21		*/
22		class AmbassadorService implements EntityCreatorInterface
23		{
24
25		/** @var EntityManager */
26		private $entityManager;
27
28		/** @var BandService */
29		private $bandService;
30
31	12	public function __construct(EntityManager $entityManager, BandService $bandService)
		0 ignored issues – show Bug introduced 2016-09-15 23:08 UTC by Report Bug Copy Issue Report You have injected the EntityManager via parameter `$entityManager`. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via `getManager()` each time you need it. The `EntityManager` might become unusable for example if a transaction is rolled back and it gets closed. Let’s assume that somewhere in your application, or in a third-party library, there is code such as the following: function someFunction(ManagerRegistry $registry) { $em = $registry->getManager(); $em->getConnection()->beginTransaction(); try { // Do something. $em->getConnection()->commit(); } catch (\Exception $ex) { $em->getConnection()->rollback(); $em->close(); throw $ex; } } If that code throws an exception and the `EntityManager` is closed. Any other code which depends on the same instance of the `EntityManager` during this request will fail. On the other hand, if you instead inject the `ManagerRegistry`, the `getManager()` method guarantees that you will always get a usable manager instance. Loading history...
32		{
33	12	$this->entityManager = $entityManager;
34	12	$this->bandService = $bandService;
35	12	}
36
37	4	public function createEntityByFormData(AbstractFormType $formType, User $creator)
38		{
39	4	if ($formType instanceof AmbassadorFormType) {
40	2	$entity = $this->createAmbassador($formType, $creator);
41		} elseif ($formType instanceof AmbassadorMemberFormType) {
42	2	$entity = $this->createAmbassadorMember($formType);
43		} else {
44		throw new FormTypeNotSupported(get_class($formType));
45		}
46
47	4	$this->entityManager->flush($entity);
48
49	4	return $entity;
50		}
51
52	3	private function getOrCreateMemberByAmbassadorAndUserLogin(
53		Ambassador $ambassador,
54		$memberLogin,
55		$memberShortDescription = '',
56		$memberDescription = ''
57		) {
58	3	$user = $this->entityManager->getRepository(User::class)->findOneByLogin($memberLogin);
59		/** @var AmbassadorMemberRepository $repository */
60	3	$repository = $this->entityManager->getRepository($ambassador->getMemberClass());
61
62	3	return $repository->getOrCreateByAmbassadorAndUser(
63		$ambassador,
64		$user,
65		$memberShortDescription,
66		$memberDescription
67		);
68
69		}
70
71	2	private function createAmbassador(AmbassadorFormType $formType, User $creator)
72		{
73	2	$ambassadorName = $formType->name;
74	2	$ambassadorDescription = $formType->description;
75	2	$ambassadorMemberLogins = (array) $formType->members;
76
77		/** @var Ambassador $ambassador */
78	2	$entityClass = $formType->getEntityClassName();
79	2	$ambassador = new $entityClass($ambassadorName, $creator, $ambassadorDescription);
80		/** @var AmbassadorRepository $repository */
81	2	$repository = $this->entityManager->getRepository($entityClass);
82	2	$repository->persist($ambassador);
83
84	2	if ($ambassador instanceof Band) {
85	1	$ambassador->addMember($this->bandService->createBandMemberFromCreator($ambassador, $creator));
86
87	1	foreach ($ambassadorMemberLogins as $memberData) {
88	1	$memberLogin = $memberData['login'];
89	1	$memberShortDescription = $memberData['short_description'];
90	1	$memberDescription = $memberData['description'] ?? '';
91
92		/** @var BandMember $member */
93	1	$member = $this->getOrCreateMemberByAmbassadorAndUserLogin(
94		$ambassador,
95		$memberLogin,
96		$memberShortDescription,
97		$memberDescription
98		);
99
100	1	$ambassador->addMember($member);
101		}
102		}
103
104	2	return $ambassador;
105		}
106
107	2	private function createAmbassadorMember(AmbassadorMemberFormType $formType)
108		{
109	2	$ambassadorId = $formType->ambassador;
110		/** @var AmbassadorRepository $ambassadorRepository */
111	2	$ambassadorRepository = $this->entityManager->getRepository($formType->getEntityClassName());
112	2	$ambassador = $ambassadorRepository->findOneById($ambassadorId);
113
114	2	return $this->getOrCreateMemberByAmbassadorAndUserLogin(
115		$ambassador,
		0 ignored issues – show Documentation introduced 2016-09-19 01:30 UTC by Report Bug Copy Issue Report `$ambassador` is of type `object\|null`, but the function expects a `object<AppBundle\Entity\...rasctucture\Ambassador>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
116	2	$formType->login,
117	2	$formType->shortDescription,
118	2	$formType->description
119		);
120		}
121		}
122

VAPC / RockParade-API

Push — master ( 21a45d...334091 )

AmbassadorService::createEntityByFormData() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like