AppBundle\Service\Ambassador\AmbassadorService

Complexity

Total Complexity

9

Size/Duplication

Total Lines	100
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	9

Test Coverage

Coverage

95.12%

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	createEntityByFormData()	0	14	3
A	getOrCreateMemberByAmbassadorAndUserLogin()	0	18	1
B	createAmbassador()	0	35	3
A	createAmbassadorMember()	0	14	1

<?php

namespace AppBundle\Service\Ambassador;

use AppBundle\Entity\Band;
use AppBundle\Entity\BandMember;
use AppBundle\Entity\Infrasctucture\Ambassador;
use AppBundle\Entity\Infrasctucture\AmbassadorMemberRepository;
use AppBundle\Entity\Infrasctucture\AmbassadorRepository;
use AppBundle\Entity\User;
use AppBundle\Exception\FormTypeNotSupported;
use AppBundle\Form\AbstractFormType;
use AppBundle\Form\Ambassador\AmbassadorFormType;
use AppBundle\Form\Ambassador\AmbassadorMemberFormType;
use AppBundle\Service\Entity\BandService;
use AppBundle\Service\Entity\Infrastructure\EntityCreatorInterface;
use Doctrine\ORM\EntityManager;

/**
 * @author Vehsamrak
 */
class AmbassadorService implements EntityCreatorInterface
{

    /** @var EntityManager */
    private $entityManager;

    /** @var BandService */
    private $bandService;

    public function __construct(EntityManager $entityManager, BandService $bandService)

You have injected the EntityManager via parameter $entityManager. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via getManager() each time you need it.

    {
        $this->entityManager = $entityManager;
        $this->bandService = $bandService;
    }

    public function createEntityByFormData(AbstractFormType $formType, User $creator)
    {
        if ($formType instanceof AmbassadorFormType) {
            $entity = $this->createAmbassador($formType, $creator);
        } elseif ($formType instanceof AmbassadorMemberFormType) {
            $entity = $this->createAmbassadorMember($formType);
        } else {
            throw new FormTypeNotSupported(get_class($formType));
        }

        $this->entityManager->flush($entity);

        return $entity;
    }

    private function getOrCreateMemberByAmbassadorAndUserLogin(
        Ambassador $ambassador,
        $memberLogin,
        $memberShortDescription = '',
        $memberDescription = ''
    ) {
        $user = $this->entityManager->getRepository(User::class)->findOneByLogin($memberLogin);
        /** @var AmbassadorMemberRepository $repository */
        $repository = $this->entityManager->getRepository($ambassador->getMemberClass());

        return $repository->getOrCreateByAmbassadorAndUser(
            $ambassador,
            $user,
            $memberShortDescription,
            $memberDescription
        );

    }

    private function createAmbassador(AmbassadorFormType $formType, User $creator)
    {
        $ambassadorName = $formType->name;
        $ambassadorDescription = $formType->description;
        $ambassadorMemberLogins = (array) $formType->members;

        /** @var Ambassador $ambassador */
        $entityClass = $formType->getEntityClassName();
        $ambassador = new $entityClass($ambassadorName, $creator, $ambassadorDescription);
        /** @var AmbassadorRepository $repository */
        $repository = $this->entityManager->getRepository($entityClass);
        $repository->persist($ambassador);

        if ($ambassador instanceof Band) {
            $ambassador->addMember($this->bandService->createBandMemberFromCreator($ambassador, $creator));

            foreach ($ambassadorMemberLogins as $memberData) {
                $memberLogin = $memberData['login'];
                $memberShortDescription = $memberData['short_description'];
                $memberDescription = $memberData['description'] ?? '';

                /** @var BandMember $member */
                $member = $this->getOrCreateMemberByAmbassadorAndUserLogin(
                    $ambassador,
                    $memberLogin,
                    $memberShortDescription,
                    $memberDescription
                );

                $ambassador->addMember($member);
            }
        }

        return $ambassador;
    }

    private function createAmbassadorMember(AmbassadorMemberFormType $formType)
    {
        $ambassadorId = $formType->ambassador;
        /** @var AmbassadorRepository $ambassadorRepository */
        $ambassadorRepository = $this->entityManager->getRepository($formType->getEntityClassName());
        $ambassador = $ambassadorRepository->findOneById($ambassadorId);

        return $this->getOrCreateMemberByAmbassadorAndUserLogin(
            $ambassador,

$ambassador is of type object|null, but the function expects a object<AppBundle\Entity\Infrasctucture\Ambassador>.

            $formType->login,
            $formType->shortDescription,
            $formType->description
        );
    }
}