UniSharp\Uploadable\Uploader::upload()

Complexity

Conditions	3
Paths	4

Size

Total Lines	28
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	17
CRAP Score	3

Importance

Changes

0

<?php
    public static function upload($file): File

Expected 2 blank lines before function; 1 found

Missing function doc comment

    {

Opening brace should be on the same line as the declaration

        $name = $file->getClientOriginalName();
        $mime = $file->getMimeType();
        $size = $file->getSize();

        switch (true) {

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of true please use TRUE.

            case in_array($mime, static::IMAGE_MIME_TYPES):

Line indented incorrectly; expected 8 spaces, found 12

                $type = 'image';

Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space

                $class = Image::class;
                break;

Case breaking statement must be indented 4 spaces from SWITCH keyword

            default:

Line indented incorrectly; expected 8 spaces, found 12

                $type = 'file';

Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space

                $class = File::class;
                break;

Case breaking statement must be indented 4 spaces from SWITCH keyword

        }

        $path = $file->store(str_plural($type));

        foreach (Config::get("uploadable.plugins.{$type}", []) as $plugin) {

As per coding-style, please use concatenation or sprintf for the variable $type instead of interpolation.

Short array syntax is not allowed

            $storagePath = Storage::disk('local')->getDriver()->getAdapter()->getPathPrefix();
            $fullPath = $storagePath . DIRECTORY_SEPARATOR . $path;

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

Concat operator must not be surrounded by spaces

            (new $plugin)->handle($fullPath);
        }

        return $class::create(compact('name', 'mime', 'size', 'path'));
    }