UniSharp\Uploadable\Uploader

Complexity

Total Complexity

3

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	upload()	0	28	3

<?php

This file is missing a doc comment.

The PHP open tag does not have a corresponding PHP close tag

Filename "Uploader.php" doesn't match the expected filename "uploader.php"

Missing file doc comment

namespace UniSharp\Uploadable;

use UniSharp\Uploadable\File;
use UniSharp\Uploadable\Image;
use Illuminate\Support\Facades\Config;
use Illuminate\Support\Facades\Storage;

class Uploader

Missing class doc comment

{

Opening brace should be on the same line as the declaration for class Uploader

    const IMAGE_MIME_TYPES = [

Short array syntax is not allowed

        'image/gif',

This array value does not seem to be aligned correcty; expected 30 spaces, but found 8.

        'image/jpeg',

This array value does not seem to be aligned correcty; expected 30 spaces, but found 8.

        'image/jpg',

This array value does not seem to be aligned correcty; expected 30 spaces, but found 8.

        'image/png'

There should be a trailing comma after the last value of an array declaration.

    ];

The closing parenthesis does not seem to be aligned correctly; expected 29 space(s), but found 4.

    public static function upload($file): File

Expected 2 blank lines before function; 1 found

Missing function doc comment

    {

Opening brace should be on the same line as the declaration

        $name = $file->getClientOriginalName();
        $mime = $file->getMimeType();
        $size = $file->getSize();

        switch (true) {

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of true please use TRUE.

            case in_array($mime, static::IMAGE_MIME_TYPES):

Line indented incorrectly; expected 8 spaces, found 12

                $type = 'image';

Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space

                $class = Image::class;
                break;

Case breaking statement must be indented 4 spaces from SWITCH keyword

            default:

Line indented incorrectly; expected 8 spaces, found 12

                $type = 'file';

Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space

                $class = File::class;
                break;

Case breaking statement must be indented 4 spaces from SWITCH keyword

        }

        $path = $file->store(str_plural($type));

        foreach (Config::get("uploadable.plugins.{$type}", []) as $plugin) {

As per coding-style, please use concatenation or sprintf for the variable $type instead of interpolation.

Short array syntax is not allowed

            $storagePath = Storage::disk('local')->getDriver()->getAdapter()->getPathPrefix();
            $fullPath = $storagePath . DIRECTORY_SEPARATOR . $path;

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

Concat operator must not be surrounded by spaces

            (new $plugin)->handle($fullPath);
        }

        return $class::create(compact('name', 'mime', 'size', 'path'));
    }

Expected 2 blank lines after function; 0 found

Expected 1 blank line before closing function brace; 0 found

Expected //end upload()

}

Expected //end class

As per coding style, files should not end with a newline character.