UFSC / moodle-local-relationship

lib.php

Spacing +1 added lines, -1 removed lines

@@ -329,7 +329,7 @@
 
         $cohorts = $DB->get_records('relationship_cohorts', array('relationshipid' => $relationship->id));
 
-        if(count($cohorts) == 0) {
+        if (count($cohorts) == 0) {
             $DB->delete_records('relationship_cohorts', array('relationshipid' => $relationship->id));
 
             $tags = tag_get_tags_array('relationship', $relationship->id);

edit.php

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
 
 if (optional_param('confirmdelete', 0, PARAM_BOOL) && confirm_sesskey() && $relationship->id) {
     $res = relationship_delete_relationship($relationship);
-    if($res == -1) {
+    if ($res == -1) {
         print_error('has_cohorts', 'local_relationship');
     }
     redirect($returnurl);

locallib.php

Indentation +1 added lines, -1 removed lines

@@ -45,7 +45,7 @@
     $PAGE->navbar->add($navtitle, new moodle_url('/local/relationship/index.php', array('contextid'=>$context->id)));
     if($module) {
         $PAGE->navbar->add(get_string($module, 'local_relationship'),
-                           new moodle_url("/local/relationship/{$module}.php", array('relationshipid'=>$relationship->id)));
+                            new moodle_url("/local/relationship/{$module}.php", array('relationshipid'=>$relationship->id)));
     }
 }
 

Spacing +20 added lines, -20 removed lines

@@ -23,10 +23,10 @@ 
 
 defined('MOODLE_INTERNAL') || die();
 
-require_once($CFG->dirroot . '/user/selector/lib.php');
-require_once($CFG->dirroot . '/tag/lib.php');
+require_once($CFG->dirroot.'/user/selector/lib.php');
+require_once($CFG->dirroot.'/tag/lib.php');
 
-function relationship_set_header($context, $url, $relationship=null, $module=null) {
+function relationship_set_header($context, $url, $relationship = null, $module = null) {
     global $PAGE, $COURSE, $DB;
 
     if ($context->contextlevel != CONTEXT_COURSECAT) {
@@ -43,27 +43,27 @@ 
 
     $PAGE->navbar->add($category->name, new moodle_url('/course/index.php', array('categoryid'=>$category->id)));
     $PAGE->navbar->add($navtitle, new moodle_url('/local/relationship/index.php', array('contextid'=>$context->id)));
-    if($module) {
+    if ($module) {
         $PAGE->navbar->add(get_string($module, 'local_relationship'),
                            new moodle_url("/local/relationship/{$module}.php", array('relationshipid'=>$relationship->id)));
     }
 }
 
-function relationship_set_title($relationship=null, $action=null, $param=null) {
+function relationship_set_title($relationship = null, $action = null, $param = null) {
     global $OUTPUT;
 
     echo $OUTPUT->header();
-    if($relationship) {
-        echo $OUTPUT->heading(get_string('relationship', 'local_relationship') . ': ' . format_string($relationship->name));
+    if ($relationship) {
+        echo $OUTPUT->heading(get_string('relationship', 'local_relationship').': '.format_string($relationship->name));
         echo html_writer::empty_tag('BR');
     }
-    if($action) {
+    if ($action) {
         echo $OUTPUT->heading(get_string($action, 'local_relationship', $param), '4');
     }
 }
 
-function relationship_groups_parse_name($format, $value, $value_is_a_name=false) {
-    if($value_is_a_name) {
+function relationship_groups_parse_name($format, $value, $value_is_a_name = false) {
+    if ($value_is_a_name) {
         if (strstr($format, '@') !== false) {
             $str = str_replace('@', $value, $format);
         } else {
@@ -72,7 +72,7 @@ 
     } else {
         if (strstr($format, '@') !== false) { // Convert $value to a character series
             $letter = 'A';
-            for($i=0; $i<$value; $i++) {
+            for ($i = 0; $i < $value; $i++) {
                 $letter++;
             }
             $str = str_replace('@', $letter, $format);
@@ -87,8 +87,8 @@ 
     $all_roles = role_get_names();
     $ctx_roles = get_roles_for_contextlevels(CONTEXT_COURSE);
     $roles = array();
-    foreach($ctx_roles AS $id=>$roleid) {
-        if($roleid > 2) {
+    foreach ($ctx_roles AS $id=>$roleid) {
+        if ($roleid > 2) {
             $roles[$roleid] = $all_roles[$roleid]->localname;
         }
     }
@@ -103,7 +103,7 @@ 
     $context = context::instance_by_id($relationship->contextid);
 
     $contextids = array();
-    foreach($context->get_parent_context_ids(true) as $ctxid) {
+    foreach ($context->get_parent_context_ids(true) as $ctxid) {
         $context = context::instance_by_id($ctxid);
         if (has_capability('moodle/cohort:view', $context)) {
             $contextids[] = $ctxid;
@@ -139,7 +139,7 @@ 
                AND g.idnumber NOT LIKE 'relationship_{$relationshipid}_%'
           ORDER BY g.name";
     $groups = array();
-    foreach($DB->get_records_sql($sql, array('relationshipid'=>$relationshipid)) as $r) {
+    foreach ($DB->get_records_sql($sql, array('relationshipid'=>$relationshipid)) as $r) {
         $groups[$r->name][] = $r;
     }
     return $groups;
@@ -206,12 +206,12 @@ 
 
     if (!empty($search)) {
         $conditions = array('name', 'idnumber', 'description');
-        $searchparam = '%' . $DB->sql_like_escape($search) . '%';
+        $searchparam = '%'.$DB->sql_like_escape($search).'%';
         foreach ($conditions as $key=>$condition) {
             $conditions[$key] = $DB->sql_like($condition, "?", false);
             $params[] = $searchparam;
         }
-        $tests[] = '(' . implode(' OR ', $conditions) . ')';
+        $tests[] = '('.implode(' OR ', $conditions).')';
     }
     $wherecondition = implode(' AND ', $tests);
 
@@ -221,9 +221,9 @@ 
              WHERE $wherecondition";
     $order = " ORDER BY name ASC";
     $allrelationships = $DB->count_records('relationship', array('contextid'=>$contextid));
-    $totalrelationships = $DB->count_records_sql($countfields . $sql, $params);
-    $relationships = $DB->get_records_sql($fields . $sql . $order, $params, $page*$perpage, $perpage);
-    foreach($relationships as $rl) {
+    $totalrelationships = $DB->count_records_sql($countfields.$sql, $params);
+    $relationships = $DB->get_records_sql($fields.$sql.$order, $params, $page*$perpage, $perpage);
+    foreach ($relationships as $rl) {
         $rl->tags = tag_get_tags_array('relationship', $rl->id);
     }
 

classes/candidate_selector.php

Spacing +9 added lines, -9 removed lines

@@ -38,9 +38,9 @@ 
 
         list($usercondition, $params) = users_search_sql($search, 'u', $this->searchanywhere);
 
-        if(!empty($this->validatinguserids)) {
+        if (!empty($this->validatinguserids)) {
             list($usertest, $userparams) = $DB->get_in_or_equal($this->validatinguserids, SQL_PARAMS_NAMED, 'val');
-            $usercondition .= " AND u.id*1000000+rc.id " . $usertest;
+            $usercondition .= " AND u.id*1000000+rc.id ".$usertest;
             $params = array_merge($params, $userparams);
         }
 
@@ -66,10 +66,10 @@ 
                        OR (rc.allowdupsingroups = 0 AND rm.id IS NULL))
                   AND {$usercondition}";
 
-        $orderby= "ORDER BY roleid, in_group, fullname";
+        $orderby = "ORDER BY roleid, in_group, fullname";
 
         if (!$this->is_validating()) {
-            $sql = $countfields . "\n" . $from;
+            $sql = $countfields."\n".$from;
             $count = $DB->count_records_sql($sql, $params);
             if ($count > $this->maxusersperpage) {
                 return $this->too_many_results($search, $count);
@@ -78,19 +78,19 @@ 
             }
         }
 
-        $sql = $selectfields . "\n" . $from .  "\n" . $orderby;
+        $sql = $selectfields."\n".$from."\n".$orderby;
 
         $users = array();
         $roleid = -1;
         $in_group = -1;
         $index = false;
-        foreach($DB->get_recordset_sql($sql, $params) AS $cand) {
-            if($cand->roleid != $roleid || $cand->in_group != $in_group) {
+        foreach ($DB->get_recordset_sql($sql, $params) AS $cand) {
+            if ($cand->roleid != $roleid || $cand->in_group != $in_group) {
                 $role = $DB->get_record('role', array('id'=>$cand->roleid), '*', MUST_EXIST);
                 $role_name = role_get_name($role);
 
-                $str_alloc = $cand->in_group == 1  ? get_string('allocated', 'local_relationship') : get_string('notallocated', 'local_relationship');
-                $index = $role_name . $str_alloc;
+                $str_alloc = $cand->in_group == 1 ? get_string('allocated', 'local_relationship') : get_string('notallocated', 'local_relationship');
+                $index = $role_name.$str_alloc;
                 $users[$index] = array();
 
                 $roleid = $cand->roleid;

classes/form/edit_cohort.php

Spacing +3 added lines, -3 removed lines

@@ -35,19 +35,19 @@
 
         $cohorts = relationship_get_cohort_options($relationshipcohort->relationshipid);
         $relationshipcohorts = relationship_get_cohorts($relationshipcohort->relationshipid);
-        foreach($relationshipcohorts AS $rc) {
+        foreach ($relationshipcohorts AS $rc) {
             unset($cohorts[$rc->cohortid]);
         }
 
         $mform->addElement('select', 'cohortid', get_string('cohort', 'cohort'), $cohorts);
 
         $roles = relationship_get_role_options();
-        foreach($relationshipcohorts AS $rc) {
+        foreach ($relationshipcohorts AS $rc) {
             unset($roles[$rc->roleid]);
         }
         $mform->addElement('select', 'roleid', get_string('role'), $roles);
 
-        if($relationshipcohort->id) {
+        if ($relationshipcohort->id) {
             $mform->freeze('roleid');
             $mform->freeze('cohortid');
         }

classes/form/autogroup.php

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
     function definition() {
         global $DB;
 
-        $mform =& $this->_form;
+        $mform = & $this->_form;
 
         $relationshipid = $this->_customdata['relationshipid'];
 

classes/existing_selector.php

Spacing +7 added lines, -7 removed lines

@@ -44,9 +44,9 @@ 
 
         list($usercondition, $params) = users_search_sql($search, 'u', $this->searchanywhere);
 
-        if(!empty($this->validatinguserids)) {
+        if (!empty($this->validatinguserids)) {
             list($usertest, $userparams) = $DB->get_in_or_equal($this->validatinguserids, SQL_PARAMS_NAMED, 'val');
-            $usercondition .= " AND u.id*1000000+rc.id " . $usertest;
+            $usercondition .= " AND u.id*1000000+rc.id ".$usertest;
             $params = array_merge($params, $userparams);
         }
 
@@ -61,10 +61,10 @@ 
                 WHERE rm.relationshipgroupid = :relationshipgroupid
                   AND {$usercondition}";
 
-        $orderby= "ORDER BY roleid, fullname";
+        $orderby = "ORDER BY roleid, fullname";
 
         if (!$this->is_validating()) {
-            $sql = $countfields . "\n" . $from;
+            $sql = $countfields."\n".$from;
             $count = $DB->count_records_sql($sql, $params);
             if ($count > $this->maxusersperpage) {
                 return $this->too_many_results($search, $count);
@@ -73,13 +73,13 @@ 
             }
         }
 
-        $sql = $selectfields . "\n" . $from .  "\n" . $orderby;
+        $sql = $selectfields."\n".$from."\n".$orderby;
 
         $users = array();
         $roleid = -1;
         $index = false;
-        foreach($DB->get_recordset_sql($sql, $params) AS $cand) {
-            if($cand->roleid != $roleid) {
+        foreach ($DB->get_recordset_sql($sql, $params) AS $cand) {
+            if ($cand->roleid != $roleid) {
                 $role = $DB->get_record('role', array('id'=>$cand->roleid), '*', MUST_EXIST);
                 $index = role_get_name($role);
                 $users[$index] = array();