UFSC / moodle-local-relationship

lib.php

Spacing +1 added lines, -1 removed lines

@@ -329,7 +329,7 @@
 
         $cohorts = $DB->get_records('relationship_cohorts', array('relationshipid' => $relationship->id));
 
-        if(count($cohorts) == 0) {
+        if (count($cohorts) == 0) {
             $DB->delete_records('relationship_cohorts', array('relationshipid' => $relationship->id));
 
             $tags = tag_get_tags_array('relationship', $relationship->id);

Doc Comments +1 added lines, -1 removed lines

@@ -284,7 +284,7 @@
  * Update existing relationship
  *
  * @param sstdClass $relationship
- * @return void
+ * @return boolean
  */
 function relationship_update_relationship($relationship) {
     global $DB;

locallib.php

Indentation +1 added lines, -1 removed lines

@@ -45,7 +45,7 @@
     $PAGE->navbar->add($navtitle, new moodle_url('/local/relationship/index.php', array('contextid'=>$context->id)));
     if($module) {
         $PAGE->navbar->add(get_string($module, 'local_relationship'),
-                           new moodle_url("/local/relationship/{$module}.php", array('relationshipid'=>$relationship->id)));
+                            new moodle_url("/local/relationship/{$module}.php", array('relationshipid'=>$relationship->id)));
     }
 }
 

Spacing +13 added lines, -13 removed lines

@@ -26,7 +26,7 @@ 
 require_once($CFG->dirroot . '/user/selector/lib.php');
 require_once($CFG->dirroot . '/tag/lib.php');
 
-function relationship_set_header($context, $url, $relationship=null, $module=null) {
+function relationship_set_header($context, $url, $relationship = null, $module = null) {
     global $PAGE, $COURSE, $DB;
 
     if ($context->contextlevel != CONTEXT_COURSECAT) {
@@ -43,27 +43,27 @@ 
 
     $PAGE->navbar->add($category->name, new moodle_url('/course/index.php', array('categoryid'=>$category->id)));
     $PAGE->navbar->add($navtitle, new moodle_url('/local/relationship/index.php', array('contextid'=>$context->id)));
-    if($module) {
+    if ($module) {
         $PAGE->navbar->add(get_string($module, 'local_relationship'),
                            new moodle_url("/local/relationship/{$module}.php", array('relationshipid'=>$relationship->id)));
     }
 }
 
-function relationship_set_title($relationship=null, $action=null, $param=null) {
+function relationship_set_title($relationship = null, $action = null, $param = null) {
     global $OUTPUT;
 
     echo $OUTPUT->header();
-    if($relationship) {
+    if ($relationship) {
         echo $OUTPUT->heading(get_string('relationship', 'local_relationship') . ': ' . format_string($relationship->name));
         echo html_writer::empty_tag('BR');
     }
-    if($action) {
+    if ($action) {
         echo $OUTPUT->heading(get_string($action, 'local_relationship', $param), '4');
     }
 }
 
-function relationship_groups_parse_name($format, $value, $value_is_a_name=false) {
-    if($value_is_a_name) {
+function relationship_groups_parse_name($format, $value, $value_is_a_name = false) {
+    if ($value_is_a_name) {
         if (strstr($format, '@') !== false) {
             $str = str_replace('@', $value, $format);
         } else {
@@ -72,7 +72,7 @@ 
     } else {
         if (strstr($format, '@') !== false) { // Convert $value to a character series
             $letter = 'A';
-            for($i=0; $i<$value; $i++) {
+            for ($i = 0; $i < $value; $i++) {
                 $letter++;
             }
             $str = str_replace('@', $letter, $format);
@@ -87,8 +87,8 @@ 
     $all_roles = role_get_names();
     $ctx_roles = get_roles_for_contextlevels(CONTEXT_COURSE);
     $roles = array();
-    foreach($ctx_roles AS $id=>$roleid) {
-        if($roleid > 2) {
+    foreach ($ctx_roles AS $id=>$roleid) {
+        if ($roleid > 2) {
             $roles[$roleid] = $all_roles[$roleid]->localname;
         }
     }
@@ -103,7 +103,7 @@ 
     $context = context::instance_by_id($relationship->contextid);
 
     $contextids = array();
-    foreach($context->get_parent_context_ids(true) as $ctxid) {
+    foreach ($context->get_parent_context_ids(true) as $ctxid) {
         $context = context::instance_by_id($ctxid);
         if (has_capability('moodle/cohort:view', $context)) {
             $contextids[] = $ctxid;
@@ -139,7 +139,7 @@ 
                AND g.idnumber NOT LIKE 'relationship_{$relationshipid}_%'
           ORDER BY g.name";
     $groups = array();
-    foreach($DB->get_records_sql($sql, array('relationshipid'=>$relationshipid)) as $r) {
+    foreach ($DB->get_records_sql($sql, array('relationshipid'=>$relationshipid)) as $r) {
         $groups[$r->name][] = $r;
     }
     return $groups;
@@ -223,7 +223,7 @@ 
     $allrelationships = $DB->count_records('relationship', array('contextid'=>$contextid));
     $totalrelationships = $DB->count_records_sql($countfields . $sql, $params);
     $relationships = $DB->get_records_sql($fields . $sql . $order, $params, $page*$perpage, $perpage);
-    foreach($relationships as $rl) {
+    foreach ($relationships as $rl) {
         $rl->tags = tag_get_tags_array('relationship', $rl->id);
     }
 

edit.php

Spacing +5 added lines, -5 removed lines

@@ -21,10 +21,10 @@ 
  * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-require_once(__DIR__.'/../../config.php');
-require_once($CFG->libdir.'/filelib.php');
-require($CFG->dirroot.'/local/relationship/lib.php');
-require_once($CFG->dirroot.'/local/relationship/locallib.php');
+require_once(__DIR__ . '/../../config.php');
+require_once($CFG->libdir . '/filelib.php');
+require($CFG->dirroot . '/local/relationship/lib.php');
+require_once($CFG->dirroot . '/local/relationship/locallib.php');
 
 require_login();
 
@@ -53,7 +53,7 @@ 
 
 if (optional_param('confirmdelete', 0, PARAM_BOOL) && confirm_sesskey() && $relationship->id) {
     $res = relationship_delete_relationship($relationship);
-    if($res == -1) {
+    if ($res == -1) {
         print_error('has_cohorts', 'local_relationship');
     }
     redirect($returnurl);

cohorts.php

Spacing +5 added lines, -5 removed lines

@@ -21,9 +21,9 @@ 
  * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-require_once(__DIR__.'/../../config.php');
-require($CFG->dirroot.'/local/relationship/lib.php');
-require_once($CFG->dirroot.'/local/relationship/locallib.php');
+require_once(__DIR__ . '/../../config.php');
+require($CFG->dirroot . '/local/relationship/lib.php');
+require_once($CFG->dirroot . '/local/relationship/locallib.php');
 
 require_login();
 
@@ -68,8 +68,8 @@ 
         get_string('cohort', 'cohort'),
         get_string('size'),
         get_string('role'),
-        get_string('allowdupsingroups', 'local_relationship').$OUTPUT->help_icon('allowdupsingroups', 'local_relationship'),
-        get_string('uniformdistribute', 'local_relationship').$OUTPUT->help_icon('uniformdistribute', 'local_relationship'),
+        get_string('allowdupsingroups', 'local_relationship') . $OUTPUT->help_icon('allowdupsingroups', 'local_relationship'),
+        get_string('uniformdistribute', 'local_relationship') . $OUTPUT->help_icon('uniformdistribute', 'local_relationship'),
         get_string('edit')
 );
 $table->colclasses = array(

edit_group.php

Spacing +4 added lines, -4 removed lines

@@ -21,10 +21,10 @@
  * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-require_once(__DIR__.'/../../config.php');
-require_once($CFG->dirroot.'/course/lib.php');
-require($CFG->dirroot.'/local/relationship/lib.php');
-require_once($CFG->dirroot.'/local/relationship/locallib.php');
+require_once(__DIR__ . '/../../config.php');
+require_once($CFG->dirroot . '/course/lib.php');
+require($CFG->dirroot . '/local/relationship/lib.php');
+require_once($CFG->dirroot . '/local/relationship/locallib.php');
 
 require_login();
 

classes/existing_selector.php

Spacing +5 added lines, -5 removed lines

@@ -44,7 +44,7 @@ 
 
         list($usercondition, $params) = users_search_sql($search, 'u', $this->searchanywhere);
 
-        if(!empty($this->validatinguserids)) {
+        if (!empty($this->validatinguserids)) {
             list($usertest, $userparams) = $DB->get_in_or_equal($this->validatinguserids, SQL_PARAMS_NAMED, 'val');
             $usercondition .= " AND u.id*1000000+rc.id " . $usertest;
             $params = array_merge($params, $userparams);
@@ -61,7 +61,7 @@ 
                 WHERE rm.relationshipgroupid = :relationshipgroupid
                   AND {$usercondition}";
 
-        $orderby= "ORDER BY roleid, fullname";
+        $orderby = "ORDER BY roleid, fullname";
 
         if (!$this->is_validating()) {
             $sql = $countfields . "\n" . $from;
@@ -73,13 +73,13 @@ 
             }
         }
 
-        $sql = $selectfields . "\n" . $from .  "\n" . $orderby;
+        $sql = $selectfields . "\n" . $from . "\n" . $orderby;
 
         $users = array();
         $roleid = -1;
         $index = false;
-        foreach($DB->get_recordset_sql($sql, $params) AS $cand) {
-            if($cand->roleid != $roleid) {
+        foreach ($DB->get_recordset_sql($sql, $params) AS $cand) {
+            if ($cand->roleid != $roleid) {
                 $role = $DB->get_record('role', array('id'=>$cand->roleid), '*', MUST_EXIST);
                 $index = role_get_name($role);
                 $users[$index] = array();

classes/observer.php

Spacing +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-require_once($CFG->dirroot.'/local/relationship/lib.php');
+require_once($CFG->dirroot . '/local/relationship/lib.php');
 
 /**
  * Event handler for relationship local plugin.

classes/form/autogroup.php

Spacing +2 added lines, -2 removed lines

@@ -24,7 +24,7 @@ 
 namespace local_relationship\form;
 defined('MOODLE_INTERNAL') || die();
 
-require_once($CFG->dirroot.'/lib/formslib.php');
+require_once($CFG->dirroot . '/lib/formslib.php');
 
 /**
  * Auto group form class
@@ -40,7 +40,7 @@ 
     function definition() {
         global $DB;
 
-        $mform =& $this->_form;
+        $mform = & $this->_form;
 
         $relationshipid = $this->_customdata['relationshipid'];
 

classes/form/edit_cohort.php

Spacing +4 added lines, -4 removed lines

@@ -24,7 +24,7 @@ 
 namespace local_relationship\form;
 defined('MOODLE_INTERNAL') || die();
 
-require_once($CFG->dirroot.'/lib/formslib.php');
+require_once($CFG->dirroot . '/lib/formslib.php');
 
 class edit_cohort extends \moodleform {
 
@@ -35,19 +35,19 @@ 
 
         $cohorts = relationship_get_cohort_options($relationshipcohort->relationshipid);
         $relationshipcohorts = relationship_get_cohorts($relationshipcohort->relationshipid);
-        foreach($relationshipcohorts AS $rc) {
+        foreach ($relationshipcohorts AS $rc) {
             unset($cohorts[$rc->cohortid]);
         }
 
         $mform->addElement('select', 'cohortid', get_string('cohort', 'cohort'), $cohorts);
 
         $roles = relationship_get_role_options();
-        foreach($relationshipcohorts AS $rc) {
+        foreach ($relationshipcohorts AS $rc) {
             unset($roles[$rc->roleid]);
         }
         $mform->addElement('select', 'roleid', get_string('role'), $roles);
 
-        if($relationshipcohort->id) {
+        if ($relationshipcohort->id) {
             $mform->freeze('roleid');
             $mform->freeze('cohortid');
         }