UB-Mannheim / PalMA

download.php

Indentation +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
     // file exists: return file for download
     header('Content-Type: application/octet-stream');
     header('Content-Disposition: attachment; filename="' .
-           addslashes($filename) . '"');
+            addslashes($filename) . '"');
     readfile($filepath);
 } else {
     // file does not exist: 404 Not Found

DBConnector.class.php

Spacing +8 added lines, -8 removed lines

@@ -116,7 +116,7 @@ 
         if (count($next_ids) > 0) {
             $next = $next_ids[0];
         } else {
-            $next = $this->querySingle('SELECT MAX(id) FROM window') + 1;
+            $next = $this->querySingle('SELECT MAX(id) FROM window')+1;
         }
         return $next;
     }
@@ -140,7 +140,7 @@ 
         // TODO: Support more than one address for a given username.
         $this->exec("INSERT OR IGNORE INTO user VALUES (NULL, '$username', 1, 0)");
         $usercount = $this->querySingle("SELECT COUNT(*) FROM user");
-        $userid = $this->querySingle("SELECT userid from user where name='".$username."'");
+        $userid = $this->querySingle("SELECT userid from user where name='" . $username . "'");
         $this->exec("INSERT INTO address VALUES ('$userid', '$address', '$device')");
         trace("user $username connected with $device, $usercount user(s) now connected");
         if ($usercount == 1) {
@@ -235,13 +235,13 @@ 
 
     public function getWindowState($window_id)
     {
-        $state = @$this->querySingle('SELECT state FROM window WHERE win_id="'.$window_id.'"');
+        $state = @$this->querySingle('SELECT state FROM window WHERE win_id="' . $window_id . '"');
         return $state;
     }
 
     public function setWindowState($window_id, $state)
     {
-        $this->exec('UPDATE window SET state="'.$state.'" WHERE win_id="'.$window_id.'"');
+        $this->exec('UPDATE window SET state="' . $state . '" WHERE win_id="' . $window_id . '"');
     }
 
     public function insertWindow($window)
@@ -259,12 +259,12 @@ 
 
     public function deleteWindow($window_id)
     {
-        $this->exec('DELETE FROM window WHERE win_id="'.$window_id.'"');
+        $this->exec('DELETE FROM window WHERE win_id="' . $window_id . '"');
     }
 
     public function deleteVNCWindow($userid)
     {
-        $winid = $this->querySingle('SELECT win_id FROM window WHERE handler="vnc" AND userid="'.$userid.'"');
+        $winid = $this->querySingle('SELECT win_id FROM window WHERE handler="vnc" AND userid="' . $userid . '"');
         require_once('control.php');
         wmClose($winid);
         $this->deleteWindow($winid);
@@ -273,12 +273,12 @@ 
 
     public function deleteDebug($table, $id, $gt)
     {
-        $this->exec('DELETE FROM '.$table.' WHERE '.$id.' >"'.$gt.'"');
+        $this->exec('DELETE FROM ' . $table . ' WHERE ' . $id . ' >"' . $gt . '"');
     }
 
     public function updateWindow($window_id, $field, $value)
     {
-        $this->exec('UPDATE window SET '.$field.'="'.$value.'" WHERE win_id="'.$window_id.'"');
+        $this->exec('UPDATE window SET ' . $field . '="' . $value . '" WHERE win_id="' . $window_id . '"');
     }
 }
 

upload.php

Indentation +4 added lines, -4 removed lines

@@ -111,10 +111,10 @@
 $curl = curl_init();
 // Set some options - we are passing in a useragent too here
 curl_setopt_array($curl, array(
-                      CURLOPT_RETURNTRANSFER => 1,
-                      CURLOPT_URL => CONFIG_CONTROL_FILE . '?newWindow=' . $sw,
-                      CURLOPT_USERAGENT => 'PalMA cURL Request'
-                               ));
+                        CURLOPT_RETURNTRANSFER => 1,
+                        CURLOPT_URL => CONFIG_CONTROL_FILE . '?newWindow=' . $sw,
+                        CURLOPT_USERAGENT => 'PalMA cURL Request'
+                                ));
 // Send the request & save response to $resp
 $resp = curl_exec($curl);
 // Close request to clear up some resources

Switch Indentation +12 added lines, -12 removed lines

@@ -54,18 +54,18 @@
     $f = fopen($targetFile, 'w');
     if ($f) {
         switch ($error) {
-            case UPLOAD_ERR_INI_SIZE:
-                $message = addslashes(__("This file is too large."));
-                break;
-            case UPLOAD_ERR_FORM_SIZE:
-                $message = addslashes(__("Large files are not supported."));
-                break;
-            case UPLOAD_ERR_PARTIAL:
-                $message = addslashes(__("File was only partially uploaded."));
-                break;
-            default:
-                $message = sprintf(addslashes(__("Error code %s.")), $error);
-                break;
+        case UPLOAD_ERR_INI_SIZE:
+            $message = addslashes(__("This file is too large."));
+            break;
+        case UPLOAD_ERR_FORM_SIZE:
+            $message = addslashes(__("Large files are not supported."));
+            break;
+        case UPLOAD_ERR_PARTIAL:
+            $message = addslashes(__("File was only partially uploaded."));
+            break;
+        default:
+            $message = sprintf(addslashes(__("Error code %s.")), $error);
+            break;
         }
         fprintf($f, "<!DOCTYPE HTML PUBLIC \"-//W3C//DTD HTML 4.01//EN\"");
         fprintf($f, "\"http://www.w3.org/TR/html4/strict.dtd\">");

db.php

Spacing +2 added lines, -2 removed lines

@@ -21,7 +21,7 @@ 
 if (!empty($_REQUEST['json'])) {
     $oldJSON = $_REQUEST['json'];
     $oldJSONarr = json_decode($oldJSON, true);
-    array_walk_recursive($oldJSONarr, function (&$value, $key) {
+    array_walk_recursive($oldJSONarr, function(&$value, $key) {
         if (is_string($value) && preg_match('/^http/', $value)) {
             $value = rawurlencode($value);
         }
@@ -72,7 +72,7 @@ 
     $database['window'] = $data;
 
     //~ $newJSON = json_encode($database, JSON_PRETTY_PRINT);
-    array_walk_recursive($database, function (&$value, $key) {
+    array_walk_recursive($database, function(&$value, $key) {
         if (is_string($value) && preg_match('/^http/', $value)) {
             $value = rawurlencode($value);
         }

SSVNCDaemon.php

Spacing +20 added lines, -20 removed lines

@@ -72,18 +72,18 @@ 
             $hostname = $this->parseHostname($buffer);
             $exit = $this->parseExit($buffer);
 
-            if ($ip!="") {
+            if ($ip != "") {
                 $client["ip"] = $ip;
             }
-            if ($hostname!="") {
+            if ($hostname != "") {
                 $client["hostname"] = $hostname;
             }
-            if ($exit!=0) {
+            if ($exit != 0) {
                 $client["exit"] = $exit;
             }
 
             if (strstr($buffer, 'create_image') && $client["ip"] != "" &&
-            $client["hostname"]!="" ) {
+            $client["hostname"] != "") {
                 // add client
                 $this->addClient($client["ip"], $client["hostname"]);
 
@@ -100,7 +100,7 @@ 
                 }
             }
 
-            $halt=$this->CONNECTIONS;
+            $halt = $this->CONNECTIONS;
 
             if ($halt == -1) {
                 exit(0);
@@ -117,13 +117,13 @@ 
         $ip = "";
         $line = $buffer;
         if (strpos($line, "Reverse VNC connection from IP")) {
-            $line=trim($line);
-            $item=explode(":", $line);
-            $ip=trim($item[1]);
-            $ip=preg_replace('/\W\W\d{4}\/\d{2}\/\d{2} \d{2}/', '', $ip);
+            $line = trim($line);
+            $item = explode(":", $line);
+            $ip = trim($item[1]);
+            $ip = preg_replace('/\W\W\d{4}\/\d{2}\/\d{2} \d{2}/', '', $ip);
         }
 
-        if ($ip!="") {
+        if ($ip != "") {
             print("\nFOUND IP: " . $ip . "\n");
         }
 
@@ -135,13 +135,13 @@ 
         $hostname = "";
         $line = $buffer;
         if (strpos($line, "Hostname")) {
-            $line=trim($line);
-            $item=explode(":", $line);
-            $hostname=trim($item[1]);
-            $hostname=preg_replace('/\.uni\-mannheim\.de/', '', $hostname);
+            $line = trim($line);
+            $item = explode(":", $line);
+            $hostname = trim($item[1]);
+            $hostname = preg_replace('/\.uni\-mannheim\.de/', '', $hostname);
         }
 
-        if ($hostname!="") {
+        if ($hostname != "") {
             print("\nFOUND HOSTNAME: " . $hostname . "\n");
         }
 
@@ -155,7 +155,7 @@ 
             $exit = 1;
         }
 
-        if ($exit!=0) {
+        if ($exit != 0) {
             print("\nCLIENT HAS DISCONNECTED " . $exit . "\n");
         }
 
@@ -171,9 +171,9 @@ 
                         "exit" => 0
                         );
         if (count($this->VNC_CLIENTS) == 0) {
-            $id=1;
+            $id = 1;
         } else {
-            $id=count($this->VNC_CLIENTS) + 1;
+            $id = count($this->VNC_CLIENTS)+1;
         }
 
         $this->VNC_CLIENTS[$id] = $vncclient;
@@ -187,7 +187,7 @@ 
 
         $this->CONNECTIONS++;
 
-        print("\n active connections: ".$this->CONNECTIONS+1);
+        print("\n active connections: " . $this->CONNECTIONS+1);
         print("\n all saved clients: " . serialize($this->VNC_CLIENTS));
     }
 
@@ -295,7 +295,7 @@ 
 
         foreach ($inactive_vnc_window_ids as $inactive_win_id) {
             // define vnc-id
-            $inactive_vnc_id = $db->querySingle("SELECT file FROM window WHERE win_id='".$inactive_win_id."'");
+            $inactive_vnc_id = $db->querySingle("SELECT file FROM window WHERE win_id='" . $inactive_win_id . "'");
 
             // delete from database (send to control.php)
             $curl = curl_init();

login.php

Indentation +1 added lines, -1 removed lines

@@ -148,7 +148,7 @@
         $_SESSION['monitor'] = CONFIG_STATIONNAME;
         $dbcon->addUser($username, $dbcon->ipAddress(), getDevice());
 
-       // Weiterleitung zur geschützten Startseite
+        // Weiterleitung zur geschützten Startseite
         if ($_SERVER['SERVER_PROTOCOL'] == 'HTTP/1.1') {
             if (php_sapi_name() == 'cgi') {
                 header('Status: 303 See Other');

globals.php

Indentation +3 added lines, -3 removed lines

@@ -13,10 +13,10 @@ 
 function monitor($action)
 {
     if (!defined('CONFIG_MONITOR_URL')) {
-      //trace('CONFIG_MONITOR_URL is undefined');
+        //trace('CONFIG_MONITOR_URL is undefined');
         return;
     }
-  //trace("monitor $action");
+    //trace("monitor $action");
     $ch = curl_init();
     $url = CONFIG_MONITOR_URL;
   
@@ -24,7 +24,7 @@ 
                         CURLOPT_RETURNTRANSFER => 1,
                         CURLOPT_URL => CONFIG_MONITOR_URL . '/' . CONFIG_STATIONNAME . '/' . base64_encode($action),
                         CURLOPT_USERAGENT => 'PalMA cURL Request'
-                               ));
+                                ));
     $resp = curl_exec($ch);
     curl_close($ch);
 }

index.php

Indentation +3 added lines, -3 removed lines

@@ -1391,11 +1391,11 @@
 
 <div id="footer">
     <?php
-      # Show authorized user name (and address) and allow logout.
+        # Show authorized user name (and address) and allow logout.
     if ($user) {
         echo("<a href=\"logout.php\" title=\"" .
-          addslashes(__('Disconnect the current user')) .
-          "\">" . addslashes(__('Log out')) . "<i class=\"fa fa-sign-out\"></i></a>");
+            addslashes(__('Disconnect the current user')) .
+            "\">" . addslashes(__('Log out')) . "<i class=\"fa fa-sign-out\"></i></a>");
     }
     ?>
 </div> <!-- Footer -->

control.php

Indentation +12 added lines, -12 removed lines

@@ -331,18 +331,18 @@ 
   
     require_once('FileHandler.class.php');
     list ($handler, $targetFile) =
-      palma\FileHandler::getFileHandler($inFile);
+        palma\FileHandler::getFileHandler($inFile);
     trace("file is now $targetFile, its handler is $handler");
 
     $window = array(
-      "id" => "",
-      "win_id" => "",
-      "name" => "",
-      "state" => "",
-      "file" => $targetFile,
-      "handler" => $handler,
-      "userid" => "",
-      "date" => $w['date']);
+        "id" => "",
+        "win_id" => "",
+        "name" => "",
+        "state" => "",
+        "file" => $targetFile,
+        "handler" => $handler,
+        "userid" => "",
+        "date" => $w['date']);
   
     createNewWindow($db, $window);
 }
@@ -401,7 +401,7 @@ 
 
             // trying mousemove and click for better vnc control
             displayCommand("xdotool mousemove --window $windowhex 100 100 " .
-                       "key $key");
+                        "key $key");
         }
 
         if ($windowname && array_key_exists('keydown', $_REQUEST)) {
@@ -416,7 +416,7 @@ 
 
             // trying mousemove and click for better vnc control
             displayCommand("xdotool mousemove --window $windowhex 100 100 " .
-                       "key $key");
+                        "key $key");
             //~ displayCommand("xdotool windowfocus $windowhex keydown $key");
         }
 
@@ -566,7 +566,7 @@ 
                 "section" => "",
                 "state" => "",
                 "file" => $openURL,
-		"handler" => "palma-browser",
+        "handler" => "palma-browser",
                 "userid" => "",
                 "date" => $date
             );

Spacing +11 added lines, -11 removed lines

@@ -33,7 +33,7 @@ 
     monitor("control.php: displayCommand $cmd");
 
     // add directories with palma-browser to PATH
-    $result = shell_exec('PATH=/usr/lib/palma:./scripts:$PATH '.$cmd);
+    $result = shell_exec('PATH=/usr/lib/palma:./scripts:$PATH ' . $cmd);
     trace("displayCommand $cmd, result=$result");
     return $result;
 }
@@ -176,7 +176,7 @@ 
     }
 
     // Make sure $layout is valid
-    if (!array_key_exists($layout, $geom)){
+    if (!array_key_exists($layout, $geom)) {
         trace("layout invalid!");
     } else {
         $db->exec("UPDATE setting SET value='$layout' WHERE key='layout'");
@@ -205,7 +205,7 @@ 
             $section = $w['section'];
             if ($section >= 1 && $section <= $maxSection && $enabled) {
                 // Show window, set size and position.
-                $wi = $section - 1;
+                $wi = $section-1;
                 $dx = $screenWidth / $dim[$wi][2];
                 $dy = $screenHeight / $dim[$wi][3];
                 $x = $dim[$wi][0] * $dx;
@@ -299,7 +299,7 @@ 
     // TODO: check how to insert the userid for all content, not just vnc.
     // Perhaps better add to array in upload.php ?
     $userid = "";
-    $queryid = $db->querySingle('SELECT user.userid FROM user WHERE user.name="' . $new['userid'] .'"');
+    $queryid = $db->querySingle('SELECT user.userid FROM user WHERE user.name="' . $new['userid'] . '"');
     if (!empty($queryid)) {
         $userid = $queryid;
     } else {
@@ -325,7 +325,7 @@ 
 {
     $inFile = $w['file'];
     if (!file_exists($inFile)) {
-        trace("".escapeshellarg($inFile)." is not a file, aborting display");
+        trace("" . escapeshellarg($inFile) . " is not a file, aborting display");
         return;
     }
   
@@ -356,7 +356,7 @@ 
     // TODO: use escapeshellarg() for filename.
     $filename = $w['file'];
 
-    $cmd = "$handler ".escapeshellarg($filename);
+    $cmd = "$handler " . escapeshellarg($filename);
     displayCommand("/usr/bin/nohup $cmd >/dev/null 2>&1 &");
 
     addNewWindow($db, $w);
@@ -378,7 +378,7 @@ 
         if ($windownumber != 'vncwin') {
             // This is the normal case.
             // Special handling is needed when called with window=vncwin, see below.
-            $window = $windownumber - 1;
+            $window = $windownumber-1;
 
             $win_id = $db->getWindowIDBySection($windownumber);
             $windowlist = windowList();
@@ -439,7 +439,7 @@ 
             $file_in_db = $db->querySingle("SELECT id FROM window WHERE file='$delete'");
             $delete = str_replace(" ", "\ ", $delete);
             trace("file in db: $file_in_db");
-            if ($file_in_db){
+            if ($file_in_db) {
                 if (file_exists($delete)) {
                     trace("+++ DELETE FILE FROM WEBINTERFACE +++");
                     unlink($delete);
@@ -447,7 +447,7 @@ 
                     trace("+++ DELETE VNC Client FROM DAEMON +++");
                     // call via daemon: ?window=vncwin&delete=VNC&vncid=123
                     trace("vnc delete in control");
-                    $win_id = escapeshellcmd($_REQUEST['vncid']);   // = hexWindow in database, but not on screen
+                    $win_id = escapeshellcmd($_REQUEST['vncid']); // = hexWindow in database, but not on screen
                     trace("VNC via Daemon ... id=$win_id");
                 } elseif (strstr($delete, "http")) {
                     trace("+++ DELETE Browserwindow +++");
@@ -540,14 +540,14 @@ 
 
         // If URL leads to pdf file, download it and treat as upload
         $headers = get_headers($openURL, 1);
-        if ($headers["Content-Type"] == "application/pdf"){
+        if ($headers["Content-Type"] == "application/pdf") {
             trace("url seems to lead to a pdf file, so downloading it...");
             $temp_name = basename($openURL);
             $temp_dir = "/tmp";
             file_put_contents("$temp_dir/$temp_name", file_get_contents($openURL));
             $mimetype = mime_content_type("$temp_dir/$temp_name");
             trace("mimetype is $mimetype");
-            if ($mimetype == "application/pdf"){
+            if ($mimetype == "application/pdf") {
                 $_FILES['file']['name'] = "$temp_name";
                 $_FILES['file']['tmp_name'] = "$temp_dir/$temp_name";
                 $_FILES['file']['error'] = "downloaded_from_url";