View GitHub Repository tiqr-server-libphp

Schedule Inspection
Subscribe
Passed
Pull Request — develop (#40)
by Pieter van der
02:45
created

833 -113 Covered Lines

1,545 -113 Total Lines

53.9 % -3.1% Code Coverage

PHP Classes Changes

33.33%
 ↗
100%
 Tiqr_OcraService_Abstract improved
88.89%
 ↘
62.5%
 Tiqr_OcraService_Tiqr got worse
80.36%
 ↘
59.49%
 Tiqr_StateStorage_Pdo got worse
93.1%
 ↘
75.68%
 Tiqr_UserSecretStorage_Pdo got worse
18.18%
 ↗
32%
 Tiqr_OcraService_OathServiceClient improved
85.37%
 ↘
76.6%
 Tiqr_StateStorage_File got worse
83.33%
 ↘
78.95%
 FileTrait got worse
86.67%
 ↘
82.35%
 Tiqr_UserSecretStorage_File got worse
92.31%
 ↘
90%
 Tiqr_UserSecretStorage got worse
58.27%
 ↘
56.29%
 OATH_OCRAParser got worse
⋮ view more  
70.59%
 ↛
 
 Tiqr_OCRAWrapper_v1 removed
74.71%
 ↛
 
 OCRA_v1 removed
100%
 ↛
 
 Tiqr_OCRAWrapper removed

CRAP Changes

 
 ⇢
9.1595
Tiqr_UserStorage_Pdo::_getStringValue() added
 
 ⇢
9.1595
Tiqr_UserStorage_Pdo::_getIntValue() added
 
 ⇢
6
Tiqr_OcraService_OathServiceClient::verifyResponse... added
 
 ⇢
5.024
Tiqr_UserStorage_Pdo::_setIntValue() added
 
 ⇢
5.024
Tiqr_UserStorage_Pdo::_setStringValue() added
 
 ⇢
3.4746
Tiqr_OcraService_Tiqr::verifyResponse() added
 
 ⇢
1
FileTrait::_userExists() added
 
 ⇢
1
Tiqr_OcraService_Abstract::__construct() added
 
 ⇢
1
Tiqr_OcraService_Abstract::generateChallenge() added
 
 ⇢
1
ReadWriteException::fromOriginalException() added
2.0065
 ↘
2
 Tiqr_Service::getEnrollmentMetadata() improved
9.1582
 ↘
9.111
 Tiqr_StateStorage::getStorage() improved
2.0625
 ↗
2.1481
 FileTrait::_saveUser() got worse
3.2098
 ↗
3.4746
 Tiqr_UserStorage_Pdo::createUser() got worse
2.032
 ↗
2.3149
 Tiqr_UserStorage_Pdo::userExists() got worse
2
 ↗
2.3149
 Tiqr_UserSecretStorage_Pdo::userExists() got worse
4.25
 ↘
3.6511
 Tiqr_Service::_getChallengeUrl() improved
3
 ↘
2.2559
 Tiqr_StateStorage_Pdo::cleanExpired() improved
4.7691
 ↗
5.5726
 Tiqr_StateStorage_Pdo::unsetValue() got worse
4.0119
 ↘
3.0987
 FileTrait::_loadUser() improved
⋮ view more  
47.7999
 ↛
 
 OCRA_v1::generateOCRA() removed
11.7741
 ↛
 
 Tiqr_OCRAWrapper_v1::_formatChallenge() removed
6
 ↛
 
 Tiqr_OcraService_OathServiceClient::generateChalle... removed
6
 ↛
 
 Tiqr_OcraService_OathServiceClient::verifyResponse... removed
5.3906
 ↛
 
 Tiqr_OCRAWrapper_v1::_challengeConfig() removed
2.1481
 ↛
 
 Tiqr_OcraService_Tiqr::_getProtocolSpecificOCRAWra... removed
2.0625
 ↛
 
 Tiqr_OCRAWrapper_v1::_calculateResponse() removed
2.0078
 ↛
 
 OATH_OCRAParser::generateSessionInformation() removed
2
 ↛
 
 Tiqr_OcraService_OathServiceClient::getVerificatio... removed
2
 ↛
 
 Tiqr_Service::getNotificationError() removed
⋮ view more