Passed
Pull Request — develop (#44)
by Pieter van der
03:20
created
library/tiqr/Tiqr/StateStorage/Pdo.php 2 patches
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
             throw new InvalidArgumentException('Empty key not allowed');
78 78
         }
79 79
         try {
80
-            $sth = $this->handle->prepare('SELECT `key` FROM ' . $this->tablename . ' WHERE `key` = ?');
80
+            $sth = $this->handle->prepare('SELECT `key` FROM '.$this->tablename.' WHERE `key` = ?');
81 81
             $sth->execute(array($key));
82 82
             return $sth->fetchColumn() !== false;
83 83
         }
@@ -97,9 +97,9 @@  discard block
 block discarded – undo
97 97
      */
98 98
     private function cleanExpired(): void {
99 99
         try {
100
-            $sth = $this->handle->prepare("DELETE FROM " . $this->tablename . " WHERE `expire` < ? AND NOT `expire` = 0");
100
+            $sth = $this->handle->prepare("DELETE FROM ".$this->tablename." WHERE `expire` < ? AND NOT `expire` = 0");
101 101
             $sth->execute(array(time()));
102
-            $deletedRows=$sth->rowCount();
102
+            $deletedRows = $sth->rowCount();
103 103
             $this->logger->notice(
104 104
                 sprintf("Deleted %d expired keys", $deletedRows)
105 105
             );
@@ -115,12 +115,12 @@  discard block
 block discarded – undo
115 115
     /**
116 116
      * @see Tiqr_StateStorage_StateStorageInterface::setValue()
117 117
      */
118
-    public function setValue(string $key, $value, int $expire=0): void
118
+    public function setValue(string $key, $value, int $expire = 0): void
119 119
     {
120 120
         if (empty($key)) {
121 121
             throw new InvalidArgumentException('Empty key not allowed');
122 122
         }
123
-        if (((float) rand() /(float) getrandmax()) < $this->cleanupProbability) {
123
+        if (((float) rand() / (float) getrandmax()) < $this->cleanupProbability) {
124 124
             $this->cleanExpired();
125 125
         }
126 126
         if ($this->keyExists($key)) {
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
130 130
         }
131 131
         // $expire == 0 means never expire
132 132
         if ($expire != 0) {
133
-            $expire+=time();    // Store unix timestamp after which the expires
133
+            $expire += time(); // Store unix timestamp after which the expires
134 134
         }
135 135
         try {
136 136
             $sth->execute(array(serialize($value), $expire, $key));
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
             throw new InvalidArgumentException('Empty key not allowed');
154 154
         }
155 155
         try {
156
-            $sth = $this->handle->prepare("DELETE FROM " . $this->tablename . " WHERE `key` = ?");
156
+            $sth = $this->handle->prepare("DELETE FROM ".$this->tablename." WHERE `key` = ?");
157 157
             $sth->execute(array($key));
158 158
         }
159 159
         catch (Exception $e) {
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
         }
184 184
 
185 185
         try {
186
-            $sth = $this->handle->prepare('SELECT `value` FROM ' . $this->tablename . ' WHERE `key` = ? AND (`expire` >= ? OR `expire` = 0)');
186
+            $sth = $this->handle->prepare('SELECT `value` FROM '.$this->tablename.' WHERE `key` = ? AND (`expire` >= ? OR `expire` = 0)');
187 187
             $sth->execute(array($key, time()));
188 188
         }
189 189
         catch (Exception $e) {
@@ -197,9 +197,9 @@  discard block
 block discarded – undo
197 197
         if (false === $result) {
198 198
             // Occurs normally
199 199
             $this->logger->info(sprintf('getValue: Key "%s" not found in PDO StateStorage', $key));
200
-            return NULL;    // Key not found
200
+            return NULL; // Key not found
201 201
         }
202
-        $result=unserialize($result, array('allowed_classes' => false));
202
+        $result = unserialize($result, array('allowed_classes' => false));
203 203
         if (false === $result) {
204 204
             throw new RuntimeException(sprintf('getValue: unserialize error for key "%s" in PDO StateStorage', $key));
205 205
         }
Please login to merge, or discard this patch.
Braces   +5 added lines, -10 removed lines patch added patch discarded remove patch
@@ -80,8 +80,7 @@  discard block
 block discarded – undo
80 80
             $sth = $this->handle->prepare('SELECT `key` FROM ' . $this->tablename . ' WHERE `key` = ?');
81 81
             $sth->execute(array($key));
82 82
             return $sth->fetchColumn() !== false;
83
-        }
84
-        catch (Exception $e) {
83
+        } catch (Exception $e) {
85 84
             $this->logger->error(
86 85
                 sprintf('Error checking for key "%s" in PDO StateStorage', $key),
87 86
                 array('exception' => $e)
@@ -103,8 +102,7 @@  discard block
 block discarded – undo
103 102
             $this->logger->notice(
104 103
                 sprintf("Deleted %d expired keys", $deletedRows)
105 104
             );
106
-        }
107
-        catch (Exception $e) {
105
+        } catch (Exception $e) {
108 106
             $this->logger->error(
109 107
                 sprintf("Deleting expired keys failed: %s", $e->getMessage()),
110 108
                 array('exception', $e)
@@ -134,8 +132,7 @@  discard block
 block discarded – undo
134 132
         }
135 133
         try {
136 134
             $sth->execute(array(serialize($value), $expire, $key));
137
-        }
138
-        catch (Exception $e) {
135
+        } catch (Exception $e) {
139 136
             $this->logger->error(
140 137
                 sprintf('Unable to store key "%s" in PDO StateStorage', $key),
141 138
                 array('exception' => $e)
@@ -155,8 +152,7 @@  discard block
 block discarded – undo
155 152
         try {
156 153
             $sth = $this->handle->prepare("DELETE FROM " . $this->tablename . " WHERE `key` = ?");
157 154
             $sth->execute(array($key));
158
-        }
159
-        catch (Exception $e) {
155
+        } catch (Exception $e) {
160 156
             $this->logger->error(
161 157
                 sprintf('Error deleting key "%s" from PDO StateStorage', $key),
162 158
                 array('exception' => $e)
@@ -185,8 +181,7 @@  discard block
 block discarded – undo
185 181
         try {
186 182
             $sth = $this->handle->prepare('SELECT `value` FROM ' . $this->tablename . ' WHERE `key` = ? AND (`expire` >= ? OR `expire` = 0)');
187 183
             $sth->execute(array($key, time()));
188
-        }
189
-        catch (Exception $e) {
184
+        } catch (Exception $e) {
190 185
             $this->logger->error(
191 186
                 sprintf('Error getting value for key "%s" from PDO StateStorage', $key),
192 187
                 array('exception' => $e)
Please login to merge, or discard this patch.