Issues in FunctionSignature.php (master) - Issues in master - TimeToogo/Pinq - Measure and Improve Code Quality continuously with Scrutinizer

Issues (70)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Source/Parsing/FunctionSignature.php (2 issues)

Labels

Bug 2

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Pinq\Parsing;

use Pinq\Expressions as O;

/**
 * Implementation of the function signature interface.
 *
 * @author Elliot Levin <[email protected]>
 */
class FunctionSignature extends MagicResolvable implements IFunctionSignature
{
    /**
     * @var int
     */
    protected $type;

    /**
     * @var boolean
     */
    protected $returnsReference;

    /**
     * @var int|null
     */
    protected $accessModifier;

    /**
     * @var int|null
     */
    protected $polymorphModifier;

    /**
     * @var bool|null
     */
    protected $isStatic;

    /**
     * @var string
     */
    protected $name;

    /**
     * @var O\ParameterExpression[]
     */
    protected $parameterExpressions;

    /**
     * @var string[]|null
     */
    protected $scopedVariableNames;

    /**
     * @var string
     */
    protected $hash;

    protected function __construct(
            $type,
            $returnsReference,
            $accessModifier,
            $polymorphModifier,
            $isStatic,
            $name,
            array $parameterExpressions,
            array $scopedVariableNames = null
    ) {
        parent::__construct($parameterExpressions);

        $this->type                 = $type;
        $this->returnsReference     = $returnsReference;
        $this->accessModifier       = $accessModifier;
        $this->polymorphModifier    = $polymorphModifier;
        $this->isStatic             = $isStatic;
        $this->parameterExpressions = $parameterExpressions;
        $this->name                 = $name;
        $this->scopedVariableNames  = $scopedVariableNames;

        $this->hash = implode(
                '-',
                [
                        $type,
                        $returnsReference,
                        $accessModifier,
                        $polymorphModifier,
                        $isStatic,
                        $name,
                        O\Expression::hashAll($parameterExpressions),
                        $scopedVariableNames !== null ? implode('|', $scopedVariableNames) : '',
                ]
        );
    }

    protected function withResolvedMagic(array $resolvedExpressions)
    {
        return new self(
                $this->type,
                $this->returnsReference,
                $this->accessModifier,
                $this->polymorphModifier,
                $this->isStatic,
                $this->name,
                O\Expression::simplifyAll($resolvedExpressions),
                $this->scopedVariableNames);
    }

    /**
     * Creates a function signature instance from the supplied reflection.
     *
     * @param \ReflectionFunctionAbstract $reflection
     *
     * @return self
     */
    public static function fromReflection(\ReflectionFunctionAbstract $reflection)
    {
        $returnsReference     = $reflection->returnsReference();
        $name                 = $reflection->getShortName();
        $parameterExpressions = self::getParameterExpressionsFromReflection($reflection);

        if ($reflection->isClosure()) {
            return self::closure(
                    $returnsReference,
                    $parameterExpressions,
                    array_keys($reflection->getStaticVariables())
            );
        } elseif ($reflection instanceof \ReflectionMethod) {
            if ($reflection->isPublic()) {
                $accessModifier = self::ACCESS_PUBLIC;
            } elseif ($reflection->isProtected()) {
                $accessModifier = self::ACCESS_PROTECTED;
            } else {
                $accessModifier = self::ACCESS_PRIVATE;
            }

            if ($reflection->isAbstract()) {
                $polymorphModifier = self::POLYMORPH_ABSTRACT;
            } elseif ($reflection->isFinal()) {
                $polymorphModifier = self::POLYMORPH_FINAL;
            } else {
                $polymorphModifier = null;
            }

            return self::method(
                    $returnsReference,
                    $accessModifier,
                    $polymorphModifier,
                    $reflection->isStatic(),
                    $name,
                    $parameterExpressions
            );
        } else {
            return self::func(
                    $returnsReference,
                    $name,
                    $parameterExpressions
            );
        }
    }

    /**
     * Creates a function signature with the supplied parameters.
     *
     * @param boolean                 $returnsReference
     * @param string                  $name
     * @param O\ParameterExpression[] $parameterExpressions
     *
     * @return self
     */
    public static function func(
            $returnsReference,
            $name,
            array $parameterExpressions
    ) {
        return new self(
                self::TYPE_FUNCTION,
                $returnsReference,
                null,
                null,
                null,
                $name,
                $parameterExpressions,
                null);
    }

    /**
     * Creates a closure signature with the supplied parameters.
     *
     * @param boolean                 $returnsReference
     * @param O\ParameterExpression[] $parameterExpressions
     * @param string[]                $scopedVariableNames
     *
     * @return self
     */
    public static function closure(
            $returnsReference,
            array $parameterExpressions,
            array $scopedVariableNames
    ) {
        return new self(
                self::TYPE_CLOSURE,
                $returnsReference,
                null,
                null,
                null,
                null,
                $parameterExpressions,
                $scopedVariableNames);
    }

    /**
     * Creates a method signature with the supplied parameters.
     *
     * @param boolean                 $returnsReference
     * @param int|null                $accessModifier
     * @param int|null                $polymorphModifier
     * @param boolean                 $isStatic
     * @param string                  $name
     * @param O\ParameterExpression[] $parameterExpressions
     *
     * @return self
     */
    public static function method(
            $returnsReference,
            $accessModifier,
            $polymorphModifier,
            $isStatic,
            $name,
            array $parameterExpressions
    ) {
        return new self(
                self::TYPE_METHOD,
                $returnsReference,
                $accessModifier,
                $polymorphModifier,
                $isStatic,
                $name,
                $parameterExpressions,
                null);
    }

    protected static function getParameterExpressionsFromReflection(\ReflectionFunctionAbstract $reflection)
    {
        $parameterExpressions = [];

        foreach ($reflection->getParameters() as $parameter) {
            $parameterExpressions[] = self::getParameterExpression($parameter);
        }

        return $parameterExpressions;
    }

    private static function getParameterExpression(\ReflectionParameter $parameter)
    {
        $typeHint = null;

        if ($parameter->isArray()) {
            $typeHint = 'array';
        } elseif ($parameter->isCallable()) {
            $typeHint = 'callable';
        } elseif ($parameter->getClass() !== null) {
            $typeHint = $parameter->getClass()->getName();

            $typeHint = $typeHint[0] === '\\' ? $typeHint : '\\' . $typeHint;
        }

        return O\Expression::parameter(
                $parameter->getName(),

                $typeHint,
                $parameter->isDefaultValueAvailable() ? O\Expression::value($parameter->getDefaultValue()) : null,
                $parameter->isPassedByReference(),
                method_exists($parameter, 'isVariadic') && $parameter->isVariadic()
        );
    }

    public function getType()
    {
        return $this->type;
    }

    public function returnsReference()
    {
        return $this->returnsReference;
    }

    public function getAccessModifier()
    {
        return $this->accessModifier;
    }

    public function getPolymorphModifier()
    {
        return $this->polymorphModifier;
    }

    public function isStatic()
    {
        return $this->isStatic;
    }

    public function getName()
    {
        return $this->name;
    }

    public function getParameterExpressions()
    {
        return $this->parameterExpressions;
    }

    public function getScopedVariableNames()
    {
        return $this->scopedVariableNames;
    }

    public function getHash()
    {
        return $this->hash;
    }
}


GitHub Access Token became invalid

Issues (70)

Security Analysis no request data

Source/Parsing/FunctionSignature.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1		<?php
2
3		namespace Pinq\Parsing;
4
5		use Pinq\Expressions as O;
6
7		/**
8		* Implementation of the function signature interface.
9		*
10		* @author Elliot Levin <[email protected]>
11		*/
12		class FunctionSignature extends MagicResolvable implements IFunctionSignature
13		{
14		/**
15		* @var int
16		*/
17		protected $type;
18
19		/**
20		* @var boolean
21		*/
22		protected $returnsReference;
23
24		/**
25		* @var int\|null
26		*/
27		protected $accessModifier;
28
29		/**
30		* @var int\|null
31		*/
32		protected $polymorphModifier;
33
34		/**
35		* @var bool\|null
36		*/
37		protected $isStatic;
38
39		/**
40		* @var string
41		*/
42		protected $name;
43
44		/**
45		* @var O\ParameterExpression[]
46		*/
47		protected $parameterExpressions;
48
49		/**
50		* @var string[]\|null
51		*/
52		protected $scopedVariableNames;
53
54		/**
55		* @var string
56		*/
57		protected $hash;
58
59		protected function __construct(
60		$type,
61		$returnsReference,
62		$accessModifier,
63		$polymorphModifier,
64		$isStatic,
65		$name,
66		array $parameterExpressions,
67		array $scopedVariableNames = null
68		) {
69		parent::__construct($parameterExpressions);
70
71		$this->type = $type;
72		$this->returnsReference = $returnsReference;
73		$this->accessModifier = $accessModifier;
74		$this->polymorphModifier = $polymorphModifier;
75		$this->isStatic = $isStatic;
76		$this->parameterExpressions = $parameterExpressions;
77		$this->name = $name;
78		$this->scopedVariableNames = $scopedVariableNames;
79
80		$this->hash = implode(
81		'-',
82		[
83		$type,
84		$returnsReference,
85		$accessModifier,
86		$polymorphModifier,
87		$isStatic,
88		$name,
89		O\Expression::hashAll($parameterExpressions),
90		$scopedVariableNames !== null ? implode('\|', $scopedVariableNames) : '',
91		]
92		);
93		}
94
95		protected function withResolvedMagic(array $resolvedExpressions)
96		{
97		return new self(
98		$this->type,
99		$this->returnsReference,
100		$this->accessModifier,
101		$this->polymorphModifier,
102		$this->isStatic,
103		$this->name,
104		O\Expression::simplifyAll($resolvedExpressions),
105		$this->scopedVariableNames);
106		}
107
108		/**
109		* Creates a function signature instance from the supplied reflection.
110		*
111		* @param \ReflectionFunctionAbstract $reflection
112		*
113		* @return self
114		*/
115		public static function fromReflection(\ReflectionFunctionAbstract $reflection)
116		{
117		$returnsReference = $reflection->returnsReference();
118		$name = $reflection->getShortName();
119		$parameterExpressions = self::getParameterExpressionsFromReflection($reflection);
120
121		if ($reflection->isClosure()) {
122		return self::closure(
123		$returnsReference,
124		$parameterExpressions,
125		array_keys($reflection->getStaticVariables())
126		);
127		} elseif ($reflection instanceof \ReflectionMethod) {
128		if ($reflection->isPublic()) {
129		$accessModifier = self::ACCESS_PUBLIC;
130		} elseif ($reflection->isProtected()) {
131		$accessModifier = self::ACCESS_PROTECTED;
132		} else {
133		$accessModifier = self::ACCESS_PRIVATE;
134		}
135
136		if ($reflection->isAbstract()) {
137		$polymorphModifier = self::POLYMORPH_ABSTRACT;
138		} elseif ($reflection->isFinal()) {
139		$polymorphModifier = self::POLYMORPH_FINAL;
140		} else {
141		$polymorphModifier = null;
142		}
143
144		return self::method(
145		$returnsReference,
146		$accessModifier,
147		$polymorphModifier,
148		$reflection->isStatic(),
149		$name,
150		$parameterExpressions
151		);
152		} else {
153		return self::func(
154		$returnsReference,
155		$name,
156		$parameterExpressions
157		);
158		}
159		}
160
161		/**
162		* Creates a function signature with the supplied parameters.
163		*
164		* @param boolean $returnsReference
165		* @param string $name
166		* @param O\ParameterExpression[] $parameterExpressions
167		*
168		* @return self
169		*/
170	View Code Duplication	public static function func(
171		$returnsReference,
172		$name,
173		array $parameterExpressions
174		) {
175		return new self(
176		self::TYPE_FUNCTION,
177		$returnsReference,
178		null,
179		null,
180		null,
181		$name,
182		$parameterExpressions,
183		null);
184		}
185
186		/**
187		* Creates a closure signature with the supplied parameters.
188		*
189		* @param boolean $returnsReference
190		* @param O\ParameterExpression[] $parameterExpressions
191		* @param string[] $scopedVariableNames
192		*
193		* @return self
194		*/
195	View Code Duplication	public static function closure(
196		$returnsReference,
197		array $parameterExpressions,
198		array $scopedVariableNames
199		) {
200		return new self(
201		self::TYPE_CLOSURE,
202		$returnsReference,
203		null,
204		null,
205		null,
206		null,
207		$parameterExpressions,
208		$scopedVariableNames);
209		}
210
211		/**
212		* Creates a method signature with the supplied parameters.
213		*
214		* @param boolean $returnsReference
215		* @param int\|null $accessModifier
216		* @param int\|null $polymorphModifier
217		* @param boolean $isStatic
218		* @param string $name
219		* @param O\ParameterExpression[] $parameterExpressions
220		*
221		* @return self
222		*/
223		public static function method(
224		$returnsReference,
225		$accessModifier,
226		$polymorphModifier,
227		$isStatic,
228		$name,
229		array $parameterExpressions
230		) {
231		return new self(
232		self::TYPE_METHOD,
233		$returnsReference,
234		$accessModifier,
235		$polymorphModifier,
236		$isStatic,
237		$name,
238		$parameterExpressions,
239		null);
240		}
241
242		protected static function getParameterExpressionsFromReflection(\ReflectionFunctionAbstract $reflection)
243		{
244		$parameterExpressions = [];
245
246		foreach ($reflection->getParameters() as $parameter) {
247		$parameterExpressions[] = self::getParameterExpression($parameter);
248		}
249
250		return $parameterExpressions;
251		}
252
253		private static function getParameterExpression(\ReflectionParameter $parameter)
254		{
255		$typeHint = null;
256
257		if ($parameter->isArray()) {
258		$typeHint = 'array';
259		} elseif ($parameter->isCallable()) {
260		$typeHint = 'callable';
261		} elseif ($parameter->getClass() !== null) {
262		$typeHint = $parameter->getClass()->getName();
		0 ignored issues – show Bug introduced 2017-03-06 03:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using `$parameter->getClass()->name`. There is an issue with `getName()` and APC-enabled PHP versions. Loading history...
263		$typeHint = $typeHint[0] === '\\' ? $typeHint : '\\' . $typeHint;
264		}
265
266		return O\Expression::parameter(
267		$parameter->getName(),
		0 ignored issues – show Bug introduced 2017-03-06 03:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using `$parameter->name`. There is an issue with `getName()` and APC-enabled PHP versions. Loading history...
268		$typeHint,
269		$parameter->isDefaultValueAvailable() ? O\Expression::value($parameter->getDefaultValue()) : null,
270		$parameter->isPassedByReference(),
271		method_exists($parameter, 'isVariadic') && $parameter->isVariadic()
272		);
273		}
274
275		public function getType()
276		{
277		return $this->type;
278		}
279
280		public function returnsReference()
281		{
282		return $this->returnsReference;
283		}
284
285		public function getAccessModifier()
286		{
287		return $this->accessModifier;
288		}
289
290		public function getPolymorphModifier()
291		{
292		return $this->polymorphModifier;
293		}
294
295		public function isStatic()
296		{
297		return $this->isStatic;
298		}
299
300		public function getName()
301		{
302		return $this->name;
303		}
304
305		public function getParameterExpressions()
306		{
307		return $this->parameterExpressions;
308		}
309
310		public function getScopedVariableNames()
311		{
312		return $this->scopedVariableNames;
313		}
314
315		public function getHash()
316		{
317		return $this->hash;
318		}
319		}
320

TimeToogo / Pinq

GitHub Access Token became invalid

Issues (70)

Security Analysis no request data

Source/Parsing/FunctionSignature.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like