Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
12 | class FunctionCallExpression extends Expression |
||
13 | { |
||
14 | /** |
||
15 | * @var Expression |
||
16 | */ |
||
17 | private $name; |
||
18 | |||
19 | /** |
||
20 | * @var ArgumentExpression[] |
||
21 | */ |
||
22 | private $arguments; |
||
23 | |||
24 | public function __construct(Expression $nameExpression, array $argumentExpressions = []) |
||
29 | |||
30 | /** |
||
31 | * @return Expression |
||
32 | */ |
||
33 | public function getName() |
||
37 | |||
38 | /** |
||
39 | * @return ArgumentExpression[] |
||
40 | */ |
||
41 | public function getArguments() |
||
45 | |||
46 | public function traverse(ExpressionWalker $walker) |
||
50 | |||
51 | /** |
||
52 | * @param Expression $name |
||
53 | * @param ArgumentExpression[] $arguments |
||
54 | * |
||
55 | * @return self |
||
56 | */ |
||
57 | View Code Duplication | public function update(Expression $name, array $arguments = []) |
|
67 | |||
68 | View Code Duplication | protected function compileCode(&$code) |
|
80 | |||
81 | public function serialize() |
||
85 | |||
86 | public function unserialize($serialized) |
||
90 | |||
91 | public function __clone() |
||
96 | } |
||
97 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.