Complex classes like ExpressionVisitor often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ExpressionVisitor, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 12 | class ExpressionVisitor extends ExpressionWalker |
||
| 13 | { |
||
| 14 | final public function walkArray(ArrayExpression $expression) |
||
| 20 | |||
| 21 | protected function visitArray(ArrayExpression $expression) |
||
| 25 | |||
| 26 | final public function walkArrayItem(ArrayItemExpression $expression) |
||
| 32 | |||
| 33 | protected function visitArrayItem(ArrayItemExpression $expression) |
||
| 37 | |||
| 38 | final public function walkAssignment(AssignmentExpression $expression) |
||
| 44 | |||
| 45 | protected function visitAssignment(AssignmentExpression $expression) |
||
| 49 | |||
| 50 | final public function walkBinaryOperation(BinaryOperationExpression $expression) |
||
| 56 | |||
| 57 | protected function visitBinaryOperation(BinaryOperationExpression $expression) |
||
| 61 | |||
| 62 | final public function walkCast(CastExpression $expression) |
||
| 68 | |||
| 69 | protected function visitCast(CastExpression $expression) |
||
| 73 | |||
| 74 | final public function walkClosure(ClosureExpression $expression) |
||
| 80 | |||
| 81 | protected function visitClosure(ClosureExpression $expression) |
||
| 85 | |||
| 86 | final public function walkClosureUsedVariable(ClosureUsedVariableExpression $expression) |
||
| 92 | |||
| 93 | protected function visitClosureUsedVariable(ClosureUsedVariableExpression $expression) |
||
| 97 | |||
| 98 | public function walkConstant(ConstantExpression $expression) |
||
| 104 | |||
| 105 | protected function visitConstant(ConstantExpression $expression) |
||
| 109 | |||
| 110 | public function walkClassConstant(ClassConstantExpression $expression) |
||
| 116 | |||
| 117 | protected function visitClassConstant(ClassConstantExpression $expression) |
||
| 121 | |||
| 122 | final public function walkParameter(ParameterExpression $expression) |
||
| 128 | |||
| 129 | protected function visitParameter(ParameterExpression $expression) |
||
| 133 | |||
| 134 | final public function walkArgument(ArgumentExpression $expression) |
||
| 135 | { |
||
| 136 | $this->visitArgument($expression); |
||
| 137 | |||
| 138 | return $expression; |
||
| 139 | } |
||
| 140 | |||
| 141 | protected function visitArgument(ArgumentExpression $expression) |
||
| 142 | { |
||
| 143 | |||
| 144 | } |
||
| 145 | |||
| 146 | final public function walkEmpty(EmptyExpression $expression) |
||
| 152 | |||
| 153 | protected function visitEmpty(EmptyExpression $expression) |
||
| 157 | |||
| 158 | final public function walkIsset(IssetExpression $expression) |
||
| 164 | |||
| 165 | protected function visitIsset(IssetExpression $expression) |
||
| 169 | |||
| 170 | final public function walkUnset(UnsetExpression $expression) |
||
| 176 | |||
| 177 | protected function visitUnset(UnsetExpression $expression) |
||
| 181 | |||
| 182 | final public function walkField(FieldExpression $expression) |
||
| 188 | |||
| 189 | protected function visitField(FieldExpression $expression) |
||
| 193 | |||
| 194 | final public function walkFunctionCall(FunctionCallExpression $expression) |
||
| 200 | |||
| 201 | protected function visitFunctionCall(FunctionCallExpression $expression) |
||
| 205 | |||
| 206 | final public function walkIndex(IndexExpression $expression) |
||
| 212 | |||
| 213 | protected function visitIndex(IndexExpression $expression) |
||
| 217 | |||
| 218 | final public function walkInvocation(InvocationExpression $expression) |
||
| 224 | |||
| 225 | protected function visitInvocation(InvocationExpression $expression) |
||
| 229 | |||
| 230 | final public function walkMethodCall(MethodCallExpression $expression) |
||
| 236 | |||
| 237 | protected function visitMethodCall(MethodCallExpression $expression) |
||
| 241 | |||
| 242 | final public function walkNew(NewExpression $expression) |
||
| 248 | |||
| 249 | protected function visitNew(NewExpression $expression) |
||
| 253 | |||
| 254 | final public function walkReturn(ReturnExpression $expression) |
||
| 260 | |||
| 261 | protected function visitReturn(ReturnExpression $expression) |
||
| 265 | |||
| 266 | final public function walkThrow(ThrowExpression $expression) |
||
| 272 | |||
| 273 | protected function visitThrow(ThrowExpression $expression) |
||
| 277 | |||
| 278 | final public function walkStaticMethodCall(StaticMethodCallExpression $expression) |
||
| 284 | |||
| 285 | protected function visitStaticMethodCall(StaticMethodCallExpression $expression) |
||
| 289 | |||
| 290 | final public function walkStaticField(StaticFieldExpression $expression) |
||
| 296 | |||
| 297 | protected function visitStaticField(StaticFieldExpression $expression) |
||
| 301 | |||
| 302 | final public function walkTernary(TernaryExpression $expression) |
||
| 308 | |||
| 309 | protected function visitTernary(TernaryExpression $expression) |
||
| 313 | |||
| 314 | final public function walkUnaryOperation(UnaryOperationExpression $expression) |
||
| 320 | |||
| 321 | protected function visitUnaryOperation(UnaryOperationExpression $expression) |
||
| 325 | |||
| 326 | final public function walkValue(ValueExpression $expression) |
||
| 332 | |||
| 333 | protected function visitValue(ValueExpression $expression) |
||
| 337 | |||
| 338 | final public function walkVariable(VariableExpression $expression) |
||
| 344 | |||
| 345 | protected function visitVariable(VariableExpression $expression) |
||
| 349 | } |
||
| 350 |