Coco\SourceWatcher\Watcher\Handler\WebPageHandler::read()

Complexity

Conditions	3
Paths	10

Size

Total Lines	25
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function read () : void
    {
        if ( $this->url == null ) {
            throw new Exception( "A URL must be set before reading" );
        }

        try {
            $ch = curl_init();

            $timeout = 5;

            curl_setopt( $ch, CURLOPT_URL, $this->url );

It seems like $ch can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

            curl_setopt( $ch, CURLOPT_RETURNTRANSFER, 1 );
            curl_setopt( $ch, CURLOPT_CONNECTTIMEOUT, $timeout );

            $this->html = curl_exec( $ch );

It seems like $ch can also be of type false; however, parameter $ch of curl_exec() does only seem to accept resource, maybe add an additional type check?

            curl_close( $ch );

It seems like $ch can also be of type false; however, parameter $ch of curl_close() does only seem to accept resource, maybe add an additional type check?

            # Create a DOM parser object
            $this->dom = new DOMDocument();

            # The @ before the method call suppresses any warnings that loadHTML might throw because of invalid HTML in the page.
            @$this->dom->loadHTML( $this->html );

It seems like you do not handle an error condition for loadHTML(). This can introduce security issues, and is generally not recommended.

        } catch ( Exception $e ) {

Consider adding a comment why this CATCH block is empty.