Coco\SourceWatcher\Watcher\Handler\WebPageHandler

Complexity

Total Complexity

8

Size/Duplication

Total Lines	60
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	read()	0	25	3
A	getDom()	0	3	1
A	__construct()	0	5	1
A	getHtml()	0	3	1
A	setUrl()	0	3	1
A	getUrl()	0	3	1

<?php

namespace Coco\SourceWatcher\Watcher\Handler;

use DOMDocument;
use Exception;

class WebPageHandler implements Handler
{
    protected string $url;
    protected string $html;
    protected DOMDocument $dom;

    public function __construct ( string $url )
    {
        $this->url = $url;
        $this->html = "";
        $this->dom = new DOMDocument();
    }

    public function getUrl () : string
    {
        return $this->url;
    }

    public function setUrl ( string $url ) : void
    {
        $this->url = $url;
    }

    public function read () : void
    {
        if ( $this->url == null ) {
            throw new Exception( "A URL must be set before reading" );
        }

        try {
            $ch = curl_init();

            $timeout = 5;

            curl_setopt( $ch, CURLOPT_URL, $this->url );

It seems like $ch can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

            curl_setopt( $ch, CURLOPT_RETURNTRANSFER, 1 );
            curl_setopt( $ch, CURLOPT_CONNECTTIMEOUT, $timeout );

            $this->html = curl_exec( $ch );

It seems like $ch can also be of type false; however, parameter $ch of curl_exec() does only seem to accept resource, maybe add an additional type check?

            curl_close( $ch );

It seems like $ch can also be of type false; however, parameter $ch of curl_close() does only seem to accept resource, maybe add an additional type check?

            # Create a DOM parser object
            $this->dom = new DOMDocument();

            # The @ before the method call suppresses any warnings that loadHTML might throw because of invalid HTML in the page.
            @$this->dom->loadHTML( $this->html );

It seems like you do not handle an error condition for loadHTML(). This can introduce security issues, and is generally not recommended.

        } catch ( Exception $e ) {

Consider adding a comment why this CATCH block is empty.

        }
    }

    public function getDom () : DOMDocument
    {
        return $this->dom;
    }

    public function getHtml () : string
    {
        return $this->html;
    }
}