Coco\SourceWatcher\Core\Extractors\DatabaseExtractor::extract()

Complexity

Conditions	4
Paths	4

Size

Total Lines	19
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

<?php
    public function extract () : array
    {
        if ( $this->databaseConnector == null ) {
            throw new SourceWatcherException( "Database connector missing" );
        }

        if ( $this->query == null ) {

It seems like you are loosely comparing $this->query of type null|string against null; this is ambiguous if the string can be empty. Consider using a strict comparison === instead.

            throw new SourceWatcherException( "Query missing" );
        }

        $result = [];

        $arrayResults = $this->databaseConnector->executePlainQuery( $this->query );

        foreach ( $arrayResults as $currentRecord ) {
            array_push( $result, new Row( $currentRecord ) );
        }

        return $result;
    }