Coco\SourceWatcher\Core\Extractors\DatabaseExtractor

Complexity

Total Complexity

5

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	extract()	0	19	4
A	__construct()	0	4	1

<?php

namespace Coco\SourceWatcher\Core\Extractors;

use Coco\SourceWatcher\Core\Database\Connections\Connector;
use Coco\SourceWatcher\Core\Extractor;
use Coco\SourceWatcher\Core\Row;
use Coco\SourceWatcher\Core\SourceWatcherException;

/**
 * Class DatabaseExtractor
 *
 * @package Coco\SourceWatcher\Core\Extractors
 */
class DatabaseExtractor extends Extractor
{
    private ?Connector $databaseConnector = null;

    private ?string $query = null;

    public function __construct ( Connector $databaseConnector, string $query )
    {
        $this->databaseConnector = $databaseConnector;
        $this->query = $query;
    }

    /**
     * @return array
     * @throws SourceWatcherException
     */
    public function extract () : array
    {
        if ( $this->databaseConnector == null ) {
            throw new SourceWatcherException( "Database connector missing" );
        }

        if ( $this->query == null ) {

It seems like you are loosely comparing $this->query of type null|string against null; this is ambiguous if the string can be empty. Consider using a strict comparison === instead.

            throw new SourceWatcherException( "Query missing" );
        }

        $result = [];

        $arrayResults = $this->databaseConnector->executePlainQuery( $this->query );

        foreach ( $arrayResults as $currentRecord ) {
            array_push( $result, new Row( $currentRecord ) );
        }

        return $result;
    }
}