TicketControllerExtension::getWaitingListSuccess() - Code Metrics - Inspection of "added waiting list functionality when the event is..." - TheBnl/event-tickets - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cc2184...cecba6 )

by Bram

created 2017-05-09 14:37 UTC

TicketControllerExtension::getWaitingListSuccess() A

↳ Parent: TicketControllerExtension

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php
/**
 * TicketControllerExtension.php
 *
 * @author Bram de Leeuw
 * Date: 09/03/17
 */

namespace Broarm\EventTickets;

use CalendarEvent_Controller;
use Extension;

/**
 * Class TicketControllerExtension
 *
 * @package Broarm\EventTickets
 *
 * @property TicketControllerExtension|TicketExtension|CalendarEvent_Controller $owner
 */
class TicketControllerExtension extends Extension
{
    private static $allowed_actions = array(

        'TicketForm',
        'WaitingListRegistrationForm',
        'checkin'
    );

    /**
     * Get the ticket form with available tickets
     *
     * @return TicketForm

     */
    public function TicketForm()
    {
        if ($this->owner->Tickets()->count() && $this->owner->getAvailability() > 0) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            $ticketForm = new TicketForm($this->owner, 'TicketForm', $this->owner->Tickets(), $this->owner->dataRecord);
            $ticketForm->setNextStep(CheckoutSteps::start());
            return $ticketForm;
        } else {
            return null;
        }
    }

    /**
     * show the waiting list form when the event is sold out
     *
     * @return WaitingListRegistrationForm

     */
    public function WaitingListRegistrationForm()
    {
        if ($this->owner->Tickets()->count()) {
            return new WaitingListRegistrationForm($this->owner, 'WaitingListRegistrationForm');
        } else {
            return null;
        }
    }

    /**
     * Go to the check in controller
     *
     * @return CheckInController
     */
    public function checkIn()
    {
        return new CheckInController($this->owner->dataRecord);
    }

    /**
     * Checks the waiting list var
     *
     * @return mixed
     */
    public function getWaitingListSuccess()
    {
        return $this->owner->getRequest()->getVar('waitinglist');
    }
}


1			<?php
2			/**
3			* TicketControllerExtension.php
4			*
5			* @author Bram de Leeuw
6			* Date: 09/03/17
7			*/
8
9			namespace Broarm\EventTickets;
10
11			use CalendarEvent_Controller;
12			use Extension;
13
14			/**
15			* Class TicketControllerExtension
16			*
17			* @package Broarm\EventTickets
18			*
19			* @property TicketControllerExtension\|TicketExtension\|CalendarEvent_Controller $owner
20			*/
21			class TicketControllerExtension extends Extension
22			{
23			private static $allowed_actions = array(
			0 ignored issues – show Comprehensibility introduced 2017-04-25 13:06 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-04-25 13:06 UTC by Report Bug Copy Issue Report The property `$allowed_actions` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
24			'TicketForm',
25			'WaitingListRegistrationForm',
26			'checkin'
27			);
28
29			/**
30			* Get the ticket form with available tickets
31			*
32			* @return TicketForm
			0 ignored issues – show Documentation introduced 2017-04-25 13:06 UTC by Report Bug Copy Issue Report Should the return type not be `TicketForm\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
33			*/
34			public function TicketForm()
35			{
36			if ($this->owner->Tickets()->count() && $this->owner->getAvailability() > 0) {
			1 ignored issue – show Bug introduced 2017-05-09 14:47 UTC by Report Bug Copy Issue Report The method `getAvailability` does only exist in `Broarm\EventTickets\TicketExtension`, but not in `Broarm\EventTickets\Tick...alendarEvent_Controller`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
37			$ticketForm = new TicketForm($this->owner, 'TicketForm', $this->owner->Tickets(), $this->owner->dataRecord);
38			$ticketForm->setNextStep(CheckoutSteps::start());
39			return $ticketForm;
40			} else {
41			return null;
42			}
43			}
44
45			/**
46			* show the waiting list form when the event is sold out
47			*
48			* @return WaitingListRegistrationForm
			0 ignored issues – show Documentation introduced 2017-05-09 14:47 UTC by Report Bug Copy Issue Report Should the return type not be `WaitingListRegistrationForm\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
49			*/
50			public function WaitingListRegistrationForm()
51			{
52			if ($this->owner->Tickets()->count()) {
53			return new WaitingListRegistrationForm($this->owner, 'WaitingListRegistrationForm');
54			} else {
55			return null;
56			}
57			}
58
59			/**
60			* Go to the check in controller
61			*
62			* @return CheckInController
63			*/
64			public function checkIn()
65			{
66			return new CheckInController($this->owner->dataRecord);
67			}
68
69			/**
70			* Checks the waiting list var
71			*
72			* @return mixed
73			*/
74			public function getWaitingListSuccess()
75			{
76			return $this->owner->getRequest()->getVar('waitinglist');
77			}
78			}
79

TheBnl / event-tickets

Push — master ( cc2184...cecba6 )

TicketControllerExtension::getWaitingListSuccess() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like